Attention is currently required from: Jason Glenesk, Martin L Roth, Angel Pons, Arthur Heymans, Elyes Haouas.
Hello build bot (Jenkins), Jason Glenesk, Martin L Roth, Angel Pons, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71711
to look at the new patch set (#6).
Change subject: util/docker/coreboot-sdk: Remove Python 2 package
......................................................................
util/docker/coreboot-sdk: Remove Python 2 package
Debian removed Python 2 from their Sid repository and so it needs to be
removed from the Dockerfile as well.
Built and tested the Dockerfile with Python 2 removed. Still works.
Change-Id: If4e298dc275c1dfaf57cd4c3f8e5f89410318ec0
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/71711/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/71711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4e298dc275c1dfaf57cd4c3f8e5f89410318ec0
Gerrit-Change-Number: 71711
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anil Kumar K, Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal, Uday Bhat, Jairaj Arava.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72881 )
Change subject: mb/google/rex: Enable audio BT offload
......................................................................
Patch Set 13:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72881/comment/8443117e_68ec453b
PS13, Line 9: Enable BT I2S offload feature.
: SSP1 needs to be used for BT offload and program vGPIO.
Please add a blank line between paragraphs or do not wrap lines after a sentence ends.
https://review.coreboot.org/c/coreboot/+/72881/comment/27e77f30_376e998b
PS13, Line 10: SSP1 needs to be used for BT offload and program vGPIO.
According to the schematics?
https://review.coreboot.org/c/coreboot/+/72881/comment/10f85bf6_3b52e070
PS13, Line 13: Playback
Play back
https://review.coreboot.org/c/coreboot/+/72881/comment/57b994d0_b977959e
PS13, Line 13: TEST=Playback through BT
1. Did BT work before?
2. What client device was used?
Patchset:
PS13:
> Hi @Uday , Can u please share the steps to verify BT audio . […]
I’d say that information could got into the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46e9702add37464122ffc78826ebf8a6c5b5b07c
Gerrit-Change-Number: 72881
Gerrit-PatchSet: 13
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com>
Gerrit-CC: Uday M Bhat
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Attention: Jairaj Arava <jairaj.arava(a)intel.com>
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Marc Jones, Patrick Rudolph, Jonathan Zhang, Simon Chou, TimLiu-SMCI, Johnny Lin, Paul Menzel, Arthur Heymans, Shuming Chu (Shuming), Shelly Chang, Elyes Haouas.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 )
Change subject: soc/intel/xeon_sp/spr: Add ACPI support for Sapphire Rapids
......................................................................
Patch Set 29:
(1 comment)
Patchset:
PS29:
hereby getting this merged. thanks everyone for the hard work!!!
--
To view, visit https://review.coreboot.org/c/coreboot/+/71967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6
Gerrit-Change-Number: 71967
Gerrit-PatchSet: 29
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Paul Menzel, Shuming Chu (Shuming), Arthur Heymans, Juan Sanchez.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add Archer City CRB support
......................................................................
Patch Set 28:
(1 comment)
File src/mainboard/intel/archercity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/71968/comment/9814c9d4_31690a84
PS27, Line 96: "SerialIoUartDebugEnable to %d\n", FSP_LOG, FSP_LOG_DEFAULT);
> Exceeding the limit is allowed for print strings. The reasoning is, that it’s easier to grep.
hi Paul do you have any example as reference? or where is this documented in guideline? thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 28
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-CC: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-CC: Juan Sanchez
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Juan Sanchez
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Paul Menzel, Shuming Chu (Shuming), Arthur Heymans, Juan Sanchez.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add Archer City CRB support
......................................................................
Patch Set 28:
(1 comment)
File src/mainboard/intel/archercity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/71968/comment/f5b899f5_722666ec
PS27, Line 83: mupd->FspmConfig.DelayAfterPCIeLinkTraining = 2000;
> hi Paul do you have any example as reference? or where is this documented in guideline? thanks.
wait I replied to wrong comment 😅
--
To view, visit https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 28
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-CC: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-CC: Juan Sanchez
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Juan Sanchez
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Paul Menzel, Shuming Chu (Shuming), Arthur Heymans, Juan Sanchez.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add Archer City CRB support
......................................................................
Patch Set 28:
(1 comment)
File src/mainboard/intel/archercity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/71968/comment/3d931d4b_e4af7bc9
PS27, Line 83: mupd->FspmConfig.DelayAfterPCIeLinkTraining = 2000;
> I meant remove the redundant comment, and just put the unit as a comment on the same line.
hi Paul do you have any example as reference? or where is this documented in guideline? thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 28
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-CC: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-CC: Juan Sanchez
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Juan Sanchez
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment