Attention is currently required from: Simon Chou, Johnny Lin, Paul Menzel, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71969 )
Change subject: configs/builder: add default config for Intel Archer City CRB
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Gerrit-Change-Number: 71969
Gerrit-PatchSet: 12
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sat, 01 Apr 2023 23:06:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Elyes Haouas.
Hello build bot (Jenkins), Martin L Roth, Arthur Heymans, Elyes Haouas,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66922
to look at the new patch set (#14).
Change subject: util/crossgcc: Update GCC from 11.3 to 12.2
......................................................................
util/crossgcc: Update GCC from 11.3 to 12.2
Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09
Signed-off-by: Felix Singer <felix.singer(a)secunet.com>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/gcc-12.2.0_ada-musl_workaround.patch
R util/crossgcc/patches/gcc-12.2.0_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-12.2.0_gnat.patch
R util/crossgcc/patches/gcc-12.2.0_libcpp.patch
R util/crossgcc/patches/gcc-12.2.0_libgcc.patch
D util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum
A util/crossgcc/sum/gcc-12.2.0.tar.xz.cksum
8 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/66922/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/66922
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09
Gerrit-Change-Number: 66922
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66920 )
Change subject: util/crossgcc: Update binutils from 2.37 to 2.40
......................................................................
Patch Set 27:
(1 comment)
Patchset:
PS27:
Mention this in the 4.20 release notes.
--
To view, visit https://review.coreboot.org/c/coreboot/+/66920
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8
Gerrit-Change-Number: 66920
Gerrit-PatchSet: 27
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 01 Apr 2023 20:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66920 )
Change subject: util/crossgcc: Update binutils from 2.37 to 2.40
......................................................................
Patch Set 26:
(1 comment)
Patchset:
PS26:
> I tested this very extensively now since I don't trust the toolchain builder at the moment. […]
Alright, everything looks good to me. Let's do this :)
Set to resolved.
--
To view, visit https://review.coreboot.org/c/coreboot/+/66920
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8
Gerrit-Change-Number: 66920
Gerrit-PatchSet: 26
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 20:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66920 )
Change subject: util/crossgcc: Update binutils from 2.37 to 2.40
......................................................................
Patch Set 26:
(1 comment)
Patchset:
PS26:
> maybe we need to wait until after coreboot release to upgrade toolchain. […]
I tested this very extensively now since I don't trust the toolchain builder at the moment. Just running another test. Will submit this later if this one passes.
--
To view, visit https://review.coreboot.org/c/coreboot/+/66920
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8
Gerrit-Change-Number: 66920
Gerrit-PatchSet: 26
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 18:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73794 )
Change subject: sb/intel/i82371eb/chip.h: Use 'unsigned int' of 'int'
......................................................................
Patch Set 5:
(1 comment)
File src/southbridge/intel/i82371eb/chip.h:
https://review.coreboot.org/c/coreboot/+/73794/comment/6190c840_8c0cddaa
PS3, Line 9: unsigned int ide0_enable:1;
: unsigned int ide0_drive0_udma33_enable:1;
: unsigned int ide0_drive1_udma33_enable:1;
: unsigned int ide1_enable:1;
: unsigned int ide1_drive0_udma33_enable:1;
: unsigned int ide1_drive1_udma33_enable:1;
: unsigned int ide_legacy_enable:1;
: unsigned int usb_enable:1;
: unsigned int gpo22_enable:1; /* GPO22/GPO23 (1) vs. XDIR#/XOE# (0) */
: unsigned int gpo22:1;
: unsigned int gpo23:1;
> this way, we change only one file.
I prefer changing multiple files and using bool instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73794
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36cc19bc2908119fe940941e108ee217a7b26f50
Gerrit-Change-Number: 73794
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 18:25:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Martin L Roth, Angel Pons, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73791 )
Change subject: crossgcc: Upgrade CMake from version 3.25.2 to 3.26.2
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62078257fd84a64c699a7f930bc306e38d2f4058
Gerrit-Change-Number: 73791
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 18:01:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Tarun Tuli, Wonkyu Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73712 )
Change subject: soc/intel/alderlake: Add support for CSE timestamp data versions
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
I will verify base cls and will ensure landing by next week early (if everything goes well)
--
To view, visit https://review.coreboot.org/c/coreboot/+/73712
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I780e250707d1d04891a5a1210b30aecb2c8620d3
Gerrit-Change-Number: 73712
Gerrit-PatchSet: 7
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 01 Apr 2023 17:35:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment