coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable VMX
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74161 ) Change subject: soc/intel/meteorlake: Enable VMX ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74161/comment/4856eeca_9d36f6b9 PS3, Line 7: soc/intel/meteorlake: Enable VMX Reading the diff, it’s only related to `DROP_CPU_FEATURE_PROGRAM_IN_FSP`? https://review.coreboot.org/c/coreboot/+/74161/comment/ac36245a_23dc7127 PS3, Line 11: > > Shouldn’t VMX programming be left to the payload or OS? […] I think it was discussed in the past, that coreboot does not need to do it, but it looks like there is `ENABLE_VMX` already in Intel’s common code. I was just confused by the commit message summary/title. File src/soc/intel/meteorlake/cpu.c: https://review.coreboot.org/c/coreboot/+/74161/comment/99d88725_7d3a464e PS3, Line 149: Vmx VMX -- To view, visit https://review.coreboot.org/c/coreboot/+/74161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e49c15fd4f78a3e633855fea550720f0a685062 Gerrit-Change-Number: 74161 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:22:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable VMX
by Subrata Banik (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74161 ) Change subject: soc/intel/meteorlake: Enable VMX ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74161/comment/5a3426d5_c11a5cec PS3, Line 11: > Shouldn’t VMX programming be left to the payload or OS? wondering if u have more background the justify your statement to leave VMC enablement to OS. why payload? who does multi-core feature programming in payload? -- To view, visit https://review.coreboot.org/c/coreboot/+/74161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e49c15fd4f78a3e633855fea550720f0a685062 Gerrit-Change-Number: 74161 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:17:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Order the CPUs based on their APIC IDs
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72131 ) Change subject: soc/intel/common: Order the CPUs based on their APIC IDs ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: The 9elements QA shows, Linux logs the messages below: ``` [ 30.055234] do_IRQ: 3.35 No irq handler for vector [ 31.056361] do_IRQ: 3.35 No irq handler for vector [ 31.070626] do_IRQ: 3.35 No irq handler for vector [ 31.084409] do_IRQ: 3.35 No irq handler for vector [ 31.099216] do_IRQ: 3.35 No irq handler for vector [ 31.113151] do_IRQ: 3.35 No irq handler for vector [ 31.127073] do_IRQ: 3.35 No irq handler for vector [ 31.140104] do_IRQ: 3.35 No irq handler for vector [ 31.153035] do_IRQ: 3.35 No irq handler for vector [ 31.164817] do_IRQ: 3.35 No irq handler for vector ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/72131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ab6053ffd036185d74d5469fbdf36d48e0021ce Gerrit-Change-Number: 72131 Gerrit-PatchSet: 12 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:16:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc: Update GCC from 11.3 to 12.2
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth, Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66922 ) Change subject: util/crossgcc: Update GCC from 11.3 to 12.2 ...................................................................... Patch Set 14: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/66922/comment/a48ee7ef_730682a2 PS14, Line 8: Please elaborate, what tests were performed, and maybe add the size changes for the QEMU targets. -- To view, visit https://review.coreboot.org/c/coreboot/+/66922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09 Gerrit-Change-Number: 66922 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:05:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Drop FSP CPU feature programming for ChromeOS
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74168 ) Change subject: soc/intel/meteorlake: Drop FSP CPU feature programming for ChromeOS ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74168/comment/45608fc7_3de59646 PS1, Line 10: those this https://review.coreboot.org/c/coreboot/+/74168/comment/061ab27b_7e55e34d PS1, Line 12: Please describe the problem, and document size and time savings. -- To view, visit https://review.coreboot.org/c/coreboot/+/74168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaed0a009813098610190b2a3a985b0748c0d51de Gerrit-Change-Number: 74168 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Benjamin Doron, Angel Pons, Maximilian Brune. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 1: (1 comment) File src/drivers/option/cfr.c: https://review.coreboot.org/c/coreboot/+/74121/comment/65bef89d_1ff82106 PS1, Line 19: uint32_t > cbtables records have a `uint32_t size;` field, and its width cannot be changed without breaking bac […] Thank you for your explanation. I commented because of [1], so to not increase the generated code. [1]: https://web.archive.org/web/*/https://notabs.org/coding/smallIntsBigPenalty… -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:02:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/smbios: Avoid buffer overflows
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Nico Huber, Angel Pons, Utkarsh Verma. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 ) Change subject: arch/x86/smbios: Avoid buffer overflows ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74128/comment/ea1bde66_0cb67e4d PS3, Line 9: The format specifiers for numbers in snprintf() calls are updated to be > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] The checkpatch comments are unfortunately added to the wrong line and refer to the line below, which is 76 characters long. https://review.coreboot.org/c/coreboot/+/74128/comment/b294a6fd_45cd9ac5 PS3, Line 21: The blank line could be removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/74128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbf93fd113791b6faa1e5128da8e692f7f00ac73 Gerrit-Change-Number: 74128 Gerrit-PatchSet: 3 Gerrit-Owner: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:00:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable VMX
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Option to drop redundant CPU feature programming
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Option to drop redundant CPU feature programming
by Paul Menzel (Code Review) 02 Apr '23

02 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74167 ) Change subject: soc/intel/meteorlake: Option to drop redundant CPU feature programming ...................................................................... Patch Set 1: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74167/comment/4285b8c8_96c51639 PS1, Line 7: Option to drop redundant CPU feature programming “Allow to …” or “Add option to …”. https://review.coreboot.org/c/coreboot/+/74167/comment/07bbb7e9_97c8b436 PS1, Line 14: these featureprogramming are this feature programming is https://review.coreboot.org/c/coreboot/+/74167/comment/af92342a_162c6798 PS1, Line 15: these this https://review.coreboot.org/c/coreboot/+/74167/comment/c9fe0afc_50da99ec PS1, Line 17: would results results https://review.coreboot.org/c/coreboot/+/74167/comment/731b9c31_72093f39 PS1, Line 17: in CPU exception Give an example? https://review.coreboot.org/c/coreboot/+/74167/comment/a08c3809_2e4dec91 PS1, Line 19: to should https://review.coreboot.org/c/coreboot/+/74167/comment/66e19d36_d7b12f2e PS1, Line 23: default by default https://review.coreboot.org/c/coreboot/+/74167/comment/64b8e7e3_032ad14a PS1, Line 25: Can’t coreboot detect if that firmware volume is present? -- To view, visit https://review.coreboot.org/c/coreboot/+/74167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3be5329390401024d7ec9eed85a5afc35ab1b776 Gerrit-Change-Number: 74167 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 13:46:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023