coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in blobs[master]: mb/starlabs/starbook/adl: Update EC binary to 1.07
by Sean Rhodes (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Sean Rhodes. Hello Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/73683 to look at the new patch set (#5). Change subject: mb/starlabs/starbook/adl: Update EC binary to 1.07 ...................................................................... mb/starlabs/starbook/adl: Update EC binary to 1.07 1.07 Disable PD requests when a normal USB-C device is connected Account for having two chargers connected Optimise the charging calculations 1.06 Strip PD responses to only include valid bits 1.05 Fix the charging voltage to 13.2V Only call Anx when USB-C PD chargers are connected Disable Hybrid-Power when charging current is less that 1536 1.04 Store power related variables in the EC RAM and mirror them to EC memory to avoid memory overflow to mitigate some strange behaviours when the EC memory overflows 1.03 Improved the reliability of DC Jack charging by modifying it to 800MHz, 3A Avoided charging stalling by continuously polling the SMBus after overcharge protection is active Exposed the behavior of overcharge protection to APCI Set the charge LED to purple when overcharge protection is active Modified fan curve Ensured the trackpad is in the desired state by polling its state every 10ms Set the brightness of the keyboard backlight to the maximum Streamlined the system by removing unused SMM events Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I3b08cb8b2b4e9e9836cd7e8c545fc83b2e0e3f99 --- M mainboard/starlabs/starbook/adl/ec.bin 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/83/73683/5 -- To view, visit https://review.coreboot.org/c/blobs/+/73683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I3b08cb8b2b4e9e9836cd7e8c545fc83b2e0e3f99 Gerrit-Change-Number: 73683 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in blobs[master]: mb/starlabs/starbook/adl: Update EC binary to 1.05
by Sean Rhodes (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Sean Rhodes. Hello Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/73683 to look at the new patch set (#4). Change subject: mb/starlabs/starbook/adl: Update EC binary to 1.05 ...................................................................... mb/starlabs/starbook/adl: Update EC binary to 1.05 1.07 Disable PD requests when a normal USB-C device is connected Account for having two chargers connected Optimise the charging calculations 1.06 Strip PD responses to only include valid bits 1.05 Fix the charging voltage to 13.2V Only call Anx when USB-C PD chargers are connected Disable Hybrid-Power when charging current is less that 1536 1.04 Store power related variables in the EC RAM and mirror them to EC memory to avoid memory overflow to mitigate some strange behaviours when the EC memory overflows 1.03 Improved the reliability of DC Jack charging by modifying it to 800MHz, 3A Avoided charging stalling by continuously polling the SMBus after overcharge protection is active Exposed the behavior of overcharge protection to APCI Set the charge LED to purple when overcharge protection is active Modified fan curve Ensured the trackpad is in the desired state by polling its state every 10ms Set the brightness of the keyboard backlight to the maximum Streamlined the system by removing unused SMM events Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I3b08cb8b2b4e9e9836cd7e8c545fc83b2e0e3f99 --- M mainboard/starlabs/starbook/adl/ec.bin 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/83/73683/4 -- To view, visit https://review.coreboot.org/c/blobs/+/73683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I3b08cb8b2b4e9e9836cd7e8c545fc83b2e0e3f99 Gerrit-Change-Number: 73683 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/common: Add code to order the different types of cores
by Jan Samek (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Subrata Banik, Sridhar Siricilla, Kyösti Mälkki, Elyes Haouas. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 ) Change subject: soc/intel/common: Add code to order the different types of cores ...................................................................... Patch Set 14: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72132/comment/4f9abe29_1f595488 PS14, Line 39: comptue compute -- To view, visit https://review.coreboot.org/c/coreboot/+/72132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21487a5eb0439ea0cb5976787d1769ee94777469 Gerrit-Change-Number: 72132 Gerrit-PatchSet: 14 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Apr 2023 07:31:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Add code to order the different types of cores
by Ronak Kanabar (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Subrata Banik, Sridhar Siricilla, Kyösti Mälkki, Elyes Haouas. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 ) Change subject: soc/intel/common: Add code to order the different types of cores ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21487a5eb0439ea0cb5976787d1769ee94777469 Gerrit-Change-Number: 72132 Gerrit-PatchSet: 14 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Apr 2023 07:18:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/smbios: Check str for NULL in smbios_add_string()
by Maximilian Brune (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Paul Menzel. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73980 ) Change subject: arch/x86/smbios: Check str for NULL in smbios_add_string() ...................................................................... Patch Set 3: (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/73980/comment/1ead99a8_be783e78 PS2, Line 48: if (str == NULL || *str == '\0') > It's basically just as useful as entering an empty string. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic228b869aea362c1f07e0808c2735ff3b285a6bd Gerrit-Change-Number: 73980 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 03 Apr 2023 06:22:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/omnigul: Add ADL and RPL dptf settings
by Subrata Banik (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Jamie Chen, Tarun Tuli, Kyle Lin, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73945 ) Change subject: mb/google/brya/var/omnigul: Add ADL and RPL dptf settings ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8280f82ff1534ea63bcb448da231712bb4abd6d3 Gerrit-Change-Number: 73945 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 05:04:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/omnigul: Add ADL and RPL dptf settings
by Sumeet R Pawnikar (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Jamie Chen, Tarun Tuli, Subrata Banik, Kyle Lin, Nick Vaccaro. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73945 ) Change subject: mb/google/brya/var/omnigul: Add ADL and RPL dptf settings ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8280f82ff1534ea63bcb448da231712bb4abd6d3 Gerrit-Change-Number: 73945 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 04:35:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/omnigul: Add ADL and RPL dptf settings
by Jamie Chen (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kyle Lin, Sumeet R Pawnikar, Nick Vaccaro. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73945 ) Change subject: mb/google/brya/var/omnigul: Add ADL and RPL dptf settings ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Hi Google, Please help to review. Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/73945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8280f82ff1534ea63bcb448da231712bb4abd6d3 Gerrit-Change-Number: 73945 Gerrit-PatchSet: 6 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 03:28:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: arch/x86/smbios: Fix file formatting
by Utkarsh Verma (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Angel Pons. Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 ) Change subject: arch/x86/smbios: Fix file formatting ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74170/comment/4494e606_24a7cd69 PS2, Line 9: minor > Not sure what "minor" is supposed to mean here. Oh yeah, chose the wrong word. I wanted to convey that no algorithmic changes are made. I'll fix it. File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/74170/comment/9de512cb_c357a18c PS2, Line 216: dimm->serial[1], dimm->serial[2], dimm->serial[3]); > It's a good idea to ask oneself whether the suggestions from automated tools make sense from a human […] Yes, I understand that and agree with it too. However, I also believe it helps to have the formatter autoformat the files. It reduces the development overhead, for me at least. The formatting is also reproducible, so it helps in collaborating. Anyhow, these are just my opinions. https://review.coreboot.org/c/coreboot/+/74170/comment/bc783a0c_a3d061ac PS2, Line 378: : t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED : | BIOS_CHARACTERISTICS_SELECTABLE_BOOT : | BIOS_CHARACTERISTICS_UPGRADEABLE; > This is not an improvement w.r.t. readability. Yes, but it was the result of the `.clang-format` file. Maybe we could update it to have the previous style. -- To view, visit https://review.coreboot.org/c/coreboot/+/74170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f44eec4d14d8b905f438c5305b640a33408c45 Gerrit-Change-Number: 74170 Gerrit-PatchSet: 3 Gerrit-Owner: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 03:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: arch/x86/smbios: Fix file formatting
by Utkarsh Verma (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Utkarsh Verma. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74170 to look at the new patch set (#3). Change subject: arch/x86/smbios: Fix file formatting ...................................................................... arch/x86/smbios: Fix file formatting This commit includes formatting changes made by clang-format. Change-Id: I40f44eec4d14d8b905f438c5305b640a33408c45 Signed-off-by: Utkarsh Verma <utkarsh(a)bitbanged.com> --- M src/arch/x86/smbios.c M src/arch/x86/smbios_defaults.c 2 files changed, 142 insertions(+), 163 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/74170/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f44eec4d14d8b905f438c5305b640a33408c45 Gerrit-Change-Number: 74170 Gerrit-PatchSet: 3 Gerrit-Owner: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023