coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mb/google/rex: Enable ACPI power resource for Fibocom modem
by Kapil Porwal (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74190 ) Change subject: mb/google/rex: Enable ACPI power resource for Fibocom modem ...................................................................... mb/google/rex: Enable ACPI power resource for Fibocom modem Enable ACPI power resource for Fibocom modem. BUG=b:253467124 TEST=Verify ACPI code for Fibocom moden in the OS. SSDT snippet: Scope (\_SB.PCI0.XHCI.RHUB.HS05) { Method (FHRF, 1, Serialized) { 0x22 = \_SB.PCI0.GTXS /* External reference */ Local0 Local0 ^= One If ((Local0 == Zero)) { \_SB.PCI0.CTXS (0x22) } Sleep (0x0A) \_SB.PCI0.CTXS (0x44) If ((Arg0 == Zero)) { Sleep (0x0A) } ElseIf ((Arg0 == One)) { Sleep (0x0A) \_SB.PCI0.CTXS (0x55) Sleep (0x01F4) } } Method (SHRF, 0, Serialized) { \_SB.PCI0.STXS (0x55) Sleep (0x14) \_SB.PCI0.STXS (0x44) Sleep (0x50) \_SB.PCI0.STXS (0x22) Sleep (0x64) } Method (_RST, 0, Serialized) // _RST: Device Reset { FHRF (Zero) SHRF () } Method (DPTS, 1, Serialized) { FHRF (One) } Device (MRST) { Name (_ADR, 0x0000000000000000) // _ADR: Address Method (_RST, 0, Serialized) // _RST: Device Reset { FHRF (One) SHRF () } } Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { PR00 }) Name (_PR3, Package (0x01) // _PR3: Power Resources for D3hot { PR00 }) PowerResource (PR00, 0x00, 0x0000) { Method (_STA, 0, Serialized) // _STA: Status { 0x22 = \_SB.PCI0.GTXS /* External reference */ Local0 Local0 ^= One If (Local0) { Return (Zero) } Return (One) } Method (_ON, 0, Serialized) // _ON_: Power On { Local0 = _STA () If ((Local0 == One)) { Return (Zero) } SHRF () } Method (_OFF, 0, Serialized) // _OFF: Power Off { FHRF (One) } } } Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: Iaaa1a0c65c6bab205213c108f84fd53328ac777b --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 135 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/74190/1 diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 44d20cb..226d806 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -202,6 +202,16 @@ register "type" = "UPC_TYPE_INTERNAL" device ref usb2_port5 on probe CELLULAR CELLULAR_USB + chip drivers/wwan/fm + register "fcpo_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E07)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A15)" + register "perst_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C05)" + register "wake_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F10)" + register "has_power_resource" = "1" + device generic 0 alias usb2_wwan on + probe CELLULAR CELLULAR_USB + end + end end end chip drivers/usb/acpi @@ -238,6 +248,16 @@ register "type" = "UPC_TYPE_INTERNAL" device ref usb3_port2 on probe CELLULAR CELLULAR_USB + chip drivers/wwan/fm + register "fcpo_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E07)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A15)" + register "perst_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C05)" + register "wake_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F10)" + register "has_power_resource" = "1" + device generic 0 alias usb3_wwan on + probe CELLULAR CELLULAR_USB + end + end end end end @@ -541,6 +561,7 @@ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A15)" register "perst_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C05)" register "wake_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F10)" + register "has_power_resource" = "1" register "add_acpi_dma_property" = "true" use rp6_rtd3 as rtd3dev device generic 0 alias rp6_wwan on -- To view, visit https://review.coreboot.org/c/coreboot/+/74190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaa1a0c65c6bab205213c108f84fd53328ac777b Gerrit-Change-Number: 74190 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: drivers/wwan/fm: Add ACPI power management for Fibocom modem
by Kapil Porwal (Code Review) 03 Apr '23

03 Apr '23

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74169 ) Change subject: drivers/wwan/fm: Add ACPI power management for Fibocom modem ...................................................................... drivers/wwan/fm: Add ACPI power management for Fibocom modem 1. Add power resource object 2. Use existing methods such as SHRF & FHRF to power on/off the modem 3. Do not use RTD3 object if it is not provided in devicetree BUG=b:253467124 TEST=Verify ACPI code for Fibocom moden in the OS. SSDT snippet: Scope (\_SB.PCI0.XHCI.RHUB.HS05) { Method (FHRF, 1, Serialized) { 0x22 = \_SB.PCI0.GTXS /* External reference */ Local0 Local0 ^= One If ((Local0 == Zero)) { \_SB.PCI0.CTXS (0x22) } Sleep (0x0A) \_SB.PCI0.CTXS (0x44) If ((Arg0 == Zero)) { Sleep (0x0A) } ElseIf ((Arg0 == One)) { Sleep (0x0A) \_SB.PCI0.CTXS (0x55) Sleep (0x01F4) } } Method (SHRF, 0, Serialized) { \_SB.PCI0.STXS (0x55) Sleep (0x14) \_SB.PCI0.STXS (0x44) Sleep (0x50) \_SB.PCI0.STXS (0x22) Sleep (0x64) } Method (_RST, 0, Serialized) // _RST: Device Reset { FHRF (Zero) SHRF () } Method (DPTS, 1, Serialized) { FHRF (One) } Device (MRST) { Name (_ADR, 0x0000000000000000) // _ADR: Address Method (_RST, 0, Serialized) // _RST: Device Reset { FHRF (One) SHRF () } } Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { PR00 }) Name (_PR3, Package (0x01) // _PR3: Power Resources for D3hot { PR00 }) PowerResource (PR00, 0x00, 0x0000) { Method (_STA, 0, Serialized) // _STA: Status { 0x22 = \_SB.PCI0.GTXS /* External reference */ Local0 Local0 ^= One If (Local0) { Return (Zero) } Return (One) } Method (_ON, 0, Serialized) // _ON_: Power On { Local0 = _STA () If ((Local0 == One)) { Return (Zero) } SHRF () } Method (_OFF, 0, Serialized) // _OFF: Power Off { FHRF (One) } } } Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I9024ec420425c5bf7d0605e961d08afe6f15eda6 --- M src/drivers/wwan/fm/acpi_fm350gl.c M src/drivers/wwan/fm/chip.h 2 files changed, 185 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/74169/1 diff --git a/src/drivers/wwan/fm/acpi_fm350gl.c b/src/drivers/wwan/fm/acpi_fm350gl.c index df91389..711d1d5 100644 --- a/src/drivers/wwan/fm/acpi_fm350gl.c +++ b/src/drivers/wwan/fm/acpi_fm350gl.c @@ -5,6 +5,9 @@ #include "chip.h" #include "soc/intel/common/block/pcie/rtd3/chip.h" +#define ACPI_POWER_RESOURCE_STATUS_ON_OP ONE_OP +#define ACPI_POWER_RESOURCE_STATUS_OFF_OP ZERO_OP + /* FCPO# to RESET# delay time during WWAN ON */ #define FM350GL_TN2B 20 /* RESET# to PERST# delay time during WWAN ON */ @@ -41,6 +44,9 @@ { const struct soc_intel_common_block_pcie_rtd3_config *rtd3_config; + if (!config->rtd3dev) + return ACPI_PCIE_RP_EMIT_NONE; + rtd3_config = config_of(config->rtd3dev); return rtd3_config->ext_pm_support; @@ -155,9 +161,11 @@ acpigen_emit_byte(RESET_TYPE_WARM); /* Perform 2nd Half of FLDR Flow: SHRF() */ acpigen_emit_namestring("SHRF"); - /* Indicates that the following _Off will be skipped. */ - acpigen_emit_byte(INCREMENT_OP); - acpigen_emit_namestring(acpi_device_path_join(parent_dev, "RTD3.OFSK")); + if (wwan_fm350gl_get_rtd3_method_support(config)) { + /* Indicates that the following _Off will be skipped. */ + acpigen_emit_byte(INCREMENT_OP); + acpigen_emit_namestring(acpi_device_path_join(parent_dev, "RTD3.OFSK")); + } } acpigen_write_method_end(); /* Method */ } @@ -176,10 +184,12 @@ acpigen_emit_byte(RESET_TYPE_COLD); /* Perform 2nd Half of FLDR Flow: SHRF () */ acpigen_emit_namestring("SHRF"); - /* Indicate kernel ACPI PM to skip _off RTD3 after reset at the end of - driver removal */ - acpigen_emit_byte(INCREMENT_OP); - acpigen_emit_namestring(acpi_device_path_join(parent_dev, "RTD3.OFSK")); + if (wwan_fm350gl_get_rtd3_method_support(config)) { + /* Indicate kernel ACPI PM to skip _off RTD3 after reset at the end of + driver removal */ + acpigen_emit_byte(INCREMENT_OP); + acpigen_emit_namestring(acpi_device_path_join(parent_dev, "RTD3.OFSK")); + } } acpigen_write_method_end(); /* Method */ } @@ -230,21 +240,22 @@ config->desc ?: dev->chip_ops->name); acpigen_write_scope(scope); { - acpigen_write_device(wwan_fm350gl_acpi_name(dev)); - { + if (wwan_fm350gl_get_rtd3_method_support(config)) { + acpigen_write_device(wwan_fm350gl_acpi_name(dev)); acpigen_write_ADR(0); if (config->name) acpigen_write_name_string("_DDN", config->name); if (config->desc) acpigen_write_name_unicode("_STR", config->desc); + if (config->add_acpi_dma_property) + acpi_device_add_dma_property(NULL); + } + wwan_fm350gl_acpi_method_fhrf(parent, config); wwan_fm350gl_acpi_method_shrf(parent, config); wwan_fm350gl_acpi_method_rst(parent, config); wwan_fm350gl_acpi_method_dpts(parent, config); - if (config->add_acpi_dma_property) - acpi_device_add_dma_property(NULL); - /* NOTE: the 5G driver will call MRST._RST to trigger a cold reset * during firmware update. */ @@ -255,8 +266,49 @@ } acpigen_write_device_end(); /* Device */ + + if (config->has_power_resource) { + static const char * const power_res_dev_states[] = { "_PR0", "_PR3" }; + /* PowerResource (PR##, 0, 0) */ + acpigen_write_power_res("PR00", 0, 0, power_res_dev_states, + ARRAY_SIZE(power_res_dev_states)); + + acpigen_write_method_serialized("_STA", 0); + /* Read GPIO status into Local0. */ + acpigen_get_tx_gpio(&config->perst_gpio); + acpigen_write_if(); + acpigen_emit_byte(LOCAL0_OP); + acpigen_write_return_op(ACPI_POWER_RESOURCE_STATUS_OFF_OP); + acpigen_write_if_end(); + acpigen_write_return_op(ACPI_POWER_RESOURCE_STATUS_ON_OP); + acpigen_pop_len(); /* Method */ + + /* Method (_ON, 0, Serialized) */ + acpigen_write_method_serialized("_ON", 0); + /* Local0 = _STA () */ + acpigen_write_store(); + acpigen_emit_namestring("_STA"); + acpigen_emit_byte(LOCAL0_OP); + /* If (( Local0 == ACPI_POWER_RESOURCE_STATUS_ON_OP)) */ + acpigen_write_if_lequal_op_op(LOCAL0_OP, ACPI_POWER_RESOURCE_STATUS_ON_OP); + acpigen_write_return_op(ZERO_OP); + acpigen_write_if_end(); + // Call SHRF i.e. Modem ON + acpigen_emit_namestring("SHRF"); + acpigen_pop_len(); /* _ON method */ + + /* Method (_OFF, 0, Serialized) */ + acpigen_write_method_serialized("_OFF", 0); + // Call FHRF i.e. Modem OFF + acpigen_emit_namestring("FHRF"); + acpigen_emit_byte(RESET_TYPE_COLD); + acpigen_pop_len(); /* _OFF method */ + + acpigen_pop_len(); /* PowerResource PR## */ } - acpigen_write_device_end(); /* Device */ + + if (wwan_fm350gl_get_rtd3_method_support(config)) + acpigen_write_device_end(); /* Device */ } acpigen_write_scope_end(); /* Scope */ } diff --git a/src/drivers/wwan/fm/chip.h b/src/drivers/wwan/fm/chip.h index 19bc4c9..2ffe5d8 100644 --- a/src/drivers/wwan/fm/chip.h +++ b/src/drivers/wwan/fm/chip.h @@ -23,6 +23,9 @@ /* Add `DmaProperty` in _DSD */ bool add_acpi_dma_property; + + /* Add ACPI Power Resource object(s) */ + bool has_power_resource; }; #endif /* __DRIVERS_WWAN_FM_CHIP_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9024ec420425c5bf7d0605e961d08afe6f15eda6 Gerrit-Change-Number: 74169 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/cmn: Implement HECI commands to get version details of ISHC
by Dinesh Gehlot (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74005 to look at the new patch set (#11). Change subject: soc/intel/cmn: Implement HECI commands to get version details of ISHC ...................................................................... soc/intel/cmn: Implement HECI commands to get version details of ISHC The patch stores the ISHC and CSE version in the CBMEM table. It verifies CSE has been updated by comparing old and current CSE versions. If it has, the patch updates the current CSE version in the CBMEM table and communicates with the ME using the HECI command to acquire the current ISHC version. It then updates the CBMEM table with the current ISHC version. BUG=b:273661726 Test=HECI version is obtained from CSE and successfully stored Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/soc/intel/common/block/cse/Makefile.inc M src/soc/intel/common/block/cse/cse_lite.c A src/soc/intel/common/block/cse/cse_partition_version.c M src/soc/intel/common/block/include/intelblocks/cse.h 5 files changed, 109 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74005/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 11 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmn: Implement HECI commands to get version details of ISHC
by build bot (Jenkins) (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 ) Change subject: soc/intel/cmn: Implement HECI commands to get version details of ISHC ...................................................................... Patch Set 10: (1 comment) File src/soc/intel/common/block/include/intelblocks/cse.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172909): https://review.coreboot.org/c/coreboot/+/74005/comment/6dcdc710_3128c99d PS10, Line 143: }fw_partition_version; space required after that close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 08:18:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn: Implement HECI commands to get version details of ISHC
by Dinesh Gehlot (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74005 to look at the new patch set (#10). Change subject: soc/intel/cmn: Implement HECI commands to get version details of ISHC ...................................................................... soc/intel/cmn: Implement HECI commands to get version details of ISHC The patch stores the ISHC and CSE version in the CBMEM table. It verifies CSE has been updated by comparing old and current CSE versions. If it has, the patch updates the current CSE version in the CBMEM table and communicates with the ME using the HECI command to acquire the current ISHC version. It then updates the CBMEM table with the current ISHC version. BUG=b:273661726 Test=HECI version is obtained from CSE and successfully stored Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/soc/intel/common/block/cse/Makefile.inc M src/soc/intel/common/block/cse/cse_lite.c A src/soc/intel/common/block/cse/cse_partition_version.c M src/soc/intel/common/block/include/intelblocks/cse.h 5 files changed, 109 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74005/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/intel/alderlake: Add support for CSE timestamp data versions
by Subrata Banik (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Bora Guvendik, Tarun Tuli, Wonkyu Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73712 ) Change subject: soc/intel/alderlake: Add support for CSE timestamp data versions ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I780e250707d1d04891a5a1210b30aecb2c8620d3 Gerrit-Change-Number: 73712 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.corp-partner.google.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 08:03:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "mb/starlabs/*: Remove sleepstates.asl"
by Sean Rhodes (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Benjamin Doron, Maximilian Brune, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73894 ) Change subject: Revert "mb/starlabs/*: Remove sleepstates.asl" ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Well, they shouldn't be *too* big. […] Misses those, created PR and what not - S4 works on my ADL with it. Yes, most distros' would boot - it was Qubes, Promox and a couple of others that wouldn't. -- To view, visit https://review.coreboot.org/c/coreboot/+/73894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e90266e66192b328b9af51c5e614774a248ddf0 Gerrit-Change-Number: 73894 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 07:55:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Add CMOS entries for the mirror flag
by Sean Rhodes (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Sean Rhodes. Hello Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73682 to look at the new patch set (#9). Change subject: mb/starlabs/starbook/adl: Add CMOS entries for the mirror flag ...................................................................... mb/starlabs/starbook/adl: Add CMOS entries for the mirror flag Add the required CMOS entries for the mirror flag, so that it can be enabled from a defconfig. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I174ac896df050480ee90c8141c5536b628c98432 --- M src/mainboard/starlabs/lite/cmos.default M src/mainboard/starlabs/lite/cmos.layout M src/mainboard/starlabs/lite/variants/glkr/cmos.default M src/mainboard/starlabs/lite/variants/glkr/cmos.layout M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout M src/mainboard/starlabs/starbook/variants/tgl/cmos.default M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 8 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/73682/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/73682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I174ac896df050480ee90c8141c5536b628c98432 Gerrit-Change-Number: 73682 Gerrit-PatchSet: 9 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Adjust USB port macros
by Sean Rhodes (Code Review) 03 Apr '23

03 Apr '23

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/72668 ) Change subject: mb/starlabs/starbook/adl: Adjust USB port macros ...................................................................... Abandoned No needed -- To view, visit https://review.coreboot.org/c/coreboot/+/72668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddb950493ce6944a90254f95f8ef2c99f9058d5b Gerrit-Change-Number: 72668 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Adjust USB port macros
by Sean Rhodes (Code Review) 03 Apr '23

03 Apr '23

Attention is currently required from: Paul Menzel, Angel Pons, Eric Lai. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72668 ) Change subject: mb/starlabs/starbook/adl: Adjust USB port macros ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddb950493ce6944a90254f95f8ef2c99f9058d5b Gerrit-Change-Number: 72668 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 07:48:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023