Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74176 )
Change subject: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
> I don't disagree there - but this is the one major patch we can't merge upstream. […]
I hope upstream merges it at some point, possibly into edk2-platforms PlatformPayloadFeature if we must, but I'm alright with the status quo until then: upstream EDK2 doesn't have SMMSTORE support, users should choose a fork that does. I worry that trying to script `git am` will risk maintaining a mess of slightly different patches per checkout...
What was upstream's rationale? Something like 'UefiPayload isn't for bootloader-specific parts?' Do we have room to push back or is PlatformPayloadFeature good enough?
Patchset:
PS3:
> pretty sure the size was set to 64k due to needing 2 32k blocks at a minimum per UEFI spec
Yeah, I recall that... Seems there's a maximum in this case too. Possibly `SMM_BLOCK_SIZE`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10d2a5a0c1d729d83e0b62bb9430863317b883cc
Gerrit-Change-Number: 74176
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 Apr 2023 03:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add tablet Starmie as variant
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74048/comment/ee8fb7a3_0929de98
PS6, Line 7: Introduce a tablet 'Starmie'
> Maybe: Add tablet Starmie as variant
Done
https://review.coreboot.org/c/coreboot/+/74048/comment/868042c0_efb95343
PS6, Line 11: display(MIPI interface and w/o bridge)
> Please add a space before (.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 7
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 03:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Ruihai Zhou, cong yang.
Hello build bot (Jenkins), cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74048
to look at the new patch set (#7).
Change subject: mb/google/corsola: Add tablet Starmie as variant
......................................................................
mb/google/corsola: Add tablet Starmie as variant
The 'Starmie' is a mt8186 tablet reference design that will share most
of Corsola design. For AP firmware, there will be a few changes, mostly
in display (MIPI interface and w/o bridge), so we create it as variants
in Corsola.
BUG=b:275470328
BRANCH=corsola
TEST=./util/abuild/abuild -t google/corsola -b starmie -a
Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/corsola/Kconfig.name
M src/mainboard/google/corsola/display.c
3 files changed, 33 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/74048/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 7
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens.
Hello Stefan Ott, build bot (Jenkins), Alexander Couzens,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74182
to look at the new patch set (#2).
Change subject: mb/lenovo/x200/blc: Add LTN121AT07L02 at 110MHz
......................................................................
mb/lenovo/x200/blc: Add LTN121AT07L02 at 110MHz
The vendor sets BLC_PWM_CTL to 0x31313131.
Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M src/mainboard/lenovo/x200/blc.c
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/74182/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
Gerrit-Change-Number: 74182
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Stefan Ott, Alexander Couzens.
Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74182 )
Change subject: mb/lenovo/x200/blc: Add LTN121AT07L02 at 110MHz
......................................................................
mb/lenovo/x200/blc: Add LTN121AT07L02 at 110MHz
The vendor sets BLC_PWM_CTL to 0x31313131.
Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
---
M src/mainboard/lenovo/x200/blc.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/74182/1
diff --git a/src/mainboard/lenovo/x200/blc.c b/src/mainboard/lenovo/x200/blc.c
index 02b16d1..7ed7717 100644
--- a/src/mainboard/lenovo/x200/blc.c
+++ b/src/mainboard/lenovo/x200/blc.c
@@ -18,6 +18,7 @@
{"B121EW09 V3 ", 400},
{"HV121WX4-120", 110}, /* Aftermarket AFFS lcd, works well at low pwm */
{"LTN121AT03001", 110},
+ {"LTN121AT07L02", 110},
{"LTN121AP03001", 750},
/* TODO: untested panels found on thinkwiki */
/* Generally CCFL runs best at lower PWM */
--
To view, visit https://review.coreboot.org/c/coreboot/+/74182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
Gerrit-Change-Number: 74182
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newchange
Attention is currently required from: Stefan Ott, Alexander Couzens.
Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74181 )
Change subject: mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
......................................................................
mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
mainboard_vbt_filename() used to assume that it is called after a call
to get_blc_pwm_freq_value() with a valid parameter, but currently it
is the first call of get_blc_pwm_freq_value(NULL), and will return 0,
making "data_led.vbt" is always returned, regardless of the actual
type of the panel.
Combined with the previous commit, in this commit
mainboard_vbt_filename() will explicitly read EDID string via
get_edid_str() and use this string to call get_blc_pwm_freq_value().
This will resolve https://ticket.coreboot.org/issues/475 .
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4
---
M src/mainboard/lenovo/x200/blc.c
1 file changed, 25 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/74181/1
diff --git a/src/mainboard/lenovo/x200/blc.c b/src/mainboard/lenovo/x200/blc.c
index ef2dbb1..02b16d1 100644
--- a/src/mainboard/lenovo/x200/blc.c
+++ b/src/mainboard/lenovo/x200/blc.c
@@ -4,6 +4,7 @@
#include <commonlib/helpers.h>
#include <console/console.h>
#include <northbridge/intel/gm45/gm45.h>
+#include <device/pci.h>
#include <drivers/intel/gma/opregion.h>
static const struct blc_pwm_t blc_entries[] = {
@@ -36,9 +37,8 @@
const char *mainboard_vbt_filename(void)
{
- u16 pwm_freq;
-
- pwm_freq = get_blc_pwm_freq_value(NULL);
+ struct device *gma = pcidev_path_on_root(PCI_DEVFN(0x2, 0));
+ u16 pwm_freq = gma ? get_blc_pwm_freq_value(get_edid_str(gma)) : 0;
if (pwm_freq == 0) {
printk(BIOS_DEBUG,
--
To view, visit https://review.coreboot.org/c/coreboot/+/74181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4
Gerrit-Change-Number: 74181
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newchange