Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74181 )
Change subject: mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4
Gerrit-Change-Number: 74181
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 04 Apr 2023 10:53:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74182 )
Change subject: mb/lenovo/x200/blc: Add LTN121AT07L02 at 750Hz
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
Gerrit-Change-Number: 74182
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 04 Apr 2023 10:52:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, ritul guru, Anand Vaikar, Fred Reitberger, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74075 )
Change subject: mb/amd/mayan: Correct PCIe bridge for M.2 NVMe SSD0
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74075/comment/8c865839_46e36f20
PS4, Line 10: updated
update
https://review.coreboot.org/c/coreboot/+/74075/comment/6356e3db_708d14cc
PS4, Line 12: Builds
and boots
https://review.coreboot.org/c/coreboot/+/74075/comment/eff27e05_a04058a6
PS4, Line 12: TEST: Builds, the device enumerates.
Maybe paste the log line from coreboot.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74075
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43096beda0405bd392574319d50e7cd6a7f8d291
Gerrit-Change-Number: 74075
Gerrit-PatchSet: 4
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 04 Apr 2023 10:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens.
Hello Stefan Ott, build bot (Jenkins), Arthur Heymans, Alexander Couzens,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74182
to look at the new patch set (#6).
Change subject: mb/lenovo/x200/blc: Add LTN121AT07L02 at 750Hz
......................................................................
mb/lenovo/x200/blc: Add LTN121AT07L02 at 750Hz
The vendor sets BLC_PWM_CTL to 0x31313131.
This value seems working well on the x200 with this panel, which is
said to be LED.
Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M src/mainboard/lenovo/x200/blc.c
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/74182/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/74182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191
Gerrit-Change-Number: 74182
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens.
Hello Stefan Ott, build bot (Jenkins), Arthur Heymans, Alexander Couzens,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74181
to look at the new patch set (#5).
Change subject: mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
......................................................................
mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
mainboard_vbt_filename() used to assume that it is called after a call
to get_blc_pwm_freq_value() with a valid parameter, but currently it
is the first call of get_blc_pwm_freq_value(NULL), and will return 0,
making "data_led.vbt" is always returned, regardless of the actual
type of the panel.
Combined with the previous commit, in this commit
mainboard_vbt_filename() will explicitly read EDID string via
get_edid_str() and use this string to call get_blc_pwm_freq_value().
This will resolve https://ticket.coreboot.org/issues/475 .
Tested on my x200s with LTD121EQ3B (LED), and x200 with LTD121EWVB
(CCFL).
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4
---
M src/mainboard/lenovo/x200/blc.c
1 file changed, 28 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/74181/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4
Gerrit-Change-Number: 74181
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Ravishankar Sarawadi, Kapil Porwal, John Zhao, Sumeet R Pawnikar, Ivy Jian, Eric Lai, Peter Ou.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71166 )
Change subject: mb/google/rex: Add DTT thermal settings for policies
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71166/comment/e8f87530_7e167a65
PS5, Line 129: # TODO: below values are initial reference values only
can u please keep a bug open for tracking purpose and add here as `FIXME`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/71166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00dd97b759c8c68edaeeb4d64422b83c5e86981d
Gerrit-Change-Number: 71166
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 10:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment