Nicholas Chin has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/74188 )
Change subject: Documentation: Fix broken URLs
......................................................................
Documentation: Fix broken URLs
- VBT information: The link from 01.org is dead, but appears to have
been identital to the i915 page in the Linux kernel docs based on
snapshots on archive.org.
- Cgit: coreboot no longer appears to have cgit running for the repo
and these links redirect to the list of repos hosted on
review.coreboot.org. Replace these with an equivalent Gitiles link.
Change-Id: Id0bfee7b806c851fbe1dcf357e14d9b593e8569a
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/acronyms.md
M Documentation/index.md
2 files changed, 23 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74188/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/74188
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0bfee7b806c851fbe1dcf357e14d9b593e8569a
Gerrit-Change-Number: 74188
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Hannah Williams, Subrata Banik, Dinesh Gehlot, Jay Patel.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72931 )
Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS8:
> Similar observation, Timestamps are same and "EC returned error result code 1" is appeared in boot l […]
We should have bug for this. Jay, can you update bug info in commit message?
And will it be better to add error message in case EC return error in insert_ec_event_timestamps function?
--
To view, visit https://review.coreboot.org/c/coreboot/+/72931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9
Gerrit-Change-Number: 72931
Gerrit-PatchSet: 11
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 01:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com>
Comment-In-Reply-To: Jay Patel <jay2.patel(a)intel.com>
Gerrit-MessageType: comment
Nicholas Chin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/74188 )
Change subject: Documentation: Fix broken URLs
......................................................................
Documentation: Fix broken URLs
- VBT information: The link from 01.org is dead, but appears to have
been identital to the i915 page in the Linux kernel docs based on
snapshots on archive.org.
- Cgit: coreboot no longer appears to have cgit running for the repo
and these links redirect to the list of repos hosted on
review.coreboot.org. Replace these with an equivalent Gitiles link.
Change-Id: Id0bfee7b806c851fbe1dcf357e14d9b593e8569a
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/acronyms.md
M Documentation/index.md
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74188/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74188
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0bfee7b806c851fbe1dcf357e14d9b593e8569a
Gerrit-Change-Number: 74188
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74188 )
Change subject: Documentation: Fix broken urls
......................................................................
Documentation: Fix broken urls
- VBT information: The link from 01.org is dead, but appears to have
been identital to the i915 page in the Linux kernel docs based on
snapshots on archive.org.
- Cgit: coreboot no longer appears to have cgit running for the repo
and these links redirect to the list of repos hosted on
review.coreboot.org. Replace these with an equivalent Gitiles link.
Change-Id: Id0bfee7b806c851fbe1dcf357e14d9b593e8569a
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/acronyms.md
M Documentation/index.md
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74188/1
diff --git a/Documentation/acronyms.md b/Documentation/acronyms.md
index 7eb6112..908d5a6 100644
--- a/Documentation/acronyms.md
+++ b/Documentation/acronyms.md
@@ -1037,7 +1037,7 @@
* VBIOS - Video BIOS
* VBNV - Vboot Non-Volatile storage
* VBT - [**Video BIOS
- Table**](https://01.org/linuxgraphics/gfx-docs/drm/ch04s02.html#id-1.4.3.4.…
+ Table**](https://www.kernel.org/doc/html/latest/gpu/i915.html#video-bios-ta…
* VESA - Video Electronics Standards Association
* VGA: Video Graphics Array
* VID: Vendor Identifier
diff --git a/Documentation/index.md b/Documentation/index.md
index 44e52a2..a1ff716 100644
--- a/Documentation/index.md
+++ b/Documentation/index.md
@@ -2,7 +2,7 @@
This is the developer documentation for [coreboot](https://coreboot.org).
It is built from Markdown files in the
-[Documentation](https://review.coreboot.org/cgit/coreboot.git/tree/Documentation)
+[Documentation](https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/Documentation/)
directory in the source code.
## Spelling of coreboot
@@ -143,7 +143,7 @@
## Getting the source code
coreboot is primarily developed in the
-[git](https://review.coreboot.org/cgit/coreboot.git) version control
+[git](https://review.coreboot.org/plugins/gitiles/coreboot) version control
system, using [Gerrit](https://review.coreboot.org) to manage
contributions and code review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74188
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0bfee7b806c851fbe1dcf357e14d9b593e8569a
Gerrit-Change-Number: 74188
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Bora Guvendik, Hannah Williams, Subrata Banik, Jay Patel.
Hello Bora Guvendik, build bot (Jenkins), Hannah Williams,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72931
to look at the new patch set (#11).
Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
......................................................................
soc/intel/cmn/blk: Request pre-reset EC boot timestamps
coreboot requests pre-reset power signal timestamps to the EC. These
timestamps are used to calculate pre-reset boot time and inserted into
the coreboot timestamp table.
BUG=None
TEST=Pre-reset timestamps added to cbmem timestamp table if flag
enabled in Kconfig file and feature enabled from romstage for
specific board.
Signed-off-by: jaypatel256 <jay2.patel(a)intel.com>
Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9
---
A src/soc/intel/common/block/ec_telemetry/Kconfig
A src/soc/intel/common/block/ec_telemetry/Makefile.inc
A src/soc/intel/common/block/ec_telemetry/ec_telemetry.c
A src/soc/intel/common/block/include/intelblocks/ec_telemetry.h
4 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/72931/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/72931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9
Gerrit-Change-Number: 72931
Gerrit-PatchSet: 11
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-MessageType: newpatchset