Attention is currently required from: Dinesh Gehlot.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/cmn: Implement an API to get ISHC version
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74209/comment/55a3e186_cd89f354
PS2, Line 7: soc/intel/cmn
soc/intel/cmd/block/cse
https://review.coreboot.org/c/coreboot/+/74209/comment/b09a0aed_42072ddd
PS2, Line 13: ISHC version is verified on the Nissa board using a debug patch
Able to build and boot google/nivviks.
here is the ISH version output with this patch
```
Add the ISH version info,
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/74209
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8
Gerrit-Change-Number: 74209
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:52:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Hannah Williams, Jay Patel.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72889 )
Change subject: cmnlb/include/ts_ser: Add Pre-reset boot timestamps' IDs
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72889/comment/2dfde164_cf50985f
PS6, Line 2: jaypatel256
Please use your name.
https://review.coreboot.org/c/coreboot/+/72889/comment/e5b7cafe_46789030
PS6, Line 14: jaypatel256
Ditto.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503dedcd574d13cf958be19bd613f7f9f3ba8163
Gerrit-Change-Number: 72889
Gerrit-PatchSet: 6
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:48:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Hannah Williams, Jay Patel, Boris Mittelberg.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72930 )
Change subject: ec/google/ec_cmd: EC command for pre-reset boot timestamps
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72930/comment/5c2e579e_a4efda96
PS7, Line 2: jaypatel256
Please configure your local git:
$ git config --global user.name "…"
$ git commit --amend --authohr="… <…>"
https://review.coreboot.org/c/coreboot/+/72930/comment/881df289_4ab8fcc2
PS7, Line 7: ec/google/ec_cmd: EC command for pre-reset boot timestamps
Please make it a statement by adding a verb (in imperative mood): Add EC command …
https://review.coreboot.org/c/coreboot/+/72930/comment/5f02e9f4_0e8c2750
PS7, Line 11:
Please add a reasoning/motivation.
https://review.coreboot.org/c/coreboot/+/72930/comment/a0ddfa55_f39e44b3
PS7, Line 15: jaypatel256
Ditto.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9324c844c04472b5ed07c5e11e263037712df59
Gerrit-Change-Number: 72930
Gerrit-PatchSet: 7
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Benjamin Doron, Maximilian Brune, Arthur Heymans, Felix Held.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68892 )
Change subject: cpu/mp_init.c: Only enable CPUs once they execute code
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c8042b4d6127239175924f996f735bf9c83c6e8
Gerrit-Change-Number: 68892
Gerrit-PatchSet: 23
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:41:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Tarun Tuli, Subrata Banik, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64802 )
Change subject: cpu/smm_module_loader.c: Fix up CPU index locally
......................................................................
Patch Set 27: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/64802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070bc00ae5e5bceb6c5b90ea833cc057dd41f6cc
Gerrit-Change-Number: 64802
Gerrit-PatchSet: 27
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:41:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Patrick Rudolph, Paul Menzel, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64625 )
Change subject: cpu/x86/mp_init.c: Generate a C header to get start32 offset
......................................................................
Patch Set 27: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/64625
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic01badd2af11a6e1dbc27c8e928916fedf104b5b
Gerrit-Change-Number: 64625
Gerrit-PatchSet: 27
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 05 Apr 2023 07:41:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment