coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/brya: Enable asynchronous End-Of-Post
by Tarun Tuli (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Subrata Banik, Jérémy Compostella, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74215 ) Change subject: mb/google/brya: Enable asynchronous End-Of-Post ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib850330fbb9e84839eb1093db054332cbcb59b41 Gerrit-Change-Number: 74215 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:37:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table
by Subrata Banik (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Dinesh Gehlot. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 ) Change subject: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74208/comment/8649f5c7_1b43a59a PS4, Line 219: u start with caps https://review.coreboot.org/c/coreboot/+/74208/comment/6fbc8ffb_4eeea84e PS4, Line 229: live_cse very innovative variable name, bt can u rename to make it more meaningful -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details
by Subrata Banik (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: SRIDHAR SIRICILLA, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Dinesh Gehlot, Kapil Porwal, Meera Ravindranath. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 ) Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ...................................................................... Patch Set 15: (3 comments) File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/74005/comment/4189a901_ac55c268 PS14, Line 1216: cse_get_partition_info > please remain to `send_get_boot_partition_info_cmd` Ack https://review.coreboot.org/c/coreboot/+/74005/comment/0c719a4e_d7b8a5a9 PS14, Line 1216: bool > static bool Ack https://review.coreboot.org/c/coreboot/+/74005/comment/377ef51e_33837597 PS14, Line 1239: > We should add a check to avoid sending ISHC partition info if platform doesn't have ISH partition it […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 15 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:30:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Dinesh Gehlot. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74208 to look at the new patch set (#4). Change subject: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table ...................................................................... soc/intel/cmn/block: Store CSE and ISHC version into cbmem table The patch stores the ISHC and CSE version in the CBMEM table. It verifies CSE has been updated by comparing old and current CSE versions. If it has, the patch updates the current CSE version in the CBMEM table. It then updates the CBMEM table with the current ISHC version. BUG=b:273661726 Test=The current and old cse and ishc versions are verified on the nissa during cold and warm reboots. Additionally, version updates are verified by a debug patch that purposely updated the stored cse version. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 3 files changed, 80 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74208/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details
by Subrata Banik (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: SRIDHAR SIRICILLA, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Dinesh Gehlot, Kapil Porwal, Meera Ravindranath. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 ) Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: @Intel Team: can you please help to review the code -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 15 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:29:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs/config.lenovo_t400_vboot_and_debug: Move PT lower
by Arthur Heymans (Code Review) 05 Apr '23

05 Apr '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74219 ) Change subject: configs/config.lenovo_t400_vboot_and_debug: Move PT lower ...................................................................... configs/config.lenovo_t400_vboot_and_debug: Move PT lower Bootblock gets too big, so move the RO page table downwards. Change-Id: I3f72d1639478eaaac09d7cfb3408944ac76307c4 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M configs/config.lenovo_t400_vboot_and_debug 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/74219/1 diff --git a/configs/config.lenovo_t400_vboot_and_debug b/configs/config.lenovo_t400_vboot_and_debug index 39c17e6..74ec35b 100644 --- a/configs/config.lenovo_t400_vboot_and_debug +++ b/configs/config.lenovo_t400_vboot_and_debug @@ -13,3 +13,4 @@ CONFIG_H8_FN_KEY_AS_VBOOT_RECOVERY_SW=y CONFIG_VBOOT=y CONFIG_USE_EXP_X86_64_SUPPORT=y +CONFIG_ARCH_X86_64_PGTBL_LOC=0xfffe8000 # Bootblock is getting too big -- To view, visit https://review.coreboot.org/c/coreboot/+/74219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f72d1639478eaaac09d7cfb3408944ac76307c4 Gerrit-Change-Number: 74219 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: security/vboot: Don't add RO pagetables to RW_A/B
by Arthur Heymans (Code Review) 05 Apr '23

05 Apr '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74218 ) Change subject: security/vboot: Don't add RO pagetables to RW_A/B ...................................................................... security/vboot: Don't add RO pagetables to RW_A/B Currently this is only used in bootblock and expects a fixed offset. Change-Id: I3c4db6fffe3343f12383fe9585620ffefb01cf81 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/vboot/Makefile.inc 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/74218/1 diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 9e42ab1..ba83c3b 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -199,6 +199,7 @@ intel_fit \ intel_fit_ts \ fspt.bin \ + pagetables \ $(call strip_quotes,$(CONFIG_RO_REGION_ONLY)) \ ,$(1)),COREBOOT,\ $(if $(filter \ -- To view, visit https://review.coreboot.org/c/coreboot/+/74218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c4db6fffe3343f12383fe9585620ffefb01cf81 Gerrit-Change-Number: 74218 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: configs/config.amd_mayan: Add defconfig file for Mayan board
by Anand Vaikar (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: ritul guru, Paul Menzel, Eric Lai, Fred Reitberger, Felix Held. Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74057 ) Change subject: configs/config.amd_mayan: Add defconfig file for Mayan board ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74057/comment/68c4d48c_63385b5d PS2, Line 7: configs/config.amd_mayan:Add > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/74057/comment/14c9eedc_9865596e PS2, Line 7: the > The article could be omitted in the summary. Done https://review.coreboot.org/c/coreboot/+/74057/comment/bdfeaa7f_0add30f4 PS2, Line 8: > What is the difference to the default config created for that board? This file (config.amd_mayan) introduces the set of default configs we are using for mayan. There is no default config file added so far for mayan in "configs/" folder and all the configs are picked up from Kconfig files. -- To view, visit https://review.coreboot.org/c/coreboot/+/74057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Gerrit-Change-Number: 74057 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:29:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: configs/config.amd_mayan: Add defconfig file for Mayan board
by Anand Vaikar (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: ritul guru, Eric Lai, Anand Vaikar, Fred Reitberger, Felix Held. Hello build bot (Jenkins), ritul guru, Eric Lai, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74057 to look at the new patch set (#3). Change subject: configs/config.amd_mayan: Add defconfig file for Mayan board ...................................................................... configs/config.amd_mayan: Add defconfig file for Mayan board Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- A configs/config.amd_mayan 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/74057/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Gerrit-Change-Number: 74057 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in gerrit-avatars[master]: Add avatar for 1002542 (Jan Samek).
by Jan Samek (Code Review) 05 Apr '23

05 Apr '23

Jan Samek has submitted this change. ( https://review.coreboot.org/c/gerrit-avatars/+/74232 ) Change subject: Add avatar for 1002542 (Jan Samek). ...................................................................... Add avatar for 1002542 (Jan Samek). Signed-off-by: Jan Samek <jan.samek(a)siemens.com> Change-Id: I870f458a6ae8b6707d329c80e138d3876daacb90 --- A 1002542.jpg 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified; Looks good to me, approved diff --git a/1002542.jpg b/1002542.jpg new file mode 100644 index 0000000..aa2fcd3 --- /dev/null +++ b/1002542.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/74232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I870f458a6ae8b6707d329c80e138d3876daacb90 Gerrit-Change-Number: 74232 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023