coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: configs/config.amd_mayan:Add the defconfig file for Mayan board
by Anand Vaikar (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: ritul guru, Eric Lai, Fred Reitberger, Felix Held. Hello build bot (Jenkins), ritul guru, Eric Lai, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74057 to look at the new patch set (#2). Change subject: configs/config.amd_mayan:Add the defconfig file for Mayan board ...................................................................... configs/config.amd_mayan:Add the defconfig file for Mayan board Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- A configs/config.amd_mayan 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/74057/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Gerrit-Change-Number: 74057 Gerrit-PatchSet: 2 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/lenovo/x200/blc: Add LTN121AT07L02 at 750Hz
by Angel Pons (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74182 ) Change subject: mb/lenovo/x200/blc: Add LTN121AT07L02 at 750Hz ...................................................................... Patch Set 8: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74182/comment/cda5d5dd_602d98b0 PS8, Line 7: LTN121AT07L02 nit: Looks like the actual panel model is `LTN121AT07-L02` with a hyphen. https://review.coreboot.org/c/coreboot/+/74182/comment/adeb8b55_2e652856 PS8, Line 12: said to be LED Seems to be right: https://www.panelook.com/LTN121AT07-L02_Samsung_12.1_LCM_overview_12632.html -- To view, visit https://review.coreboot.org/c/coreboot/+/74182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b0ec04c6f6fcb6d4027a5114698db87d7718191 Gerrit-Change-Number: 74182 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:01:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: nb/intel/gm45: Export EDID-reading routine as a function
by Angel Pons (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Bill XIE. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74180 ) Change subject: nb/intel/gm45: Export EDID-reading routine as a function ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdbe4d76f9b59e7ae83b60cda042c2d1c39827ca Gerrit-Change-Number: 74180 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:57:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
by Angel Pons (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74181 ) Change subject: mb/lenovo/x200: Read EDID in mainboard_vbt_filename() ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4 Gerrit-Change-Number: 74181 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "soc/intel/cmn/cse: Handle EOP completion asynchronously"
by Paul Menzel (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Nick Vaccaro. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74207 ) Change subject: Revert "soc/intel/cmn/cse: Handle EOP completion asynchronously" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74207/comment/90f77733_8ff7c39d PS2, Line 11: This initial change was causing a boot failure when transitioning into : recovery mode. On all brya devices, just skolas? That information should not be hidden in the TEST= tag line. > > What kind of failure? > boot failure That’s too general. coreboot logs let you pinpoint, where it fails, so that information would be nice to have. -- To view, visit https://review.coreboot.org/c/coreboot/+/74207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibebb20a000a239c344af1c96b8d376352b9c774e Gerrit-Change-Number: 74207 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Reland drivers/intel/dptf: Add multiple fan support under dptf
by Paul Menzel (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Lance Zhao, Subrata Banik, Caveh Jalali, Reka Norman, Tim Wawrzynczak, Sumeet R Pawnikar, Boris Mittelberg. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73249 ) Change subject: Reland drivers/intel/dptf: Add multiple fan support under dptf ...................................................................... Patch Set 3: (12 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73249/comment/c266ee14_36d8106c PS3, Line 13: Gmeet Please use Google Meet. https://review.coreboot.org/c/coreboot/+/73249/comment/da780c3a_13c357f4 PS3, Line 15: as per the expectation as expected https://review.coreboot.org/c/coreboot/+/73249/comment/707e83ff_00e7119a PS3, Line 16: observed is observed https://review.coreboot.org/c/coreboot/+/73249/comment/39b706df_cbbdc8bb PS3, Line 16: the an https://review.coreboot.org/c/coreboot/+/73249/comment/97482ebb_0d8e6334 PS3, Line 18: AlderLake Alder Lake https://review.coreboot.org/c/coreboot/+/73249/comment/0bc82bb1_a0d33314 PS3, Line 18: observed is observed https://review.coreboot.org/c/coreboot/+/73249/comment/33218800_5a82c1f8 PS3, Line 22: Thank you for the detailed problem description. Please also describe the implementation as you adapted several components. https://review.coreboot.org/c/coreboot/+/73249/comment/f8340e90_89f78f8b PS3, Line 25: Alderlake Ditto. https://review.coreboot.org/c/coreboot/+/73249/comment/ea0f1238_5d24b112 PS3, Line 26: Alderlake Ditto. File src/include/acpi/acpigen_dptf.h: https://review.coreboot.org/c/coreboot/+/73249/comment/b3568c2a_fe005a04 PS3, Line 128: speed Please append the unit: speed_rpm. https://review.coreboot.org/c/coreboot/+/73249/comment/5582eb12_f0e31865 PS3, Line 130: noise_level Ditto. https://review.coreboot.org/c/coreboot/+/73249/comment/e74a4ef7_48ced9f3 PS3, Line 132: power Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/73249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id07d279ff962253c22be9d395ed7be0d732aeaa7 Gerrit-Change-Number: 73249 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:48:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Add DTT thermal settings for policies
by Paul Menzel (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal, John Zhao, Sumeet R Pawnikar, Ivy Jian, Eric Lai, Peter Ou. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71166 ) Change subject: mb/google/rex: Add DTT thermal settings for policies ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71166/comment/92e51c4c_f3e60fd4 PS6, Line 7: for policies What does “for policies” mean? https://review.coreboot.org/c/coreboot/+/71166/comment/b07b00bc_ee4e80f3 PS6, Line 9: Add DTT thermal settings for policies for rex0 board Where are these values from? -- To view, visit https://review.coreboot.org/c/coreboot/+/71166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00dd97b759c8c68edaeeb4d64422b83c5e86981d Gerrit-Change-Number: 71166 Gerrit-PatchSet: 6 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Reland drivers/intel/dptf: Add multiple fan support under dptf
by Sumeet R Pawnikar (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Lance Zhao, Subrata Banik, Caveh Jalali, Reka Norman, Tim Wawrzynczak, Boris Mittelberg. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73249 ) Change subject: Reland drivers/intel/dptf: Add multiple fan support under dptf ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73249/comment/eadfc9e5_fbd9ec13 PS1, Line 8: > Please make it clear that this is a reland. E.g. change the subject to […] Done https://review.coreboot.org/c/coreboot/+/73249/comment/a520b35d_791b986c PS1, Line 23: TEST=Built and tested on Alderlake-P Redrix system for two fans support > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] Done File src/include/acpi/acpigen_dptf.h: https://review.coreboot.org/c/coreboot/+/73249/comment/06d8111e_5deea0f2 PS1, Line 207: void dptf_write_multifan_perf( > Does this work: […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/73249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id07d279ff962253c22be9d395ed7be0d732aeaa7 Gerrit-Change-Number: 73249 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:21:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Reland drivers/intel/dptf: Add multiple fan support under dptf
by Sumeet R Pawnikar (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Lance Zhao, Subrata Banik, Caveh Jalali, Tim Wawrzynczak, Sumeet R Pawnikar, Boris Mittelberg. Hello Lance Zhao, build bot (Jenkins), Subrata Banik, Caveh Jalali, Reka Norman, Tim Wawrzynczak, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73249 to look at the new patch set (#2). Change subject: Reland drivers/intel/dptf: Add multiple fan support under dptf ...................................................................... Reland drivers/intel/dptf: Add multiple fan support under dptf This reverts commit 4dba71fd25c91a9e610287c61238a8fe24452e4e. Add multiple fan support for dptf policies. This also fixes the Gmeet resolution drop issue as per b:246535768 comment#12. When system starts Gmeet video call, it uses the hardware accelerated encoder as per the expectation. But, as soon as another system connects to the call, the immediate fallback observed from hardware to software encoder. Due to this, Gmeet resolution dropped from 720p to 180p. This issue observed on AlderLake-N SoC based fanless platforms. This same issue was not seen on fan based systems. With the fix in dptf driver where fan configures appropriate setting for only fan participant, able to see consistent 720p resolution. BUG=b:246535768,b:235254828 BRANCH=None TEST=Built and tested on Alderlake-P Redrix system for two fans support and on Alderlake-N fanless systems. With this code change Gmeet resolution drop not observed. Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> Change-Id: Id07d279ff962253c22be9d395ed7be0d732aeaa7 --- M src/acpi/acpigen_dptf.c M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/ec/google/chromeec/acpi/emem.asl M src/ec/google/chromeec/chip.h M src/ec/google/chromeec/ec_acpi.c M src/ec/google/chromeec/ec_dptf_helpers.c M src/ec/google/common/dptf.h M src/include/acpi/acpigen_dptf.h 9 files changed, 238 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/73249/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id07d279ff962253c22be9d395ed7be0d732aeaa7 Gerrit-Change-Number: 73249 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash
by Michał Żygowski (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Tarun Tuli, Martin L Roth, Subrata Banik, Paul Menzel, Krystian Hebel. Hello build bot (Jenkins), Tarun Tuli, Martin L Roth, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68987 to look at the new patch set (#7). Change subject: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash ...................................................................... soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash The patch adds a possibility to cache the PCIe 5.0 HSPHY firmware in the SPI flash. New flashmap region is created for that purpose. The goal of caching is to reduce the dependency on CSME and the HECI IP LOAD command which may fail when the CSME is disabled, e.g. soft disabled by HECI command or HAP disabled. This change allows to keep PCIe 5.0 functioning even if CSME/HECI is not functional. TEST=Boot Ubuntu 22.04 on MSI PRO Z690-A and notice PCIe 5.0 port is functional after loading the HSPHY from cache. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f --- M Makefile.inc M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/Makefile.inc M src/soc/intel/alderlake/hsphy.c M util/cbfstool/default-x86.fmd 5 files changed, 325 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/68987/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f Gerrit-Change-Number: 68987 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023