coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Dinesh Gehlot, Kapil Porwal. Hello build bot (Jenkins), Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74005 to look at the new patch set (#15). Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ...................................................................... soc/intel/cmd/block: Implement an API to get firmware partition details This patch retrieves details of a specified firmware partition. The information retrieved includes the mkhi header, current firmware version, and other information about the partition. The patch communicates with the ME using the HECI command to acquire this information. BUG=b:273661726 Test=Verified the changes for ISHC partition on nissa board. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 81 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74005/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 15 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/intel/mtlrvp: Fix the file name (chromeos.debug-fsp.fmd) typo
by Subrata Banik (Code Review) 05 Apr '23

05 Apr '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74217 ) Change subject: mb/intel/mtlrvp: Fix the file name (chromeos.debug-fsp.fmd) typo ...................................................................... mb/intel/mtlrvp: Fix the file name (chromeos.debug-fsp.fmd) typo This patch renames debug FMD file(chromeos.debug-fsp.fmd) to chromeos-debug-fsp.fmd in order to match the file path name in `FMDFILE` config. TEST=Able to build intel/mtlrvp with this code change. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic8de07e4befa6b1ab8ab57d593c6939d87c48e9b --- R src/mainboard/intel/mtlrvp/chromeos-debug-fsp.fmd 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/74217/1 diff --git a/src/mainboard/intel/mtlrvp/chromeos.debug-fsp.fmd b/src/mainboard/intel/mtlrvp/chromeos-debug-fsp.fmd similarity index 100% rename from src/mainboard/intel/mtlrvp/chromeos.debug-fsp.fmd rename to src/mainboard/intel/mtlrvp/chromeos-debug-fsp.fmd -- To view, visit https://review.coreboot.org/c/coreboot/+/74217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8de07e4befa6b1ab8ab57d593c6939d87c48e9b Gerrit-Change-Number: 74217 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Documentation/measured_boot.md: document new TPM options
by Michał Żygowski (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Daniel P. Smith, Maciej Pijanowski, Krystian Hebel, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68752 ) Change subject: Documentation/measured_boot.md: document new TPM options ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dae8e95c59b440c75e13473eefc4c2cf4fd369b Gerrit-Change-Number: 68752 Gerrit-PatchSet: 15 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel P. Smith Gerrit-Attention: Daniel P. Smith Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:00:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make usage of PCRs configurable via Kconfig
by Michał Żygowski (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Maciej Pijanowski, Christian Walter, Krystian Hebel, Yu-Ping Wu, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68750 ) Change subject: security/tpm: make usage of PCRs configurable via Kconfig ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3a192d902072f6f8d415c2952a36522b5bf09f9 Gerrit-Change-Number: 68750 Gerrit-PatchSet: 13 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:58:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/inteltool: Add support for Jasper Lake
by Karol Zmyslowski (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Maciej Pijanowski, Michał Żygowski, Jakub Czapiga, Stefan Reinauer, Michal Zygowski. Karol Zmyslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 ) Change subject: util/inteltool: Add support for Jasper Lake ...................................................................... Patch Set 10: (15 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73934/comment/d77f6950_20c54d22 PS9, Line 10: Documents: Intel Datasheet: 633935, rev. 006 > Document number needs to be fixed Done Patchset: PS10: > Still not all of my comments were worked on in the patchset #10 Currently, I still apply changes, regarding pointed notes. File util/inteltool/gpio_names/jasperlake.h: https://review.coreboot.org/c/coreboot/+/73934/comment/b54b82e1_ad69fcfe PS9, Line 190: const char *const jasperlake_pch_community1_jtag_names[] = { > If you see at others, the naming convention is typically: "emmitsburg_group_jtag ", We can drop the […] Done https://review.coreboot.org/c/coreboot/+/73934/comment/fe15eac4_937bb2ce PS9, Line 203: .display = "------- GPIO Group GPP_SYS_JTAG -------", > As far as I can see, others uarchs typically use: "------- GPIO Group JTAG -------" Done https://review.coreboot.org/c/coreboot/+/73934/comment/d14cf12c_d0bad2b9 PS9, Line 305: .display = "------- GPIO Group GPP_H -------", > This should be: "------- GPIO Group SPI -------" Done https://review.coreboot.org/c/coreboot/+/73934/comment/8b057a0b_1a982b58 PS9, Line 312: "GSPI0_CLK_LOOPBK", "GSPI0_CLK_LOOPBK", > Another instance that can probably be included in already existing group, and this group can be then […] Ack https://review.coreboot.org/c/coreboot/+/73934/comment/9bb63867_0b8ee9aa PS9, Line 317: .display = "------- GPIO Group GPP_B -------", > The display name is incorrect, but it will be gone once we merge loopbacks into some group. Ack https://review.coreboot.org/c/coreboot/+/73934/comment/7b330469_c3c76c48 PS9, Line 359: const char *const jasperlake_pch_group_sys_comm2_names[] = { > This should be "jasperlake_pch_group_cpu_names". Consult alderlake_h.h as an example. Ack https://review.coreboot.org/c/coreboot/+/73934/comment/9ba3d5c7_f9f89c57 PS9, Line 378: .display = "------- GPIO Group GPP_SYS_COMM2 -------", > "------- GPIO Group CPU -------" Done https://review.coreboot.org/c/coreboot/+/73934/comment/66e53b1b_da613f18 PS9, Line 384: const char *const jasperlake_pch_group_sys_pcie_names[] = { > "jasperlake_pch_group_pcie_vgpio_names" fits probably better Ack WiP. https://review.coreboot.org/c/coreboot/+/73934/comment/14364967_50295e72 PS9, Line 467: .display = "------- GPIO Group GPP_SYS_PCIE -------", > "------- GPIO Group PCIe vGPIO -------" Done https://review.coreboot.org/c/coreboot/+/73934/comment/6177e7ce_5d85c0b0 PS9, Line 473: const char *const jasperlake_pch_group_sys_vusb_names[] = { > maybe "jasperlake_pch_group_vgpio_usb_names", or similar Done. https://review.coreboot.org/c/coreboot/+/73934/comment/8aa4f756_53f660d3 PS9, Line 496: const char *const jasperlake_pch_group_dsw_names[] = { > This should be: "jasperlake_pch_group_gpd_names" Ack Corrected. https://review.coreboot.org/c/coreboot/+/73934/comment/8917a821_07da2413 PS9, Line 510: const struct gpio_group jasperlake_pch_group_dsw = { > This should be: jasperlake_pch_group_gpd Ack Corrected. https://review.coreboot.org/c/coreboot/+/73934/comment/a3682b63_b61a5642 PS9, Line 511: .display = "------- GPIO Group GPP_S -------", > This should be: "------- GPIO Group GPD -------: Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4134bd03f5544b5845cde998ee526e5ddd5b51d Gerrit-Change-Number: 73934 Gerrit-PatchSet: 10 Gerrit-Owner: Karol Zmyslowski Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michal Zygowski <miczyg94(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Michal Zygowski <miczyg94(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:57:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/measured_boot.md: fix SRTM/DRTM explanations
by Michał Żygowski (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Daniel P. Smith, Maciej Pijanowski, Krystian Hebel, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68751 ) Change subject: Documentation/measured_boot.md: fix SRTM/DRTM explanations ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If224dc0cf3c0515dbd18daca544c22275e96b459 Gerrit-Change-Number: 68751 Gerrit-PatchSet: 13 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel P. Smith Gerrit-Attention: Daniel P. Smith Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:52:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in gerrit-avatars[master]: Add avatar for 1002542 (Jan Samek).
by Jan Samek (Code Review) 05 Apr '23

05 Apr '23

Jan Samek has uploaded this change for review. ( https://review.coreboot.org/c/gerrit-avatars/+/74232 ) Change subject: Add avatar for 1002542 (Jan Samek). ...................................................................... Add avatar for 1002542 (Jan Samek). Signed-off-by: Jan Samek <jan.samek(a)siemens.com> Change-Id: I870f458a6ae8b6707d329c80e138d3876daacb90 --- A 1002542.jpg 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/32/74232/1 diff --git a/1002542.jpg b/1002542.jpg new file mode 100644 index 0000000..aa2fcd3 --- /dev/null +++ b/1002542.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/74232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I870f458a6ae8b6707d329c80e138d3876daacb90 Gerrit-Change-Number: 74232 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: configs/config.amd_mayan:Add the defconfig file for Mayan board
by Paul Menzel (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: ritul guru, Eric Lai, Anand Vaikar, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74057 ) Change subject: configs/config.amd_mayan:Add the defconfig file for Mayan board ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74057/comment/1cb8433d_7d11d4e3 PS2, Line 7: configs/config.amd_mayan:Add Please add a space after the colon. https://review.coreboot.org/c/coreboot/+/74057/comment/a31f2fcd_4d2cc7a9 PS2, Line 7: the The article could be omitted in the summary. https://review.coreboot.org/c/coreboot/+/74057/comment/332af7cc_6e35c695 PS2, Line 8: What is the difference to the default config created for that board? -- To view, visit https://review.coreboot.org/c/coreboot/+/74057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Gerrit-Change-Number: 74057 Gerrit-PatchSet: 2 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:25:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Order the different types of cores based on APIC IDs
by Jan Samek (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Subrata Banik, Paul Menzel, Sridhar Siricilla, Kyösti Mälkki, Elyes Haouas. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 ) Change subject: soc/intel/common: Order the different types of cores based on APIC IDs ...................................................................... Patch Set 18: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72132/comment/7c5af373_9a3913b7 PS18, Line 13: /sys/devices/system/cpu/cpu0/topology/thread_siblings_list:0-1 Sorry to ask a stupid question, but isn't just the first list unordered? After ordering it, the assignment of the HT siblings to each core is just the same before and after the patch. I even verified this on my hardware - before the patch: ``` $ grep . /sys/devices/system/cpu/cpu*/topology/thread_siblings_list | sort -V /sys/devices/system/cpu/cpu0/topology/thread_siblings_list:0-1 /sys/devices/system/cpu/cpu1/topology/thread_siblings_list:0-1 /sys/devices/system/cpu/cpu2/topology/thread_siblings_list:2-3 /sys/devices/system/cpu/cpu3/topology/thread_siblings_list:2-3 /sys/devices/system/cpu/cpu4/topology/thread_siblings_list:4-5 /sys/devices/system/cpu/cpu5/topology/thread_siblings_list:4-5 /sys/devices/system/cpu/cpu6/topology/thread_siblings_list:6-7 /sys/devices/system/cpu/cpu7/topology/thread_siblings_list:6-7 /sys/devices/system/cpu/cpu8/topology/thread_siblings_list:8-9 /sys/devices/system/cpu/cpu9/topology/thread_siblings_list:8-9 /sys/devices/system/cpu/cpu10/topology/thread_siblings_list:10-11 /sys/devices/system/cpu/cpu11/topology/thread_siblings_list:10-11 /sys/devices/system/cpu/cpu12/topology/thread_siblings_list:12 /sys/devices/system/cpu/cpu13/topology/thread_siblings_list:13 /sys/devices/system/cpu/cpu14/topology/thread_siblings_list:14 /sys/devices/system/cpu/cpu15/topology/thread_siblings_list:15 /sys/devices/system/cpu/cpu16/topology/thread_siblings_list:16 /sys/devices/system/cpu/cpu17/topology/thread_siblings_list:17 /sys/devices/system/cpu/cpu18/topology/thread_siblings_list:18 /sys/devices/system/cpu/cpu19/topology/thread_siblings_list:19 ``` And after the patch: ``` $ grep . /sys/devices/system/cpu/cpu*/topology/thread_siblings_list | sort -V /sys/devices/system/cpu/cpu0/topology/thread_siblings_list:0-1 /sys/devices/system/cpu/cpu1/topology/thread_siblings_list:0-1 /sys/devices/system/cpu/cpu2/topology/thread_siblings_list:2-3 /sys/devices/system/cpu/cpu3/topology/thread_siblings_list:2-3 /sys/devices/system/cpu/cpu4/topology/thread_siblings_list:4-5 /sys/devices/system/cpu/cpu5/topology/thread_siblings_list:4-5 /sys/devices/system/cpu/cpu6/topology/thread_siblings_list:6-7 /sys/devices/system/cpu/cpu7/topology/thread_siblings_list:6-7 /sys/devices/system/cpu/cpu8/topology/thread_siblings_list:8-9 /sys/devices/system/cpu/cpu9/topology/thread_siblings_list:8-9 /sys/devices/system/cpu/cpu10/topology/thread_siblings_list:10-11 /sys/devices/system/cpu/cpu11/topology/thread_siblings_list:10-11 /sys/devices/system/cpu/cpu12/topology/thread_siblings_list:12 /sys/devices/system/cpu/cpu13/topology/thread_siblings_list:13 /sys/devices/system/cpu/cpu14/topology/thread_siblings_list:14 /sys/devices/system/cpu/cpu15/topology/thread_siblings_list:15 /sys/devices/system/cpu/cpu16/topology/thread_siblings_list:16 /sys/devices/system/cpu/cpu17/topology/thread_siblings_list:17 /sys/devices/system/cpu/cpu18/topology/thread_siblings_list:18 /sys/devices/system/cpu/cpu19/topology/thread_siblings_list:19 ``` At least I can tell, in both my and your case, the patch doesn't seem to break anything. Feel free to correct me, if I'm wrong there. Used a vanilla Linux kernel v6.1.9 with Busybox v1.36.0 as a payload. -- To view, visit https://review.coreboot.org/c/coreboot/+/72132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21487a5eb0439ea0cb5976787d1769ee94777469 Gerrit-Change-Number: 72132 Gerrit-PatchSet: 18 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: configs/config.amd_mayan:Add the defconfig file for Mayan board
by build bot (Jenkins) (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: ritul guru, Eric Lai, Fred Reitberger, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74057 ) Change subject: configs/config.amd_mayan:Add the defconfig file for Mayan board ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173394): https://review.coreboot.org/c/coreboot/+/74057/comment/d4e35e80_23381961 PS2, Line 11: Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> Duplicate signature -- To view, visit https://review.coreboot.org/c/coreboot/+/74057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32 Gerrit-Change-Number: 74057 Gerrit-PatchSet: 2 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:17:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023