coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel/cmn/block/cse: Implement an API to get ISHC version
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Subrata Banik. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 ) Change subject: soc/intel/cmn/block/cse: Implement an API to get ISHC version ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74209/comment/ecc8b06c_39ede67f PS2, Line 7: soc/intel/cmn > soc/intel/cmd/block/cse Ack https://review.coreboot.org/c/coreboot/+/74209/comment/5868eb15_0761511d PS2, Line 13: ISHC version is verified on the Nissa board using a debug patch > Able to build and boot google/nivviks. […] Ack File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/74209/comment/c92ffe3e_ff2aecde PS2, Line 1215: > Add a comment saying, this cmd can only work post FSP-M (after CSE DID cmd being sent) Ack https://review.coreboot.org/c/coreboot/+/74209/comment/af52b5a2_9202e23a PS2, Line 1215: : bool get_ishc_version(struct fw_version *resp_version) > ``` […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 Gerrit-Change-Number: 74209 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 14:28:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst
by Jon Murphy (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 ) Change subject: mb/google/myst: First pass GPIO configuration for Myst ...................................................................... Patch Set 13: (1 comment) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74095/comment/9e8bf895_16be84fc PS11, Line 111: SPI_SOC_DI_FPMCU_DO_R > I see. Thanks for the explanation. […] Some of that is scripted. I pinged klug@. We can follow up for consistency. -- To view, visit https://review.coreboot.org/c/coreboot/+/74095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b Gerrit-Change-Number: 74095 Gerrit-PatchSet: 13 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 14:28:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Subrata Banik. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 ) Change subject: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table ...................................................................... Patch Set 5: (14 comments) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74208/comment/6a02a975_99ef463d PS2, Line 206: /*compare if stored cse version is same as current cse*/ > ``` […] Ack https://review.coreboot.org/c/coreboot/+/74208/comment/e67f9b53_9eeca7d0 PS2, Line 208: struct fw_version_resp resp; > add this comment as line #208 […] Ack https://review.coreboot.org/c/coreboot/+/74208/comment/482fe199_c564d03c PS2, Line 210: */ > one space to end the line Ack https://review.coreboot.org/c/coreboot/+/74208/comment/c018fca6_3c2418ef PS2, Line 210: /* > one space to start the line Ack https://review.coreboot.org/c/coreboot/+/74208/comment/e0e5b246_8bc9d06d PS2, Line 224: /*update current cse version*/ > ``` […] Ack https://review.coreboot.org/c/coreboot/+/74208/comment/91c4fcf3_c77b21b2 PS2, Line 254: store_cse_version(&(cse_bp->fw_ver)); > ``` […] Ack https://review.coreboot.org/c/coreboot/+/74208/comment/2ce0416a_09bc10e7 PS2, Line 1182: store_ishc_version(); > ``` […] Ack File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74208/comment/59fcbc42_25e7b85e PS4, Line 219: u > start with caps Ack https://review.coreboot.org/c/coreboot/+/74208/comment/9c8d63ff_21459d9f PS4, Line 219: u > start with caps Ack https://review.coreboot.org/c/coreboot/+/74208/comment/219cfa84_b9355c97 PS4, Line 229: live_cse > very innovative variable name, bt can u rename to make it more meaningful Ack File src/soc/intel/common/block/include/intelblocks/cse.h: https://review.coreboot.org/c/coreboot/+/74208/comment/da353ca2_114ac2e5 PS2, Line 147: pre_cse > prev_cse_fw_version Ack https://review.coreboot.org/c/coreboot/+/74208/comment/dc2ac7d6_5491fce2 PS2, Line 148: curr_ish > cur_ish_fw_version Ack https://review.coreboot.org/c/coreboot/+/74208/comment/6971b41f_9f98b5ca PS2, Line 153: curr_cse > cur_cse_fw_version Ack https://review.coreboot.org/c/coreboot/+/74208/comment/f4656220_aabd1763 PS2, Line 154: ish_info > ish_partition_info Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 5 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 14:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/block/cse: Implement an API to get ISHC version
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Dinesh Gehlot. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74209 to look at the new patch set (#3). Change subject: soc/intel/cmn/block/cse: Implement an API to get ISHC version ...................................................................... soc/intel/cmn/block/cse: Implement an API to get ISHC version This patch adds an API that will fetch the current ISHC version from cbmem. It alerts the user if the current ISHC version is outdated. BUG=b:273661726 Test=The ISHC version, 5.4.2.7779, was retrieved on the Nissa board. : Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/74209/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8 Gerrit-Change-Number: 74209 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable chromeOS EC
by Jon Murphy (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Raul Rangel, Eric Lai, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 ) Change subject: mb/google/myst: Enable chromeOS EC ...................................................................... Patch Set 15: (1 comment) File src/mainboard/google/myst/ec.c: https://review.coreboot.org/c/coreboot/+/74099/comment/7b8013c7_5242f26d PS12, Line 4: #include <console/console.h> > Not required yet. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e Gerrit-Change-Number: 74099 Gerrit-PatchSet: 15 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 14:25:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: SRIDHAR SIRICILLA, Subrata Banik, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Kapil Porwal, Meera Ravindranath. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 ) Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ...................................................................... Patch Set 15: (3 comments) File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/74005/comment/bfa1a538_0c950a68 PS14, Line 1216: cse_get_partition_info > please remain to `send_get_boot_partition_info_cmd` Ack https://review.coreboot.org/c/coreboot/+/74005/comment/c636e541_9e89bef6 PS14, Line 1216: bool > static bool Ack https://review.coreboot.org/c/coreboot/+/74005/comment/12d311c4_cb696f9b PS14, Line 1239: > We should add a check to avoid sending ISHC partition info if platform doesn't have ISH partition it […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 15 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 13:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: intel/cmn/smm: Introduce PERIODIC_SMI_RATE_SELECTION_IN_GEN_PMCON_B
by Michał Żygowski (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Paul Menzel, Maximilian Brune, Angel Pons, Krystian Hebel. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69870 ) Change subject: intel/cmn/smm: Introduce PERIODIC_SMI_RATE_SELECTION_IN_GEN_PMCON_B ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/smm/Kconfig: https://review.coreboot.org/c/coreboot/+/69870/comment/f2505adb_4f71230f PS4, Line 53: Intel Core processors select the periodic SMI rate via GEN_PMCON_A. > It would probably result in much more code, since you have to implement it for every SOC. Maybe if the discrepancy was much higher, but for now only the apollolake has been identified with such difference. -- To view, visit https://review.coreboot.org/c/coreboot/+/69870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11241836ecc9066d323977b030686567c87ed256 Gerrit-Change-Number: 69870 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 13:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table
by Dinesh Gehlot (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Dinesh Gehlot. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74208 to look at the new patch set (#5). Change subject: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table ...................................................................... soc/intel/cmn/block: Store CSE and ISHC version into cbmem table The patch stores the ISHC and CSE version in the CBMEM table. It verifies CSE has been updated by comparing old and current CSE versions. If it has, the patch updates the current CSE version in the CBMEM table. It then updates the CBMEM table with the current ISHC version. BUG=b:273661726 Test=The current and old cse and ishc versions are verified on the nissa during cold and warm reboots. Additionally, version updates are verified by a debug patch that purposely updated the stored cse version. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 3 files changed, 80 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/74208/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0 Gerrit-Change-Number: 74208 Gerrit-PatchSet: 5 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/lint/stable-017: Update full config patern matching
by Arthur Heymans (Code Review) 05 Apr '23

05 Apr '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74220 ) Change subject: util/lint/stable-017: Update full config patern matching ...................................................................... util/lint/stable-017: Update full config patern matching CONFIG_ARCH gives false positives for CONFIG_USE_EXP_X86_64_SUPPORT so use a different string: 'CONFIG_MAINBOARD_DIR'. Change-Id: Ie5d4fc4693bc303afb16884c53c9ca4d1778a5cb Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/lint/lint-stable-017-configs 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/74220/1 diff --git a/util/lint/lint-stable-017-configs b/util/lint/lint-stable-017-configs index 3f92f53..5be74457 100755 --- a/util/lint/lint-stable-017-configs +++ b/util/lint/lint-stable-017-configs @@ -12,7 +12,7 @@ # shellcheck source=helper_functions.sh . "${LINTDIR}/helper_functions.sh" -SYMBOLS='CONFIG_ARCH_\|CONFIG_MAINBOARD_HAS_' +SYMBOLS='CONFIG_MAINBOARD_DIR\|CONFIG_MAINBOARD_HAS_' #look for a couple of things that should only be set by select keywords for file in \ -- To view, visit https://review.coreboot.org/c/coreboot/+/74220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5d4fc4693bc303afb16884c53c9ca4d1778a5cb Gerrit-Change-Number: 74220 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp/acpi: Fix _OSC method
by Jonathan Zhang (Code Review) 05 Apr '23

05 Apr '23

Attention is currently required from: Patrick Rudolph, Johnny Lin, Ziang Wang, Christian Walter, Arthur Heymans, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74231 ) Change subject: soc/intel/xeon_sp/acpi: Fix _OSC method ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl: https://review.coreboot.org/c/coreboot/+/74231/comment/ee57bdaf_6ce3ce67 PS2, Line 56: If (Arg0 == ToUUID ("68f2d50b-c469-4d8a-bd3d-941a103fd3fc")) nit: would be good to add back the comment that this GUID is for CXL, as defined in ACPI spec. -- To view, visit https://review.coreboot.org/c/coreboot/+/74231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide598e386c30ced24e4f96c37f2b4a609ac33441 Gerrit-Change-Number: 74231 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 05 Apr 2023 13:45:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023