Attention is currently required from: Bora Guvendik, Hannah Williams, Paul Menzel.
Jay Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72889 )
Change subject: commonlib: Add Pre-reset boot timestamps' IDs
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72889/comment/05ea76b6_3acc3f7d
PS6, Line 2: jaypatel256
> Please use your name.
Done
https://review.coreboot.org/c/coreboot/+/72889/comment/82a0c431_abf7d758
PS6, Line 7: cmnlb/include/ts_ser
> *commonlib* would be enough as prefix in my opinion.
Done
https://review.coreboot.org/c/coreboot/+/72889/comment/301f7fc8_dc7c9a9c
PS6, Line 14: jaypatel256
> Ditto.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/72889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503dedcd574d13cf958be19bd613f7f9f3ba8163
Gerrit-Change-Number: 72889
Gerrit-PatchSet: 7
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 06 Apr 2023 15:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Hannah Williams, Tarun Tuli, Jamie Ryu, Wonkyu Kim, Kapil Porwal, Jay Patel.
Hello Bora Guvendik, build bot (Jenkins), Hannah Williams, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73192
to look at the new patch set (#7).
Change subject: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex
......................................................................
mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex
Enables feature to record pre-reset boot time using EC boot timestamps.
BUG=b:271012752
TEST=Pre-reset boot timestamps added to the timestamp table, verified
using cbmem -t
Signed-off-by: Jay Patel <jay2.patel(a)intel.com>
Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2
---
M src/mainboard/google/rex/Kconfig
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/73192/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/73192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2
Gerrit-Change-Number: 73192
Gerrit-PatchSet: 7
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Hannah Williams, Jamie Ryu, Subrata Banik, Wonkyu Kim, Kapil Porwal, Jay Patel.
Hello Bora Guvendik, build bot (Jenkins), Hannah Williams, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73191
to look at the new patch set (#7).
Change subject: soc/intel/mtl/romstage: Insert EC boot timestamps
......................................................................
soc/intel/mtl/romstage: Insert EC boot timestamps
Calls the function to insert EC boot timestamps to the coreboot
timestamp table for Meteorlake SOC based on Kconfig flag
SOC_INTEL_EC_BOOT_TIMESTAMPS.
BUG=b:271012752
TEST=None
Signed-off-by: Jay Patel <jay2.patel(a)intel.com>
Change-Id: Iebda928a31d55a081f68b9833b66f757a9cd9aa7
---
M src/soc/intel/meteorlake/romstage/romstage.c
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/73191/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/73191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebda928a31d55a081f68b9833b66f757a9cd9aa7
Gerrit-Change-Number: 73191
Gerrit-PatchSet: 7
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Hannah Williams, Jay Patel.
Hello Bora Guvendik, build bot (Jenkins), Hannah Williams,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72889
to look at the new patch set (#7).
Change subject: commonlib: Add Pre-reset boot timestamps' IDs
......................................................................
commonlib: Add Pre-reset boot timestamps' IDs
Adds pre-reset EC boot timestamps' IDs to the timestamp_id enum.
BUG=b:271012752
TEST=None
Signed-off-by: Jay Patel <jay2.patel(a)intel.com>
Change-Id: I503dedcd574d13cf958be19bd613f7f9f3ba8163
---
M src/commonlib/include/commonlib/timestamp_serialized.h
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/72889/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/72889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503dedcd574d13cf958be19bd613f7f9f3ba8163
Gerrit-Change-Number: 72889
Gerrit-PatchSet: 7
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Hannah Williams, Subrata Banik, Dinesh Gehlot, Jay Patel.
Hello Bora Guvendik, build bot (Jenkins), Hannah Williams,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72931
to look at the new patch set (#12).
Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
......................................................................
soc/intel/cmn/blk: Request pre-reset EC boot timestamps
coreboot requests pre-reset power signal timestamps to the EC. These
timestamps are used to calculate pre-reset boot time and inserted into
the coreboot timestamp table.
BUG=b:271012752
TEST=Pre-reset timestamps added to cbmem timestamp table if flag
enabled in Kconfig file and feature enabled from romstage for
specific board.
Signed-off-by: Jay Patel <jay2.patel(a)intel.com>
Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9
---
A src/soc/intel/common/block/ec_telemetry/Kconfig
A src/soc/intel/common/block/ec_telemetry/Makefile.inc
A src/soc/intel/common/block/ec_telemetry/ec_telemetry.c
A src/soc/intel/common/block/include/intelblocks/ec_telemetry.h
4 files changed, 103 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/72931/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/72931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9
Gerrit-Change-Number: 72931
Gerrit-PatchSet: 12
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Hannah Williams, Jay Patel, Boris Mittelberg.
Hello Bora Guvendik, build bot (Jenkins), Hannah Williams, Caveh Jalali, Boris Mittelberg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72930
to look at the new patch set (#8).
Change subject: ec/google/ec_cmd: EC command for pre-reset boot timestamps
......................................................................
ec/google/ec_cmd: EC command for pre-reset boot timestamps
This patch defines the command for the host to request the timestamps
for pre-reset events recorded by the EC.
BUG=b:271012752
TEST=None
Signed-off-by: Jay Patel <jay2.patel(a)intel.com>
Change-Id: Ia9324c844c04472b5ed07c5e11e263037712df59
---
M src/ec/google/chromeec/ec_commands.h
1 file changed, 19 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/72930/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/72930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9324c844c04472b5ed07c5e11e263037712df59
Gerrit-Change-Number: 72930
Gerrit-PatchSet: 8
Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, Paul Menzel, Kapil Porwal, John Zhao, Sumeet R Pawnikar, Ivy Jian, Eric Lai, Peter Ou.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71166 )
Change subject: mb/google/rex: Add DTT thermal settings for thermal control
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00dd97b759c8c68edaeeb4d64422b83c5e86981d
Gerrit-Change-Number: 71166
Gerrit-PatchSet: 7
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 15:01:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment