coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[L] Change in coreboot[master]: arch/x86/smbios: Fix file formatting
by Utkarsh Verma (Code Review) 08 Apr '23

08 Apr '23

Attention is currently required from: Paul Menzel, Angel Pons. Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 ) Change subject: arch/x86/smbios: Fix file formatting ...................................................................... Patch Set 4: (2 comments) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/74170/comment/9553d149_b9b0469c PS2, Line 378: : t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED : | BIOS_CHARACTERISTICS_SELECTABLE_BOOT : | BIOS_CHARACTERISTICS_UPGRADEABLE; > Yes, but it was the result of the `.clang-format` file. […] Fix in the new changes https://review.coreboot.org/c/coreboot/+/74170/comment/72586f8a_e80eec0e PS2, Line 1276: || device_type == SMBIOS_DEVICE_TYPE_UNKNOWN) > What exactly is fixed here? Both conditions were nicely aligned before. Fixed in the new changes. -- To view, visit https://review.coreboot.org/c/coreboot/+/74170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f44eec4d14d8b905f438c5305b640a33408c45 Gerrit-Change-Number: 74170 Gerrit-PatchSet: 4 Gerrit-Owner: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 08 Apr 2023 01:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/blk/pcie: Program LTR max latencies
by Matt DeVillier (Code Review) 08 Apr '23

08 Apr '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74288 ) Change subject: soc/amd/common/blk/pcie: Program LTR max latencies ...................................................................... soc/amd/common/blk/pcie: Program LTR max latencies PCIe bridges need to provide the LTR (latency tolernace reporting) maximum snoop/non-snoop values so that they are inherited by downstream PCIe devices which support and enable LTR. Without this, downstream devices cannot have LTR enabled, which is a requirement for supporting PCIe L1 substates. Enabling L1ss without LTR has unpredictable behavior, including some devices refusing to enter L1 low power modes at all. BUG=b:265890321 TEST=build/boot google/skyrim (multiple variants, NVMe drives), ensure LTR is enabled, latency values are correctly set, and that device power draw at idle is in the expected range (<25 mW). Change-Id: Icf188e69cf5676be870873c56d175423d16704b4 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/soc/amd/common/block/pci/pcie_gpp.c 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74288/1 diff --git a/src/soc/amd/common/block/pci/pcie_gpp.c b/src/soc/amd/common/block/pci/pcie_gpp.c index 0ce3268..5df1cb1 100644 --- a/src/soc/amd/common/block/pci/pcie_gpp.c +++ b/src/soc/amd/common/block/pci/pcie_gpp.c @@ -47,6 +47,20 @@ acpigen_pop_len(); /* Scope */ } +/* Latency tolerance reporting, max snoop/non-snoop latency value 1.047ms */ +#define PCIE_LTR_MAX_LATENCY_1047US 0x1001 + +static void pcie_get_ltr_max_latencies(u16 *max_snoop, u16 *max_nosnoop) +{ + *max_snoop = PCIE_LTR_MAX_LATENCY_1047US; + *max_nosnoop = PCIE_LTR_MAX_LATENCY_1047US; +} + +static struct pci_operations pcie_ops = { + .get_ltr_max_latencies = pcie_get_ltr_max_latencies, + .set_subsystem = pci_dev_set_subsystem, +}; + struct device_operations amd_internal_pcie_gpp_ops = { .read_resources = pci_bus_read_resources, .set_resources = pci_dev_set_resources, @@ -65,4 +79,5 @@ .reset_bus = pci_bus_reset, .acpi_name = pcie_gpp_acpi_name, .acpi_fill_ssdt = acpi_device_write_gpp_pci_dev, + .ops_pci = &pcie_ops, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/74288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf188e69cf5676be870873c56d175423d16704b4 Gerrit-Change-Number: 74288 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/phoenix/Kconfig: Prevent changes to AMD_FWM_POSITION_INDEX
by Paul Menzel (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74249 ) Change subject: soc/amd/phoenix/Kconfig: Prevent changes to AMD_FWM_POSITION_INDEX ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74249/comment/951b5363_4eb9038e PS2, Line 10: to the only valid value and prevent mainboard overrides. … by making the option non-user-configurable. File src/soc/amd/phoenix/Kconfig: https://review.coreboot.org/c/coreboot/+/74249/comment/c84db46a_0a879668 PS2, Line 310: Typically this is calculated by the ROM size, but there may : be situations where you want to put the firmware directory : table in a different location. : 0: 512 KB - 0xFFFA0000 : 1: 1 MB - 0xFFF20000 : 2: 2 MB - 0xFFE20000 : 3: 4 MB - 0xFFC20000 : 4: 8 MB - 0xFF820000 : 5: 16 MB - 0xFF020000 Should this be updated too? -- To view, visit https://review.coreboot.org/c/coreboot/+/74249 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f720dbadf2d28a3c39daa4bd653a407be4893d0 Gerrit-Change-Number: 74249 Gerrit-PatchSet: 2 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/amd/birman/port_descriptors_phoenix.c: Update DXIO for birman
by Paul Menzel (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Jason Glenesk, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69705 ) Change subject: mb/amd/birman/port_descriptors_phoenix.c: Update DXIO for birman ...................................................................... Patch Set 13: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69705/comment/504e305b_5aa6f794 PS13, Line 7: mb/amd/birman/port_descriptors_phoenix.c: Update DXIO for birman Maybe: > mb/amd/birman: Update DXIO descripters per schematic -- To view, visit https://review.coreboot.org/c/coreboot/+/69705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76cf6715b60a1857bf58349d70a623bf043594fe Gerrit-Change-Number: 69705 Gerrit-PatchSet: 13 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:56:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/amd/birman/ec.c: Update EC configuration for birman
by Paul Menzel (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Jason Glenesk, Martin Roth, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73971 ) Change subject: mb/amd/birman/ec.c: Update EC configuration for birman ...................................................................... Patch Set 7: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73971/comment/11ad4356_f3b49cbb PS7, Line 7: Update EC configuration for birman “for birman” is redundant. Maybe: > Update EC configuration per schematic File src/mainboard/amd/birman/ec.c: https://review.coreboot.org/c/coreboot/+/73971/comment/c2806664_32692536 PS7, Line 219: for (i = 0; i < count; i++) { Add a blank line above? https://review.coreboot.org/c/coreboot/+/73971/comment/3258e6ad_315727a8 PS7, Line 222: cfg[i].addr, tmp); Fits on the previous line? -- To view, visit https://review.coreboot.org/c/coreboot/+/73971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd9df120f555eb06f920f6263a8d2ab45c05baec Gerrit-Change-Number: 73971 Gerrit-PatchSet: 7 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable gfx_hda
by Paul Menzel (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74278 ) Change subject: mb/google/myst: Enable gfx_hda ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/myst/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74278/comment/600aeeb6_aefaa469 PS4, Line 148: chip drivers/usb/acpi Unrelated? (Rebase glitch?) -- To view, visit https://review.coreboot.org/c/coreboot/+/74278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58096f1408f66f968af1494e487cf2bfc43b9a0f Gerrit-Change-Number: 74278 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/arm* Fix some linter warnings and errors
by Philipp M (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Felix Singer, Philipp Hug, Paul Menzel, Julius Werner, ron minnich, Elyes Haouas. Philipp M has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74173 ) Change subject: arch/arm* Fix some linter warnings and errors ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74173/comment/5d59eef9_9ff67928 PS1, Line 7: Fixed > Fix linter warnings and errors […] Done https://review.coreboot.org/c/coreboot/+/74173/comment/007b777d_ada76c7e PS1, Line 7: src/arch/ Fixed some linter warnings and errors > Maybe split the commit into three: arch/arm*, arch/riscv, console. Done, this is the first patch, two others will follow :) https://review.coreboot.org/c/coreboot/+/74173/comment/c99e16c9_f7bf496e PS1, Line 9: This is my first commit to coreboot, so please tell me if I'm missing something. > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] Done https://review.coreboot.org/c/coreboot/+/74173/comment/5862c323_5920106f PS1, Line 9: This is my first commit to coreboot, so please tell me if I'm missing something. > Welcome to coreboot. This could be added as a comment, but does not belong into the commit message. Done Patchset: PS2: Thank you for your time and tips! -- To view, visit https://review.coreboot.org/c/coreboot/+/74173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I976cffe971695f591ec42fce46e6743444277759 Gerrit-Change-Number: 74173 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp M Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable chromeOS EC
by Paul Menzel (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 ) Change subject: mb/google/myst: Enable chromeOS EC ...................................................................... Patch Set 19: (1 comment) File src/mainboard/google/myst/dsdt.asl: https://review.coreboot.org/c/coreboot/+/74099/comment/bc2fd7b0_8c3ff575 PS18, Line 18: Name(LIDS, 0) > https://review.coreboot. […] Thank you. Maybe add a comment with to-do? -- To view, visit https://review.coreboot.org/c/coreboot/+/74099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e Gerrit-Change-Number: 74099 Gerrit-PatchSet: 19 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:51:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/arm* Fix some linter warnings and errors
by Philipp M (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Felix Singer, Philipp Hug, Philipp M, Julius Werner, ron minnich, Elyes Haouas. Hello Felix Singer, build bot (Jenkins), Philipp Hug, Julius Werner, ron minnich, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74173 to look at the new patch set (#2). Change subject: arch/arm* Fix some linter warnings and errors ...................................................................... arch/arm* Fix some linter warnings and errors Correct some linter issues. Some changes seem like no big addition to readability to me, but I guess having everything more uniform is good. Signed-off-by: Philipp Macher <philipp-macher(a)web.de> Change-Id: I976cffe971695f591ec42fce46e6743444277759 --- M src/arch/arm/include/arch/hlt.h M src/arch/arm/include/armv7/arch/cache.h M src/arch/arm64/include/arch/hlt.h 3 files changed, 20 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/74173/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I976cffe971695f591ec42fce46e6743444277759 Gerrit-Change-Number: 74173 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp M Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Philipp M Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable PCIe devices in devicetree
by Jon Murphy (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74112 ) Change subject: mb/google/myst: Enable PCIe devices in devicetree ...................................................................... Patch Set 30: (2 comments) File src/mainboard/google/myst/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74112/comment/0cad5ca3_748d85fb PS30, Line 49: .gpio_group_id = GPIO_27, > Similar to comment below. SD_AUX_RST is on GPIO_29. Done https://review.coreboot.org/c/coreboot/+/74112/comment/46c2f10e_9fdd6f58 PS30, Line 64: .gpio_group_id = GPIO_6, > I'm not sure what this does, but on Skyrim GPIO_6 is tied to SSD_AUX_RST. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdad785bcb90de036095bcc4219c15f55f4277fe Gerrit-Change-Number: 74112 Gerrit-PatchSet: 30 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Fri, 07 Apr 2023 22:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mark Hasemeyer <markhas(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023