coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: Update intel-sec-tools submodule to upstream master
by build bot (Jenkins) (Code Review) 10 Apr '23

10 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74322 ) Change subject: Update intel-sec-tools submodule to upstream master ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173782): https://review.coreboot.org/c/coreboot/+/74322/comment/e30a44a8_5982c5cb PS1, Line 9: Updating from commit id 0031ac7: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173782): https://review.coreboot.org/c/coreboot/+/74322/comment/eb8c8436_184e9b51 PS1, Line 12: to commit id 237c035: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I705c89a1ba36b9d10c5f2326c02d3e37e9a263f6 Gerrit-Change-Number: 74322 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 10:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update intel-sec-tools submodule to upstream master
by Elyes Haouas (Code Review) 10 Apr '23

10 Apr '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74322 ) Change subject: Update intel-sec-tools submodule to upstream master ...................................................................... Update intel-sec-tools submodule to upstream master Updating from commit id 0031ac7: 2021-06-22 14:22:03 +0200 - (Merge pull request #245 from 9elements/meparser) to commit id 237c035: 2023-02-15 16:18:28 +0000 - (Merge pull request #348 from 9elements/feature/brute_force_tpm_event_log_sha256) This brings in 247 new commits. Change-Id: I705c89a1ba36b9d10c5f2326c02d3e37e9a263f6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/intel-sec-tools 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/74322/1 diff --git a/3rdparty/intel-sec-tools b/3rdparty/intel-sec-tools index 0031ac7..237c035 160000 --- a/3rdparty/intel-sec-tools +++ b/3rdparty/intel-sec-tools @@ -1 +1 @@ -Subproject commit 0031ac73447baeb197fb2d80e5fba2470716e76d +Subproject commit 237c035e4f122f70f850dacdc9750ce42bce0d81 -- To view, visit https://review.coreboot.org/c/coreboot/+/74322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I705c89a1ba36b9d10c5f2326c02d3e37e9a263f6 Gerrit-Change-Number: 74322 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Update cmocka submodule to upstream master
by build bot (Jenkins) (Code Review) 10 Apr '23

10 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74321 ) Change subject: Update cmocka submodule to upstream master ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173781): https://review.coreboot.org/c/coreboot/+/74321/comment/320830fb_af94b860 PS1, Line 9: Updating from commit id 8931845: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173781): https://review.coreboot.org/c/coreboot/+/74321/comment/fe578fdf_575ae3a7 PS1, Line 12: to commit id 309ee5e: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d1b3bff650cde25fceb40d8360a954339ee268b Gerrit-Change-Number: 74321 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 10:27:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update cmocka submodule to upstream master
by Elyes Haouas (Code Review) 10 Apr '23

10 Apr '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74321 ) Change subject: Update cmocka submodule to upstream master ...................................................................... Update cmocka submodule to upstream master Updating from commit id 8931845: 2020-10-12 08:24:45 +0200 - (cmocka: Fix cm_print_error() in check_for_leftover_values(_list)) to commit id 309ee5e: 2023-03-23 10:27:02 +0100 - (Allow macros as input for convenience macros) This brings in 163 new commits. Change-Id: I0d1b3bff650cde25fceb40d8360a954339ee268b Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/cmocka 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/74321/1 diff --git a/3rdparty/cmocka b/3rdparty/cmocka index 8931845..309ee5e 160000 --- a/3rdparty/cmocka +++ b/3rdparty/cmocka @@ -1 +1 @@ -Subproject commit 8931845c35e78b5123d73430b071affd537d5935 +Subproject commit 309ee5e4024f003980b51f1e43be7b21b672326b -- To view, visit https://review.coreboot.org/c/coreboot/+/74321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d1b3bff650cde25fceb40d8360a954339ee268b Gerrit-Change-Number: 74321 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Update opensbi submodule to upstream master
by build bot (Jenkins) (Code Review) 10 Apr '23

10 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74320 ) Change subject: Update opensbi submodule to upstream master ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173780): https://review.coreboot.org/c/coreboot/+/74320/comment/e8397a4f_202bb85f PS1, Line 12: to commit id 2868f26: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aa6eb017b0126b7fe335c3b002bb5d59e8a8cb Gerrit-Change-Number: 74320 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 10:25:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update opensbi submodule to upstream master
by Elyes Haouas (Code Review) 10 Apr '23

10 Apr '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74320 ) Change subject: Update opensbi submodule to upstream master ...................................................................... Update opensbi submodule to upstream master Updating from commit id 5019fd1: 2022-09-01 16:53:28 +0530 - (include: sbi: Reduce includes in sbi_pmu.h) to commit id 2868f26: 2023-04-07 11:22:25 +0530 - (lib: utils: fdt_fixup: avoid buffer overrun) This brings in 186 new commits. Change-Id: I65aa6eb017b0126b7fe335c3b002bb5d59e8a8cb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/opensbi 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/74320/1 diff --git a/3rdparty/opensbi b/3rdparty/opensbi index 5019fd1..2868f26 160000 --- a/3rdparty/opensbi +++ b/3rdparty/opensbi @@ -1 +1 @@ -Subproject commit 5019fd124b4c46e1581129c5154fc2cdd3b777ed +Subproject commit 2868f26131308ff345382084681ea89c5b0159f1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aa6eb017b0126b7fe335c3b002bb5d59e8a8cb Gerrit-Change-Number: 74320 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by build bot (Jenkins) (Code Review) 10 Apr '23

10 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74319 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173779): https://review.coreboot.org/c/coreboot/+/74319/comment/53250f7e_350ca7bc PS1, Line 9: Updating from commit id 4c985e867: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173779): https://review.coreboot.org/c/coreboot/+/74319/comment/c8cebb78_f26a0655 PS1, Line 12: to commit id 04f59c4a6: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9d1b685258bfaf453af0b2971e11fbd23dcd160 Gerrit-Change-Number: 74319 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 10:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Elyes Haouas (Code Review) 10 Apr '23

10 Apr '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74319 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id 4c985e867: 2023-03-14 19:53:19 +0100 - (Merge "fix(cpus): workaround for Neoverse V1 errata 2743233" into integration) to commit id 04f59c4a6: 2023-04-06 13:52:25 +0200 - (Merge "style(docs): fix typo s/flase/false/" into integration) This brings in 179 new commits. Change-Id: Ia9d1b685258bfaf453af0b2971e11fbd23dcd160 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M 3rdparty/arm-trusted-firmware 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/74319/1 diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 4c985e8..04f59c4 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 4c985e867469523f91588a2f76bbb5ee5ca53d05 +Subproject commit 04f59c4a642b35699498dde40b3b0a98440e98e4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9d1b685258bfaf453af0b2971e11fbd23dcd160 Gerrit-Change-Number: 74319 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/: Store CSE firmware version into cbmem table
by Dinesh Gehlot (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 ) Change subject: soc/intel/: Store CSE firmware version into cbmem table ...................................................................... Patch Set 4: (3 comments) File src/soc/intel/alderlake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/74256/comment/c1fc97ec_e773aa0c PS3, Line 235: DRIVERS_INTEL_ISH > if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE) && CONFIG(SOC_INTEL_GET_FIRMWARE_VERSIONS_FROM_CSE)) Ack File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74256/comment/8dc03b04_fad16e6c PS3, Line 1087: if (!cse_get_bp_info(&cse_bp_info)) > > suspect code indent for conditional statements (8, 24) […] Ack https://review.coreboot.org/c/coreboot/+/74256/comment/f5b072a4_6ef610fb PS3, Line 1184: ENV_RAMSTAGE > if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && CONFIG(SOC_INTEL_GET_FIRMWARE_VERSIONS_FROM_CSE)) Check for `SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE` may not require, it is already checked at parent if condition. -- To view, visit https://review.coreboot.org/c/coreboot/+/74256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8 Gerrit-Change-Number: 74256 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 10:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/: Store CSE firmware version into cbmem table
by Dinesh Gehlot (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74256 to look at the new patch set (#4). Change subject: soc/intel/: Store CSE firmware version into cbmem table ...................................................................... soc/intel/: Store CSE firmware version into cbmem table The patch implements an API that stores the CSE firmware version in the CBMEM table. The API will be called either from RAMSTAGE or ROMSTAGE based on underlying platform. BUG=b:273661726 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8 --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/soc/intel/alderlake/romstage/romstage.c M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 4 files changed, 62 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/74256/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8 Gerrit-Change-Number: 74256 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023