Attention is currently required from: Felix Singer, Martin L Roth, Stefan Reinauer.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71065 )
Change subject: (not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023.04"
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
> Done
not tested.
(U-boot is Experimental)
--
To view, visit https://review.coreboot.org/c/coreboot/+/71065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24
Gerrit-Change-Number: 71065
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Mon, 10 Apr 2023 08:17:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Stefan Reinauer.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71065 )
Change subject: (not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023.04"
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
> Tested?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/71065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24
Gerrit-Change-Number: 71065
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Mon, 10 Apr 2023 08:10:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla.
Hello build bot (Jenkins), SRIDHAR SIRICILLA, Subrata Banik, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla, Meera Ravindranath,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74005
to look at the new patch set (#24).
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................
soc/intel/cmd/block: Implement an API to get firmware partition details
This patch retrieves details of a specified firmware partition. The
information retrieved includes the mkhi header, current firmware
version, and other information about the partition. The patch
communicates with the ME using the HECI command to acquire this
information.
BUG=b:273661726
Test=Verified the changes for ISHC partition on nissa board.
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74005/24
--
To view, visit https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 24
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, Arthur Heymans.
Hello Felix Singer, build bot (Jenkins), Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72005
to look at the new patch set (#4).
Change subject: treewide: Remove Intel Quark SoC & Galileo mainboard
......................................................................
treewide: Remove Intel Quark SoC & Galileo mainboard
Remove unmaintained SoC Intel Quark and Galileo board:
(Documentation/releases/coreboot-4.20-relnotes.md)
Change-Id: I8f68b851f2eb3a99f12aa0f5ab3370cd0c2a76ae
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
D configs/config.intel_galileo_gen1
D configs/config.intel_galileo_gen2
D configs/config.intel_galileo_gen2.debug
D configs/config.intel_galileo_gen2.fsp2.0
D configs/config.intel_galileo_gen2.sd
D configs/config.intel_galileo_gen2.vboot
M payloads/libpayload/Kconfig
D payloads/libpayload/configs/config.galileo
M src/arch/x86/Kconfig
M src/cpu/x86/entry32.S
M src/drivers/intel/fsp1_1/ramstage.c
D src/mainboard/intel/galileo/Kconfig
D src/mainboard/intel/galileo/Kconfig.name
D src/mainboard/intel/galileo/Makefile.inc
D src/mainboard/intel/galileo/board_info.txt
D src/mainboard/intel/galileo/devicetree.cb
D src/mainboard/intel/galileo/dsdt.asl
D src/mainboard/intel/galileo/gen1.h
D src/mainboard/intel/galileo/gen2.h
D src/mainboard/intel/galileo/gpio.c
D src/mainboard/intel/galileo/mainboard.c
D src/mainboard/intel/galileo/reg_access.c
D src/mainboard/intel/galileo/reg_access.h
D src/mainboard/intel/galileo/romstage.c
D src/mainboard/intel/galileo/sd.c
D src/mainboard/intel/galileo/vboot.c
D src/mainboard/intel/galileo/vboot.fmd
D src/soc/intel/quark/Kconfig
D src/soc/intel/quark/Makefile.inc
D src/soc/intel/quark/acpi.c
D src/soc/intel/quark/bootblock/bootblock.c
D src/soc/intel/quark/bootblock/esram_init.S
D src/soc/intel/quark/chip.c
D src/soc/intel/quark/chip.h
D src/soc/intel/quark/ehci.c
D src/soc/intel/quark/fsp_params.c
D src/soc/intel/quark/gpio_i2c.c
D src/soc/intel/quark/i2c.c
D src/soc/intel/quark/include/soc/IntelQNCConfig.h
D src/soc/intel/quark/include/soc/Ioh.h
D src/soc/intel/quark/include/soc/QuarkNcSocId.h
D src/soc/intel/quark/include/soc/acpi.h
D src/soc/intel/quark/include/soc/car.h
D src/soc/intel/quark/include/soc/cpu.h
D src/soc/intel/quark/include/soc/i2c.h
D src/soc/intel/quark/include/soc/iomap.h
D src/soc/intel/quark/include/soc/nvs.h
D src/soc/intel/quark/include/soc/pci_devs.h
D src/soc/intel/quark/include/soc/pei_wrapper.h
D src/soc/intel/quark/include/soc/pm.h
D src/soc/intel/quark/include/soc/ramstage.h
D src/soc/intel/quark/include/soc/reg_access.h
D src/soc/intel/quark/include/soc/romstage.h
D src/soc/intel/quark/include/soc/sd.h
D src/soc/intel/quark/include/soc/spi.h
D src/soc/intel/quark/include/soc/storage_test.h
D src/soc/intel/quark/lpc.c
D src/soc/intel/quark/memmap.c
D src/soc/intel/quark/northcluster.c
D src/soc/intel/quark/reg_access.c
D src/soc/intel/quark/reset.c
D src/soc/intel/quark/romstage/Makefile.inc
D src/soc/intel/quark/romstage/car.c
D src/soc/intel/quark/romstage/debug.c
D src/soc/intel/quark/romstage/fsp_params.c
D src/soc/intel/quark/romstage/pcie.c
D src/soc/intel/quark/romstage/report_platform.c
D src/soc/intel/quark/romstage/romstage.c
D src/soc/intel/quark/sd.c
D src/soc/intel/quark/spi.c
D src/soc/intel/quark/spi_debug.c
D src/soc/intel/quark/storage_test.c
D src/soc/intel/quark/tsc_freq.c
D src/soc/intel/quark/uart.c
D src/soc/intel/quark/uart_common.c
M util/release/genrelnotes
M util/xcompile/xcompile
77 files changed, 15 insertions(+), 6,476 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/72005/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/72005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f68b851f2eb3a99f12aa0f5ab3370cd0c2a76ae
Gerrit-Change-Number: 72005
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla.
Hello build bot (Jenkins), SRIDHAR SIRICILLA, Subrata Banik, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla, Meera Ravindranath,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74005
to look at the new patch set (#23).
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................
soc/intel/cmd/block: Implement an API to get firmware partition details
This patch retrieves details of a specified firmware partition. The
information retrieved includes the mkhi header, current firmware
version, and other information about the partition. The patch
communicates with the ME using the HECI command to acquire this
information.
BUG=b:273661726
Test=Verified the changes for ISHC partition on nissa board.
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74005/23
--
To view, visit https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 23
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Stefan Reinauer, Elyes Haouas.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71065 )
Change subject: (not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023.04"
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173761):
https://review.coreboot.org/c/coreboot/+/71065/comment/bd356967_fd8ef487
PS6, Line 10: https://source.denx.de/u-boot/u-boot/-/blob/master/doc/develop/release_cycl…
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/71065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24
Gerrit-Change-Number: 71065
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 10 Apr 2023 08:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Stefan Reinauer, Elyes Haouas.
Hello Felix Singer, build bot (Jenkins), Martin L Roth, Stefan Reinauer, Elias Souza,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71065
to look at the new patch set (#6).
Change subject: (not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023.04"
......................................................................
(not tested)payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2023.04"
U-Boot v2023.04 was released on Mon 03 April 2023.
https://source.denx.de/u-boot/u-boot/-/blob/master/doc/develop/release_cycl…
Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M payloads/external/U-Boot/Kconfig
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/71065/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/71065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24
Gerrit-Change-Number: 71065
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Stefan Reinauer.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74318 )
Change subject: payloads/seabios: Update stable from 1.16.1 to 1.16.2
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173760):
https://review.coreboot.org/c/coreboot/+/74318/comment/e09f7ce6_305460cf
PS1, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/74318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19b31f89c8fc504284f327c975c159616eb1b241
Gerrit-Change-Number: 74318
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Mon, 10 Apr 2023 07:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment