coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Sean Rhodes (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74477 ) Change subject: soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74477/comment/b29487e3_52d44160 PS4, Line 10: in globally > drop? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2590e8dec0a308e0dc3d467cb3dd2bb97e877492 Gerrit-Change-Number: 74477 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 20:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Sean Rhodes (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik. Hello build bot (Jenkins), Nico Huber, Tarun Tuli, Subrata Banik, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74477 to look at the new patch set (#5). Change subject: soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT Remove the `TcssD3ColdDisable` option in devicetree, as it exists in Kconfig. The setting is currently unused. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I2590e8dec0a308e0dc3d467cb3dd2bb97e877492 --- M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/fsp_params.c 2 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/74477/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2590e8dec0a308e0dc3d467cb3dd2bb97e877492 Gerrit-Change-Number: 74477 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Michael Niewöhner (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik, Kapil Porwal. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74478 ) Change subject: soc/intel/meteorlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74478/comment/e4691820_edf09269 PS3, Line 10: in globally drop? -- To view, visit https://review.coreboot.org/c/coreboot/+/74478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08930ef84438140a13df74900570b126088bd1cb Gerrit-Change-Number: 74478 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 20:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Sean Rhodes (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74476 ) Change subject: soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74476/comment/aedf5bec_d633180a PS3, Line 10: in globally > drop that? Done https://review.coreboot.org/c/coreboot/+/74476/comment/dab5af87_18d22163 PS3, Line 11: D3Cold_SUPPORT > D3COLD_SUPPORT Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50e49e900c96748edd5b678765e47cc0e0d9b280 Gerrit-Change-Number: 74476 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 20:42:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Michael Niewöhner (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74477 ) Change subject: soc/intel/alderlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74477/comment/bb65fb72_2c86e2de PS4, Line 10: in globally drop? -- To view, visit https://review.coreboot.org/c/coreboot/+/74477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2590e8dec0a308e0dc3d467cb3dd2bb97e877492 Gerrit-Change-Number: 74477 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 20:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Sean Rhodes (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik. Hello build bot (Jenkins), Nico Huber, Tarun Tuli, Subrata Banik, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74476 to look at the new patch set (#4). Change subject: soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT Remove the `TcssD3ColdDisable` option in devicetree, as it exists in Kconfig. The setting is only used on `starlabs/starbook` which selects D3COLD_SUPPORT so the UPDs will not change. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I50e49e900c96748edd5b678765e47cc0e0d9b280 --- M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devtree.c M src/soc/intel/tigerlake/chip.h M src/soc/intel/tigerlake/fsp_params.c 4 files changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/74476/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50e49e900c96748edd5b678765e47cc0e0d9b280 Gerrit-Change-Number: 74476 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT
by Michael Niewöhner (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74476 ) Change subject: soc/intel/tigerlake: Replace TcssD3ColdDisable with D3COLD_SUPPORT ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74476/comment/c6520dab_85cf80ef PS3, Line 10: in globally drop that? https://review.coreboot.org/c/coreboot/+/74476/comment/5ed7c42a_9cc5ba13 PS3, Line 11: D3Cold_SUPPORT D3COLD_SUPPORT -- To view, visit https://review.coreboot.org/c/coreboot/+/74476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50e49e900c96748edd5b678765e47cc0e0d9b280 Gerrit-Change-Number: 74476 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 20:41:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add Power Limits
by Jérémy Compostella (Code Review) 19 Apr '23

19 Apr '23

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: support Power Limits and Voltage Regulator
by Jérémy Compostella (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74572 to look at the new patch set (#3). Change subject: soc/intel/meteorlake: support Power Limits and Voltage Regulator ...................................................................... soc/intel/meteorlake: support Power Limits and Voltage Regulator Power Limits and Voltage Regulator settings are the result of at least the following combination of factors: - The voltage regular itself - The TDP/SoC used - The board design (extra chips, cooling system, ...) - The Operating System and the use-cases - Power and performance measurements and tuning Those settings being board design and use-case specific, they cannot be reduced to simple database indexed on a SoC ID and TDP. They must factor in the board itself. Therefore, this patch adds support to apply Power Limits and Voltage Regulator settings supplied by a board specific database. Note that the FSP includes default Power Limits and Voltage Regulator settings. These settings may be good enough for basic board bring-up but should be refined per board design. BRANCH=None BUG=b:262499722 TEST=TBD Change-Id: Ia1a6d4872718730951591cde6677557eebe3a944 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/chipset.cb M src/soc/intel/meteorlake/romstage/fsp_params.c M src/soc/intel/meteorlake/systemagent.c 4 files changed, 135 insertions(+), 44 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/74572/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1a6d4872718730951591cde6677557eebe3a944 Gerrit-Change-Number: 74572 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common/rtd3: Use D3COLD_SUPPORT to set max sleep state
by Michael Niewöhner (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sean Rhodes, Nico Huber. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74406 ) Change subject: soc/intel/common/rtd3: Use D3COLD_SUPPORT to set max sleep state ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I578d4933b6144aec79fe0b2eb168338ef82c0b9d Gerrit-Change-Number: 74406 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 20:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023