coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2
by Elyes Haouas (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, Elyes Haouas. Hello Felix Singer, build bot (Jenkins), Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73792 to look at the new patch set (#12). Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 ...................................................................... crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/sum/clang-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/clang-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/cmake-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/cmake-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/compiler-rt-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/llvm-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/llvm-16.0.2.src.tar.xz.cksum 11 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/73792/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/73792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Gerrit-Change-Number: 73792 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [Test] [Do Not Merge] Rex: Move CSE FW sync to RAMSTAGE
by Anil Kumar K (Code Review) 20 Apr '23

20 Apr '23

Anil Kumar K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74623 ) Change subject: [Test] [Do Not Merge] Rex: Move CSE FW sync to RAMSTAGE ...................................................................... [Test] [Do Not Merge] Rex: Move CSE FW sync to RAMSTAGE Change-Id: I0a5922f40e719e1bc4e6dc58559d820172550dee --- M src/mainboard/google/rex/Kconfig M src/soc/intel/meteorlake/romstage/romstage.c 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/74623/1 diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 62ece95..575c51e 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -41,6 +41,7 @@ select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 + select SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE if BOARD_GOOGLE_REX_COMMON diff --git a/src/soc/intel/meteorlake/romstage/romstage.c b/src/soc/intel/meteorlake/romstage/romstage.c index ebb440c..ea0931d 100644 --- a/src/soc/intel/meteorlake/romstage/romstage.c +++ b/src/soc/intel/meteorlake/romstage/romstage.c @@ -128,7 +128,7 @@ /* Initialize HECI interface */ cse_init(HECI1_BASE_ADDRESS); - if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SKU)) { + if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE)) { timestamp_add_now(TS_CSE_FW_SYNC_START); cse_fw_sync(); timestamp_add_now(TS_CSE_FW_SYNC_END); -- To view, visit https://review.coreboot.org/c/coreboot/+/74623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a5922f40e719e1bc4e6dc58559d820172550dee Gerrit-Change-Number: 74623 Gerrit-PatchSet: 1 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: nb/amd/pi/00730F01/northbridge: remove unneeded AGESA.h include
by Elyes Haouas (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74618 ) Change subject: nb/amd/pi/00730F01/northbridge: remove unneeded AGESA.h include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If95eb9e5135de2b256d1f584afcedfd6e0cf8d8e Gerrit-Change-Number: 74618 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 20 Apr 2023 18:19:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/(adl, cmn, mtl): Refactor cse_fw_sync() function
by Kapil Porwal (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: SRIDHAR SIRICILLA, Tarun Tuli, Subrata Banik, Kangheui Won. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74582 ) Change subject: soc/intel/(adl, cmn, mtl): Refactor cse_fw_sync() function ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5e8fc2b8c3b605103f7b1238df5a8405e363f83 Gerrit-Change-Number: 74582 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Apr 2023 18:11:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in amd_blobs[master]: Add GenoaPI 1.0.0.4 blos
by Varshit Pandya (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Arthur Heymans. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/amd_blobs/+/74587 ) Change subject: Add GenoaPI 1.0.0.4 blos ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/amd_blobs/+/74587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: amd_blobs Gerrit-Branch: master Gerrit-Change-Id: Iefe6ee816381ad81df784db935c4d5647ee5fd54 Gerrit-Change-Number: 74587 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 20 Apr 2023 18:05:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
by Tim Van Patten (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: John Su, Jason Nien, Jon Murphy, Jason Glenesk, Chris Wang, Martin Roth, Karthik Ramasubramanian, Felix Held. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74583 ) Change subject: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74583/comment/ea554a72_7ae9b9b2 PS3, Line 7: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead We should update Whiterun as well, to prevent hitting similar issues there, assuming the eMMC is more accurate. File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74583/comment/720100f1_f2928b1a PS3, Line 88: if (gpio_get(EMMC_CLKREQ_GPIO)) { Whiterun uses this same query, but is not being fixed with this CL. Is it possible to create a `get_storage_type()` function in `variants/baseboard/gpio.c`, which unifies the GPIO checking and can be called here? The return type would be an `enum` that includes EMMC, NVME, and can be extended to anything else that's supported. That would also prevent redefining `EMMC_CLKREQ_GPIO` here. -- To view, visit https://review.coreboot.org/c/coreboot/+/74583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a9225473a6ae1ba01dc8e5d982c4999f073267e Gerrit-Change-Number: 74583 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 20 Apr 2023 17:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/skyrim: Add named GPIO's
by Raul Rangel (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 ) Change subject: mb/google/skyrim: Add named GPIO's ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74592/comment/0eb963f5_fee0ad87 PS2, Line 10: SYS_RST_ODL One of the nice things about using the numbers is that we can quickly glance at the table to make sure we defined all the GPIOs in the ramstage table. We should add a compile time check to verify that the ramstage table contains definitions for all the GPIOs. -- To view, visit https://review.coreboot.org/c/coreboot/+/74592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340 Gerrit-Change-Number: 74592 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 17:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/octopus: Add EC_HOST_EVENT_PANIC to SCI mask
by Rob Barnes (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Rob Barnes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74622 to look at the new patch set (#2). Change subject: mb/google/octopus: Add EC_HOST_EVENT_PANIC to SCI mask ...................................................................... mb/google/octopus: Add EC_HOST_EVENT_PANIC to SCI mask Adding EC_HOST_EVENT_PANIC to SCI mask allows the EC to interrupt the Kernel when an EC panic occurs. If system safe mode is also enabled on the EC, the kernel will have a short period to extract and save info about the EC panic. BUG=b:268342532 BRANCH=firmware-octopus-11297.B TEST=Observe kernel ec panic handler run when ec panics Signed-off-by: Rob Barnes <robbarnes(a)google.com> Change-Id: I37e566e459f39f8bc2dafc3c3915260259730ca6 --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/74622/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37e566e459f39f8bc2dafc3c3915260259730ca6 Gerrit-Change-Number: 74622 Gerrit-PatchSet: 2 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Refactor ramstage cse fw sync() function
by Kapil Porwal (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: SRIDHAR SIRICILLA, Tarun Tuli, Subrata Banik, Kangheui Won. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74581 ) Change subject: soc/intel/cmn/cse: Refactor ramstage_cse_fw_sync() function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c7a91c81d51dbf6742e12c58a24b9f52fff5630 Gerrit-Change-Number: 74581 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Apr 2023 17:37:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: add power limits update support for variants
by Subrata Banik (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Sumeet R Pawnikar, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74620 ) Change subject: soc/intel/common: add power limits update support for variants ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/include/intelblocks/power_limit.h: https://review.coreboot.org/c/coreboot/+/74620/comment/b769dfa9_a37913a2 PS1, Line 45: struct cpu_power_limits { : uint16_t mchid; : u8 cpu_tdp; : unsigned int pl1_min_power; : unsigned int pl1_max_power; : unsigned int pl2_min_power; : unsigned int pl2_max_power; : unsigned int pl4_power; : }; would you consider using this data structure inside brya as well ? https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/brya/… -- To view, visit https://review.coreboot.org/c/coreboot/+/74620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I414715f211d816bbfad03a673ca96dd5df94caeb Gerrit-Change-Number: 74620 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 17:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023