coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/amd/mendocino: rename pwr_on_vary_bl_to_blon to edp_panel_t8_ms
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Fred Reitberger, Felix Held. Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74787 ) Change subject: soc/amd/mendocino: rename pwr_on_vary_bl_to_blon to edp_panel_t8_ms ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74787/comment/b9f44045_b0fd564a PS1, Line 13: none > same with the other 3 patches. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecdfe47cd9142d8a1ddeee0ec988d37b2a11028e Gerrit-Change-Number: 74787 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 23:40:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMS...
by Anil Kumar K (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Paul Menzel, Kapil Porwal, Sridhar Siricilla, Anil Kumar K. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74763 to look at the new patch set (#5). Change subject: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE ...................................................................... soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE the change 'commit 248dbe0908f1b ("Trigger cse_fw_sync before DRAM Init")' added change to enable CSE FW sync in ROMSTAGE i.e. before DRAM initialization. This patch adds CONFIG flag to choose CSE FW sync in ROMSTAGE, allowing platforms to disable this option when they choose to perform CSE FW sync in RAMSTAGE instead. BUG=b:273207144 BRANCH=none Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0 --- M src/soc/intel/meteorlake/romstage/romstage.c 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/74763/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0 Gerrit-Change-Number: 74763 Gerrit-PatchSet: 5 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMS...
by Anil Kumar K (Code Review) 26 Apr '23

26 Apr '23

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMS...
by Anil Kumar K (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Paul Menzel, Kapil Porwal, Sridhar Siricilla, Anil Kumar K. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74763 ) Change subject: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE ...................................................................... Patch Set 4: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74763/comment/df9f1e6f_1baccf32 PS1, Line 7: Add config option to choose CSE FW sync in ROMSTAGE > > 72? Done Commit Message: https://review.coreboot.org/c/coreboot/+/74763/comment/7756cbd4_bf6cca31 PS3, Line 24: Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0 > Two Change-Ids? fixed File src/soc/intel/meteorlake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/74763/comment/ac58add7_a1b2f438 PS1, Line 131: SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE > use the commit hash from Alder Lake where this changes had landed previously Done https://review.coreboot.org/c/coreboot/+/74763/comment/e2a76166_d82bc4dd PS1, Line 130: : if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE)) : cse_fw_sync(); > this gives the option to mainboard to choose - ROMSTAGE or RAMSTAGE depending on the config flag Done File src/soc/intel/meteorlake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/74763/comment/bcbbf570_7c115e0b PS3, Line 131: if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE)) > Can we check SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE first? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0 Gerrit-Change-Number: 74763 Gerrit-PatchSet: 4 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 23:38:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jamie Ryu <jamie.m.ryu(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: adjust the eDP panel power sequence
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Nien, Chris Wang, Martin Roth. Hello Jason Glenesk, build bot (Jenkins), Jason Nien, Matt DeVillier, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74790 to look at the new patch set (#4). Change subject: mb/google/skyrim/var/winterhold: adjust the eDP panel power sequence ...................................................................... mb/google/skyrim/var/winterhold: adjust the eDP panel power sequence Set edp_panel_t9_ms to 8ms which means it will delay 8ms between backlight off and vary backlight off. BUG=b:271704149 BRANCH=Skyrim TEST=Build; Verify the UPD was passed to system integrated table; Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: I952d05b18e29cf30256f43562a5052007c5c6268 --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/74790/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I952d05b18e29cf30256f43562a5052007c5c6268 Gerrit-Change-Number: 74790 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMS...
by Anil Kumar K (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Anil Kumar K, Tarun Tuli, Kapil Porwal, Sridhar Siricilla. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74763 to look at the new patch set (#4). Change subject: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE ...................................................................... soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE the change 'commit:248dbe0908f1b: ("Trigger cse_fw_sync before DRAM Init")' added change to enable CSE FW sync in ROMSTAGE i.e. before DRAM initialization. This patch adds CONFIG flag to choose CSE FW sync in ROMSTAGE, allowing platforms to disable this option when they choose to perform CSE FW sync in RAMSTAGE instead. BUG=b:273207144 BRANCH=none Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0 --- M src/soc/intel/meteorlake/romstage/romstage.c 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/74763/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0 Gerrit-Change-Number: 74763 Gerrit-PatchSet: 4 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/mendocino: update FSP parameters for eDP power sequence adjus...
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Raul Rangel, Chris Wang, Fred Reitberger, Felix Held. Hello Jason Glenesk, build bot (Jenkins), Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74789 to look at the new patch set (#3). Change subject: soc/amd/mendocino: update FSP parameters for eDP power sequence adjustment ...................................................................... soc/amd/mendocino: update FSP parameters for eDP power sequence adjustment Add UPD parameter for eDP power sequence adjustment. The edp_panel_t9_ms parameter is set for bloff to varybloff. BUG=b:271704149 BRANCH=Skyrim TEST=Build; Verify the UPD was pass to system integrated table. Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Id651c9cc4d6f4e27f6c78ca10ca12936d66ef43b --- M src/soc/amd/mendocino/chip.h M src/soc/amd/mendocino/fsp_m_params.c 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/74789/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id651c9cc4d6f4e27f6c78ca10ca12936d66ef43b Gerrit-Change-Number: 74789 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: vc/amd/fsp/mendocino/FspmUpd: Add UPD to set eDP panel T9 vaule
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Raul Rangel, Chris Wang, Fred Reitberger, Felix Held. Hello Jason Glenesk, build bot (Jenkins), Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74788 to look at the new patch set (#3). Change subject: vc/amd/fsp/mendocino/FspmUpd: Add UPD to set eDP panel T9 vaule ...................................................................... vc/amd/fsp/mendocino/FspmUpd: Add UPD to set eDP panel T9 vaule Add UPD edp_panel_t9_ms for eDP panel sequence adjustment. BUG=b:271704149 BRANCH=Skyrim Test=Build/Boot to ChromeOS Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Idc1a212e9c203584a6497fd6cbd3f995eeb030f2 --- M src/vendorcode/amd/fsp/mendocino/FspmUpd.h 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74788/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1a212e9c203584a6497fd6cbd3f995eeb030f2 Gerrit-Change-Number: 74788 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/mendocino: rename pwr_on_vary_bl_to_blon to edp_panel_t8_ms
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Raul Rangel, Jason Nien, Chris Wang, Fred Reitberger, Felix Held. Hello Jason Glenesk, build bot (Jenkins), Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74787 to look at the new patch set (#2). Change subject: soc/amd/mendocino: rename pwr_on_vary_bl_to_blon to edp_panel_t8_ms ...................................................................... soc/amd/mendocino: rename pwr_on_vary_bl_to_blon to edp_panel_t8_ms Rename the UPD pwr_on_vary_bl_to_blon to edp_panel_t8_ms to match the eDP sequence timing in milliseconds. BUG=b:271704149 BRANCH=Skyrim Test=Build/Boot to ChromeOS Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Iecdfe47cd9142d8a1ddeee0ec988d37b2a11028e --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb M src/soc/amd/mendocino/chip.h M src/soc/amd/mendocino/fsp_m_params.c M src/vendorcode/amd/fsp/mendocino/FspmUpd.h 4 files changed, 24 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/74787/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecdfe47cd9142d8a1ddeee0ec988d37b2a11028e Gerrit-Change-Number: 74787 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/amd: Drop acpi_fill_madt_irqoverride()
by Felix Held (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Kyösti Mälkki, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74357 ) Change subject: soc/amd: Drop acpi_fill_madt_irqoverride() ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS2: > when dropping this, please also drop the corresponding irq_override array in soc/amd/common/block/in […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460fd5fde3a7fba5518ccfc153a266d097a95a39 Gerrit-Change-Number: 74357 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 23:23:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023