coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix variable expansion
by Maximilian Brune (Code Review) 02 Feb '23

02 Feb '23

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72660 ) Change subject: src/sbom/Makefile.inc: Fix variable expansion ...................................................................... src/sbom/Makefile.inc: Fix variable expansion Make does its work in two distinct phases. The first one basically initzializes and expands all variables, which are not in a recipe and the second expands all variables inside recipes and then executes the recipes if neccessary. Currently on some mainboards it can happen that cpu_microcode_bins variable is filled with microcode paths AFTER swid-files-y is expanded in the prerequisite for the sbom rule. That causes the "$(build-dir)/intel-microcode-%.json pattern matchin rule not to be invoked. At the time, when the recipe is executed however (second phase of make), swid-files-y will now contain the cpu microcode paths from cpu_microcode_bins. That causes the goswid tooling to fail since the neccessary files were never created, since "(build-dir)/intel-microcode-%.json" target was never executed. In order to trigger the expansion of swid-files-y at the second make phase (after cpu_microcode_bins is fully filled), this patch makes use of make's secondary expansion feature. Before on some boards (including samsung/lumpy) the goswid tool complained about not finding the microcode sbom files. Test: build samsung/lumpy with CONFIG_SBOM_MICROCODE=y Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I884469a388fd48be89d74ccda686dd8f299d63eb --- M src/sbom/Makefile.inc 1 file changed, 34 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/72660/1 diff --git a/src/sbom/Makefile.inc b/src/sbom/Makefile.inc index b99420e..21e2fa4 100644 --- a/src/sbom/Makefile.inc +++ b/src/sbom/Makefile.inc @@ -85,7 +85,7 @@ ## Build final SBOM (Software Bill of Materials) file in uswid format -$(build-dir)/sbom.uswid: $(build-dir)/coreboot.json $(swid-files-y) $(swid-files-compiler) | $(build-dir)/goswid $(build-dir) +$(build-dir)/sbom.uswid: $(build-dir)/coreboot.json $$(swid-files-y) $(swid-files-compiler) | $(build-dir)/goswid $(build-dir) echo " SBOM " $^ $(build-dir)/goswid convert -o $@ \ --parent $(build-dir)/coreboot.json \ -- To view, visit https://review.coreboot.org/c/coreboot/+/72660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884469a388fd48be89d74ccda686dd8f299d63eb Gerrit-Change-Number: 72660 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Add EC_HOST_EVENT_PANIC to SCI mask
by Tim Van Patten (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Nien, Martin Roth, Rob Barnes. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72455 ) Change subject: mb/google/skyrim: Add EC_HOST_EVENT_PANIC to SCI mask ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72455/comment/a3adbae9_d4a4b503 PS1, Line 16: TEST=Observe kernel ec panic handler run when ec panics > No surprises when testing each scenario: […] Great, thanks for verifying that. -- To view, visit https://review.coreboot.org/c/coreboot/+/72455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b50ab3c0bcef192ef89f173852cda222f1533c7 Gerrit-Change-Number: 72455 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 01:00:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Add EC_HOST_EVENT_PANIC to SCI mask
by Rob Barnes (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Nien, Martin Roth. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72455 ) Change subject: mb/google/skyrim: Add EC_HOST_EVENT_PANIC to SCI mask ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72455/comment/46b75463_1c34d17b PS1, Line 10: If system safe mode is also enabled : on the EC, the kernel will have a short period to extract and save info : about the EC panic. > Thanks for the detailed explanations. […] EC does a system reset which will toggle EC_SYS_RST_L, which toggles SYS_RESET_L on the AP. So AP state will be cleared. https://review.coreboot.org/c/coreboot/+/72455/comment/d96dbe30_c7759446 PS1, Line 16: TEST=Observe kernel ec panic handler run when ec panics > LGTM No surprises when testing each scenario: 1. System reboots. No sign in kernel or AP logs that the SCI was received before rebooting. 2. Safe mode starts, no new logs in kernel, handler does not run, EC reboots. 3. System reboots. No sign in kernel or AP logs that the SCI was received before rebooting. 4. Safe mode starts, kernel handler runs and flushes log. /var/log/cros_ec.previous contains EC log. /var/log/messages shows 'CrOS EC Panic Reported. Shutdown is imminent!' -- To view, visit https://review.coreboot.org/c/coreboot/+/72455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b50ab3c0bcef192ef89f173852cda222f1533c7 Gerrit-Change-Number: 72455 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 00:56:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: security/vboot: Don't build with flashrom support
by Brian Norris (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Raul Rangel, Jack Rosenthal, Julius Werner, Yu-Ping Wu. Hello Raul Rangel, Jack Rosenthal, Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72716 to look at the new patch set (#4). Change subject: security/vboot: Don't build with flashrom support ...................................................................... security/vboot: Don't build with flashrom support We don't need flashrom support just for vboot payloads. The current default (USE_FLASHROM=1) is mostly harmless, especially if libflashrom is not present (the autodetection in vboot_reference just spits out a pkg-config error but doesn't actually fail the build), but it's better to be clear we don't need it. BUG=b:172225709 TEST=build Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/security/vboot/Makefile.inc 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/72716/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/72716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Gerrit-Change-Number: 72716 Gerrit-PatchSet: 4 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU
by Ren Kuo (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Paul Menzel, Reka Norman, Sumeet R Pawnikar, Peter Ou. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 ) Change subject: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71860/comment/01a03aaa_055e67ed PS5, Line 9: Limit(PL) > Please add a space before the (. fixed. https://review.coreboot.org/c/coreboot/+/71860/comment/201b83a2_3f1a042f PS5, Line 9: Craasneto > Shouldn’t that be mentioned in the prefix? fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 00:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU
by Ren Kuo (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Paul Menzel, Reka Norman, Sumeet R Pawnikar, Peter Ou. Hello build bot (Jenkins), David Wu, Tarun Tuli, Kangheui Won, Reka Norman, Vidya Gopalakrishnan, Sumeet R Pawnikar, Tyler Wang, Peter Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71860 to look at the new patch set (#9). Change subject: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU ...................................................................... mb/google/nissa/var/craask: Add DPTF settings for 15W CPU Add ADL-N 15W CPU thermal settings. BUG=b:265101768 TEST=emerge-nissa coreboot Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 74 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/71860/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: security/vboot: Don't build with flashrom support
by Brian Norris (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Raul Rangel, Jack Rosenthal, Julius Werner, Yu-Ping Wu. Hello Raul Rangel, Jack Rosenthal, Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72716 to look at the new patch set (#3). Change subject: security/vboot: Don't build with flashrom support ...................................................................... security/vboot: Don't build with flashrom support We don't need flashrom support just for vboot payloads. This is mostly harmless, especially if libflashrom is not present (the autodetection in vboot_reference just spits out a pkg-config error but doesn't actually fail the build), but it's better to be clear we don't need it. BUG=b:172225709 TEST=build Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/security/vboot/Makefile.inc 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/72716/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Gerrit-Change-Number: 72716 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU
by Ren Kuo (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Paul Menzel, Reka Norman, Sumeet R Pawnikar, Peter Ou. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 ) Change subject: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71860/comment/04d1e74c_18075f97 PS5, Line 7: Modify > This is too broad. Please use a more specific commit message summary. fixed. https://review.coreboot.org/c/coreboot/+/71860/comment/84eecc2e_e54cdb65 PS5, Line 9: Add ADL-N 15W CPU Power Limit(PL) settings for Craasneto > Where did you get the new information from? fixed. Thermal team's Peter Ou provide the table -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 8 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 00:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: security/vboot: Don't build with flashrom support
by Brian Norris (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72716 to look at the new patch set (#2). Change subject: security/vboot: Don't build with flashrom support ...................................................................... security/vboot: Don't build with flashrom support We don't need flashrom support just for vboot payloads. This is mostly harmless, especially if libflashrom is not present (the autodetection in vboot_reference just spits out a pkg-config error but doesn't actually fail the build), but it's better to be clear we need it. BUG=b:172225709 TEST=build Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/security/vboot/Makefile.inc 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/72716/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Gerrit-Change-Number: 72716 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: security/vboot: Don't build with flashrom support
by Brian Norris (Code Review) 02 Feb '23

02 Feb '23

Brian Norris has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72716 ) Change subject: security/vboot: Don't build with flashrom support ...................................................................... security/vboot: Don't build with flashrom support We don't need flashrom support just for vboot payloads. This is mostly harmless, especially if libflashrom is not present (the autodetection in vboot_reference just spits out a pkg-config error but doesn't actually fail the build), but it's better to be clear we need it. Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/security/vboot/Makefile.inc 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/72716/1 diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 8747e02..f6103bb 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -33,6 +33,7 @@ $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$$(abspath $$(dir $$(VBOOT_LIB_$(1)))) \ V=$(V) \ + USE_FLASHROM=0 \ fwlib \ $(if $(CONFIG_SBOM_VBOOT),$$(abspath $$(dir $$(VBOOT_LIB_$(1))))/vboot_host.pc) -- To view, visit https://review.coreboot.org/c/coreboot/+/72716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Gerrit-Change-Number: 72716 Gerrit-PatchSet: 1 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023