coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp/util.c: Add support for spr-sp
by Simon Chou (Code Review) 02 Feb '23

02 Feb '23

Simon Chou has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/71960 ) Change subject: soc/intel/xeon_sp/util.c: Add support for spr-sp ...................................................................... Abandoned obsolete by [CB:72400] and [CB:72403] -- To view, visit https://review.coreboot.org/c/coreboot/+/71960 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcf21f36c69df467a4c690d882522d88fa76f634 Gerrit-Change-Number: 71960 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix variable expansion
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Maximilian Brune. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72660 ) Change subject: src/sbom/Makefile.inc: Fix variable expansion ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: would you please rebase on https://review.coreboot.org/c/coreboot/+/70251 -- To view, visit https://review.coreboot.org/c/coreboot/+/72660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884469a388fd48be89d74ccda686dd8f299d63eb Gerrit-Change-Number: 72660 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 02:05:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU
by Tyler Wang (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Paul Menzel, Reka Norman, Sumeet R Pawnikar, Peter Ou. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 ) Change subject: mb/google/nissa/var/craask: Add DPTF settings for 15W CPU ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd Gerrit-Change-Number: 71860 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 01:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Add entry RIB whose subprog equals 1
by Bao Zheng (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, Jason Glenesk, ritul guru, Zheng Bao, Fred Reitberger. Hello Jason Glenesk, build bot (Jenkins), Zheng Bao, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72507 to look at the new patch set (#3). Change subject: amdfwtool: Add entry RIB whose subprog equals 1 ...................................................................... amdfwtool: Add entry RIB whose subprog equals 1 For the PHX, it uses subprog 0. For the PHX2, it uses subprog 1. Change-Id: Ib013f264fc9940ad95e559fe19bba72c06a19625 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/data_parse.c 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/72507/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib013f264fc9940ad95e559fe19bba72c06a19625 Gerrit-Change-Number: 72507 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: amdfwtool: Set the level of RIB file as level 2
by Bao Zheng (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Glenesk, Marshall Dawson, ritul guru, Zheng Bao, Fred Reitberger, Felix Held. Hello Jason Glenesk, build bot (Jenkins), Marshall Dawson, ritul guru, Zheng Bao, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72508 to look at the new patch set (#2). Change subject: amdfwtool: Set the level of RIB file as level 2 ...................................................................... amdfwtool: Set the level of RIB file as level 2 It is about AB recovery layout which only has level 2. Change-Id: I836f11ca0bf5ad37e5093419465244a5c83318cb Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/72508/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I836f11ca0bf5ad37e5093419465244a5c83318cb Gerrit-Change-Number: 72508 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: security/vboot: Don't build with flashrom support
by Jack Rosenthal (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Raul Rangel, Brian Norris, Julius Werner, Yu-Ping Wu. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72716 ) Change subject: security/vboot: Don't build with flashrom support ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53bcc2d1e7666646ddad58ba3717cfdd321014e8 Gerrit-Change-Number: 72716 Gerrit-PatchSet: 4 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 01:44:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Add phoenix and glinda in get_psp_fw_type
by Bao Zheng (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/72717 to review the following change. Change subject: amdfwtool: Add phoenix and glinda in get_psp_fw_type ...................................................................... amdfwtool: Add phoenix and glinda in get_psp_fw_type Change-Id: If80cc5396703cef41cc615008c9f0dac0b7bbb09 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/72717/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index f95070d..0e5f8fa 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -762,6 +762,8 @@ { switch (soc_id) { case PLATFORM_MENDOCINO: + case PLATFORM_PHOENIX: + case PLATFORM_GLINDA: /* Fallback to fw_type if fw_id is not populated, which serves the same purpose on older SoCs. */ return header->fw_id ? header->fw_id : header->fw_type; -- To view, visit https://review.coreboot.org/c/coreboot/+/72717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If80cc5396703cef41cc615008c9f0dac0b7bbb09 Gerrit-Change-Number: 72717 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix variable expansion
by build bot (Jenkins) (Code Review) 02 Feb '23

02 Feb '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72660 ) Change subject: src/sbom/Makefile.inc: Fix variable expansion ...................................................................... Patch Set 1: (3 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169679): https://review.coreboot.org/c/coreboot/+/72660/comment/a330345b_c512eaa7 PS1, Line 11: the second expands all variables inside recipes and then executes the 'neccessary' may be misspelled - perhaps 'necessary'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169679): https://review.coreboot.org/c/coreboot/+/72660/comment/8a39ae3b_a5d56440 PS1, Line 15: in the prerequisite for the sbom rule. That causes the 'matchin' may be misspelled - perhaps 'matching'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169679): https://review.coreboot.org/c/coreboot/+/72660/comment/ee07141b_576b8ae8 PS1, Line 19: cpu_microcode_bins. That causes the goswid tooling to fail since the 'neccessary' may be misspelled - perhaps 'necessary'? -- To view, visit https://review.coreboot.org/c/coreboot/+/72660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884469a388fd48be89d74ccda686dd8f299d63eb Gerrit-Change-Number: 72660 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Feb 2023 01:23:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Add SBOM (Software Bill of Materials) Generation
by Maximilian Brune (Code Review) 02 Feb '23

02 Feb '23

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63639 ) Change subject: Add SBOM (Software Bill of Materials) Generation ...................................................................... Patch Set 49: (1 comment) Patchset: PS49: > I forget to note that running the build will create "go" directory at my "/home" sry for the late reply, I was quite busy these past few days. I did test the implementation, but it turns out this bug is dependent on the mainboard you build for. I fixed, tested and explained it in: CB:72660 -- To view, visit https://review.coreboot.org/c/coreboot/+/63639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb7481d4903f95d200eddbfed7728fbec51819d0 Gerrit-Change-Number: 63639 Gerrit-PatchSet: 49 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 02 Feb 2023 01:17:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Allow the location to be a relative address
by Bao Zheng (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: ritul guru, Zheng Bao, Fred Reitberger. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 ) Change subject: amdfwtool: Allow the location to be a relative address ...................................................................... Patch Set 16: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/69856/comment/2f638627_64de1d51 PS12, Line 2462: if (efs_location & 0xFF000000) : efs_location = efs_location - rom_base_address; : if (body_location & 0xFF000000) : body_location = body_location - rom_base_address; > I like how that turned out. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c Gerrit-Change-Number: 69856 Gerrit-PatchSet: 16 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 01:14:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023