coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: treewide: Remove unuseful "_HID: Hardware ID" comment
by Felix Held (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro, Elyes Haouas. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72661 ) Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: hm, not sure if i'd remove that, since HID means something completely different in the ACPI vs the USB context which i found confusing some years ago. don't have a too strong opinion about this, so if someone else also wants those comments gone, won't complain -- To view, visit https://review.coreboot.org/c/coreboot/+/72661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905 Gerrit-Change-Number: 72661 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72012 to look at the new patch set (#4). Change subject: mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4 ...................................................................... mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4 Set DmiMaxLinkSpeed to 4 in FSP to ensure that FSP always supports PCIe Gen 4 drives. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I0e31919122dacfbdc2486fa8216a28b479f3bd00 --- M src/mainboard/starlabs/starbook/variants/adl/romstage.c M src/mainboard/starlabs/starbook/variants/tgl/romstage.c 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/72012/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/72012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e31919122dacfbdc2486fa8216a28b479f3bd00 Gerrit-Change-Number: 72012 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: vc/siemens/hwilib: Change uint32_t return type to size_t
by Jan Samek (Code Review) 02 Feb '23

02 Feb '23

Jan Samek has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72667 ) Change subject: vc/siemens/hwilib: Change uint32_t return type to size_t ...................................................................... vc/siemens/hwilib: Change uint32_t return type to size_t The commit fcff39f0ea47 ("vc/siemens/hwilib: Rename 'maxlen' to 'dstsize'") changed the 'dstsize' input parameter type from uint32_t to size_t. This patch changes also the return parameter, which is often directly compared with the aforementioned input parameter value. This should introduce no change on 32-bit builds and stay consistent across the project in the case of 64-bit builds and avoid comparisons of integers of different width here. BUG=none TEST=No changes to hwilib behavior on any of the siemens/mc_apl1 or siemens/mc_ehl variants. Change-Id: I0a623f55b596297cdb6e17232828b9536c9a43e6 Signed-off-by: Jan Samek <jan.samek(a)siemens.com> --- M src/vendorcode/siemens/hwilib/hwilib.c M src/vendorcode/siemens/hwilib/hwilib.h 2 files changed, 29 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/72667/1 diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c index b6c8c6b..2a3c10a 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.c +++ b/src/vendorcode/siemens/hwilib/hwilib.c @@ -53,7 +53,7 @@ struct param_pos pos[MAX_BLOCK_NUM]; uint64_t mask; uint8_t mask_offset; - uint32_t (*get_field)(const struct param_info *param, uint8_t *dst, size_t dstsize); + size_t (*get_field)(const struct param_info *param, uint8_t *dst, size_t dstsize); }; /* Storage for pointers to the different blocks. The contents will be filled @@ -69,7 +69,7 @@ /* Storage for the cbfs file name of the currently open hwi file. */ static char current_hwi[HWI_MAX_NAME_LEN]; -static uint32_t hwilib_read_bytes(const struct param_info *param, uint8_t *dst, size_t dstsize); +static size_t hwilib_read_bytes(const struct param_info *param, uint8_t *dst, size_t dstsize); /* Add all supported fields to this variable. It is important to use the * field type of a given field as the array index so that all the information @@ -385,7 +385,7 @@ * @param dstsize Size of the memory passed in via the *dst pointer * @return Number of copied bytes on success, 0 on error */ -static uint32_t hwilib_read_bytes(const struct param_info *param, uint8_t *dst, size_t dstsize) +static size_t hwilib_read_bytes(const struct param_info *param, uint8_t *dst, size_t dstsize) { uint8_t i = 0, *blk = NULL; @@ -541,7 +541,7 @@ * @param dstsize Size of the memory passed in via the *dst pointer * @return Number of copied bytes on success, 0 on error */ -uint32_t hwilib_get_field(hwinfo_field_t field, uint8_t *dst, size_t dstsize) +size_t hwilib_get_field(hwinfo_field_t field, uint8_t *dst, size_t dstsize) { /* Check the boundaries of params-variable */ if ((uint32_t)field < ARRAY_SIZE(params)) diff --git a/src/vendorcode/siemens/hwilib/hwilib.h b/src/vendorcode/siemens/hwilib/hwilib.h index e4b11dd..2a4f4cd 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.h +++ b/src/vendorcode/siemens/hwilib/hwilib.h @@ -123,6 +123,6 @@ /* Use this function to get fields out of supported info blocks * This function returns the number of copied bytes or 0 on error. */ -uint32_t hwilib_get_field(hwinfo_field_t field, uint8_t *dst, size_t dstsize); +size_t hwilib_get_field(hwinfo_field_t field, uint8_t *dst, size_t dstsize); #endif /* SIEMENS_HWI_LIB_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/72667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a623f55b596297cdb6e17232828b9536c9a43e6 Gerrit-Change-Number: 72667 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72012 to look at the new patch set (#3). Change subject: mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4 ...................................................................... mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4 Set DmiMaxLinkSpeed to 4 in FSP to ensure that FSP always supports PCIe Gen 4 drives. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I0e31919122dacfbdc2486fa8216a28b479f3bd00 --- M src/mainboard/starlabs/starbook/variants/adl/romstage.c M src/mainboard/starlabs/starbook/variants/tgl/romstage.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/72012/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e31919122dacfbdc2486fa8216a28b479f3bd00 Gerrit-Change-Number: 72012 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Sean Rhodes has restored this change. ( https://review.coreboot.org/c/coreboot/+/72012 ) Change subject: mb/starlabs/starbook/{tgl,adl}: Set DmiMaxLinkSpeed to 4 ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/72012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e31919122dacfbdc2486fa8216a28b479f3bd00 Gerrit-Change-Number: 72012 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[L] Change in libgfxinit[master]: common/gma-registers: Update for Tiger Lake
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Nico Huber, Jérémy Compostella, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67489 ) Change subject: common/gma-registers: Update for Tiger Lake ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I61331746365a80c9f953e7d75749f138a2e9adac Gerrit-Change-Number: 67489 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:11:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgfxinit[master]: common: Begin Alder Lake integration
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jérémy Compostella, Tim Wawrzynczak. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/70888 ) Change subject: common: Begin Alder Lake integration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/70888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ia9ab283b388735c4dd01c710251057c12b90b18e Gerrit-Change-Number: 70888 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:11:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Nico Huber, Tarun Tuli, Jérémy Compostella, Tim Wawrzynczak. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/70887 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/70887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I84f15837856ecc5ec8df18b39d3989885cd550d4 Gerrit-Change-Number: 70887 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:11:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel: Use common codeflow for MP init
by Sean Rhodes (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Nico Huber, Tarun Tuli, Subrata Banik, Jonathan Zhang, Johnny Lin, Kapil Porwal, Christian Walter, Arthur Heymans, Lean Sheng Tan, Werner Zeh, Tim Chu. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72604 ) Change subject: soc/intel: Use common codeflow for MP init ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822468a6f15565b97e57612a294a0b80b45b932 Gerrit-Change-Number: 72604 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:09:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda
by Felix Held (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72659 ) Change subject: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: i'd split this patch into two halves: one for picasso, cezanne and mendocino that doesn't change behavior and one for phenix and glinda that changes behavior. or have one patch change to use the common code and another one to change behavior on phoenix and glinda. mixing cleanups/code improvements with functional changes in one patch makes the very unlikely case of the need for a revert more difficult. apart from that, i like the patch -- To view, visit https://review.coreboot.org/c/coreboot/+/72659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie05c790573e4e68f3ec91bacffcc7d7efb986d79 Gerrit-Change-Number: 72659 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:09:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023