coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: console: Add SimNow console logging
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72751 ) Change subject: console: Add SimNow console logging ...................................................................... console: Add SimNow console logging The AMD SimNow tool supports fast logging through an IO port. Add a new console to support SimNow logging through port 80. TEST=observe significant speed improvements on SimNow console log Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I42a431f48ea14ba4adacbd4a32e15abe7c5e4951 --- M src/console/Kconfig M src/console/console.c M src/include/console/console.h A src/include/console/simnow.h A src/soc/amd/common/block/simnow/Makefile.inc A src/soc/amd/common/block/simnow/simnow_console.c 6 files changed, 86 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/72751/1 diff --git a/src/console/Kconfig b/src/console/Kconfig index c6aec18..721cc60 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -367,6 +367,14 @@ help Send coreboot debug output to a System76 embedded controller. +config CONSOLE_AMD_SIMNOW + bool "AMD SimNow console output" + default n + depends on SOC_AMD_COMMON && !POST_IO + select CONSOLE_POST + help + Send coreboot debug output to IO ports for SimNow + config CONSOLE_OVERRIDE_LOGLEVEL bool help diff --git a/src/console/console.c b/src/console/console.c index 499a336..9a079ed 100644 --- a/src/console/console.c +++ b/src/console/console.c @@ -5,6 +5,7 @@ #include <console/i2c_smbus.h> #include <console/ne2k.h> #include <console/qemu_debugcon.h> +#include <console/simnow.h> #include <console/spi.h> #include <console/spkmodem.h> #include <console/streams.h> @@ -28,6 +29,7 @@ __flashconsole_init(); __system76_ec_init(); __i2c_smbus_console_init(); + __simnow_console_init(); } void console_interactive_tx_byte(unsigned char byte, void *data_unused) @@ -47,6 +49,7 @@ __spiconsole_tx_byte(byte); __system76_ec_tx_byte(byte); __i2c_smbus_console_tx_byte(byte); + __simnow_console_tx_byte(byte); } void console_stored_tx_byte(unsigned char byte, void *data_unused) diff --git a/src/include/console/console.h b/src/include/console/console.h index 6f44d7f..c69efcd 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -72,7 +72,7 @@ #define HAS_ONLY_FAST_CONSOLES !(CONFIG(SPKMODEM) || CONFIG(CONSOLE_QEMU_DEBUGCON) || \ CONFIG(CONSOLE_SERIAL) || CONFIG(CONSOLE_NE2K) || CONFIG(CONSOLE_USB) || \ CONFIG(EM100PRO_SPI_CONSOLE) || CONFIG(CONSOLE_SPI_FLASH) || \ - CONFIG(CONSOLE_SYSTEM76_EC)) + CONFIG(CONSOLE_SYSTEM76_EC) || CONFIG(CONSOLE_AMD_SIMNOW)) #else static inline int get_log_level(void) { return -1; } diff --git a/src/include/console/simnow.h b/src/include/console/simnow.h new file mode 100644 index 0000000..9a9d679 --- /dev/null +++ b/src/include/console/simnow.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef CONSOLE_SIMNOW_H +#define CONSOLE_SIMNOW_H + +#include <stdint.h> + +void simnow_console_init(void); +void simnow_console_tx_byte(unsigned char data); + +#define __SIMNOW_CONSOLE_ENABLE__ CONFIG(CONSOLE_AMD_SIMNOW) + +#if __SIMNOW_CONSOLE_ENABLE__ +static inline void __simnow_console_init(void) +{ + simnow_console_init(); +} + +static inline void __simnow_console_tx_byte(u8 data) +{ + simnow_console_tx_byte(data); +} +#else +static inline void __simnow_console_init(void) {} +static inline void __simnow_console_tx_byte(u8 data) {} +#endif + +#endif /* CONSOLE_SIMNOW_H */ diff --git a/src/soc/amd/common/block/simnow/Makefile.inc b/src/soc/amd/common/block/simnow/Makefile.inc new file mode 100644 index 0000000..a109d4a --- /dev/null +++ b/src/soc/amd/common/block/simnow/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-only + +all-$(CONFIG_CONSOLE_AMD_SIMNOW) += simnow_console.c + +ifeq ($(CONFIG_DEBUG_SMI),y) +smm-$(CONFIG_AMD_SOC_CONSOLE_UART) += simnow_console.c +endif diff --git a/src/soc/amd/common/block/simnow/simnow_console.c b/src/soc/amd/common/block/simnow/simnow_console.c new file mode 100644 index 0000000..478674a --- /dev/null +++ b/src/soc/amd/common/block/simnow/simnow_console.c @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <arch/io.h> +#include <console/console.h> +#include <console/simnow.h> + +#define AMD_SIMNOW_PORT 0x80 +#define AMD_SIMNOW_PORT_DATA_BEGIN 0x5f535452ul +#define AMD_SIMNOW_PORT_DATA_END 0x5f454e44ul + +void simnow_console_init(void) +{ + outl(AMD_SIMNOW_PORT_DATA_BEGIN, AMD_SIMNOW_PORT); +} + +void simnow_console_tx_byte(unsigned char data) +{ + outb(data, AMD_SIMNOW_PORT); + + if (data == '\n') { + outl(AMD_SIMNOW_PORT_DATA_END, AMD_SIMNOW_PORT); + outl(AMD_SIMNOW_PORT_DATA_BEGIN, AMD_SIMNOW_PORT); + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/72751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a431f48ea14ba4adacbd4a32e15abe7c5e4951 Gerrit-Change-Number: 72751 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: amdfwtool: Put soc name setting to fw.cfg from command line
by Bao Zheng (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Nien, Matt DeVillier. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58552 ) Change subject: amdfwtool: Put soc name setting to fw.cfg from command line ...................................................................... Patch Set 35: (1 comment) Patchset: PS35: Since https://review.coreboot.org/c/coreboot/+/72456 need to change, this also need to change. hold -- To view, visit https://review.coreboot.org/c/coreboot/+/58552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0eead1f2156542ea03d58145f5ad67683bf9b52 Gerrit-Change-Number: 58552 Gerrit-PatchSet: 35 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 15:13:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: treewide: Remove unuseful "_HID: Hardware ID" comment
by Tim Crawford (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Sean Rhodes, Jeremy Soller, Nick Vaccaro, Felix Held, Elyes Haouas. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72661 ) Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > hm, not sure if i'd remove that, since HID means something completely different in the ACPI vs the U […] I do think these should be documented somewhere, but not every time they're used. For example, Documentation/acpi/uid.md mentions _HID, _CID, and _UID, but doesn't actually define what any of them mean. -- To view, visit https://review.coreboot.org/c/coreboot/+/72661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905 Gerrit-Change-Number: 72661 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:50:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Remove command line option soc-name
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, Zheng Bao. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72468 ) Change subject: amdfwtool: Remove command line option soc-name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba2ebd5d0310538e04c07493d28039509ad02321 Gerrit-Change-Number: 72468 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 02 Feb 2023 14:34:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/*/Makefile.inc: remove command line soc-name
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72467 ) Change subject: soc/amd/*/Makefile.inc: remove command line soc-name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf9e491ed46ae574ccd17f24925e3e5c595039fa Gerrit-Change-Number: 72467 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:33:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Put soc name setting to fw.cfg from command line
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, Jason Nien, Matt DeVillier. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58552 ) Change subject: amdfwtool: Put soc name setting to fw.cfg from command line ...................................................................... Patch Set 35: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0eead1f2156542ea03d58145f5ad67683bf9b52 Gerrit-Change-Number: 58552 Gerrit-PatchSet: 35 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:32:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/*: Add SOC_NAME in fw.cfg(s)
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Zheng Bao, Martin Roth, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72457 ) Change subject: soc/amd/*: Add SOC_NAME in fw.cfg(s) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18f73462a3995038fe93750320dfc053fec969ba Gerrit-Change-Number: 72457 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:32:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Parse the line with SOC_NAME
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, Zheng Bao. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72456 ) Change subject: amdfwtool: Parse the line with SOC_NAME ...................................................................... Patch Set 2: (1 comment) File util/amdfwtool/data_parse.c: https://review.coreboot.org/c/coreboot/+/72456/comment/74839a70_a071df81 PS2, Line 651: } else if (strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) { : /* TODO: Add back later */ : /* cb_config->soc_id = : identify_platform(&(oneline[match[2].rm_so])); */ This else-if block should be added in CB:58552 since it is not necessary until then. That would avoid adding a "TODO" comment here that is removed there. -- To view, visit https://review.coreboot.org/c/coreboot/+/72456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b8d7154d22db13675ff57b6abe61c747604c524 Gerrit-Change-Number: 72456 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 02 Feb 2023 14:31:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda
by Felix Held (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72659 ) Change subject: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: should i abandon CB:72690 which did some work that won't be needed with this patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/72659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie05c790573e4e68f3ec91bacffcc7d7efb986d79 Gerrit-Change-Number: 72659 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/cezanne/reset: deduplicate code
by Felix Held (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72690 ) Change subject: soc/amd/cezanne/reset: deduplicate code ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: i guess that this one won't be needed after CB:72659, so should i abandon this one? File src/soc/amd/cezanne/reset.c: https://review.coreboot.org/c/coreboot/+/72690/comment/a6f388b7_aeaaf3ab PS1, Line 21: do_cold_reset(); > is it worth adding a printk here to alert that a warm reset was requested but a cold reset will be p […] hm, not sure -- To view, visit https://review.coreboot.org/c/coreboot/+/72690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3fe010a2b361ae9a1befeb4f07b12a80d978460 Gerrit-Change-Number: 72690 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:26:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023