coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by char (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Hello build bot (Jenkins), Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72827 to look at the new patch set (#5). Change subject: superio/ite: Add support for ITE IT8987e ...................................................................... superio/ite: Add support for ITE IT8987e Datasheet IT8987E/VG Preliminary Specification V0.3.1, revision B. This is specifically to support the Acer Swift 3 mainboard addition. See changeset 70623. Signed-off-by: hack-char <char(a)dmail.site> Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 --- M src/superio/ite/Makefile.inc A src/superio/ite/it8987e/Kconfig A src/superio/ite/it8987e/Makefile.inc A src/superio/ite/it8987e/chip.h A src/superio/ite/it8987e/it8987e.h A src/superio/ite/it8987e/superio.c 6 files changed, 144 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/72827/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 5 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by build bot (Jenkins) (Code Review) 05 Feb '23

05 Feb '23

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by char (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Hello build bot (Jenkins), Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72827 to look at the new patch set (#4). Change subject: superio/ite: Add support for ITE IT8987e ...................................................................... superio/ite: Add support for ITE IT8987e Datasheet IT8987E/VG Preliminary Specification V0.3.1, revision B. This is specifically to support the Acer Swift 3 mainboard addition. See changeset 70623. Signed-off-by: hack-char <char(a)dmail.site> Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 --- M src/superio/ite/Makefile.inc A src/superio/ite/it8987e/Kconfig A src/superio/ite/it8987e/Makefile.inc A src/superio/ite/it8987e/chip.h A src/superio/ite/it8987e/it8987e.h A src/superio/ite/it8987e/superio.c 6 files changed, 146 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/72827/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 4 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by char (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Hello build bot (Jenkins), Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72827 to look at the new patch set (#3). Change subject: superio/ite: Add support for ITE IT8987e ...................................................................... superio/ite: Add support for ITE IT8987e Datasheet IT8987E/VG Preliminary Specification V0.3.1, revision B. This is specifically to support the Acer Swift 3 mainboard addition. See changeset 70623. Signed-off-by: hack-char <char(a)dmail.site> Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 --- M src/superio/ite/Makefile.inc A src/superio/ite/it8987e/Kconfig A src/superio/ite/it8987e/Makefile.inc A src/superio/ite/it8987e/chip.h A src/superio/ite/it8987e/it8987e.h A src/superio/ite/it8987e/superio.c 6 files changed, 146 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/72827/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 3 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Adding new ITE IT8987e
by build bot (Jenkins) (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 ) Change subject: Adding new ITE IT8987e ...................................................................... Patch Set 2: Verified-1 (32 comments) File src/superio/ite/it8987e/superio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/69097fd5_f9e41c33 PS2, Line 18: if (!dev->enabled) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/64ebe412_51aad5bf PS2, Line 18: if (!dev->enabled) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/d36f66b2_ce02a520 PS2, Line 19: return; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/19c48683_cc26a509 PS2, Line 19: return; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/1e9c6237_2f7ff17c PS2, Line 21: switch (dev->path.pnp.device) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/5d6678f0_b71c095e PS2, Line 21: switch (dev->path.pnp.device) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/b3dc3231_f3c02de1 PS2, Line 22: case IT8987E_KBCK: code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/46206cdb_ebc19e5c PS2, Line 22: case IT8987E_KBCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/42267015_593907f0 PS2, Line 23: pc_keyboard_init(NO_AUX_DEVICE); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/3981ae89_751cd255 PS2, Line 23: pc_keyboard_init(NO_AUX_DEVICE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/3b6e3ca7_3e344b78 PS2, Line 24: break; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/90e2ce86_f2d886da PS2, Line 24: break; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/e684a61d_16a6999d PS2, Line 25: default: code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/77b4acad_4d536d5f PS2, Line 27: break; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/17eaf571_f2982883 PS2, Line 27: break; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/b33ae4b4_4671021c PS2, Line 28: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/4a39f319_6d63c46e PS2, Line 28: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/18dab40f_32e34f3c PS2, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/43a931b2_db255dce PS2, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/84ada449_46cbbae9 PS2, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/4833d30e_8f459145 PS2, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/6998c502_b3cd0a51 PS2, Line 65: const struct superio_ite_it8987e_config *conf; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/399b493c_573a1190 PS2, Line 65: const struct superio_ite_it8987e_config *conf; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/da0db5bf_5ae43c16 PS2, Line 69: conf = dev->chip_info; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/64ba510f_2a3354c2 PS2, Line 69: conf = dev->chip_info; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/9fe94037_12b7afda PS2, Line 70: if (!conf) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/79b3253a_dbb41ef3 PS2, Line 70: if (!conf) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/89f74648_bf37d440 PS2, Line 70: if (!conf) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/8ad5c21b_c76c4583 PS2, Line 74: printk(BIOS_INFO, "IT8987E: init ITE EC\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/1b11ef1f_c21cdddc PS2, Line 75: ite_ec_init(0x25e, &conf->ec); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/d6691f56_dd7826b6 PS2, Line 75: ite_ec_init(0x25e, &conf->ec); please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/2e2d4ca2_eee65a16 PS2, Line 75: ite_ec_init(0x25e, &conf->ec); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 2 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Feb 2023 21:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Adding new ITE IT8987e
by Paul Menzel (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 ) Change subject: Adding new ITE IT8987e ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72827/comment/87e240bc_d47c23ea PS1, Line 11: Please add the datasheet name and version. -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 1 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Feb 2023 20:57:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Adding new ITE IT8987e
by Paul Menzel (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 ) Change subject: Adding new ITE IT8987e ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72827/comment/96af62a9_c31be8f3 PS1, Line 7: Adding new ITE IT8987e Please use imperative mood: > superio/ite: Add support for ITE IT8987e -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 1 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Feb 2023 20:57:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Add support for and select CONFIG_VBIOS_CACHE_IN_FMAP
by Martin L Roth (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70900 ) Change subject: mb/google/skyrim: Add support for and select CONFIG_VBIOS_CACHE_IN_FMAP ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70900/comment/3753035e_a418f071 PS1, Line 15: > We should add a depends_on here for a chromeos change to disable the saved psp_verstage. […] The signed verstage has been removed from chromeos for now, so we can merge this when everything else is ready. File src/mainboard/google/skyrim/Kconfig: https://review.coreboot.org/c/coreboot/+/70900/comment/a6a79452_16df211e PS8, Line 108: VBIOS_CACHE_IN_FMAP Is there any reason we shouldn't just select this, since the cache region actually *is* in the FMAP after this change? if this isn't just saying that the FMAP has the VBIOS_CACHE region, maybe change this to USE_VBIOS_CACHE_IN_FMAP? -- To view, visit https://review.coreboot.org/c/coreboot/+/70900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5857fa4a15250bf6478bffa96b16200e318492b1 Gerrit-Change-Number: 70900 Gerrit-PatchSet: 8 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sun, 05 Feb 2023 20:36:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/mendocino: Add support for VBIOS FMAP cache
by Martin L Roth (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70899 ) Change subject: soc/amd/mendocino: Add support for VBIOS FMAP cache ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ddadc254e05aca0fdd7a9567160a9329cb0e15c Gerrit-Change-Number: 70899 Gerrit-PatchSet: 8 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Feb 2023 20:32:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block/gfx: Use TPM-stored hash for vbios cache validation
by Martin L Roth (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72402 ) Change subject: soc/amd/common/block/gfx: Use TPM-stored hash for vbios cache validation ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c8f23b000b90a1072aeb7a57d3b7b2b2bc626dc Gerrit-Change-Number: 72402 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Feb 2023 20:30:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023