coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: src/soc/intel/common/block/pcie/rtd3: Fix root port _ON logic
by Eric Lai (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Anil Kumar K, Cliff Huang, Jérémy Compostella. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72826 ) Change subject: src/soc/intel/common/block/pcie/rtd3: Fix root port _ON logic ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/pcie/rtd3/rtd3.c: https://review.coreboot.org/c/coreboot/+/72826/comment/c278dd39_f3595649 PS2, Line 195: acpigen_emit_byte(DECREMENT_OP); will this CL cause DECREMENT twice? -- To view, visit https://review.coreboot.org/c/coreboot/+/72826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1ea2e78e98d334a90294ee6cdd14ae2de9b9b62 Gerrit-Change-Number: 72826 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 00:19:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
by David Hendricks (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Ryback Hung, Paul Menzel, Angel Pons, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 ) Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock ...................................................................... Patch Set 8: -Code-Review (1 comment) File src/soc/intel/common/block/fast_spi/fast_spi.c: https://review.coreboot.org/c/coreboot/+/71953/comment/952d64f1_82131435 PS6, Line 467: pci_write_config32(dev, SPI_BIOS_DECODE_EN, bde); > Done Sorry, looking back at this I think what Paul meant is: `pci_or_config32(dev, SPI_BIOS_DECODE_EN, SPI_BIOS_DECODE_LOCK);` Then we can get rid of the `bde` variable and reduce the size of this function by 3 lines. -- To view, visit https://review.coreboot.org/c/coreboot/+/71953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285 Gerrit-Change-Number: 71953 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 00:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Simon Chou <simonchou(a)supermicro.com.tw> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
by David Hendricks (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Ryback Hung, Paul Menzel, Angel Pons, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 ) Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/common/block/fast_spi/fast_spi.c: https://review.coreboot.org/c/coreboot/+/71953/comment/4fd4e2e3_146d71ab PS6, Line 467: pci_write_config32(dev, SPI_BIOS_DECODE_EN, bde); > I checked the implementation of pci_or_config32(), both pci_read_config32() and pci_write_config32() […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285 Gerrit-Change-Number: 71953 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 05 Feb 2023 23:52:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Chou <simonchou(a)supermicro.com.tw> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
by David Hendricks (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Ryback Hung, Paul Menzel, Angel Pons, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 ) Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285 Gerrit-Change-Number: 71953 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 05 Feb 2023 23:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: tree: drop repeated words
by Elyes Haouas (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Erik van den Bogaert, Martin L Roth, Frans Hendriks, Patrick Rudolph, Jakub Czapiga, Christian Walter, Angel Pons, Julius Werner, Lean Sheng Tan, Alexander Couzens, Evgeny Zinoviev, Alexander Goncharov. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72795 ) Change subject: tree: drop repeated words ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c6d0887a45fdb4b6de294770a7fdd5545a9479b Gerrit-Change-Number: 72795 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 05 Feb 2023 23:44:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by char (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Hello build bot (Jenkins), Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72827 to look at the new patch set (#7). Change subject: superio/ite: Add support for ITE IT8987e ...................................................................... superio/ite: Add support for ITE IT8987e Datasheet IT8987E/VG Preliminary Specification V0.3.1, revision B. This is specifically to support the Acer Swift 3 mainboard addition. See changeset 70623. Signed-off-by: hack-char <char(a)dmail.site> Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 --- M src/superio/ite/Makefile.inc A src/superio/ite/it8987e/Kconfig A src/superio/ite/it8987e/Makefile.inc A src/superio/ite/it8987e/chip.h A src/superio/ite/it8987e/it8987e.h A src/superio/ite/it8987e/superio.c 6 files changed, 144 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/72827/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 7 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: tree: drop repeated words
by Nicholas Chin (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: Erik van den Bogaert, Martin L Roth, Frans Hendriks, Patrick Rudolph, Jakub Czapiga, Christian Walter, Angel Pons, Julius Werner, Lean Sheng Tan, Alexander Couzens, Evgeny Zinoviev, Alexander Goncharov. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72795 ) Change subject: tree: drop repeated words ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72795/comment/7d909ab1_4c42bfac PS1, Line 7: drop Nit: capitalize -- To view, visit https://review.coreboot.org/c/coreboot/+/72795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c6d0887a45fdb4b6de294770a7fdd5545a9479b Gerrit-Change-Number: 72795 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 05 Feb 2023 21:22:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by build bot (Jenkins) (Code Review) 05 Feb '23

05 Feb '23

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by char (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. Hello build bot (Jenkins), Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72827 to look at the new patch set (#6). Change subject: superio/ite: Add support for ITE IT8987e ...................................................................... superio/ite: Add support for ITE IT8987e Datasheet IT8987E/VG Preliminary Specification V0.3.1, revision B. This is specifically to support the Acer Swift 3 mainboard addition. See changeset 70623. Signed-off-by: hack-char <char(a)dmail.site> Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 --- M src/superio/ite/Makefile.inc A src/superio/ite/it8987e/Kconfig A src/superio/ite/it8987e/Makefile.inc A src/superio/ite/it8987e/chip.h A src/superio/ite/it8987e/it8987e.h A src/superio/ite/it8987e/superio.c 6 files changed, 145 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/72827/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 6 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: superio/ite: Add support for ITE IT8987e
by build bot (Jenkins) (Code Review) 05 Feb '23

05 Feb '23

Attention is currently required from: char, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 ) Change subject: superio/ite: Add support for ITE IT8987e ...................................................................... Patch Set 5: (5 comments) File src/superio/ite/it8987e/superio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/8d48a568_5dede266 PS5, Line 18: if (!dev->enabled) suspect code indent for conditional statements (8, 24) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/62ddfd97_e5146349 PS5, Line 21: switch (dev->path.pnp.device) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/5fb3fab2_19c8b7d2 PS5, Line 49: PNP_MSC0 | PNP_MSC1 | PNP_MSC2, 0xfffe, 0xfffe, 0xfffe, 0xfffe}, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/2a03f8a9_09c9e348 PS5, Line 49: PNP_MSC0 | PNP_MSC1 | PNP_MSC2, 0xfffe, 0xfffe, 0xfffe, 0xfffe}, please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/ebc1aeeb_b635a4cc PS5, Line 71: } else { suspect code indent for conditional statements (8, 24) -- To view, visit https://review.coreboot.org/c/coreboot/+/72827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide92e41ccadcea665544a07895614fa9514619e2 Gerrit-Change-Number: 72827 Gerrit-PatchSet: 5 Gerrit-Owner: char Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: char Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Feb 2023 21:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023