coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: src/soc/intel/common/block/pcie/rtd3: Fix root port _STA logic
by Eric Lai (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Cliff Huang, Tarun Tuli, Subrata Banik, Jérémy Compostella, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72421 ) Change subject: src/soc/intel/common/block/pcie/rtd3: Fix root port _STA logic ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6f1e7a5b3e9fd0ea00e1e5b54058a14c6e9e09e Gerrit-Change-Number: 72421 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cordelia Huang <cordelia1396(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:46:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add ACPI configuration for USB2/3 ports
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Sridhar Siricilla, Eric Lai, Usha P. Hello build bot (Jenkins), Sridhar Siricilla, Eric Lai, Usha P, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72787 to look at the new patch set (#3). Change subject: mb/intel/mtlrvp: Add ACPI configuration for USB2/3 ports ...................................................................... mb/intel/mtlrvp: Add ACPI configuration for USB2/3 ports This patch adds ACPI configuration for USB2/3 ports for mtlrvp as per schematics. This helps in generating corresponding ACPI code at runtime that includes port information. BUG=b:224325352 BRANCH=None TEST=Able to build and boot MTLRVP. Connect USB device and check if corresponding enumeration of USB device (14.0) is observed on executing lspci. 00:14.0 USB controller: Intel Corporation Device 7e7d (rev 01) 00:14.1 USB controller: Intel Corporation Device 7e7e (rev 01) Signed-off-by: Harsha B R <harsha.b.r(a)intel.com> Change-Id: Ie150247661322e3944be15dc70f66033266d8aac Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb 2 files changed, 102 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/72787/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie150247661322e3944be15dc70f66033266d8aac Gerrit-Change-Number: 72787 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add ACPI configuration for USB2/3 ports
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72787 ) Change subject: mb/intel/mtlrvp: Add ACPI configuration for USB2/3 ports ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie150247661322e3944be15dc70f66033266d8aac Gerrit-Change-Number: 72787 Gerrit-PatchSet: 2 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:26:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Describe mainboard configuration for BB Retimer
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72786 ) Change subject: mb/intel/mtlrvp: Describe mainboard configuration for BB Retimer ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1a0026b064aa4f7fcd27e75c0b0d052ec620dcc Gerrit-Change-Number: 72786 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Describe TCSS USB ports
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72785 ) Change subject: mb/intel/mtlrvp: Describe TCSS USB ports ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0054ac4e3d1d9b97cfea615831ec8f3d3e00c9e0 Gerrit-Change-Number: 72785 Gerrit-PatchSet: 2 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:26:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/mtlrvp: Enable WWAN ACPI
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72779 ) Change subject: mb/intel/mtlrvp: Enable WWAN ACPI ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72779 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I870cc0782fb989f1bdbe369a4a12630a62729d8e Gerrit-Change-Number: 72779 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/mtlrvp: Enable PCIe port 8 for WLAN
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72778 ) Change subject: mb/intel/mtlrvp: Enable PCIe port 8 for WLAN ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief3c0eff40ced57d29ce343e569b6b392c27ad74 Gerrit-Change-Number: 72778 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:26:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/mtlrvp: Enable PCIe port 7 for WWAN
by Harsha B R (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72777 ) Change subject: mb/intel/mtlrvp: Enable PCIe port 7 for WWAN ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib372db9642a3c7b3a21a112fa0e6e0b4bc88a9ea Gerrit-Change-Number: 72777 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:26:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Enable ACPI support for Type-C ports
by Usha P (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jamie Ryu, Harsha B R, Sridhar Siricilla. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72789 ) Change subject: mb/intel/mtlrvp: Enable ACPI support for Type-C ports ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e5957ca7a6c542a64d79b2ceefbed79ead15811 Gerrit-Change-Number: 72789 Gerrit-PatchSet: 3 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:22:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VM18
by Rex-BC Chen (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 ) Change subject: soc/mediatek: Add support for regulator VM18 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: src/mainboard/google/corsola/regulator.c:27:1: error: static assertion failed: "regulator_id size error" 27 | _Static_assert(ARRAY_SIZE(regulator_id) == MTK_REGULATOR_NUM, "regulator_id size error"); | ^~~~~~~~~~~~~~ cc1: note: unrecognized command-line option '-Wno-array-compare' may have been intended to silence earlier diagnostics make[2]: *** [Makefile:399: /cb-build/coreboot-gerrit.0/gcc-chromeos/GOOGLE_KINGLER/romstage/mainboard/google/corsola/regulator.o] Error 1 make[2]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit' -- To view, visit https://review.coreboot.org/c/coreboot/+/72747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Gerrit-Change-Number: 72747 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 03:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023