coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: mb/google/geralt: Init MT6359P only once in ramstage
by Rex-BC Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Paul Menzel, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72839 ) Change subject: mb/google/geralt: Init MT6359P only once in ramstage ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72839/comment/5a78d0be_1b38d1b9 PS1, Line 12: > mt6359p_init() will call pmic_efuse_setting(), so pmic_efuse_setting() are called twice. […] add this to commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/72839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29498d186ba5665ae20e84985174fc10f8d4accd Gerrit-Change-Number: 72839 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:43:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/picasso/soc_util: use cpuid_match
by Felix Held (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Eric Lai, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72860 ) Change subject: soc/amd/picasso/soc_util: use cpuid_match ...................................................................... Patch Set 4: (1 comment) File src/soc/amd/picasso/soc_util.c: https://review.coreboot.org/c/coreboot/+/72860/comment/00745f69_8ebd4e6c PS4, Line 97: 0xffffff00 > create another mask for this? that would be good, but i didn't find a good name for this mask. CPUID_ALL_STEPPINGS_ALL_BASE_MODELS_MASK maybe? -- To view, visit https://review.coreboot.org/c/coreboot/+/72860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 Gerrit-Change-Number: 72860 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/mtlrvp: Enable WWAN ACPI
by Sridhar Siricilla (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Jamie Ryu, Harsha B R, Usha P. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72779 ) Change subject: mb/intel/mtlrvp: Enable WWAN ACPI ...................................................................... Patch Set 7: (1 comment) File src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb: https://review.coreboot.org/c/coreboot/+/72779/comment/86d154be_b47362d2 PS7, Line 102: PCIE_RP_LTR what about PCI error reporting? -- To view, visit https://review.coreboot.org/c/coreboot/+/72779 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I870cc0782fb989f1bdbe369a4a12630a62729d8e Gerrit-Change-Number: 72779 Gerrit-PatchSet: 7 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VM18
by Rex-BC Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Paul Menzel, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 ) Change subject: soc/mediatek: Add support for regulator VM18 ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Gerrit-Change-Number: 72747 Gerrit-PatchSet: 4 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Init MT6359P only once in ramstage
by Liju-Clr Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72839 ) Change subject: mb/google/geralt: Init MT6359P only once in ramstage ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72839/comment/fc436278_c34a4212 PS1, Line 7: Calling > (Please use imperative mood: Call instead of Calling) […] Done https://review.coreboot.org/c/coreboot/+/72839/comment/86a4b487_8fbe78e3 PS1, Line 10: add > move mt6359p_init() to mainboard. […] Done https://review.coreboot.org/c/coreboot/+/72839/comment/6d37db5e_a31b94bd PS1, Line 10: mt6359 > mt6359p? Done https://review.coreboot.org/c/coreboot/+/72839/comment/e96c6474_aa32b9ac PS1, Line 12: > What user visible problem does multiple initialization cause? mt6359p_init() will call pmic_efuse_setting(), so pmic_efuse_setting() are called twice. 11 msecs will be increased on booting time. File src/soc/mediatek/mt8188/msdc.c: https://review.coreboot.org/c/coreboot/+/72839/comment/d9dc2190_77234cac PS1, Line 13: #include <soc/mt6359p.h> > remove Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29498d186ba5665ae20e84985174fc10f8d4accd Gerrit-Change-Number: 72839 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Remove unnecessary !! for boolean variable
by Rex-BC Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72869 ) Change subject: soc/mediatek: Remove unnecessary !! for boolean variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a7cec632f21a258b8364c82e25b59e55ab7453 Gerrit-Change-Number: 72869 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/corsola: Use function to get regulator IDs
by Rex-BC Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72838 ) Change subject: mb/google/corsola: Use function to get regulator IDs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d28ebf2affe4e9464b1a7c1fb2bbb9e31d64a5e Gerrit-Change-Number: 72838 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:40:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VM18
by Liju-Clr Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 ) Change subject: soc/mediatek: Add support for regulator VM18 ...................................................................... Patch Set 4: (1 comment) File src/soc/mediatek/common/mt6359p.c: https://review.coreboot.org/c/coreboot/+/72747/comment/d86c4621_c641c1bf PS3, Line 329: !!enable > Enable is already a boolean, so the !! is not needed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Gerrit-Change-Number: 72747 Gerrit-PatchSet: 4 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:31:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/corsola: Use function to get regulator IDs
by Liju-Clr Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72838 ) Change subject: mb/google/corsola: Use function to get regulator IDs ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72838/comment/3d2f5368_2799b215 PS1, Line 7: Use get_mt6366_regulator_id() instead of regulator_id[] > Use fcuntion to get regulator IDs Done https://review.coreboot.org/c/coreboot/+/72838/comment/433d778f_672fb1e8 PS1, Line 10: . > when we need to add new regulator IDs for Geralt. Done https://review.coreboot.org/c/coreboot/+/72838/comment/3ba607b7_f3b06b68 PS1, Line 10: use get_mt6366_regulator_id() to : replace regulator_id[]. > we implement get_mt6366_regulator_id() to get regulator IDs. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d28ebf2affe4e9464b1a7c1fb2bbb9e31d64a5e Gerrit-Change-Number: 72838 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 08:30:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Remove unnecessary !! for boolean variable
by Liju-Clr Chen (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Hung-Te Lin. Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72869 ) Change subject: soc/mediatek: Remove unnecessary !! for boolean variable ...................................................................... soc/mediatek: Remove unnecessary !! for boolean variable Enable is already a boolean, so the !! is not needed. BUG=None TEST=build pass. Change-Id: I25a7cec632f21a258b8364c82e25b59e55ab7453 Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M src/soc/mediatek/common/mt6359p.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/72869/1 diff --git a/src/soc/mediatek/common/mt6359p.c b/src/soc/mediatek/common/mt6359p.c index de22b3e..e2c8e14 100644 --- a/src/soc/mediatek/common/mt6359p.c +++ b/src/soc/mediatek/common/mt6359p.c @@ -316,12 +316,12 @@ void mt6359p_enable_vpa(bool enable) { - mt6359p_write_field(PMIC_VPA_CON0, !!enable, 0x1, 0); + mt6359p_write_field(PMIC_VPA_CON0, enable, 0x1, 0); } void mt6359p_enable_vsim1(bool enable) { - mt6359p_write_field(PMIC_VSIM1_CON0, !!enable, 0x1, 0); + mt6359p_write_field(PMIC_VSIM1_CON0, enable, 0x1, 0); } static void init_pmif_arb(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/72869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a7cec632f21a258b8364c82e25b59e55ab7453 Gerrit-Change-Number: 72869 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023