coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: src: Add and use POST_BOOTBLOCK_C_ENTRY
by Elyes Haouas (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Raul Rangel, Jeff Daly, Matt DeVillier, Jonathan Zhang, Arthur Heymans, Jason Glenesk, Sean Rhodes, Tarun Tuli, Martin L Roth, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Fred Reitberger, Felix Held, Tim Chu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71593 ) Change subject: src: Add and use POST_BOOTBLOCK_C_ENTRY ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I'd let <console/console.h> chain-include <commonlib/console/post_codes.h>. Please let me know your thoughts. File src/soc/intel/skylake/bootblock/bootblock.c: https://review.coreboot.org/c/coreboot/+/71593/comment/4cdea502_ae1500b9 PS2, Line 4: <commonlib/console/post_codes.h> <console/console.h> is needed for post_code() function -- To view, visit https://review.coreboot.org/c/coreboot/+/71593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45a86ece016e098ca42a31207fdedda5c49708d7 Gerrit-Change-Number: 71593 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/{common, meteorlake}: Add support for new MCH
by Sridhar Siricilla (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72835 to look at the new patch set (#2). Change subject: soc/intel/{common, meteorlake}: Add support for new MCH ...................................................................... soc/intel/{common, meteorlake}: Add support for new MCH The patch adds support for new Meteor Lake MCH (ID:0x7d16). TEST=Build and boot the system having MCH ID:0x7d16. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ib0c9ce5c58e4bdec5e7245840f0892d651922cd9 --- M src/include/device/pci_ids.h M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/meteorlake/bootblock/report_platform.c 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/72835/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0c9ce5c58e4bdec5e7245840f0892d651922cd9 Gerrit-Change-Number: 72835 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/brya: Add usb_lpm_incapable for Type-C port with PS8815
by Kapil Porwal (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Tarun Tuli, Ron Lee, Nick Vaccaro. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71925 ) Change subject: mb/google/brya: Add usb_lpm_incapable for Type-C port with PS8815 ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9246ff7908887404f49ec10ee781c8cba410557 Gerrit-Change-Number: 71925 Gerrit-PatchSet: 8 Gerrit-Owner: Ron Lee <ron.lee(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ron Lee <ron.lee(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in qc_blobs[master]: sc7280/boot,shrm: Update qclib blobs binaries from 35 to 43
by Sudheer Amrabadi (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Shelley Chen, Julius Werner. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/70743 ) Change subject: sc7280/boot,shrm: Update qclib blobs binaries from 35 to 43 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/qc_blobs/+/70743/comment/ada255ec_297b31e6 PS1, Line 7: shrm > Updated related commit message, can you please review Ack -- To view, visit https://review.coreboot.org/c/qc_blobs/+/70743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: Ibac733ad6aae2e9bb1198a283257b1e40e13488e Gerrit-Change-Number: 70743 Gerrit-PatchSet: 2 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: comment

1 0

[M] Change in qc_blobs[master]: sc7280/boot,shrm: Update qclib blobs binaries from 35 to 43
by Sudheer Amrabadi (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Shelley Chen, Julius Werner. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/70743 ) Change subject: sc7280/boot,shrm: Update qclib blobs binaries from 35 to 43 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/qc_blobs/+/70743/comment/55088975_cfa5f2f1 PS1, Line 7: shrm > maybe something like "sc7280/boot,shrm:" would make it more clear? Updated related commit message, can you please review -- To view, visit https://review.coreboot.org/c/qc_blobs/+/70743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: Ibac733ad6aae2e9bb1198a283257b1e40e13488e Gerrit-Change-Number: 70743 Gerrit-PatchSet: 2 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:31:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel: Use common codeflow for MP init
by Arthur Heymans (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Johnny Lin, Dinesh Gehlot, David Hendricks, Kapil Porwal, Christian Walter, Werner Zeh, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72604 ) Change subject: soc/intel: Use common codeflow for MP init ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > CPU frequency seems to be dropping with the changes. On ToT bin it was ~1200MHz but it drops to ~400MHz for few cases with changes for rex. > > Steps to reproduce: > 1. Check CPU information from AP console. > 2. Compare all occurrence of key word "CPU MHz" > ``` > localhost ~ cat /proc/cpuinfo > ``` > That's really strange as the bootflow is pretty much identical. No new code is run. Are you sure CPU freq change is not to be expected? You can see what power states are expected with powertop. cpuinfo just shows the current cpu freq which depends on the load. -- To view, visit https://review.coreboot.org/c/coreboot/+/72604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822468a6f15565b97e57612a294a0b80b45b932 Gerrit-Change-Number: 72604 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/picasso/soc_util: use cpuid_match
by Felix Held (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Eric Lai, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72860 ) Change subject: soc/amd/picasso/soc_util: use cpuid_match ...................................................................... Patch Set 5: (1 comment) File src/soc/amd/picasso/soc_util.c: https://review.coreboot.org/c/coreboot/+/72860/comment/0cd599b5_2741cc9d PS4, Line 97: 0xffffff00 > CPUID_ALL_STEPPINGS_AND_BASE_MODELS_MASK? Don't know how to shorter this. sounds good to me and i also can't think of a shorter name that still makes it clear enough what it;s doing. update the patch -- To view, visit https://review.coreboot.org/c/coreboot/+/72860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 Gerrit-Change-Number: 72860 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Remove unused S0IX variable
by Lean Sheng Tan (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Sean Rhodes, Tarun Tuli. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72797 ) Change subject: soc/intel/alderlake: Remove unused S0IX variable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85fc5dabf10c6df7f11fd1defe8a39afc9f95325 Gerrit-Change-Number: 72797 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/picasso/soc_util: use cpuid_match
by Felix Held (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Matt DeVillier, Fred Reitberger, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72860 to look at the new patch set (#5). Change subject: soc/amd/picasso/soc_util: use cpuid_match ...................................................................... soc/amd/picasso/soc_util: use cpuid_match Now that there is a cpuid_match function, we can use it instead of doing basically the same thing manually. In the functions is_fam17_1x and is_fam17_2x both the stepping number and the lower nibble of the model number are masked out. To avoid having magic constants in the code, introduce the CPUID_ALL_STEPPINGS_AND_BASE_MODELS_MASK definition. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 --- M src/arch/x86/include/arch/cpu.h M src/soc/amd/picasso/soc_util.c 2 files changed, 26 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/72860/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/72860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 Gerrit-Change-Number: 72860 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/rtd3: Hook up supported states to Kconfig
by Sean Rhodes (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Matt DeVillier, Angel Pons, Eric Lai. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72765 ) Change subject: soc/intel/rtd3: Hook up supported states to Kconfig ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72765/comment/7353c843_f4c2467d PS1, Line 9: S3 does not support D3Cold, > Adjusted so it's configurable, but defaults as there are 3 boards in the tree that need it. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e Gerrit-Change-Number: 72765 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023