Attention is currently required from: TimLiu-SMCI, Jonathan Zhang, Ryback Hung, David Hendricks, Paul Menzel, Angel Pons, Tim Chu.
Simon Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 )
Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/71953/comment/c875be46_8eccdd40
PS6, Line 467: pci_write_config32(dev, SPI_BIOS_DECODE_EN, bde);
> Sorry, looking back at this I think what Paul meant is: […]
Update it according to the review comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285
Gerrit-Change-Number: 71953
Gerrit-PatchSet: 9
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Tue, 07 Feb 2023 10:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Chou <simonchou(a)supermicro.com.tw>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72835 )
Change subject: soc/intel/{common, meteorlake}: Add support for new MCH
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/72835/comment/33654ec4_ca7665cd
PS1, Line 184: case PCI_DID_INTEL_MTL_P_ID_5:
: soc_config = &config->power_limits_config[MTL_P_POWER_LIMITS_5];
> this is dead code at this moment as we are not overriding anything per SKU. […]
Right, I will remove the code now, and can be added later if the SKU has specific power limits.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72835
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c9ce5c58e4bdec5e7245840f0892d651922cd9
Gerrit-Change-Number: 72835
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Tue, 07 Feb 2023 09:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72871 )
Change subject: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure
......................................................................
soc/intel/meteorlake: Update soc_intel_meteorlake_config structure
The patch removes hybrid_storage_mode variable from
soc_intel_meteorlake_config struct since hybrid storage is no longer
supported on Meteor Lake platform.
TEST=Verify the build for Rex board
Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5
---
M src/soc/intel/meteorlake/chip.h
1 file changed, 16 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/72871/1
diff --git a/src/soc/intel/meteorlake/chip.h b/src/soc/intel/meteorlake/chip.h
index 4e95321..1b9d192 100644
--- a/src/soc/intel/meteorlake/chip.h
+++ b/src/soc/intel/meteorlake/chip.h
@@ -300,11 +300,6 @@
/* Enable(1)/Disable(0) HPD/DDC */
uint8_t ddi_ports_config[DDI_PORT_COUNT];
- /* Hybrid storage mode enable (1) / disable (0)
- * This mode makes FSP detect Optane and NVME and set PCIe lane mode
- * accordingly */
- uint8_t hybrid_storage_mode;
-
/*
* Override CPU flex ratio value:
* CPU ratio value controls the maximum processor non-turbo ratio.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5
Gerrit-Change-Number: 72871
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: newchange
Jan Samek has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72804 )
Change subject: mb/siemens/mc_ehl3/lcd_panel.c: Set LVDS re-power delay to 1 s
......................................................................
mb/siemens/mc_ehl3/lcd_panel.c: Set LVDS re-power delay to 1 s
The currently used panel type could work with 500 ms but increasing
the value to 1 second allows to use a wider range of LVDS LCD panels,
as many of them specify the delay of 1 s as minimum.
BUG=none
TEST=Test link stability using a panel with minimum re-power delay of
1 s.
Change-Id: I2dd86e791c1212b67a80d7e6cfc474ad91b26c6b
Signed-off-by: Jan Samek <jan.samek(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c
1 file changed, 20 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/72804/1
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c
index 7b16254..c57d598 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c
@@ -82,8 +82,8 @@
cfg->t2_delay = 0x01;
/* LVDS to backlight active delay: 200 ms */
cfg->t3_timing = 0x04;
- /* Minimum re-power delay: 500 ms */
- cfg->t12_timing = 0x0a;
+ /* Minimum re-power delay: 1 s */
+ cfg->t12_timing = 0x14;
/* Backlight off to LVDS inactive delay: 200 ms */
cfg->t4_timing = 0x04;
/* Enable LVDS to VDD inactive delay. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/72804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dd86e791c1212b67a80d7e6cfc474ad91b26c6b
Gerrit-Change-Number: 72804
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-MessageType: newchange