coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3036 discussions

[XL] Change in coreboot[main]: payloads: Add uefistub payload
by Simon Glass (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Benjamin Doron, Martin L Roth, Maximilian Brune, Patrick Rudolph. Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78913?usp=email ) Change subject: payloads: Add uefistub payload ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I struggle to understand the goal here. We already have U-Boot as a payload which can boot into Linuxboot and provide an EFI interface. Why do we need to pull pieces out of U-Boot to achieve this? It doesn't seem a very friendly approach to me...particularly as the files do not seem to reference U-Bot as the source. But even if they do, this seems like a fork to me. A huge amount of work went into making U-Boot support this feature. Much ongoing work is happening to improve it - the code base is under active development. I believe it would make more sense for coreboot to embrace U-Boot as a first-class coreboot payload, rather than always trying to use something else. I have been trying hard to get U-Boot to work better as a coreboot payload. U-Boot's CI now boots coreboot to check it works on every PR. I would really like to see some reciprocal efforts, rather than this sort of thing. Please? -- To view, visit https://review.coreboot.org/c/coreboot/+/78913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4093378e89c3cb43fb0846666de80a7da36b03f1 Gerrit-Change-Number: 78913 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 21:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: payloads: Add uefistub payload
by David Milosevic (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Benjamin Doron, Martin L Roth, Maximilian Brune, Patrick Rudolph. David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78913?usp=email ) Change subject: payloads: Add uefistub payload ...................................................................... Patch Set 4: (1 comment) File payloads/uefistub/src/arch/arm64/uefistub.ld: https://review.coreboot.org/c/coreboot/+/78913/comment/c326152a_720ad41c : PS4, Line 90: #ifdef CONFIG_EFI_FDT Use ```#if CONFIG_EFI_FDT == 1``` instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/78913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4093378e89c3cb43fb0846666de80a7da36b03f1 Gerrit-Change-Number: 78913 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 20:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Add PPTT support
by David Milosevic (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, Lance Zhao, Martin L Roth, Maximilian Brune, Nico Huber, Patrick Rudolph, Tim Wawrzynczak. David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78071?usp=email ) Change subject: acpi: Add PPTT support ...................................................................... Patch Set 22: (1 comment) File src/acpi/acpi_pptt.c: https://review.coreboot.org/c/coreboot/+/78071/comment/84e66e64_6aef9eac : PS17, Line 131: cache_reference_t cache_refs[CONFIG_ACPI_PPTT_MAX_CACHES]; > > Well, QEMU-SBSA is a rather simple example, with a homogenuous hierarchy […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia119e1ba15756704668116bdbc655190ec94ff10 Gerrit-Change-Number: 78071 Gerrit-PatchSet: 22 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 30 Nov 2023 20:30:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC
by Felix Held (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Cliff Huang, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79219?usp=email ) Change subject: [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC ...................................................................... Patch Set 1: (2 comments) File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/79219/comment/c6745a46_01c45c37 : PS1, Line 869: ACPI_DBG2_PORT_SERIAL_16550 > Maybe rename this one to `ACPI_DBG2_PORT_SERIAL_16550_IO_ONLY` Done https://review.coreboot.org/c/coreboot/+/79219/comment/06e8d057_b9ef70c2 : PS1, Line 875: ACPI_DBG2_PORT_SERIAL_16550_GENERIC > I like this idea i like that idea too -- To view, visit https://review.coreboot.org/c/coreboot/+/79219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5 Gerrit-Change-Number: 79219 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 20:22:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC
by Felix Held (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak. Hello Cliff Huang, Lance Zhao, Matt DeVillier, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79219?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC ...................................................................... [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC The Microsoft Debug Port Table 2 (DBG2) specification says that the serial port subtype 0x00 should only be used for I/O-mapped 16550 compatible UARTs. The subtype 0x12 is a superset of that, and supports specifying MMIO vs IO and the register access size via the generic address structure. Rename the subtype 0x00 definition to ACPI_DBG2_PORT_SERIAL_16550_IO_ONLY and add the subtype 0x12 definition as new ACPI_DBG2_PORT_SERIAL_16550, so that the acpi_write_dbg2_uart function will write the correct subtype for the generic 16550 UART. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5 --- M src/include/acpi/acpi.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/79219/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5 Gerrit-Change-Number: 79219 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: inteltool/gpio_names/icelake.h: Add SPDX license header
by Felix Singer (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Martin L Roth, Nicholas Chin, Stefan Reinauer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78628?usp=email ) Change subject: inteltool/gpio_names/icelake.h: Add SPDX license header ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Any reason not to combine all of the inteltool gpio_names SPDX header licenses into a single commit? +1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 20:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/variants/deku: Add basic DTT
by Eran Mitrani (Code Review) 30 Nov '23

30 Nov '23

Eran Mitrani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79353?usp=email ) Change subject: mb/google/rex/variants/deku: Add basic DTT ...................................................................... mb/google/rex/variants/deku: Add basic DTT Add default Intel DPTF. BUG=b:305793886 TEST=util/abuild/abuild -p none -t google/rex -x -a -b deku Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: Id681754fc8e7b418de35f66df097cadd4aad7448 --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/79353/1 diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 2cba613..8602b59 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -55,6 +55,11 @@ }" device domain 0 on + device ref dtt on + chip drivers/intel/dptf + device generic 0 alias dptf_policy on end + end + end device ref pcie_rp7 on # Enable LAN1 Card PCIE 7 using clk 2 register "pcie_rp[PCH_RP(7)]" = "{ -- To view, visit https://review.coreboot.org/c/coreboot/+/79353?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id681754fc8e7b418de35f66df097cadd4aad7448 Gerrit-Change-Number: 79353 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: Kconfig: Move rustccfg file to a more benign place
by Patrick Georgi (Code Review) 30 Nov '23

30 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79342?usp=email ) Change subject: Kconfig: Move rustccfg file to a more benign place ...................................................................... Kconfig: Move rustccfg file to a more benign place It's put in $(obj) now. Not sure if we'll need it, but there has been some interest in rust support in coreboot, and removing support for it would be more work than this, so let's just keep it around. Change-Id: I532fde9625dbf7463752ef1af525b77d12676c93 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79342 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Felix Held: Looks good to me, approved diff --git a/Makefile b/Makefile index d41dd4f..b521f04 100644 --- a/Makefile +++ b/Makefile @@ -23,6 +23,7 @@ DOTCONFIG ?= $(top)/.config KCONFIG_CONFIG = $(DOTCONFIG) KCONFIG_AUTOADS := $(obj)/cb-config.ads +KCONFIG_RUSTCCFG := $(obj)/cb-config.rustcfg KCONFIG_AUTOHEADER := $(obj)/config.h KCONFIG_AUTOCONFIG := $(obj)/auto.conf KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd @@ -42,6 +43,7 @@ endif COREBOOT_EXPORTS += KCONFIG_WARN_UNKNOWN_SYMBOLS COREBOOT_EXPORTS += KCONFIG_AUTOADS KCONFIG_PACKAGE +COREBOOT_EXPORTS += KCONFIG_RUSTCCFG # Make does not offer a recursive wildcard function, so here's one: rwildcard=$(wildcard $1$2) $(foreach d,$(wildcard $1*),$(call rwildcard,$d/,$2)) -- To view, visit https://review.coreboot.org/c/coreboot/+/79342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I532fde9625dbf7463752ef1af525b77d12676c93 Gerrit-Change-Number: 79342 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: build system: Exempt `make *config` from strict symbol checks
by Patrick Georgi (Code Review) 30 Nov '23

30 Nov '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79298?usp=email ) Change subject: build system: Exempt `make *config` from strict symbol checks ...................................................................... build system: Exempt `make *config` from strict symbol checks The "config" targets exist to edit the .config file, and so they should be more forgiving with invalid configs (that they'll convert into valid configs on save). They will still emit warnings about invalid symbols, but not exit with an error. The regular build process still fails if the .config looks unexpected (for example when there's an unknown config flag). Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79298 Reviewed-by: Mike Banon <mikebdp2(a)gmail.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M Makefile M util/kconfig/Makefile.inc 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Martin L Roth: Looks good to me, approved Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Mike Banon: Looks good to me, but someone else must approve diff --git a/Makefile b/Makefile index 5ed6933..d41dd4f 100644 --- a/Makefile +++ b/Makefile @@ -29,14 +29,17 @@ KCONFIG_SPLITCONFIG := $(obj)/config/ KCONFIG_TRISTATE := $(obj)/tristate.conf KCONFIG_NEGATIVES := 1 -KCONFIG_WERROR:= 1 -KCONFIG_WARN_UNKNOWN_SYMBOLS:= 1 +KCONFIG_WERROR := 1 +KCONFIG_WARN_UNKNOWN_SYMBOLS := 1 KCONFIG_PACKAGE := CB.Config KCONFIG_MAKEFILE_REAL ?= $(objk)/Makefile.real COREBOOT_EXPORTS += KCONFIG_CONFIG KCONFIG_AUTOHEADER KCONFIG_AUTOCONFIG COREBOOT_EXPORTS += KCONFIG_DEPENDENCIES KCONFIG_SPLITCONFIG KCONFIG_TRISTATE -COREBOOT_EXPORTS += KCONFIG_NEGATIVES KCONFIG_WERROR +COREBOOT_EXPORTS += KCONFIG_NEGATIVES +ifeq ($(filter %config,$(MAKECMDGOALS)),) +COREBOOT_EXPORTS += KCONFIG_WERROR +endif COREBOOT_EXPORTS += KCONFIG_WARN_UNKNOWN_SYMBOLS COREBOOT_EXPORTS += KCONFIG_AUTOADS KCONFIG_PACKAGE diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc index 3a9f353..83fad88 100644 --- a/util/kconfig/Makefile.inc +++ b/util/kconfig/Makefile.inc @@ -47,8 +47,6 @@ # Fill in Linux kconfig build rules to work -oldconfig: KCONFIG_STRICT= - savedefconfig: $(objk)/conf cp $(DOTCONFIG) $(DEFCONFIG) chmod +w $(DEFCONFIG) -- To view, visit https://review.coreboot.org/c/coreboot/+/79298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Gerrit-Change-Number: 79298 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: uwe taz <uwepoeche(a)arcor.de> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[main]: superio/smsc: Add support for the SCH555x series
by Martin L Roth (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Máté Kukri. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64359?usp=email ) Change subject: superio/smsc: Add support for the SCH555x series ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS2: > I've looked at this again, and based on the complexity of the sch5545 code, I think this would take […] It's fine. This is probably no worse off than any of our other superio code. We really need a maintainer for the whole area. -- To view, visit https://review.coreboot.org/c/coreboot/+/64359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4 Gerrit-Change-Number: 64359 Gerrit-PatchSet: 4 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 16:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
304
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023