coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[main]: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
by Mike Banon (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Balázs Vinarz, HacX Scedix, Kyösti Mälkki, Martin L Roth, Paul Menzel, Vlado Ilic, awokd(a)danwin1210.me. Hello Balázs Vinarz, HacX Scedix, Martin L Roth, Paul Menzel, Vlado Ilic, awokd(a)danwin1210.me, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76832?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards ...................................................................... util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards restore_agesa.sh reverts the opensource AGESA AMD boards removal that happened after 5e8e911b7caee021faff96c4e82a77a42544ea62 (0 point of history, or 0 PoH) - by git-reverting: 1) the "bad commits" (marked as "CBF" = coreboot build failure) - that either remove or break a code needed for our boards 2) the "unlucky commits" (marked as "GRF" = git revert failure) - that are a roadblock for git-reverting the "bad commits" Right now at 16875ec8e304e87922af2f26a3fbd825bccb312e (5173 PoH), it takes 40 CBF git reverts - just 1% of 5173 commits since the OSS AGESA removal! - - making this removal look questionable and the idea of restoration viable. SUCCESSFUL TESTS for the opensource AGESA boards which I own (Lenovo G505S - - fam15 laptop, ASUS A88XM-E - fam15 desktop, ASUS AM1I-A - fam16 desktop): 1) only build: 69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for AM1I-A, most likely boot works too but I didn't have the time to test 2) build & boot: 786292a0fca78405d56afb3f97a88f17f1c4bd32 (5166 PoH) for G505S test only, 11ba8ebbcc662ebd1dc8e14372a020eb32f26561 (3741 PoH) for G505S test only, 69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for G505S and A88XM-E Change-Id: Ib4658dcaf4ff6fbac36070529284f2c982ed73c3 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- A util/scripts/restore_agesa.sh 1 file changed, 232 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/76832/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/76832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4658dcaf4ff6fbac36070529284f2c982ed73c3 Gerrit-Change-Number: 76832 Gerrit-PatchSet: 9 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Reviewer: HacX Scedix <oblongs.figure-0z(a)icloud.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Vlado Ilic <kakonema(a)gmail.com> Gerrit-Reviewer: awokd(a)danwin1210.me Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: HacX Scedix <oblongs.figure-0z(a)icloud.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: awokd(a)danwin1210.me Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Felix Held (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Arthur Heymans, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) Change subject: vendorcode/amd: Hook up opensil ...................................................................... Patch Set 15: (2 comments) File src/vendorcode/amd/opensil/Kconfig: https://review.coreboot.org/c/coreboot/+/76511/comment/045dfa9e_100f6365 : PS14, Line 8: sil > Nit: capitalize - openSIL oh, missed that one File src/vendorcode/amd/opensil/genoa_poc/meson_cross.template: https://review.coreboot.org/c/coreboot/+/76511/comment/59bedd7b_3d86636b : PS14, Line 17: # openSIL isn't compatible with coreboot's assert implementation, so use special case : '-D_PORTING_H_=1', : '-DSIL_DEBUG_ENABLE=##SIL_DEBUG_ENABLE##', : # openSIL uses coreboot assert which uses printk which warns about unused-param > These two comments seem to contradict each other. not really. the first one is probably just not worded too well. see Arthur's comment from November 22 about the _PORTING_H_ thing -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 27 Nov 2023 19:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Fred Reitberger (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) Change subject: vendorcode/amd: Hook up opensil ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 17:44:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Matt DeVillier (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) Change subject: vendorcode/amd: Hook up opensil ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 17:44:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Revert "nipperkin: Fix WLAN to GEN2 speed" & "Disable PSPP for WLAN"
by Tim Van Patten (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Bao Zheng, Felix Held, Jason Nien, Martin Roth, Zheng Bao. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79172?usp=email ) Change subject: Revert "nipperkin: Fix WLAN to GEN2 speed" & "Disable PSPP for WLAN" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79172/comment/50135eb3_b986cd00 : PS2, Line 22: What testing has been done for this? The original bug that landed these changes was: b/228830362: Nipperkin: Hang during S0i3 resume due to WLAN PSPP. The CLs that this is reverting did: 1. `TEST=Suspend stress test passes on Nipperkin` 2. `TEST=suspend_stress_test on AC and DC` I think this should do the same before landing. -- To view, visit https://review.coreboot.org/c/coreboot/+/79172?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id207076542edc8ea0cabc6e02e29856c2b6803c7 Gerrit-Change-Number: 79172 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 17:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/cezanne: Move PSP_VERSTAGE_MAP_ENTIRE_SPIROM config
by Tim Van Patten (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Matt DeVillier. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79306?usp=email ) Change subject: soc/amd/cezanne: Move PSP_VERSTAGE_MAP_ENTIRE_SPIROM config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79306?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I476971700824fed06d17000001afc075105fa1ee Gerrit-Change-Number: 79306 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 17:19:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Martin L Roth (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) Change subject: vendorcode/amd: Hook up opensil ...................................................................... Patch Set 15: Code-Review+2 (3 comments) Patchset: PS15: I noted a couple of minor issues - let's fix these in a follow-on commit. Marking everyone else's changes as +2 - Do not merge until there's another +2 for my changes please. File src/vendorcode/amd/opensil/Kconfig: https://review.coreboot.org/c/coreboot/+/76511/comment/3a74d483_b65caa79 : PS14, Line 8: sil Nit: capitalize - openSIL File src/vendorcode/amd/opensil/genoa_poc/meson_cross.template: https://review.coreboot.org/c/coreboot/+/76511/comment/5f6643a6_c68bad76 : PS14, Line 17: # openSIL isn't compatible with coreboot's assert implementation, so use special case : '-D_PORTING_H_=1', : '-DSIL_DEBUG_ENABLE=##SIL_DEBUG_ENABLE##', : # openSIL uses coreboot assert which uses printk which warns about unused-param These two comments seem to contradict each other. -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 16:50:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/mendocino: Add DBG2 ACPI table
by Raul Rangel (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Bao Zheng, Cliff Huang, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Simon Glass, Tim Wawrzynczak, Zheng Bao. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79174?usp=email ) Change subject: soc/amd/mendocino: Add DBG2 ACPI table ...................................................................... Patch Set 6: (1 comment) File src/soc/amd/mendocino/agesa_acpi.c: https://review.coreboot.org/c/coreboot/+/79174/comment/2e828138_e4b9a541 : PS6, Line 33: current = acpi_16550_write_dbg2_uart(rsdp, current, : uart_platform_base(get_uart_for_console()), NULL); Can we do this in soc/common instead? All AMD boards should have this generated. -- To view, visit https://review.coreboot.org/c/coreboot/+/79174?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c97a78d1889549421baf0bc1a2e8f959a0f47e2 Gerrit-Change-Number: 79174 Gerrit-PatchSet: 6 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Mon, 27 Nov 2023 16:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution
by Jay Patel (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Bernardo Perez Priego, Brandon Breitenstein, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik, Tanu Malhotra, Vijay P Hiremath. Hello Bernardo Perez Priego, Brandon Breitenstein, Pratikkumar V Prajapati, Subrata Banik, Tanu Malhotra, Vijay P Hiremath, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78282?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Vijay P Hiremath, Verified+1 by build bot (Jenkins) Change subject: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution ...................................................................... mb/intel/mtlrvp: Add new MTL-P board variant for PD solution This patch adds new board variant to enable PD chip based type-C solution for MTL-RVP. Reshuffles Type-C related devicetree code since the mtlrvp_pd variant supports 2 type-C ports while the other variants support 4. BUG=b:303839908 BRANCH=none TEST=check if you can observe MTLRVP PD solution option as part of make menuconfig. Able to boot to ChromeOS with PD solution. Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Signed-off-by: Jay Patel <jay2.patel(a)intel.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb A src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb 6 files changed, 76 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/78282/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/78282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Gerrit-Change-Number: 78282 Gerrit-PatchSet: 5 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Varshit Pandya (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth, Martin Roth. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) Change subject: vendorcode/amd: Hook up opensil ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 16:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023