coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: Add support for rust
by Martin L Roth (Code Review) 04 Nov '23

04 Nov '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74124?usp=email ) Change subject: Add support for rust ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/74124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibff3ca83b3dfebcc18006cddf0f649bcfb076500 Gerrit-Change-Number: 74124 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: soc/amd/mendocino: Conditionally select HAVE_FSP_LOGO_SUPPORT
by Felix Held (Code Review) 03 Nov '23

03 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78882?usp=email ) Change subject: soc/amd/mendocino: Conditionally select HAVE_FSP_LOGO_SUPPORT ...................................................................... soc/amd/mendocino: Conditionally select HAVE_FSP_LOGO_SUPPORT Indicate FSP has support to display logo when graphics initialization is done in FSP. BUG=b:294055390 TEST=Build and boot to OS in Skyrim with and without passing the BMP logo buffer from coreboot. Change-Id: I6112c03723dcbc34cb0f57c400f831c765b95115 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78882 Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/amd/mendocino/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/soc/amd/mendocino/Kconfig b/src/soc/amd/mendocino/Kconfig index 2fcd508..ef72280 100644 --- a/src/soc/amd/mendocino/Kconfig +++ b/src/soc/amd/mendocino/Kconfig @@ -17,6 +17,7 @@ select HAVE_CF9_RESET select HAVE_EM100_SUPPORT select HAVE_FSP_GOP + select HAVE_FSP_LOGO_SUPPORT if RUN_FSP_GOP select HAVE_SMI_HANDLER select IDT_IN_EVERY_STAGE select PARALLEL_MP_AP_WORK -- To view, visit https://review.coreboot.org/c/coreboot/+/78882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6112c03723dcbc34cb0f57c400f831c765b95115 Gerrit-Change-Number: 78882 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Add support for rust
by Martin L Roth (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Angel Pons, Christian Walter, Maximilian Brune, Patrick Georgi, Paul Menzel, Subrata Banik, Tim Crawford, Werner Zeh, ron minnich. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74124?usp=email ) Change subject: Add support for rust ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > - Assumes rustup is installed by some means, with no explanation on how it is installed […] This also doesn't add rust to the coreboot toolchain, but as a system-wide install. -- To view, visit https://review.coreboot.org/c/coreboot/+/74124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibff3ca83b3dfebcc18006cddf0f649bcfb076500 Gerrit-Change-Number: 74124 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 17:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Add support for rust
by Felix Singer (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Angel Pons, Christian Walter, Martin L Roth, Maximilian Brune, Patrick Georgi, Paul Menzel, Subrata Banik, Tim Crawford, Werner Zeh, ron minnich. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74124?usp=email ) Change subject: Add support for rust ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > - Assumes rustup is installed by some means, with no explanation on how it is installed […] I'm working on some patches which integrate the rust toolchain much better. So no worries 😊 Will make them public for review after the 4.22 release. Still needs some rework. -- To view, visit https://review.coreboot.org/c/coreboot/+/74124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibff3ca83b3dfebcc18006cddf0f649bcfb076500 Gerrit-Change-Number: 74124 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 17:48:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume
by Jonathon Hall (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Bill XIE, Jérémy Compostella, Nico Huber. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78906?usp=email ) Change subject: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume ...................................................................... Patch Set 7: (1 comment) Patchset: PS4: > Sorry, I don't see how this makes things better. It adds […] Thanks for the context Nico, good to be aware of that. I think we should go ahead with patchset #5 also. Differentiating S3 wakeup for this behavior sounds too subtle / coincidental to me, maybe applying the GM45 behavior too broadly, and not clear that it would solve the unknown behavior of other boards that might have cmos.layout fields outside of the checksum. In my opinion there's no need for any more complexity unless we have specific examples that warrant it. So IMO, either we try to identify boards with cmos.layout fields outside of the checksum (not sure this is worth that amount of effort), or we try this change given that we think they probably would have problems already. -- To view, visit https://review.coreboot.org/c/coreboot/+/78906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I872bf5f41422bc3424cd8631e932aaae2ae82f7a Gerrit-Change-Number: 78906 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 17:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Add support for rust
by Tim Crawford (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Angel Pons, Christian Walter, Felix Singer, Martin L Roth, Maximilian Brune, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh, ron minnich. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74124?usp=email ) Change subject: Add support for rust ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: - Assumes rustup is installed by some means, with no explanation on how it is installed - Hard-codes the Rust version in the rustup command instead of specifying a toolchain override - Installs arbitrary tools, with no explanation of why they are required -- To view, visit https://review.coreboot.org/c/coreboot/+/74124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibff3ca83b3dfebcc18006cddf0f649bcfb076500 Gerrit-Change-Number: 74124 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 17:14:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/amd/genoa: Hook SMP and SMM init
by Felix Held (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Arthur Heymans, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76523?usp=email ) Change subject: soc/amd/genoa: Hook SMP and SMM init ...................................................................... Patch Set 5: (1 comment) File src/soc/amd/genoa/include/soc/cpu.h: https://review.coreboot.org/c/coreboot/+/76523/comment/e8a8ebec_a3266310 : PS5, Line 6: #define GENOA_A0_CPUID 0x00a10f00 would also be good if you can switch to using the CPUID_FROM_FMS macro instead of the magic numbers -- To view, visit https://review.coreboot.org/c/coreboot/+/76523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c2d976addacd5a2ba70eb629510128853b9f847 Gerrit-Change-Number: 76523 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 03 Nov 2023 16:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Kapil Porwal (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Julius Werner, Lean Sheng Tan, Paul Menzel, Subrata Banik, Werner Zeh. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765?usp=email ) Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > > I guess this is explainable due to the nature of how this feature works? […] Currently I am not seeing the regression. I investigated the below segment as well but I am not seeing any difference with/without this CL - ``` # cbmem -t ... 60:device initialization 959,184 (577) 15:starting LZMA decompress (ignore for x86) 964,119 (4,934) 16:finished LZMA decompress (ignore for x86) 964,220 (101) 114:started elog init 979,189 (14,968) 115:finished elog init 982,740 (3,550) ... ``` ``` # cbmem -c1 | grep -in "BS: BS_DEV_INIT " 2377:[DEBUG] BS: BS_DEV_INIT run times (exec / console): 20 / 0 ms 2383:[DEBUG] BS: BS_DEV_INIT exit times (exec / console): 4 / 0 ms ``` ``` # cbmem -c1 | grep -in "init finished in" | grep -v "0 msecs" 2036:[DEBUG] Root Device init finished in 4 msecs 2224:[DEBUG] PCI: 00:1f.2 init finished in 12 msecs ``` I will try it on a few more boards. -- To view, visit https://review.coreboot.org/c/coreboot/+/74765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 12 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: sridhar siricilla <siricillasridhar(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 16:12:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume
by Nico Huber (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Bill XIE, Jonathon Hall, Jérémy Compostella. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78906?usp=email ) Change subject: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume ...................................................................... Patch Set 7: (1 comment) Patchset: PS4: > Then we could restore the checked range only during s3 resume, while restore the whole CMOS after 14 […] Sorry, I don't see how this makes things better. It adds complexity and at the same time doesn't maintain the original behavior either. I justed wanted to create awareness of what we are changing. Let's just back off to the problem statement. There are cases like GM45 where we want to do things differently. And we have other cases (of data outside the checksummed range) where we don't know exactly what should be done. Any of them may be affected by extending the clearing to the second bank. I think it's ok to change these unknown cases. We are already in the middle of it anyway: Even with patchset #6, it's still not what we had before extending the CMOS clearing to bank 1. So I would prefer patchset #5. Also an alternative, but I think this would be overkill, is to make it board-specific; e.g. add a Kconfig that controls the behavior. -- To view, visit https://review.coreboot.org/c/coreboot/+/78906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I872bf5f41422bc3424cd8631e932aaae2ae82f7a Gerrit-Change-Number: 78906 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Comment-Date: Fri, 03 Nov 2023 16:10:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: pc80/rtc: Clear CMOS on errors on S3 resume too
by Nico Huber (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Bill XIE, Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78881?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: pc80/rtc: Clear CMOS on errors on S3 resume too ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Stalling this as we might not need the S3 condition... -- To view, visit https://review.coreboot.org/c/coreboot/+/78881?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1533875466f6eb7b409bb19ef98f6dcaf2d115c4 Gerrit-Change-Number: 78881 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 16:07:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023