coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[main]: vendorcode/amd/opensil: Add initial setup and API calls
by Felix Held (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Arthur Heymans, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76515?usp=email ) Change subject: vendorcode/amd/opensil: Add initial setup and API calls ...................................................................... Patch Set 6: (2 comments) File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h: https://review.coreboot.org/c/coreboot/+/76515/comment/75affd2e_d43e2482 : PS6, Line 7: might be good to do the whitespace changes in a separate patch. same below in lines 59 and 170 File src/vendorcode/amd/opensil/genoa_poc/ramstage.c: https://review.coreboot.org/c/coreboot/+/76515/comment/0964724c_78de042a : PS6, Line 86: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_EXIT, opensil_entry, (void *)SIL_TP1); we should probably look into removing the BOOT_STATE_INIT_ENTRY in this file and have the few calls in the soc code or possibly some common amd opensil code to have more control over the timing of those calls. i'd say adding a TODO comment for this should be the way to go here -- To view, visit https://review.coreboot.org/c/coreboot/+/76515?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4833a5a86034a13e6be102a6b68c3bb54108bc9a Gerrit-Change-Number: 76515 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 29 Nov 2023 14:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add OV13B10 MIPI camera device
by Weimin Wu (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Dolan Liu, Jianeng Ceng, Nick Vaccaro, Paul Menzel, Subrata Banik. Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79163?usp=email ) Change subject: mb/google/nissa/var/anraggar: Add OV13B10 MIPI camera device ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79163/comment/4eecc2a4_6d5c08ae : PS3, Line 11: Sensor:OV13B10-GA5A : Driver:DW9714V : EEPROM:GT24P64E > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/79163/comment/103b8243_8cad270f : PS3, Line 15: > Please also mention the source. […] Done https://review.coreboot.org/c/coreboot/+/79163/comment/2e8726b2_e94afb0e : PS3, Line 17: TEST=Google Camera app working > Please paste the related log messages from coreboot and the Linux kernel. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76 Gerrit-Change-Number: 79163 Gerrit-PatchSet: 4 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 14:37:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add OV13B10 MIPI camera device
by Weimin Wu (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Dolan Liu, Jianeng Ceng, Nick Vaccaro, Subrata Banik, Weimin Wu. Hello Arec Kao, Dolan Liu, Eric Lai, Jianeng Ceng, Nick Vaccaro, Paul Menzel, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79163?usp=email to look at the new patch set (#4). Change subject: mb/google/nissa/var/anraggar: Add OV13B10 MIPI camera device ...................................................................... mb/google/nissa/var/anraggar: Add OV13B10 MIPI camera device Enable MIPI camera for anraggar project. Sensor: OV13B10-GA5A Driver: DW9714V EEPROM: GT24P64E Ref to SCH, use MIPI 4-lane serial output interface. BUG=b:309518095 TEST=Google Camera app working Checking log with: coreboot log: \_SB.PCI0.I2C2.CAM0: Intel MIPI Camera Device I2C address 036h \_SB.PCI0.I2C2.VCM0: Intel MIPI Camera Device I2C address 0ch \_SB.PCI0.I2C2.NVM0: Intel MIPI Camera Device I2C address 050h kernel log: kernel: [ 6.140429] intel-ipu6-isys intel-ipu6-isys0: bind ov13b10 11-0036 nlanes is 4 port is 1 cros_camera_service[4755]: Read camera eeprom from /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom cros_camera_service[4755]: Probing media device '/dev/media0' cros_camera_service[4755]: Probing sensor 'ov13b10 11-0036' (v4l-subdev17) cros_camera_service[4755]: Found V4L2 sensor subdev on /sys/devices/pci0000:00/0000:00:15.2/i2c_designware.2/i2c-11/i2c-OVTIDB10:00/video4linux/v4l-subdev17 Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/gpio.c M src/mainboard/google/brya/variants/anraggar/overridetree.cb 2 files changed, 27 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/79163/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76 Gerrit-Change-Number: 79163 Gerrit-PatchSet: 4 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: build system: Exempt `make *config` from strict symbol checks
by Martin L Roth (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Patrick Georgi, Uwe Poeche, uwe taz. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79298?usp=email ) Change subject: build system: Exempt `make *config` from strict symbol checks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Gerrit-Change-Number: 79298 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: uwe taz <uwepoeche(a)arcor.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: uwe taz <uwepoeche(a)arcor.de> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 14:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: util/kconfig: Uprev to Linux 6.1's kconfig
by Patrick Georgi (Code Review) 29 Nov '23

29 Nov '23

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79203?usp=email ) Change subject: util/kconfig: Uprev to Linux 6.1's kconfig ...................................................................... Patch Set 3: (1 comment) File util/kconfig/confdata.c: https://review.coreboot.org/c/coreboot/+/79203/comment/48ae5851_22e7d8cb : PS3, Line 235: char *name = getenv("KCONFIG_RUSTCCFG"); > looks like we need to set that one. […] Thanks for bringing it up. https://review.coreboot.org/c/coreboot/+/79342 moves it to $(obj) -- To view, visit https://review.coreboot.org/c/coreboot/+/79203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79159130ba3515ede59e9fb9fbf087e2ed76257a Gerrit-Change-Number: 79203 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 29 Nov 2023 14:33:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Kconfig: Move rustccfg file to a more benign place
by Patrick Georgi (Code Review) 29 Nov '23

29 Nov '23

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79342?usp=email ) Change subject: Kconfig: Move rustccfg file to a more benign place ...................................................................... Kconfig: Move rustccfg file to a more benign place It's put in $(obj) now. Not sure if we'll need it, but there has been some interest in rust support in coreboot, and removing support for it would be more work than this, so let's just keep it around. Change-Id: I532fde9625dbf7463752ef1af525b77d12676c93 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/79342/1 diff --git a/Makefile b/Makefile index d41dd4f..b521f04 100644 --- a/Makefile +++ b/Makefile @@ -23,6 +23,7 @@ DOTCONFIG ?= $(top)/.config KCONFIG_CONFIG = $(DOTCONFIG) KCONFIG_AUTOADS := $(obj)/cb-config.ads +KCONFIG_RUSTCCFG := $(obj)/cb-config.rustcfg KCONFIG_AUTOHEADER := $(obj)/config.h KCONFIG_AUTOCONFIG := $(obj)/auto.conf KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd @@ -42,6 +43,7 @@ endif COREBOOT_EXPORTS += KCONFIG_WARN_UNKNOWN_SYMBOLS COREBOOT_EXPORTS += KCONFIG_AUTOADS KCONFIG_PACKAGE +COREBOOT_EXPORTS += KCONFIG_RUSTCCFG # Make does not offer a recursive wildcard function, so here's one: rwildcard=$(wildcard $1$2) $(foreach d,$(wildcard $1*),$(call rwildcard,$d/,$2)) -- To view, visit https://review.coreboot.org/c/coreboot/+/79342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I532fde9625dbf7463752ef1af525b77d12676c93 Gerrit-Change-Number: 79342 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: build system: Exempt `make *config` from strict symbol checks
by Patrick Georgi (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Martin L Roth, Uwe Poeche, uwe taz. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79298?usp=email ) Change subject: build system: Exempt `make *config` from strict symbol checks ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > This helps to get working config files with unknown symbols/config switches to prevent error if usin […] Re 1) In patch set 2 I re-enabled the warnings for the *config targets, so it should be closer to what you had before. Does that help? Re 2) rustc_cfg has been brought up in https://review.coreboot.org/c/coreboot/+/79203 We'll need to sort it out, but let's handle that separately. -- To view, visit https://review.coreboot.org/c/coreboot/+/79298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Gerrit-Change-Number: 79298 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: uwe taz <uwepoeche(a)arcor.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: uwe taz <uwepoeche(a)arcor.de> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 14:27:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: build system: Exempt `make *config` from strict symbol checks
by Patrick Georgi (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Martin L Roth, Patrick Georgi, Uwe Poeche, uwe taz. Hello Martin L Roth, Uwe Poeche, build bot (Jenkins), uwe taz, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79298?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Uwe Poeche, Verified+1 by build bot (Jenkins) Change subject: build system: Exempt `make *config` from strict symbol checks ...................................................................... build system: Exempt `make *config` from strict symbol checks The "config" targets exist to edit the .config file, and so they should be more forgiving with invalid configs (that they'll convert into valid configs on save). They will still emit warnings about invalid symbols, but not exit with an error. The regular build process still fails if the .config looks unexpected (for example when there's an unknown config flag). Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M Makefile M util/kconfig/Makefile.inc 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/79298/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Gerrit-Change-Number: 79298 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: uwe taz <uwepoeche(a)arcor.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: uwe taz <uwepoeche(a)arcor.de> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: build system: Exempt `make *config` from strict symbol checks
by Patrick Georgi (Code Review) 29 Nov '23

29 Nov '23

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79341?usp=email ) Change subject: build system: Exempt `make *config` from strict symbol checks ...................................................................... build system: Exempt `make *config` from strict symbol checks The "config" targets exist to edit the .config file, and so they should be more forgiving with invalid configs (that they'll convert into valid configs on save). They will still emit warnings about invalid symbols, but not exit with an error. The regular build process still fails if the .config looks unexpected (for example when there's an unknown config flag). Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M Makefile M util/kconfig/Makefile.inc 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/79341/1 diff --git a/Makefile b/Makefile index 5ed6933..d41dd4f 100644 --- a/Makefile +++ b/Makefile @@ -29,14 +29,17 @@ KCONFIG_SPLITCONFIG := $(obj)/config/ KCONFIG_TRISTATE := $(obj)/tristate.conf KCONFIG_NEGATIVES := 1 -KCONFIG_WERROR:= 1 -KCONFIG_WARN_UNKNOWN_SYMBOLS:= 1 +KCONFIG_WERROR := 1 +KCONFIG_WARN_UNKNOWN_SYMBOLS := 1 KCONFIG_PACKAGE := CB.Config KCONFIG_MAKEFILE_REAL ?= $(objk)/Makefile.real COREBOOT_EXPORTS += KCONFIG_CONFIG KCONFIG_AUTOHEADER KCONFIG_AUTOCONFIG COREBOOT_EXPORTS += KCONFIG_DEPENDENCIES KCONFIG_SPLITCONFIG KCONFIG_TRISTATE -COREBOOT_EXPORTS += KCONFIG_NEGATIVES KCONFIG_WERROR +COREBOOT_EXPORTS += KCONFIG_NEGATIVES +ifeq ($(filter %config,$(MAKECMDGOALS)),) +COREBOOT_EXPORTS += KCONFIG_WERROR +endif COREBOOT_EXPORTS += KCONFIG_WARN_UNKNOWN_SYMBOLS COREBOOT_EXPORTS += KCONFIG_AUTOADS KCONFIG_PACKAGE diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc index 3a9f353..83fad88 100644 --- a/util/kconfig/Makefile.inc +++ b/util/kconfig/Makefile.inc @@ -47,8 +47,6 @@ # Fill in Linux kconfig build rules to work -oldconfig: KCONFIG_STRICT= - savedefconfig: $(objk)/conf cp $(DOTCONFIG) $(DEFCONFIG) chmod +w $(DEFCONFIG) -- To view, visit https://review.coreboot.org/c/coreboot/+/79341?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If427e075766c68d493dd406609f21b6bb27d1d74 Gerrit-Change-Number: 79341 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: security/vboot: Add Kconfig option to clear recovery request
by Michał Żygowski (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74343?usp=email ) Change subject: security/vboot: Add Kconfig option to clear recovery request ...................................................................... Patch Set 8: (2 comments) File src/security/vboot/bootmode.c: https://review.coreboot.org/c/coreboot/+/74343/comment/ea2a0b92_d6aaa9e8 : PS4, Line 68: BS_ON_ENTRY > CSME-required reboots should be all done at POST_DEVICE, unless CSE LITE has different flow, which I […] Added the comment as you suggested Yu-Ping Wu. If POST_DEVICE ON_ENTRY is too early, maybe we could shift the vbnv backup to OS_RESUME_CHECK ON_ENTRY? File src/security/vboot/bootmode.c: https://review.coreboot.org/c/coreboot/+/74343/comment/8a12e102_34b7f0e2 : PS6, Line 59: if (!CONFIG(VBOOT_CLEAR_RECOVERY_IN_RAMSTAGE)) > Please wrap the entire thing (including `BOOT_STATE_INIT_ENTRY`) in an `#if` block instead. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74343?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ffaf3e8f61a28a68c9802c184961b1b9bf9d617 Gerrit-Change-Number: 74343 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 13:46:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023