coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: qualcomm/sc7180: Move QCSDI and increase romstage size
by Julius Werner (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Felix Held, Shelley Chen. Hello Felix Held, Shelley Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79074?usp=email to look at the new patch set (#2). Change subject: qualcomm/sc7180: Move QCSDI and increase romstage size ...................................................................... qualcomm/sc7180: Move QCSDI and increase romstage size We need to increase romstage size a little to make a compiler upgrade fit. Unfortunately the end of the romstage directly touches the QCSDI region in the current memlayout, and there is no other way to reshuffle things to make more space... so we need to move QCSDI out of the way. This means that anyone who is actually building this platform with CONFIG_QC_SDI_ENABLE (which requires a proprietary blob that's not publicly available) will need to recompile their QCSDI binary to match the new start address. Change-Id: Iaf13e4001b3c763e3ec59009779931ec75603d5d Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/soc/qualcomm/sc7180/memlayout.ld 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/79074/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf13e4001b3c763e3ec59009779931ec75603d5d Gerrit-Change-Number: 79074 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/geralt: Disable SD card support for Ciri
by Yu-Ping Wu (Code Review) 17 Nov '23

17 Nov '23

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78958?usp=email ) Change subject: mb/google/geralt: Disable SD card support for Ciri ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/geralt/Kconfig: https://review.coreboot.org/c/coreboot/+/78958/comment/e094339e_3931dd18 : PS4, Line 70: bool Just realized that this could be simplified using `def_bool`. Uploaded CB:79076. -- To view, visit https://review.coreboot.org/c/coreboot/+/78958?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4e021e7896d093560f39c40573ac616d76438c2 Gerrit-Change-Number: 78958 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 00:59:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/geralt/Kconfig: Simplify SDCARD_INIT with def_bool
by Yu-Ping Wu (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79076?usp=email ) Change subject: mb/google/geralt/Kconfig: Simplify SDCARD_INIT with def_bool ...................................................................... mb/google/geralt/Kconfig: Simplify SDCARD_INIT with def_bool Change-Id: Ie033204894e829ab3bff79297e93861a4585495a Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/mainboard/google/geralt/Kconfig 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/79076/1 diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index c422441..8848f13 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -67,9 +67,7 @@ default 0x50 config SDCARD_INIT - bool - default y if BOARD_GOOGLE_GERALT - default n if BOARD_GOOGLE_CIRI + def_bool BOARD_GOOGLE_GERALT choice prompt "Speaker AMP for Geralt" -- To view, visit https://review.coreboot.org/c/coreboot/+/79076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie033204894e829ab3bff79297e93861a4585495a Gerrit-Change-Number: 79076 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/corsola/Kconfig: Simplify SDCARD_INIT with def_bool
by Yu-Ping Wu (Code Review) 17 Nov '23

17 Nov '23

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79075?usp=email ) Change subject: mb/google/corsola/Kconfig: Simplify SDCARD_INIT with def_bool ...................................................................... mb/google/corsola/Kconfig: Simplify SDCARD_INIT with def_bool Change-Id: I249917cccfd644d69546c4602a3190d03d0b3277 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/mainboard/google/corsola/Kconfig 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/79075/1 diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 805a83a..7acdea4 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -102,11 +102,9 @@ default 7 config SDCARD_INIT - bool - default y if BOARD_GOOGLE_MAGIKARP - default y if BOARD_GOOGLE_TENTACRUEL - default y if BOARD_GOOGLE_KINGLER_COMMON - default n if BOARD_GOOGLE_KRABBY_COMMON + def_bool BOARD_GOOGLE_KINGLER_COMMON || \ + BOARD_GOOGLE_MAGIKARP || \ + BOARD_GOOGLE_TENTACRUEL config DRIVER_TPM_SPI_BUS hex -- To view, visit https://review.coreboot.org/c/coreboot/+/79075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I249917cccfd644d69546c4602a3190d03d0b3277 Gerrit-Change-Number: 79075 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: crossgcc: Upgrade GCC from 11.4.0 to 13.2.0
by Julius Werner (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Elyes Haouas, Felix Singer, Lennart Eichhorn. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70771?usp=email ) Change subject: crossgcc: Upgrade GCC from 11.4.0 to 13.2.0 ...................................................................... Patch Set 27: (1 comment) Patchset: PS27: > Julius, can you help on this issue? https://qa.coreboot. […] Strangely enough, when I check out this patch and rebuild crossgcc, I do see an increase in size compared to the old compiler, but it still fits into 100K for me. Is there a reason I would get different results with the same compiler and same code? Anyway, I dug into the reason for the size difference a little and identified a number of situations where the new GCC generates larger code (but also some where it's better). One example is that it doesn't seem to be as eager to produce separate jump tables for small-ish switch statements (easy to see in vb2_digest_extend()) — maybe that's some sort of branch predictor optimization so that might be an intended trade-off. I've also found one situation about accessing multiple indices in a global array that just seems to be a clear bug (easy to see in vboot's default vb2ex_hwcrypto_digest_finalize()), I filed that at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112573. There is also a big difference in LzmaDecode() which becomes over 1KB larger (~20% increase), but that code is a horrible mess even in source form so I'm afraid there's probably not much we can understand there. In general, it would probably be a good idea to just always compare binary sizes during compiler uprevs (at least one board for each architecture) and record the findings in the commit message, so that we're at least aware of big changes and can try to investigate if necessary. Anyway, this should fix the Trogdor issue: CB:79074 -- To view, visit https://review.coreboot.org/c/coreboot/+/70771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f2ed4de4811abaa13528906de71eee29a8f2910 Gerrit-Change-Number: 70771 Gerrit-PatchSet: 27 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lennart Eichhorn <lennarteichhorn(a)googlemail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 17 Nov 2023 00:54:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: qualcomm/sc7180: Move QCSDI and increase romstage size
by Julius Werner (Code Review) 17 Nov '23

17 Nov '23

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79074?usp=email ) Change subject: qualcomm/sc7180: Move QCSDI and increase romstage size ...................................................................... qualcomm/sc7180: Move QCSDI and increase romstage size We need to increase romstage size a little to make a compiler upgrade fit. Unfortunately the end of the romstage directly touches the QCSDI region in the current memlayout, and there is no other way to reshuffle things to make more space... so we need to move QCSDI out of the way. This means that anyone who is actually building this platform with CONFIG_QC_SDI_ENABLE (which requires a proprietary blob that's not publicly available) will need to recompile their QCSDI binary to match the new start address. Change-Id: Iaf13e4001b3c763e3ec59009779931ec75603d5d Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/soc/qualcomm/sc7180/memlayout.ld 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/79074/1 diff --git a/src/soc/qualcomm/sc7180/memlayout.ld b/src/soc/qualcomm/sc7180/memlayout.ld index e956c64..c6bb267 100644 --- a/src/soc/qualcomm/sc7180/memlayout.ld +++ b/src/soc/qualcomm/sc7180/memlayout.ld @@ -23,8 +23,8 @@ AOPSRAM_END(0x0B100000) SSRAM_START(0x14680000) - OVERLAP_DECOMPRESSOR_VERSTAGE_ROMSTAGE(0x14680000, 100K) - REGION(qcsdi, 0x14699000, 52K, 4K) + OVERLAP_DECOMPRESSOR_VERSTAGE_ROMSTAGE(0x14680000, 104K) + REGION(qcsdi, 0x1469ED00, 52K, 4K) REGION(modem_id, 0x146ABD00, 4, 4) SSRAM_END(0x146AE000) -- To view, visit https://review.coreboot.org/c/coreboot/+/79074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf13e4001b3c763e3ec59009779931ec75603d5d Gerrit-Change-Number: 79074 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: arch/arm64: Extend cache helper functions
by David Milosevic (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Julius Werner. Hello Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79106?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: arch/arm64: Extend cache helper functions ...................................................................... arch/arm64: Extend cache helper functions This patch extends the cpu_get_cache_info function, so that additional information like size of cache lines can be retrieved. Furthermore, static functions were grouped and moved to the top and non-static functions to the bottom, in order to provide a better structure to the file. Patch was tested against the qemu-sbsa mainboard. Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> --- M src/arch/arm64/armv8/cache.c M src/arch/arm64/include/armv8/arch/cache.h 2 files changed, 91 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/79106/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de Gerrit-Change-Number: 79106 Gerrit-PatchSet: 2 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: tests: Allow specifying vboot source directory
by Yu-Ping Wu (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Martin L Roth. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78849?usp=email ) Change subject: tests: Allow specifying vboot source directory ...................................................................... Patch Set 4: (1 comment) File Makefile: https://review.coreboot.org/c/coreboot/+/78849/comment/85b0bcef_98971a45 : PS4, Line 18: abspath The problem with this patch is, when passing an absolute path to `-I`, `vboot-fixup-includes` in security/vboot/Makefile.inc will incorrectly prepend `$(top)` to the include path. While `vboot-fixup-includes` can definitely be fixed, I think it's better to leave `VBOOT_SOURCE` a relative path here. When running unit tests, we can still pass an absolute `VBOOT_SOURCE` to make. -- To view, visit https://review.coreboot.org/c/coreboot/+/78849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d Gerrit-Change-Number: 78849 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 00:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: docker/coreboot-sdk: Add perl modules for gcov
by Felix Singer (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79072?usp=email ) Change subject: docker/coreboot-sdk: Add perl modules for gcov ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If32a42ce17edcbae94394f770c26d3300abebcbe Gerrit-Change-Number: 79072 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 00:13:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tests: Allow specifying vboot source directory
by Yu-Ping Wu (Code Review) 17 Nov '23

17 Nov '23

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78849?usp=email ) Change subject: tests: Allow specifying vboot source directory ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: roccochen@ FYI. See CB:78863 about why Jenkins build didn't fail previously. -- To view, visit https://review.coreboot.org/c/coreboot/+/78849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d Gerrit-Change-Number: 78849 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Thu, 16 Nov 2023 23:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023