coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: Update amd_blobs submodule to upstream main branch
by Felix Held (Code Review) 05 Oct '23

05 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78232?usp=email ) Change subject: Update amd_blobs submodule to upstream main branch ...................................................................... Update amd_blobs submodule to upstream main branch Updating from commit id ae822f2d0db7 (2023-09-21): MDN: Restore SMU fw version 90.41.0 to commit id b1741d184add (2023-10-04): PCO: Update SMU firmware to 4.30.77.200 This brings in 1 new commit: b1741d184a PCO: Update SMU firmware to 4.30.77.200 BRANCH=zork BUG=b:299603947 Change-Id: I0ce75b762bda90a5fa3bc546de42bc5d55637e17 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78232 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index ae822f2..b1741d1 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit ae822f2d0db7e9f9c8dff4ad1539ea2282f28f27 +Subproject commit b1741d184add2a38c5e8ff025593d0c1c48f782f -- To view, visit https://review.coreboot.org/c/coreboot/+/78232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ce75b762bda90a5fa3bc546de42bc5d55637e17 Gerrit-Change-Number: 78232 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: soc/intel: Fix slp-s0 residency counter frequency LPIT table
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Lance Zhao, Subrata Banik, Sukumar Ghorai, Tarun, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78164?usp=email ) Change subject: soc/intel: Fix slp-s0 residency counter frequency LPIT table ...................................................................... Patch Set 11: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78164/comment/76dc713d_4ce8ec09 : PS11, Line 7: soc/intel soc/intel/mtl https://review.coreboot.org/c/coreboot/+/78164/comment/bff232a3_e5d7e61f : PS11, Line 7: Fix slp-s0 residency counter frequency LPIT table Maybe: > Set slp-s0 residency counter frequency to … https://review.coreboot.org/c/coreboot/+/78164/comment/688ef2ed_1d9e2be7 : PS11, Line 16: meteorlake Meteor Lake https://review.coreboot.org/c/coreboot/+/78164/comment/d87cb964_b992c4f3 : PS11, Line 20: cat /sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us : cat /sys/kernel/debug/pmc_core/slp_s0_residency_usec Please also paste the content. File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78164/comment/f5ffd3fb_4a08dc3a : PS11, Line 442: ACPI_SOC_INTEL_SLP_S0_FREQ Add the unit? https://review.coreboot.org/c/coreboot/+/78164/comment/f021aee7_72422052 : PS11, Line 444: 0x2005 How many μs is that? https://review.coreboot.org/c/coreboot/+/78164/comment/32ed5ff9_9202a621 : PS11, Line 446: meteorlake Meteor Lake -- To view, visit https://review.coreboot.org/c/coreboot/+/78164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I401dd4a09a67d81a9ea3a56cd22f1a681e2a9349 Gerrit-Change-Number: 78164 Gerrit-PatchSet: 11 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:48:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by YH Lin (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78182?usp=email ) Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78182/comment/6875c7d7_8dc2e674 : PS1, Line 9: Sync'ing the FW_CONFIG definitions per b/290689824. > Please elaborate. Most people do not have access to the issue. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78182 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:48:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: add hook for WiFi SAR table
by YH Lin (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78181?usp=email ) Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78181/comment/4530e88e_147188d9 : PS1, Line 9: In preparation for WiFi SAR table addition by adding hook for it. > Please elaborate. (For example, state the problem. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78181 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by YH Lin (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, YH Lin. Hello Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78182?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... mb/google/rex/var/karis: sync CBI FW_CONFIG definitions Sync'ing Karis' FW_CONFIG definitions stored in CBI, ``` _FW_MASKS = struct( DB_USB = 0x00000003, # bit1~bit0 STYLUS = 0x00000004, # bit2 AMP = 0x00000038, # bit5~bit3 FAN = 0x000000C0, # bit7~bit6 MIPI_CAM = 0x00000300, # bit9 ~ bit8 FP_MCU = 0x00000C00, # bit11 ~ bit10 KB_TYPE = 0x00001000, # bit12 WIFI_TYPE = 0x00002000, # bit13 ) _FW_CONFIGS = struct( DB_USB_UNKNOWN = hw_topo.make_fw_config(_FW_MASKS.DB_USB, 0), DB_USB4_ANX7452 = hw_topo.make_fw_config(_FW_MASKS.DB_USB, 1), STYLUS_ABSENT = hw_topo.make_fw_config(_FW_MASKS.STYLUS, 0), STYLUS_PRESENT = hw_topo.make_fw_config(_FW_MASKS.STYLUS, 1), AUDIO_ALC5650 = hw_topo.make_fw_config(_FW_MASKS.AMP, 0), FP_MCU_ABSENT = hw_topo.make_fw_config(_FW_MASKS.FP_MCU, 0), FP_MCU_NUVOTON = hw_topo.make_fw_config(_FW_MASKS.FP_MCU, 1), FP_MCU_ELAN = hw_topo.make_fw_config(_FW_MASKS.FP_MCU, 2), WIFI_TYPE_CNVI = hw_topo.make_fw_config(_FW_MASKS.WIFI_TYPE, 0), WIFI_TYPE_PCIE = hw_topo.make_fw_config(_FW_MASKS.WIFI_TYPE, 1), MIPI_UF_CAM_HI556 = hw_topo.make_fw_config(_FW_MASKS.MIPI_CAM, 0), ) ``` BUG=b:290689824 TEST=emerge-rex coreboot Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Signed-off-by: YH Lin <yueherngl(a)google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/78182/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78182 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: add hook for WiFi SAR table
by YH Lin (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, YH Lin. Hello Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78181?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... mb/google/rex/var/karis: add hook for WiFi SAR table WiFi SAR table for karis will be place into the CBFS later on and as a result adding the hook in coreboot to make use of the SAR table once the table is available. BUG=b:290689824 TEST=emerge-rex coreboot Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Signed-off-by: YH Lin <yueherngl(a)google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/karis/Makefile.inc A src/mainboard/google/rex/variants/karis/variant.c 3 files changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/78181/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78181 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/amd/genoa: Add SMI support
by Felix Held (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78221?usp=email ) Change subject: soc/amd/genoa: Add SMI support ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/genoa/include/soc/smi.h: https://review.coreboot.org/c/coreboot/+/78221/comment/8b775285_14af12b9 : PS1, Line 26: #define SMITYPE_G_GENINT2_L 1 this table doesn't seem to be updated for genoa yet; this entry should for example be #define SMITYPE_G_AGPIO115_L 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78221?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I491f4075cef8976e4b0762752c9e2e3c2ef886d5 Gerrit-Change-Number: 78221 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:45:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel: separate slp-s0 residency counter frequency in LPIT table
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Sukumar Ghorai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78177?usp=email ) Change subject: soc/intel: separate slp-s0 residency counter frequency in LPIT table ...................................................................... Patch Set 10: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78177/comment/34114c2f_dc9c5c81 : PS10, Line 25: It would have been nice, if you had stated, that the code didn’t change, as the new macro is also defined as 0. File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/78177/comment/0d6435a1_9a380213 : PS10, Line 456: #define ACPI_LPIT_CTR_FREQ_TSC 0 : #define ACPI_LPIT_SLP_S0_FREQ 0 Only at the top of the file, the values are aligned with tabs. After that spaces are used. Maybe keep that? -- To view, visit https://review.coreboot.org/c/coreboot/+/78177?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibde764551a21b9aecb1c269948f4823548294711 Gerrit-Change-Number: 78177 Gerrit-PatchSet: 10 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:44:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: doc/forums: Add a section for local groups and meetups
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: David Hendricks, Felix Singer, Martin L Roth, Patrick Georgi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76937?usp=email ) Change subject: doc/forums: Add a section for local groups and meetups ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Thank you for organizing this meetup. File Documentation/community/forums.md: https://review.coreboot.org/c/coreboot/+/76937/comment/bc30f05a_476ec485 : PS1, Line 43: Local groups and meetups are not organized by the coreboot project but : by affiliated individuals from the community. Isn’t the project the community? I do not think this disclaimer is needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/76937?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib814ce34b24cd199e5a0a623bffde4b7d93deff0 Gerrit-Change-Number: 76937 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: cbfs: Restore 32-bit padding in cbfs_header
by Julius Werner (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Elyes Haouas, Ivan Jager. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78239?usp=email ) Change subject: cbfs: Restore 32-bit padding in cbfs_header ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Yeah, sorry, this should have never been changed. cbfstool is using sizeof() on that structure so the size of the `pad[1]` member was important. -- To view, visit https://review.coreboot.org/c/coreboot/+/78239?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4199dcc4823469c5986ac967a55b1c85cc62f780 Gerrit-Change-Number: 78239 Gerrit-PatchSet: 1 Gerrit-Owner: Ivan Jager Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivan Jager Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 05 Oct 2023 21:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023