coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/joxer: Config I2C frequency
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Felix Held, Ivan Chen, Mark Hsieh, Nick Vaccaro, Subrata Banik, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78218?usp=email ) Change subject: mb/google/nissa/var/joxer: Config I2C frequency ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78218/comment/baa7ebe3_d55759c7 : PS1, Line 9: Measured the I2C frequency meets spec. > I have uploaded all I2C devices measurement result on issue tracker, thanks. […] These issues are not publicly accessible, so it’d be nice to have the information in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/78218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17dd1cb7800d00669f86fc6e2b350757695da881 Gerrit-Change-Number: 78218 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Change camera fw_config feild
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Robert Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78213?usp=email ) Change subject: mb/google/nissa/var/quandiso: Change camera fw_config feild ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78213/comment/4109b374_5c3af5e5 : PS3, Line 7: feild field https://review.coreboot.org/c/coreboot/+/78213/comment/e851526c_37615135 : PS3, Line 9: reserve reserves -- To view, visit https://review.coreboot.org/c/coreboot/+/78213?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4343083f0d69a49c642657d165ceac349cd7422 Gerrit-Change-Number: 78213 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: cbfs: Restore 32-bit padding in cbfs_header
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Elyes Haouas, Ivan Jager, Julius Werner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78239?usp=email ) Change subject: cbfs: Restore 32-bit padding in cbfs_header ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78239/comment/707badb6_aaf6d3bd : PS1, Line 9: It was changed from a fixed size 1 array to a to a flexible array (It refers to the line below.) > `Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 242bac0e162c ("commonlib/bsd/cbfs_serialized.h: Use C99 flexible arrays")'` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/78239?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4199dcc4823469c5986ac967a55b1c85cc62f780 Gerrit-Change-Number: 78239 Gerrit-PatchSet: 1 Gerrit-Owner: Ivan Jager Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivan Jager Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/common/vboot: Fix the PSP verstage timestamps
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Martin Roth, Matt DeVillier, Tim Van Patten. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78231?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/amd/common/vboot: Fix the PSP verstage timestamps ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78231/comment/da46972c_a79a6e50 : PS1, Line 7: Fix the PSP verstage timestamps Maybe more specific: > Fix PSP verstage timestamps after TSC timer conversion https://review.coreboot.org/c/coreboot/+/78231/comment/7738e88d_d319469e : PS1, Line 9: CB:74016 As git operates with hashes, I’d add that (and the summary). It’d be enough as a Fixes: tag. https://review.coreboot.org/c/coreboot/+/78231/comment/9d057143_4c3e4fd6 : PS1, Line 11: timestamps(in microseconds) Please add a space before (. https://review.coreboot.org/c/coreboot/+/78231/comment/62d601ba_8eeb492d : PS1, Line 13: adjust adjusted -- To view, visit https://review.coreboot.org/c/coreboot/+/78231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e52bef22f65596152f29c511bed680427660ff5 Gerrit-Change-Number: 78231 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Update TBT PCIe Reg Map offsets for QS
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Ravishankar Sarawadi, Tarun, Utkarsh H Patel. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78163?usp=email ) Change subject: soc/intel/meteorlake: Update TBT PCIe Reg Map offsets for QS ...................................................................... Patch Set 6: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78163/comment/f2347cc1_f82f1744 : PS6, Line 14: Please mention the datasheet name and revision. File src/soc/intel/meteorlake/acpi/tcss_pcierp.asl: https://review.coreboot.org/c/coreboot/+/78163/comment/0512bbf3_ae1c7fa6 : PS6, Line 54: Offset(0xBA8), /* 0xBA8, MPC - Miscellaneous Port Configuration Register */ : , 30, : HPEX, 1, /* 30, Hot Plug SCI Enable */ : PMEX, 1, /* 31, Power Management SCI Enable */ : Offset(0xBB2), /* 0xBB2, RPPGEN - Root Port Power Gating Enable */ : , 2, : L23E, 1, /* 2, L23_Rdy Entry Request (L23ER) */ : L23R, 1, /* 3, L23_Rdy to Detect Transition (L23R2DT) */ In Gerrit, the `/*` are not correctly aligned with line 53. https://review.coreboot.org/c/coreboot/+/78163/comment/caa3a6fc_6085b5b1 : PS6, Line 70: Offset(0xBAC), /* 0xBAC, SMSCS - SMI/SCI Status Register */ Please align `/*`. https://review.coreboot.org/c/coreboot/+/78163/comment/6efe7499_58279ff0 : PS6, Line 67: #if CONFIG(SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON) : Offset(0xDC), /* 0xDC, SMSCS - SMI/SCI Status Register */ : #else : Offset(0xBAC), /* 0xBAC, SMSCS - SMI/SCI Status Register */ : #endif Maybe define a macro for SMSCS? -- To view, visit https://review.coreboot.org/c/coreboot/+/78163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0497f7108ef5046c2694aece232263582514a0c5 Gerrit-Change-Number: 78163 Gerrit-PatchSet: 6 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:37:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: add hook for WiFi SAR table
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Tarun, YH Lin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78181?usp=email ) Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78181/comment/d6702590_be2791c5 : PS1, Line 9: In preparation for WiFi SAR table addition by adding hook for it. Please elaborate. (For example, state the problem.) -- To view, visit https://review.coreboot.org/c/coreboot/+/78181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78181 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:33:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Tarun, YH Lin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78182?usp=email ) Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78182/comment/724edad7_fd737fa7 : PS1, Line 9: Sync'ing the FW_CONFIG definitions per b/290689824. Please elaborate. Most people do not have access to the issue. -- To view, visit https://review.coreboot.org/c/coreboot/+/78182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78182 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:32:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable SD card GPIOs with fw_config
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Nick Vaccaro, Robert Chen, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78253?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable SD card GPIOs with fw_config ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78253/comment/9a0a91ca_9843400f : PS3, Line 8: Why? Please elaborate. -- To view, visit https://review.coreboot.org/c/coreboot/+/78253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6789d42b9a3f9b979fd481a88cc7d69db2dcfe Gerrit-Change-Number: 78253 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:31:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Kane Chen, Kapil Porwal, Ravishankar Sarawadi, Tarun. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78252?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78252/comment/e3b971b7_340cc2d2 : PS2, Line 13: TEST=suspend_stress_test 50 cycle pass, type-c display OK on screebo Maybe make that clear: > TEST=as before: suspend_stress_test 50 cycle pass, type-c display OK on screebo -- To view, visit https://review.coreboot.org/c/coreboot/+/78252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235 Gerrit-Change-Number: 78252 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:31:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/rex0: update dptf thermal settings
by Paul Menzel (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email ) Change subject: mb/google/rex/var/rex0: update dptf thermal settings ...................................................................... Patch Set 2: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78180/comment/b6d3049d_097bd19e : PS2, Line 7: update dptf thermal settings Maybe more specific: > Update DPTF thermal settings to start fan earlier https://review.coreboot.org/c/coreboot/+/78180/comment/6f136570_257bc3c8 : PS2, Line 9: During internal testing observed Maybe: Internal testing showed, … https://review.coreboot.org/c/coreboot/+/78180/comment/459d91b7_d68523f9 : PS2, Line 10: While this even fan does not start : to control the temperature. Maybe: In this situation, the fan does not even start to lower the temperature. https://review.coreboot.org/c/coreboot/+/78180/comment/0515fa36_05fedaf3 : PS2, Line 12: high too high https://review.coreboot.org/c/coreboot/+/78180/comment/a5ac46b0_84f0eabb : PS2, Line 13: With updated new settings Please document, where the new settings came from. At what temperature does the fan start? https://review.coreboot.org/c/coreboot/+/78180/comment/3bda829a_1ffbdcac : PS2, Line 13: start fan early for TSR0 and TSR1 : sensors to prevent high CPU temperature Maybe: … the fan starts early for TSR0 and TSR1 so the temperature stays below X °C. -- To view, visit https://review.coreboot.org/c/coreboot/+/78180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf Gerrit-Change-Number: 78180 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 19:29:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023