coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[L] Change in coreboot[main]: SNB+MRC boards: Do not redo PEI data struct in hook
by Patrick Rudolph (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Alexander Couzens, Angel Pons, Keith Hui, Martin L Roth. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76962?usp=email ) Change subject: SNB+MRC boards: Do not redo PEI data struct in hook ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File src/mainboard/roda/rv11/variants/rw11/early_init.c: https://review.coreboot.org/c/coreboot/+/76962/comment/68669b63_12f4520e : PS5, Line 64: pcie_init set by northbridge_fill_pei_data? https://review.coreboot.org/c/coreboot/+/76962/comment/13520015_1e539efa : PS5, Line 65: usb3 Use devicetree setting register "usb3.mode"= ...? -- To view, visit https://review.coreboot.org/c/coreboot/+/76962?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie349a8f400eecca3cdbc196ea0790aebe0549e39 Gerrit-Change-Number: 76962 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 18:20:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/mtl: Set slp-s0 counter frequency
by Subrata Banik (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Eran Mitrani, Sukumar Ghorai, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78277?usp=email ) Change subject: soc/intel/mtl: Set slp-s0 counter frequency ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78277/comment/8dfdd764_068b57f1 : PS1, Line 458: 8197 > Acknowledged did u missed to submit the CL and marked ack ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e95cd69e941d4d72d5c36a07660ca07ee2499ba Gerrit-Change-Number: 78277 Gerrit-PatchSet: 1 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 18:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: nb/intel/sandybridge: Standardize MRC vs. native SPD mapping API
by Patrick Rudolph (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Angel Pons, Keith Hui, Martin L Roth. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76965?usp=email ) Change subject: nb/intel/sandybridge: Standardize MRC vs. native SPD mapping API ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76965?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a75279d981e46505930a9ce1aae894ccc4e1f24 Gerrit-Change-Number: 76965 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 18:15:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/*: Update SPD mapping for sandybridge boards
by Patrick Rudolph (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Alexander Couzens, Angel Pons, Evgeny Zinoviev, Keith Hui, Kevin Keijzer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76967?usp=email ) Change subject: mb/*: Update SPD mapping for sandybridge boards ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/mainboard/google/stout/early_init.c: https://review.coreboot.org/c/coreboot/+/76967/comment/559cc867_b2ffcfef : PS5, Line 85: unrelated change -- To view, visit https://review.coreboot.org/c/coreboot/+/76967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6ac0a36b2fc0b9686f6e875dd020ae8dba72a72 Gerrit-Change-Number: 76967 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 18:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/mtl: Set slp-s0 counter frequency
by Sukumar Ghorai (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Eran Mitrani, Tarun. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78277?usp=email ) Change subject: soc/intel/mtl: Set slp-s0 counter frequency ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78277/comment/e1c03efa_71983505 : PS1, Line 458: 8197 > nit: ~8. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/78277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e95cd69e941d4d72d5c36a07660ca07ee2499ba Gerrit-Change-Number: 78277 Gerrit-PatchSet: 1 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 17:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: enable WIFI_SAR for all variants
by Subrata Banik (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78308?usp=email ) Change subject: mb/google/rex: enable WIFI_SAR for all variants ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78308?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17709cb5d75b56c6c1f386ab527c5c8730011bed Gerrit-Change-Number: 78308 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 17:38:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m_pro: Drop useless early init code
by Patrick Rudolph (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Keith Hui, Paul Menzel, Vlado Cibic. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73693?usp=email ) Change subject: mb/asus/p8z77-m_pro: Drop useless early init code ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304fc1610740375b59121b6b8784122440795838 Gerrit-Change-Number: 73693 Gerrit-PatchSet: 8 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vlado Cibic Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 16:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: enable WIFI_SAR for all variants
by YH Lin (Code Review) 10 Oct '23

10 Oct '23

YH Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78308?usp=email ) Change subject: mb/google/rex: enable WIFI_SAR for all variants ...................................................................... mb/google/rex: enable WIFI_SAR for all variants Enabling support of WiFi SAR table for all rex variants by setting the option at baseboard level. BUG=b:290689824 TEST=emerge-rex coreboot Change-Id: I17709cb5d75b56c6c1f386ab527c5c8730011bed Signed-off-by: YH Lin <yueherngl(a)google.com> --- M src/mainboard/google/rex/Kconfig 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/78308/1 diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 23a21b3..2a540d6 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -45,11 +45,11 @@ select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 + select CHROMEOS_WIFI_SAR if CHROMEOS config BOARD_GOOGLE_MODEL_REX def_bool n select BOARD_GOOGLE_BASEBOARD_REX - select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_GENERIC_MAX98357A select DRIVERS_GENESYSLOGIC_GL9755 select DRIVERS_I2C_SX9324 @@ -68,7 +68,6 @@ config BOARD_GOOGLE_MODEL_SCREEBO def_bool n select BOARD_GOOGLE_BASEBOARD_REX - select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_GENERIC_ALC1015 select DRIVERS_GENESYSLOGIC_GL9750 select DRIVERS_GENESYSLOGIC_GL9750_INVERT_WP @@ -76,7 +75,6 @@ config BOARD_GOOGLE_MODEL_KARIS def_bool n select BOARD_GOOGLE_BASEBOARD_REX - select CHROMEOS_WIFI_SAR if CHROMEOS config BOARD_GOOGLE_BASEBOARD_OVIS def_bool n -- To view, visit https://review.coreboot.org/c/coreboot/+/78308?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17709cb5d75b56c6c1f386ab527c5c8730011bed Gerrit-Change-Number: 78308 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/amd/onyx: Use BMC SOL by default
by Felix Held (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Arthur Heymans, Martin Roth, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76509?usp=email ) Change subject: mb/amd/onyx: Use BMC SOL by default ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76509?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefe61d25367bbe5cff0cacbfbafa32607de77d0f Gerrit-Change-Number: 76509 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 16:18:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/amd/onyx: use AMD SoC UART
by Felix Held (Code Review) 10 Oct '23

10 Oct '23

Attention is currently required from: Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78267?usp=email ) Change subject: mb/amd/onyx: use AMD SoC UART ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78267?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79ebbcc6a4a3a93e8437ef56aebdcf72f9a3e6ab Gerrit-Change-Number: 78267 Gerrit-PatchSet: 8 Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 16:18:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023