coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: soc/amd/genoa/include/data_fabric: add VGA decode enable register
by Felix Held (Code Review) 12 Oct '23

12 Oct '23

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78319?usp=email ) Change subject: soc/amd/genoa/include/data_fabric: add VGA decode enable register ...................................................................... soc/amd/genoa/include/data_fabric: add VGA decode enable register Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Iaf4a1fd61ad1d545b1ea0ab3fcf6c7a3d0260cd0 --- M src/soc/amd/genoa/include/soc/data_fabric.h 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/78319/1 diff --git a/src/soc/amd/genoa/include/soc/data_fabric.h b/src/soc/amd/genoa/include/soc/data_fabric.h index 6388926..02c639a 100644 --- a/src/soc/amd/genoa/include/soc/data_fabric.h +++ b/src/soc/amd/genoa/include/soc/data_fabric.h @@ -6,6 +6,20 @@ #include <amdblocks/data_fabric_defs.h> #include <types.h> +#define DF_VGA_EN DF_REG_ID(0, 0xc08) + +union df_vga_en { + struct { + uint32_t ve : 1; /* [ 0.. 0] */ + uint32_t np : 1; /* [ 1.. 1] */ + uint32_t cpu_dis : 1; /* [ 2.. 2] */ + uint32_t : 1; /* [ 3.. 3] */ + uint32_t dst_fabric_id : 12; /* [ 4..15] */ + uint32_t : 16; /* [16..31] */ + }; + uint32_t raw; +}; + #define DF_PCI_CFG_BASE0 DF_REG_ID(0, 0xc80) #define DF_PCI_CFG_LIMIT0 DF_REG_ID(0, 0xc84) -- To view, visit https://review.coreboot.org/c/coreboot/+/78319?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf4a1fd61ad1d545b1ea0ab3fcf6c7a3d0260cd0 Gerrit-Change-Number: 78319 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Nick Vaccaro (Code Review) 12 Oct '23

12 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email ) Change subject: mb/google/brox: Create new Brox baseboard ...................................................................... Patch Set 9: (3 comments) File src/mainboard/google/brox/Kconfig: https://review.coreboot.org/c/coreboot/+/78009/comment/0ada8122_25ee4ef2 : PS9, Line 84: BOARD_GOOGLE_BASEBOARD_HADES You can get rid of checks for hades, hades has been deprecated and wouldn't be part of the brox family anyway. https://review.coreboot.org/c/coreboot/+/78009/comment/0e1003c9_05546083 : PS9, Line 85: BOARD_GOOGLE_BASEBOARD_HADES same https://review.coreboot.org/c/coreboot/+/78009/comment/839ee8ec_e8f1919b : PS9, Line 154: BOARD_GOOGLE_PIRRHA Is pirrha a Brox variant? If not, this check should be deleted. -- To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Gerrit-Change-Number: 78009 Gerrit-PatchSet: 9 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 22:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Shelley Chen (Code Review) 12 Oct '23

12 Oct '23

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Shelley Chen (Code Review) 12 Oct '23

12 Oct '23

Attention is currently required from: Paul Menzel, Shelley Chen. Hello Nick Vaccaro, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78009?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brox: Create new Brox baseboard ...................................................................... mb/google/brox: Create new Brox baseboard This CL is just getting the initial brox framework to get the baseboard building. Copied files from brask baseboard and tried to remove contents of some files like the device tree and memory IDs. BUG=b:300690448 BRANCH=None TEST=./util/abuild/abuild -p none -t GOOGLE_BROX -x -a Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Signed-off-by: Shelley Chen <shchen(a)google.com> --- A src/mainboard/google/brox/Kconfig A src/mainboard/google/brox/Kconfig.name A src/mainboard/google/brox/Makefile.inc A src/mainboard/google/brox/acpi/gps.asl A src/mainboard/google/brox/acpi/gpu_defines.h A src/mainboard/google/brox/acpi/gpu_ec.asl A src/mainboard/google/brox/acpi/gpu_top.asl A src/mainboard/google/brox/acpi/nbci.asl A src/mainboard/google/brox/acpi/nvjt.asl A src/mainboard/google/brox/acpi/nvop.asl A src/mainboard/google/brox/acpi/nvpcf.asl A src/mainboard/google/brox/acpi/peg.asl A src/mainboard/google/brox/acpi/power.asl A src/mainboard/google/brox/acpi/utility.asl A src/mainboard/google/brox/board_info.txt A src/mainboard/google/brox/bootblock.c A src/mainboard/google/brox/chromeos.c A src/mainboard/google/brox/chromeos.fmd A src/mainboard/google/brox/dsdt.asl A src/mainboard/google/brox/ec.c A src/mainboard/google/brox/mainboard.c A src/mainboard/google/brox/romstage.c A src/mainboard/google/brox/smihandler.c A src/mainboard/google/brox/spd/Makefile.inc A src/mainboard/google/brox/variants/baseboard/brox/Makefile.inc A src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb A src/mainboard/google/brox/variants/baseboard/brox/gma-mainboard.ads A src/mainboard/google/brox/variants/baseboard/brox/gpio.c A src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h A src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h A src/mainboard/google/brox/variants/baseboard/brox/memory.c A src/mainboard/google/brox/variants/baseboard/brox/ramstage.c A src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h A src/mainboard/google/brox/variants/brox/Makefile.inc A src/mainboard/google/brox/variants/brox/data.vbt A src/mainboard/google/brox/variants/brox/fw_config.c A src/mainboard/google/brox/variants/brox/gpio.c A src/mainboard/google/brox/variants/brox/include/variant/ec.h A src/mainboard/google/brox/variants/brox/include/variant/gpio.h A src/mainboard/google/brox/variants/brox/memory/Makefile.inc A src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt A src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt A src/mainboard/google/brox/variants/brox/overridetree.cb A src/mainboard/google/brox/variants/brox/ramstage.c A src/mainboard/google/brox/variants/brox/variant.c A src/mainboard/google/brox/wwan_power.asl 46 files changed, 2,855 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/78009/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Gerrit-Change-Number: 78009 Gerrit-PatchSet: 10 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: configurable slp-s0 residency counter frequency in LPIT table
by Paul Menzel (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Lance Zhao, Subrata Banik, Sukumar Ghorai, Tarun, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78164?usp=email ) Change subject: configurable slp-s0 residency counter frequency in LPIT table ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78164/comment/f666b374_2bf36c3e : PS14, Line 7: configurable slp-s0 residency counter frequency in LPIT table > Acknowledged Not solved yet. -- To view, visit https://review.coreboot.org/c/coreboot/+/78164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I401dd4a09a67d81a9ea3a56cd22f1a681e2a9349 Gerrit-Change-Number: 78164 Gerrit-PatchSet: 15 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 21:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Nick Vaccaro (Code Review) 11 Oct '23

11 Oct '23

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Shelley Chen (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email ) Change subject: mb/google/brox: Create new Brox baseboard ...................................................................... Patch Set 9: (3 comments) File src/mainboard/google/brox/variants/brox/memory/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78009/comment/73d75331_11c982ba : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : SPD_SOURCES = : SPD_SOURCES += spd/lp5/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B > Please see and use https://chromium-review.googlesource. […] generated with ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt: https://review.coreboot.org/c/coreboot/+/78009/comment/7809a186_36644f55 : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : DRAM Part Name ID to assign > Please see and use https://chromium-review.googlesource. […] Ok, I see what you are getting at now. It's now generated with ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt File src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt: PS8: > Please see and use https://chromium-review.googlesource. […] generated with ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt -- To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Gerrit-Change-Number: 78009 Gerrit-PatchSet: 9 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 21:22:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Shelley Chen (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Paul Menzel, Shelley Chen. Hello Nick Vaccaro, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78009?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brox: Create new Brox baseboard ...................................................................... mb/google/brox: Create new Brox baseboard This CL is just getting the initial brox framework to get the baseboard building. Copied files from brask baseboard and tried to remove contents of some files like the device tree and memory IDs. BUG=b:300690448 BRANCH=None TEST=./util/abuild/abuild -p none -t GOOGLE_BROX -x -a Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Signed-off-by: Shelley Chen <shchen(a)google.com> --- A src/mainboard/google/brox/Kconfig A src/mainboard/google/brox/Kconfig.name A src/mainboard/google/brox/Makefile.inc A src/mainboard/google/brox/acpi/gps.asl A src/mainboard/google/brox/acpi/gpu_defines.h A src/mainboard/google/brox/acpi/gpu_ec.asl A src/mainboard/google/brox/acpi/gpu_top.asl A src/mainboard/google/brox/acpi/nbci.asl A src/mainboard/google/brox/acpi/nvjt.asl A src/mainboard/google/brox/acpi/nvop.asl A src/mainboard/google/brox/acpi/nvpcf.asl A src/mainboard/google/brox/acpi/peg.asl A src/mainboard/google/brox/acpi/power.asl A src/mainboard/google/brox/acpi/utility.asl A src/mainboard/google/brox/board_info.txt A src/mainboard/google/brox/bootblock.c A src/mainboard/google/brox/chromeos.c A src/mainboard/google/brox/chromeos.fmd A src/mainboard/google/brox/dsdt.asl A src/mainboard/google/brox/ec.c A src/mainboard/google/brox/mainboard.c A src/mainboard/google/brox/romstage.c A src/mainboard/google/brox/smihandler.c A src/mainboard/google/brox/spd/Makefile.inc A src/mainboard/google/brox/variants/baseboard/brox/Makefile.inc A src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb A src/mainboard/google/brox/variants/baseboard/brox/gma-mainboard.ads A src/mainboard/google/brox/variants/baseboard/brox/gpio.c A src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h A src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h A src/mainboard/google/brox/variants/baseboard/brox/memory.c A src/mainboard/google/brox/variants/baseboard/brox/ramstage.c A src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h A src/mainboard/google/brox/variants/brox/Makefile.inc A src/mainboard/google/brox/variants/brox/data.vbt A src/mainboard/google/brox/variants/brox/fw_config.c A src/mainboard/google/brox/variants/brox/gpio.c A src/mainboard/google/brox/variants/brox/include/variant/ec.h A src/mainboard/google/brox/variants/brox/include/variant/gpio.h A src/mainboard/google/brox/variants/brox/memory/Makefile.inc A src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt A src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt A src/mainboard/google/brox/variants/brox/overridetree.cb A src/mainboard/google/brox/variants/brox/ramstage.c A src/mainboard/google/brox/variants/brox/variant.c A src/mainboard/google/brox/wwan_power.asl 46 files changed, 2,855 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/78009/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Gerrit-Change-Number: 78009 Gerrit-PatchSet: 9 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/system76/tgl-u: galp5: Enable DRIVERS_GENERIC_BAYHUB_LV2
by Tim Crawford (Code Review) 11 Oct '23

11 Oct '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78298?usp=email ) Change subject: mb/system76/tgl-u: galp5: Enable DRIVERS_GENERIC_BAYHUB_LV2 ...................................................................... mb/system76/tgl-u: galp5: Enable DRIVERS_GENERIC_BAYHUB_LV2 The 3060 variant of the galp5 uses the OZ711LV2. Enable the driver to fix LTR programming, as was done for other models in commit 3d7a5bdf58e0 ("mb/system76: Enable DRIVERS_GENERIC_BAYHUB_LV2 to fix LTR issue"). Tested on system76/galp5 with a 3060: CPU reaches C-states deeper than C2 when idle. Change-Id: I3667e08acd23c12638159a2f7d2592737a34e63d Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/tgl-u/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/78298/1 diff --git a/src/mainboard/system76/tgl-u/Kconfig b/src/mainboard/system76/tgl-u/Kconfig index 927f130..5acec55 100644 --- a/src/mainboard/system76/tgl-u/Kconfig +++ b/src/mainboard/system76/tgl-u/Kconfig @@ -3,6 +3,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_BAYHUB_LV2 if BOARD_SYSTEM76_GALP5 select DRIVERS_GENERIC_CBFS_SERIAL select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID -- To view, visit https://review.coreboot.org/c/coreboot/+/78298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3667e08acd23c12638159a2f7d2592737a34e63d Gerrit-Change-Number: 78298 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Nick Vaccaro (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Paul Menzel, Shelley Chen. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email ) Change subject: mb/google/brox: Create new Brox baseboard ...................................................................... Patch Set 8: (4 comments) File src/mainboard/google/brox/variants/brox/memory/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78009/comment/56968d53_6b58af81 : PS5, Line 7: SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:F, H9HCNNNBKMMLXR-NEE, MT53E512M32D1NP-046 WT:B : SPD_SOURCES += spd/lp4x/set-0/spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A : SPD_SOURCES += spd/lp4x/set-0/spd-7.hex # ID = 2(0b0010) Parts = MT53E2G32D4NQ-046 WT:A, MT53E2G32D4NQ-046 WT:C : SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 3(0b0011) Parts = H9HCNNNCPMMLXR-NEE, MT53E1G32D2NP-046 WT:B : Remove File src/mainboard/google/brox/variants/brox/memory/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78009/comment/f64659d0_8f212732 : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : SPD_SOURCES = : SPD_SOURCES += spd/lp5/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B Please see and use https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt: https://review.coreboot.org/c/coreboot/+/78009/comment/37003c61_47e237b6 : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : DRAM Part Name ID to assign Please see and use https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… File src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt: PS8: Please see and use https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… -- To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Gerrit-Change-Number: 78009 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 11 Oct 2023 20:47:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023