coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[M] Change in coreboot[main]: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution
by Jay Patel (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Bernardo Perez Priego, Brandon Breitenstein, Paul Menzel, Tanu Malhotra, Vijay P Hiremath. Hello Bernardo Perez Priego, Brandon Breitenstein, Tanu Malhotra, Vijay P Hiremath, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78282?usp=email to look at the new patch set (#3). Change subject: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution ...................................................................... mb/intel/mtlrvp: Add new MTL-P board variant for PD solution This patch adds new board variant to enable PD chip based type-C solution for MTL-RVP. Type-C related devicetree code reshuffled since the mtlrvp_pd variant supports 2 type-C ports while the other variants support 4. BUG=b:303839908 BRANCH=none TEST=check if you can observe MTLRVP PD solution option as part of make menuconfig. Able to boot to ChromeOS with PD solution. Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Signed-off-by: Jay Patel <jay2.patel(a)intel.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb A src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb 6 files changed, 76 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/78282/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Gerrit-Change-Number: 78282 Gerrit-PatchSet: 3 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Attention: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/amd/*/Kconfig: rework SPL options
by Felix Held (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78309?usp=email ) Change subject: soc/amd/*/Kconfig: rework SPL options ...................................................................... Patch Set 4: (1 comment) File src/soc/amd/common/block/psp/Kconfig: https://review.coreboot.org/c/coreboot/+/78309/comment/67617239_9bd05d95 : PS3, Line 40: SOC_AMD_COMMON_BLOCK_PSP_PERFORM_SPL_FUSING > i'd say that the ones below are the inconsistent ones, but i wasn't 100% sure if the config files in […] pushed a new patchset that changes this -- To view, visit https://review.coreboot.org/c/coreboot/+/78309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I12fd8775db66f16fe632674cd67c6af483e8d4e2 Gerrit-Change-Number: 78309 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 17:29:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/amd/*/Kconfig: rework SPL options
by Felix Held (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78309?usp=email ) Change subject: soc/amd/*/Kconfig: rework SPL options ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I12fd8775db66f16fe632674cd67c6af483e8d4e2 Gerrit-Change-Number: 78309 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 17:27:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard
by Shelley Chen (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Nick Vaccaro, Paul Menzel. Hello Nick Vaccaro, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78009?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brox: Create new Brox baseboard ...................................................................... mb/google/brox: Create new Brox baseboard This CL is just getting the initial brox framework to get the baseboard building. Copied files from brask baseboard and tried to remove contents of some files like the device tree and memory IDs. BUG=b:300690448 BRANCH=None TEST=./util/abuild/abuild -p none -t GOOGLE_BROX -x -a Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Signed-off-by: Shelley Chen <shchen(a)google.com> --- A src/mainboard/google/brox/Kconfig A src/mainboard/google/brox/Kconfig.name A src/mainboard/google/brox/Makefile.inc A src/mainboard/google/brox/acpi/gps.asl A src/mainboard/google/brox/acpi/gpu_defines.h A src/mainboard/google/brox/acpi/gpu_ec.asl A src/mainboard/google/brox/acpi/gpu_top.asl A src/mainboard/google/brox/acpi/nbci.asl A src/mainboard/google/brox/acpi/nvjt.asl A src/mainboard/google/brox/acpi/nvop.asl A src/mainboard/google/brox/acpi/nvpcf.asl A src/mainboard/google/brox/acpi/peg.asl A src/mainboard/google/brox/acpi/power.asl A src/mainboard/google/brox/acpi/utility.asl A src/mainboard/google/brox/board_info.txt A src/mainboard/google/brox/bootblock.c A src/mainboard/google/brox/chromeos.c A src/mainboard/google/brox/chromeos.fmd A src/mainboard/google/brox/dsdt.asl A src/mainboard/google/brox/ec.c A src/mainboard/google/brox/mainboard.c A src/mainboard/google/brox/romstage.c A src/mainboard/google/brox/smihandler.c A src/mainboard/google/brox/spd/Makefile.inc A src/mainboard/google/brox/variants/baseboard/brox/Makefile.inc A src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb A src/mainboard/google/brox/variants/baseboard/brox/gma-mainboard.ads A src/mainboard/google/brox/variants/baseboard/brox/gpio.c A src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h A src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h A src/mainboard/google/brox/variants/baseboard/brox/memory.c A src/mainboard/google/brox/variants/baseboard/brox/ramstage.c A src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h A src/mainboard/google/brox/variants/brox/Makefile.inc A src/mainboard/google/brox/variants/brox/data.vbt A src/mainboard/google/brox/variants/brox/fw_config.c A src/mainboard/google/brox/variants/brox/gpio.c A src/mainboard/google/brox/variants/brox/include/variant/ec.h A src/mainboard/google/brox/variants/brox/include/variant/gpio.h A src/mainboard/google/brox/variants/brox/memory/Makefile.inc A src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt A src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt A src/mainboard/google/brox/variants/brox/overridetree.cb A src/mainboard/google/brox/variants/brox/ramstage.c A src/mainboard/google/brox/variants/brox/variant.c A src/mainboard/google/brox/wwan_power.asl 46 files changed, 2,853 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/78009/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98 Gerrit-Change-Number: 78009 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution
by Jay Patel (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Paul Menzel, Tanu Malhotra, Vijay P Hiremath. Jay Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78282?usp=email ) Change subject: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78282/comment/6c193b4c_9af242cc : PS1, Line 9: will add > adds Done https://review.coreboot.org/c/coreboot/+/78282/comment/8b1de9ee_164e6152 : PS1, Line 14: solutin > solution Done https://review.coreboot.org/c/coreboot/+/78282/comment/e3d04d47_9b725c4c : PS1, Line 14: solutin option > One space. Done File src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78282/comment/58207fe7_9be79815 : PS1, Line 248: end > Please mention in the commit message that the code hunk is moved. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Gerrit-Change-Number: 78282 Gerrit-PatchSet: 2 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Attention: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 11 Oct 2023 16:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution
by Jay Patel (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Jay Patel, Tanu Malhotra, Vijay P Hiremath. Hello Tanu Malhotra, Vijay P Hiremath, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78282?usp=email to look at the new patch set (#2). Change subject: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution ...................................................................... mb/intel/mtlrvp: Add new MTL-P board variant for PD solution This patch adds new board variant to enable PD chip based type-C solution for MTL-RVP. For common use amongst variants, type-C related devicetree code reshuffled. BUG=b:303839908 BRANCH=none TEST=check if you can observe MTLRVP PD solution option as part of make menuconfig. Able to boot to ChromeOS with PD solution. Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Signed-off-by: Jay Patel <jay2.patel(a)intel.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb A src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb 6 files changed, 76 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/78282/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Gerrit-Change-Number: 78282 Gerrit-PatchSet: 2 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Attention: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: AUTHORS: Update Authors list from original to 4.21 release
by Matt DeVillier (Code Review) 11 Oct '23

11 Oct '23

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78286?usp=email ) Change subject: AUTHORS: Update Authors list from original to 4.21 release ...................................................................... AUTHORS: Update Authors list from original to 4.21 release This commit adds all the individual authors and their companies, as determined by their email addresses. Because it is very difficult to figure out if an individual is doing work on their own, or on the company's behalf, both are being added. This will be maintained as a part of the release process from here on. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id199f1c5d49d74290002d46dbdfc1d33b0fb55e5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78286 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M AUTHORS 1 file changed, 545 insertions(+), 7 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified diff --git a/AUTHORS b/AUTHORS index 169d2b4..d135a6a 100644 --- a/AUTHORS +++ b/AUTHORS @@ -10,73 +10,212 @@ 3mdeb Embedded Systems Consulting 9elements Agency GmbH +Aamir Bohra +Aaron Durbin +Abe Levkoy +Abel Briggs Abhinav Hardikar +AdaCore +Adam Liu +Adam Mills Advanced Computing Lab, LANL Advanced Micro Devices, Inc. -AdaCore AG Electronics Ltd. +Ahamed Husni +Akshu Agrawal +Al Hirani +Alan Huang +AlanKY Lee +Alec Wang +Alex James +Alex Levin +Alex Miao Alex Thiessen Alex Züpke +Alex1 Kao Alexander Couzens +Alexander Goncharov Alexandru Gagniuc +Alexey Buyanov +Alexey Vazhnov +Alice Sell +Allen-KH Cheng +Amanda Hwang +American Megatrends International, LLC +Amersel +Amit Caleechurn Analog Devices Inc. Analogix Semiconductor +Anand Mistry +Anand Vaikar Andre Heider +Andrew McRae +Andrew SH Cheng +Andrey Pronin Andriy Gapon Andy Fleming +Andy Pont +Andy-ld Lu Angel Pons +Anil Kumar K +Anna Karaś +Annie Chen Anton Kochkov +Ao Zhong +Arashk Mahshidfar +Arec Kao +Ariel Fang ARM Limited and Contributors Arthur Heymans Asami Doi +Aseda Aboagye +Ashish Kumar Mishra +Ashqti ASPEED Technology Inc. Atheros Corporation Atmel Corporation +Balaji Manigandan +Balázs Vinarz BAP - Bruhnspace Advanced Projects +Baruch Siach +Ben Chuang +Ben Kao +Ben McMillen +Ben Zhang +Benjamin Doron +Bernardo Perez Priego +Bhanu Prakash Maiya Bill Xie +Bin Meng Bitland Tech Inc. +Bob Moragues +Bora Guvendik Boris Barbulovski +Boris Mittelberg +Brandon Breitenstein +Brian Norris +Bryant Ou Carl-Daniel Hailfinger +Casper Chang +Caveh Jalali Cavium Inc. +Chao Gui +Chen-Tsung Hsieh +Chia-Ling Hou +Chien-Chih Tseng +Chris Wang +Christian Gmeiner +Christian Walter Christoph Grenz +Christopher Meis +Chuangwei Technology Co., Ltd +Chun-Jie Chen +Cirrus Logic, Inc. +CK HU +Clay Daniels +Cliff Huang Code Aurora Forum +Compal Electronics, Inc. +Cong Yang +CoolStar coresystems GmbH Corey Osgood Curt Brune +Curtis Chen Custom Ideas +Cyberus Technology GmbH +Da Lao +Daisuke Nojiri Damien Zammit +Dan Callaghan +Daniel Campello +Daniel Gröber +Daniel Kang +Daniel Maslowski +Daniel Peng +Daniel Rosa Franzini Dave Airlie David Brownell David Greenman David Hendricks +David Lin +David Milosevic David Mosberger-Tang David Mueller David S. Peterson +David Wu +Dawei Chien +Deepika Punyamurtula +Deepti Deshatty Denis 'GNUtoo' Carikli Denis Dowling DENX Software Engineering +Deomid 'rojer' Ryabkov +Derek Basehore +Derek Huang Derek Waldner Digital Design Corporation +Dinesh Gehlot +Divya S Sasidharan +Dmitry Ponamorev +Dmitry Torokhov DMP Electronics Inc. +Dominik Behr Donghwa Lee Drew Eckhardt +Dtrain Hsu +Duan Huayang +Dun Tan +Duncan Laurie Dynon Avionics +Ed Sharma +Eddy Lu +Edward Hill Edward O'Callaghan +Edward-JW Yang Egbert Eich +Elias Souza +Eloy Degen ELSOFT AG Eltan B.V +Eltan B.V. Elyes Haouas +Eran Mitrani Eric Biederman +Eric Lai +Eric Peers +EricKY Cheng +EricR Lai +Erik van den Bogaert Eswar Nallusamy +Ethan Tsao +Eugene Myers +Evan Green Evgeny Zinoviev +Fabian Groffen Fabian Kunkel +Fabio Aiuto Fabrice Bellard Facebook, Inc. +Felix Friedlander Felix Held Felix Singer +Fengquan Chen +Flora Fu +Florian Laufenböck +Francois Toguo Fotso +Frank Chu +Frank Wu +Franklin Lin +Frans Hendriks +Fred Reitberger Frederic Potter Free Software Foundation, Inc. Freescale Semiconductor, Inc. +Furquan Shaikh +Gaggery Tsai +Gang C Chen +Garmin Chang Gary Jennejohn George Trudeau Gerald Van Baren @@ -84,164 +223,563 @@ Gergely Kiss Google LLC Greg Watson +Grzegorz Bernacki Guennadi Liakhovetski +Guodong Liu +Gwendal Grignou Hal Martin +Hao Chou +Hao Wang HardenedLinux -Hewlett-Packard Development Company, L.P. +Harsha B R +Harshit Sharma +Henry C Chen Hewlett Packard Enterprise Development LP +Hewlett-Packard Development Company, L.P. +Himanshu Sahdev +Housong Zhang +Hsiao Chien Sung +Hsin-hsiung wang +Hsin-Te Yuan +Hsuan Ting Chen +Huaqin Technology Co., Ltd Huaqin Telecom Inc. +Hui Liu +Huijuan Xie +Hung-Te Lin +Ian Douglas Scott +Ian Feng IBM Corporation Idwer Vollering +Igor Bagnucki Igor Pavlov +Ikjoon Jang Imagination Technologies Infineon Technologies InKi Dae +INSPUR Co., Ltd Intel Corporation +Inventec Corp Iru Cai +Isaac Lee Isaku Yamahata +Ivan Chen Ivan Vatlin +Ivy Jian +Jack Rosenthal +Jacob Garber +Jairaj Arava +Jakub Czapiga +James Chao +James Lo James Ye +Jamie Chen +Jamie Ryu +Jan Dabros +Jan Samek +Jan Tatje +Jason Glenesk +Jason Nein +Jason V Le +Jason Z Chen Jason Zhao +jason-ch chen +Jason-jh Lin +Jay Patel +Jeff Chase +Jeff Daly +Jeff Li +Jérémy Compostella +Jeremy Soller +Jes Klinke +Jesper Lin +Jessy Jiang +Jett Rink +Jg Daolongzhu +Jian Tong +Jianeng Ceng +Jianjun Wang +Jim Lai +Jimmy Su +Jincheng Li +Jingle Hsu +Jitao Shi Joe Pillow +Joe Tessler +Joel Kitching +Joey Peng Johanna Schander +John Su +John Zhao +Johnny Li +Johnny Lin +johnson wang +Jon Murphy Jonas 'Sortie' Termansen +Jonas Loeffelholz Jonathan A. Kollasch Jonathan Neuschäfer +Jonathan Zhang +Jonathon Hall Jordan Crouse Jörg Mische Joseph Smith +Josie Nordrum +Julia Tsai +Julian Schroeder +Julian Stecklina +Julien Viard de Galbert +Julius Werner +Kacper Stojek +Kaiyen Chang +Kane Chen +Kangheui Won +Kapil Porwal +Karol Zmyslowski +Karthik Ramasubramanian Keith Hui Keith Packard +Kenneth Chan +Kevin Chang +Kevin Cheng +Kevin Chiu +Kevin Chowski Kevin Cody-Little +Kevin Keijzer Kevin O'Connor +Kevin3 Yang +kewei xu +Kilari Raasi +Kirk Wang +Konrad Adamczyk Kontron Europe GmbH +Kornel Dulęba +Krishna P Bhat D +Krystian Hebel Kshitij +Kshitiz Godara +Kulkarni. Srinivas +Kun Liu +Kyle Lin Kyösti Mälkki +Lance Zhao +Lawrence Chang Leah Rowe +Lean Sheng Tan Lei Wen +Lenovo Group Ltd +Leo Chou Li-Ta Lo +Liam Flaherty Libra Li Libretrend LDA +Lijian Zhao +Liju-Clr Chen Linaro Limited +linear Linus Torvalds Linux Networx, Inc. LiPPERT ADLINK Technology GmbH +Liya Li Lubomir Rintel Luc Verhaegen +Lucas Chen +Mac Chiang Maciej Matuszczyk +Maciej Pijanowski +Macpaul Lin +Madhusudanarao Amara +Magf +Malik Hsu +Mandy Liu +Manoj Gupta Marc Bertens Marc Jones +Marco Chen +Marek Kasiewicz Marek Vasut +Mario Scheithauer Marius Gröger +Mariusz Szafranski +Mariusz Szafrański +Mark Hasemeyer +Mark Hsieh +Mars Chen +Marshall Dawson Martin Mares Martin Renters Martin Roth Marvell International Ltd. Marvell Semiconductor Inc. +Marx Wang +Masanori Ogino +Máté Kukri +Matei Dibu +Mathew King +Matt Chen +Matt Delco Matt DeVillier +Matt Papageorge +Matthew Blecker +Matthew Ziegelbaum +Mattias Nissler +Maulik V Vaghela +MAULIK V VAGHELA +Maulik Vaghela +Max Fritz Maxim Polyakov +Maximilian Brune +Mediatek Inc. MediaTek Inc. +Meera Ravindranath +Meng-Huan Yu +Meta Platforms, Inc +mgabryelski1 +Mice Lin Michael Brunner -Michael Schroeder +Michael Büchler Michael Niewöhner +Michael Schroeder +Michael Strosche +Michael Walle +Michał Kopeć +Michal Suchanek +Michał Żygowski +Micro-Star INT'L CO., LTD. Mika Westerberg +Mike Banon +Mike Shih +Miriam Polzer +mkurumel +Moises Garcia Mondrian Nuessle +Monikaanan MontaVista Software, Inc. +Morgan Jang +Moritz Fischer +Morris Hsu +mtk15698 +mturney mturney +Musse Abdullahi Myles Watson +Nancy.Lin +Naresh Solanki +Nathan Lu +Neill Corlett Network Appliance Inc. +Nicholas Chin Nicholas Sielicki Nick Barker +Nick Chen +Nick Vaccaro Nico Huber Nico Rikken Nicola Corna +Nicolas Boichat +Nicole Faerber +Nikolai Vyssotski Nils Jacobs +Nina Wu Nir Tzachar Nokia Corporation +Nuvoton Technology Corporation NVIDIA Corporation Olivier Langlois Ollie Lo Omar Pakker Online SAS +Opal Voravootivat Orion Technologies, LLC +Pablo Ceballos +Pablo Stebler +Pan Gao Patrick Georgi +Patrick Huang Patrick Rudolph +Patrik Tesarik Pattrick Hueper +Paul Fagerburg +Paul Menzel +Paul2 Huang Paulo Alcantara Pavel Sayekat +Paz Zcharya PC Engines GmbH +Pegatron Corp +Peichao Li Per Odlund Peter Korsgaard +Peter Lemenkov +Peter Marheine Peter Stuge +Petr Cvek +Philip Chen +Philipp Bartsch Philipp Degler Philipp Deppenwiese Philipp Hug +Piotr Kleinschmidt +Po Xu +Prasad Malisetty +Prashant Malani +Pratik Vishwakarma +Pratikkumar Prajapati +Pratikkumar V Prajapati Protectli Purism SPC -Qualcomm Technologies +Purism, SPC +Qii Wang +Qualcomm Technologies, Inc. +Quanta Computer INC +Raihow Shi +Rajat Jain +Rajesh Patil Raptor Engineering, LLC +Rasheed Hsueh +Raul Rangel +Ravi Kumar +Ravi Mistry +Ravindra +Ravishankar Sarawadi +Ray Han Lim Ng +Raymond Chung Red Hat, Inc +ReddestDream +Rehan Ghori Reinhard Meyer +Reka Norman +Ren Kuo Renze Nicolai +Reto Buerki +Rex Chou +Rex-BC Chen +Ricardo Quesada +Ricardo Ribalda Richard Spiegel Richard Woodruff +Rick Lee +Ricky Chang +Riku Viitanen +Ritul Guru +Rizwan Qureshi +Rnhmjoj +Rob Barnes Rob Landley +Robert Chen Robert Reeves +Robert Zieba Robinson P. Tryon Rockchip, Inc. +Rocky Phagura +Roger Lu +Roja Rani Yarubandi Romain Lievin Roman Zippel +Ron Lee +Ron Minnich +Ronak Kanabar Ronald G. Minnich +Rory Liu Rudolf Marek +Rui Zhou +Ruihai Zhou +Runyang Chen Russell King Ruud Schramp +Ruwen Liu +Ryan Chuang +Ryan Lin Sage Electronic Engineering, LLC +Sajida Bhanu +Sam Lewis +Sam McNally Sam Ravnborg Samsung Electronics Samuel Holland +Sandeep Maheswaram +Sathya Prakash M R +Satya Priya Kakitapalli +Saurabh Mishra SciTech Software, Inc. -Sebastian Grzywna +Scott Chao +SDC Systems Ltd +Sean Rhodes +Sebastian 'Swift Geek' Grzywna secunet Security Networks AG +Selma Bensaid +Semihalf +Sen Chu Sencore Inc Sergej Ivanov +Sergii Dmytruk +Serin Yeh +Seven Lee +SH Kim +Shahina Shaik +Shaocheng Wang +Shaoming Chen +Shaunak Saha +Shelley Chen +Shelly Chang +Sheng-Liang Pan +Shiyu Sun +Shon Wang +Shou-Chieh Hsu +Shreesh Chhabbi +Shuo Liu Siemens AG SiFive, Inc +Silicom Ltd. Silicon Integrated System Corporation Silverback Ltd. +Simon Glass +Simon Yang +Simon Zhou +Sindhoor Tilak +Solomon Alan-Dei +Song Fan +Sridhar Siricilla +Srinidhi N Kaushik +Srinivasa Rao Mandadapu +ST Microelectronics +Stanley Wu +Star Labs Online Ltd +Stefan Binding +Stefan Ott Stefan Reinauer Stefan Tauner +Stephen Edworthy Steve Magnani Steve Shenton -ST Microelectronics +Subrata Banik +Sudheer Amrabadi +Sugnan Prabhu S +Sukumar Ghorai +Sumeet R Pawnikar +Sunwei Li SUSE LINUX AG Sven Schnelle Syed Mohammed Khasim -System76 +System76, Inc. +szarpaj +T Michael Turney +TangYiwei +Taniya Das +Tao Xia +Tarun Tuli +Teddy Shih +Terry Chen Texas Instruments The Android Open Source Project The ChromiumOS Authors The Linux Foundation The Regents of the University of California +Thejaswani Putta +Thomas Heijligen Thomas Winischhofer +Tim Chen +Tim Chu +Tim Crawford +Tim Van Patten +Tim Wawrzynczak +Timofey Komarov Timothy Pearson +tinghan shen Tobias Diedrich +Tom Hiller +Tommie Lin +Tony Huang +Tracy Wu +Trevor Wu Tristan Corrick Tungsten Graphics, Inc. Tyan Computer Corp. +Tyler Wang +Tzung-Bi Shih +U.S. National Security Agency ucRobotics Inc. +Uday Bhat University of Heidelberg +Usha P Uwe Hermann +Uwe Poeche +V Sowmya +Václav Straka +Vadim Bendebury +Van Chen +Varshit B Pandya +Veerabhadrarao Badiganti +Venkat Thogaru +Venkata Krishna Nimmagadda VIA Technologies, Inc +Victor Ding +Vidya Gopalakrishnan Vikram Narayanan +Vikrant L Jadeja +Vinod Polimera Vipin Kumar +Vitaly Rodionov Vladimir Serbinenko Vlado Cibic +Vsujithk Wang Qing Pei +Wanghao11 Ward Vandewege +Wayne Wang +Weimin Wu +Weiyi Lu +Wenbin Mei +Wentao Qin +Werner Zeh Wilbert Duijvenvoorde +William Wei +Wilson Chou +Wim Vervoorn Win Enterprises +Wisley Chen +Wistron Corp Wiwynn Corp. +Wiwynn Corporation +Wizard Shen +Wojciech Macek Wolfgang Denk +Won Chung +Wonkyu Kim +Wuxy +Xin Ji +Xixi Chen +Xuxin Xiong YADRO +Yan Liu Yann Collet +Yaroslav Kurlaev +YH Lin +Yidi Lin +Yilin Yang Yinghai Lu +Yolk Shih +Yong Zhi +Yongkun Yu +Yongqiang Niu +Yu-hsuan Hsu +Yu-Ping Wu +Yuanliding +Yuchen He +Yuchen Huang +Yunlong Jia Zachary Yedidia +Zanxi Chen +Zhanyong Wang +Zheng Bao +Zhenguo Li +Zhi7 Li +Zhiqiang Ma +Zhixing Ma +Zhiyong Tao +zhongtian wu +Zhuohao Lee +Ziang Wang +Zoey Wu +Zoltan Baldaszti +小田喜陽彦 +陳建宏 \ No newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/78286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id199f1c5d49d74290002d46dbdfc1d33b0fb55e5 Gerrit-Change-Number: 78286 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Remove `SAGV_POINTS_0_1_2` workaround
by Kapil Porwal (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Eran Mitrani, Haikun Zhou, Kane Chen, Subrata Banik, Tarun, Wentao Qin. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78316?usp=email ) Change subject: mb/google/rex/var/screebo: Remove `SAGV_POINTS_0_1_2` workaround ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3fad845d8c9ace30eb1719f6ff35bc63a4e25404 Gerrit-Change-Number: 78316 Gerrit-PatchSet: 1 Gerrit-Owner: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Mike Lee <mike5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 15:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: amdfwtool: Move code related to getting options to a new file
by Bao Zheng (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Zheng Bao. Hello Zheng Bao, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78311?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: amdfwtool: Move code related to getting options to a new file ...................................................................... amdfwtool: Move code related to getting options to a new file Cleanup the messy code. The code left in main is all about filling tables. To help to do this, 1. Some local variables are put into global struct. 2. Add some functions. Set some functions to global. TEST=Identical test on all AMD platforms Change-Id: Ia25c3fd5de7ae48054359f0f6551d91d7a4f6828 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/Makefile M util/amdfwtool/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h A util/amdfwtool/opts.c 5 files changed, 797 insertions(+), 761 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/78311/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia25c3fd5de7ae48054359f0f6551d91d7a4f6828 Gerrit-Change-Number: 78311 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: configurable slp-s0 residency counter frequency in LPIT table
by Sukumar Ghorai (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Lance Zhao, Paul Menzel, Subrata Banik, Tarun, Tim Wawrzynczak. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78164?usp=email ) Change subject: configurable slp-s0 residency counter frequency in LPIT table ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78164/comment/b957d14a_048f0646 : PS14, Line 7: configurable slp-s0 residency counter frequency in LPIT table > Please make it a statement by adding a verb (in imperative mood). […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/78164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I401dd4a09a67d81a9ea3a56cd22f1a681e2a9349 Gerrit-Change-Number: 78164 Gerrit-PatchSet: 15 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 15:16:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023