coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3353 discussions

[S] Change in coreboot[main]: soc/intel/meteorlake: Adjust Power State Current 2 threshold
by Subrata Banik (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Eran Mitrani, Jérémy Compostella, Kapil Porwal, Shelley Chen, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78653?usp=email ) Change subject: soc/intel/meteorlake: Adjust Power State Current 2 threshold ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865 Gerrit-Change-Number: 78653 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 05:21:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/intel/gma/opregion: Use CBFS cache to load VBT
by Subrata Banik (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Arthur Heymans, Eran Mitrani, Jakub Czapiga, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77886?usp=email ) Change subject: drivers/intel/gma/opregion: Use CBFS cache to load VBT ...................................................................... Patch Set 32: (1 comment) File src/drivers/intel/gma/opregion.c: https://review.coreboot.org/c/coreboot/+/77886/comment/6a7d966e_3d0d514f : PS32, Line 48: data = NULL; : size = 0; can't we just `return NULL` from here ? -- To view, visit https://review.coreboot.org/c/coreboot/+/77886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e37e718a71bd85b0d7dee1efc4c0391798f16f7 Gerrit-Change-Number: 77886 Gerrit-PatchSet: 32 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 05:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Adjust Power State Current 2 threshold
by Sukumar Ghorai (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Eran Mitrani, Jérémy Compostella, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78653?usp=email ) Change subject: soc/intel/meteorlake: Adjust Power State Current 2 threshold ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: tested -- To view, visit https://review.coreboot.org/c/coreboot/+/78653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865 Gerrit-Change-Number: 78653 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 04:50:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/intel/gma/opregion: Use CBFS cache to load VBT
by Jérémy Compostella (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Arthur Heymans, Eran Mitrani, Jakub Czapiga, Julius Werner, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77886?usp=email ) Change subject: drivers/intel/gma/opregion: Use CBFS cache to load VBT ...................................................................... Patch Set 32: (1 comment) Patchset: PS32: @subrata, I was not fully satisfied with the error handling so I made a final change. -- To view, visit https://review.coreboot.org/c/coreboot/+/77886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e37e718a71bd85b0d7dee1efc4c0391798f16f7 Gerrit-Change-Number: 77886 Gerrit-PatchSet: 32 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 04:41:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/mendocino: Update FSP-S UPD to pass boot logo
by Matt DeVillier (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78817?usp=email ) Change subject: soc/amd/mendocino: Update FSP-S UPD to pass boot logo ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: tested working on frostflow with `HAVE_FSP_LOGO_SUPPORT` and locally-built FSP -- To view, visit https://review.coreboot.org/c/coreboot/+/78817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie522956b6dfe2400ef91d43c80f2adc6d52c8415 Gerrit-Change-Number: 78817 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 04:40:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Adjust Power State Current 2 threshold
by Jérémy Compostella (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78653?usp=email ) Change subject: soc/intel/meteorlake: Adjust Power State Current 2 threshold ...................................................................... Patch Set 3: (2 comments) File src/soc/intel/meteorlake/chip.h: https://review.coreboot.org/c/coreboot/+/78653/comment/d4af9902_3d76be50 : PS2, Line 291: power_state_current1_threshold > nit: ps_cur_1_threshold? Done File src/soc/intel/meteorlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/78653/comment/9cb5306d_bcb80457 : PS2, Line 243: power_state_current1_threshold > with ```ps_cur_1_threshold```, it can fit in the line above IMO Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865 Gerrit-Change-Number: 78653 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 04:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Adjust Power State Current 2 threshold
by Jérémy Compostella (Code Review) 31 Oct '23

31 Oct '23

Attention is currently required from: Eran Mitrani, Jérémy Compostella, Kapil Porwal, Shelley Chen, Tarun. Hello Eran Mitrani, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78653?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/meteorlake: Adjust Power State Current 2 threshold ...................................................................... soc/intel/meteorlake: Adjust Power State Current 2 threshold VccSA Power State 2 (PS2) current threshold has be adjusted to 10A to improve PS2 residency which reduces Voltage Regular (VR) power loss. BUG=b:308002192 TEST=power and performance analysis shows a positive Load Line result Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/chipset.cb M src/soc/intel/meteorlake/romstage/fsp_params.c 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/78653/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865 Gerrit-Change-Number: 78653 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/amd/mendocino: Ensure MP2 disable soft fuse bit set properly
by Matt DeVillier (Code Review) 31 Oct '23

31 Oct '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78823?usp=email ) Change subject: soc/amd/mendocino: Ensure MP2 disable soft fuse bit set properly ...................................................................... soc/amd/mendocino: Ensure MP2 disable soft fuse bit set properly Commit e728766f4596 ("soc/amd/mendocino: Do not load MP2 Firmware when in RO") added logic to ensure that the MP2 disable soft fuse bit was set for the RO section, but failed to check if the bit was already set otherwise (as it is for non-ChromeOS builds). This caused the bit to appear twice in the PSP_RO_SOFTFUSE_BITS string, and when the string was converted to a numeric value, bit (n+1) was set instead of n. To mitigate this, check that the common PSP_SOFTFUSE_BITS string doesn't already contain the MP2 disable bit before adding it to the RO-specific PSP_RO_SOFTFUSE_BITS one. TEST=build/boot google/skyrim (frostflow). Use a verbose build (V=1) to verify that the correct soft fuse value is passed to amdfwtool for RO and RW_A/B for both ChromeOS and non-ChromeOS builds. Change-Id: I2e207e20132d44016fbcb986bdfd8e935d8fead5 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/soc/amd/mendocino/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/78823/1 diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.inc index f123487..f99aab3 100644 --- a/src/soc/amd/mendocino/Makefile.inc +++ b/src/soc/amd/mendocino/Makefile.inc @@ -236,9 +236,11 @@ AMDFW_COMMON_ARGS += $(OPT_PSP_LOAD_MP2_FW) OPT_PSP_LOAD_MP2_FW = else -# Disable MP2 FW loading in VBOOT RO +# Disable MP2 FW loading in VBOOT RO if not already disabled +ifeq ($(findstring 29, $(PSP_SOFTFUSE_BITS)),) PSP_RO_SOFTFUSE_BITS += 29 endif +endif $(obj)/amdfw.rom: $(call strip_quotes, $(PSP_BIOSBIN_FILE)) \ $(PSP_VERSTAGE_FILE) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/78823?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e207e20132d44016fbcb986bdfd8e935d8fead5 Gerrit-Change-Number: 78823 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: [DONOTMERGE] Use local partial header
by Jérémy Compostella (Code Review) 31 Oct '23

31 Oct '23

Jérémy Compostella has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78793?usp=email ) Change subject: [DONOTMERGE] Use local partial header ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/78793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie13f389a21d53143167b3fba83aa792d089829d1 Gerrit-Change-Number: 78793 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: [DONOTMERGE] Use local partial header
by Jérémy Compostella (Code Review) 31 Oct '23

31 Oct '23

Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78793?usp=email ) Change subject: [DONOTMERGE] Use local partial header ...................................................................... [DONOTMERGE] Use local partial header Change-Id: Ie13f389a21d53143167b3fba83aa792d089829d1 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/78793/1 diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 05d7f70..5539f31 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -341,7 +341,7 @@ config FSP_HEADER_PATH string "Location of FSP headers" - default "src/vendorcode/intel/fsp/fsp2_0/meteorlake/" + default "3rdparty/blobs/intel/mtl/fsp/PartialHeader/Include" config FSP_FD_PATH string -- To view, visit https://review.coreboot.org/c/coreboot/+/78793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie13f389a21d53143167b3fba83aa792d089829d1 Gerrit-Change-Number: 78793 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023