coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: soc/intel/alderlake: Add romstage early graphics support
by Jérémy Compostella (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Tarun Tuli, Nico Huber, Michał Żygowski, Swift Geek (Sebastian Grzywna), Elyes Haouas. Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Cliff Huang, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Tarun Tuli, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro, Swift Geek (Sebastian Grzywna), Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70303 to look at the new patch set (#47). Change subject: soc/intel/alderlake: Add romstage early graphics support ...................................................................... soc/intel/alderlake: Add romstage early graphics support BUG=b:252792591 BRANCH=firmware-brya-14505.B TEST=Verify that VGA text mode is functional in romstage Change-Id: I727b28bbe180edc2574e09bf03f1534d6282bdb2 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/romstage/Makefile.inc M src/soc/intel/alderlake/romstage/fsp_params.c A src/soc/intel/alderlake/romstage/graphics.c 5 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/70303/47 -- To view, visit https://review.coreboot.org/c/coreboot/+/70303 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727b28bbe180edc2574e09bf03f1534d6282bdb2 Gerrit-Change-Number: 70303 Gerrit-PatchSet: 47 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: Add common function to disable LT memory lock
by Jérémy Compostella (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Jérémy Compostella, Angel Pons. Hello build bot (Jenkins), Tarun Tuli, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71655 to look at the new patch set (#5). Change subject: soc/intel/common: Add common function to disable LT memory lock ...................................................................... soc/intel/common: Add common function to disable LT memory lock Add a common function to unlock memory by setting MSR 0x2e6 to 0. If internal chipset conditions are met, it unlocks access to the DRAM. BUG=b:252792591 BRANCH=firmware-brya-14505.B TEST=romstage early graphics is operational Change-Id: Ic666919ed51f683c9a1ef0b7ba061cd2949faf1e Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/include/intelblocks/cpulib.h M src/soc/intel/common/block/include/intelblocks/msr.h 3 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/71655/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/71655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic666919ed51f683c9a1ef0b7ba061cd2949faf1e Gerrit-Change-Number: 71655 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/common/block: Add Intel VGA early graphics support
by Jérémy Compostella (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Zhixing Ma, Tarun Tuli, Nico Huber, Michał Żygowski, Subrata Banik, Kapil Porwal, Swift Geek (Sebastian Grzywna). Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Cliff Huang, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Tarun Tuli, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro, Swift Geek (Sebastian Grzywna), Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70299 to look at the new patch set (#28). Change subject: soc/intel/common/block: Add Intel VGA early graphics support ...................................................................... soc/intel/common/block: Add Intel VGA early graphics support This patch introduces an early graphics driver which can be used in romstage in cache-as-ram mode. The implementation relies on `libgfxinit' and provide VGA text mode support. SoCs wanting to take advantage of this driver must implement the following functions: - `void early_graphics_soc_device_init(void)' to set the graphic device MMIO to the `CONFIG_GFX_GMA_DEFAULT_MMIO' value (typically PCI graphic device Base Address Register 0). - `void early_graphics_soc_panel_init(void)' to set the panel power sequence timing parameters. BUG=b:252792591 BRANCH=firmware-brya-14505.B TEST=Graphics bring up observed on skolas with extra patches Change-Id: Ie4ad1215e5fadd0adc1271b6bd6ddb0ea258cb5b Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/drivers/intel/gma/gma-gfx_init.ads M src/drivers/intel/gma/hires_fb/gma-gfx_init.adb M src/drivers/intel/gma/libgfxinit.h M src/drivers/intel/gma/text_fb/gma-gfx_init.adb M src/soc/intel/common/block/graphics/Kconfig M src/soc/intel/common/block/graphics/Makefile.inc A src/soc/intel/common/block/graphics/early_graphics.c A src/soc/intel/common/block/include/intelblocks/early_graphics.h 8 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/70299/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/70299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4ad1215e5fadd0adc1271b6bd6ddb0ea258cb5b Gerrit-Change-Number: 70299 Gerrit-PatchSet: 28 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/morgana: update morgana cpuid
by ritul guru (Code Review) 05 Jan '23

05 Jan '23

ritul guru has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71689 ) Change subject: soc/amd/morgana: update morgana cpuid ...................................................................... soc/amd/morgana: update morgana cpuid Change-Id: Ieaad72a6b964f4b2ab572733694def88e30888a3 Signed-off-by: Ritul Guru <ritul.bits(a)gmail.com> --- M src/soc/amd/morgana/include/soc/cpu.h 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/71689/1 diff --git a/src/soc/amd/morgana/include/soc/cpu.h b/src/soc/amd/morgana/include/soc/cpu.h index ac85861..1440cae 100644 --- a/src/soc/amd/morgana/include/soc/cpu.h +++ b/src/soc/amd/morgana/include/soc/cpu.h @@ -3,6 +3,6 @@ #ifndef AMD_MORGANA_CPU_H #define AMD_MORGANA_CPU_H -#define MORGANA_A0_CPUID 0x008a0f00 /* TODO: Update for Morgana */ +#define MORGANA_A0_CPUID 0x00A70F80 #endif /* AMD_MORGANA_CPU_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/71689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaad72a6b964f4b2ab572733694def88e30888a3 Gerrit-Change-Number: 71689 Gerrit-PatchSet: 1 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/morgana: update max number of cpus to 16 for morgana
by ritul guru (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Hello Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71688 to look at the new patch set (#3). Change subject: soc/amd/morgana: update max number of cpus to 16 for morgana ...................................................................... soc/amd/morgana: update max number of cpus to 16 for morgana Change-Id: I5169a900345e2aabefcf1e2c249ee4bce6dc8fc5 Signed-off-by: Ritul Guru <ritul.bits(a)gmail.com> --- M src/soc/amd/morgana/Kconfig M src/soc/amd/morgana/cpu.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/71688/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5169a900345e2aabefcf1e2c249ee4bce6dc8fc5 Gerrit-Change-Number: 71688 Gerrit-PatchSet: 3 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/morgana: update max number of cpus to 16 for morgana
by ritul guru (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Hello Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71688 to look at the new patch set (#2). Change subject: soc/amd/morgana: update max number of cpus to 16 for morgana ...................................................................... soc/amd/morgana: update max number of cpus to 16 for morgana Change-Id: I5169a900345e2aabefcf1e2c249ee4bce6dc8fc5 Signed-off-by: Ritul Guru <ritul.bits(a)gmail.com> --- M src/soc/amd/morgana/Kconfig M src/soc/amd/morgana/cpu.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/71688/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5169a900345e2aabefcf1e2c249ee4bce6dc8fc5 Gerrit-Change-Number: 71688 Gerrit-PatchSet: 2 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/morgana: update max number of cpus to 16 for margana
by ritul guru (Code Review) 05 Jan '23

05 Jan '23

ritul guru has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71688 ) Change subject: soc/amd/morgana: update max number of cpus to 16 for margana ...................................................................... soc/amd/morgana: update max number of cpus to 16 for margana Change-Id: I5169a900345e2aabefcf1e2c249ee4bce6dc8fc5 Signed-off-by: Ritul Guru <ritul.bits(a)gmail.com> --- M src/soc/amd/morgana/Kconfig M src/soc/amd/morgana/cpu.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/71688/1 diff --git a/src/soc/amd/morgana/Kconfig b/src/soc/amd/morgana/Kconfig index 7765f92..ce57540 100644 --- a/src/soc/amd/morgana/Kconfig +++ b/src/soc/amd/morgana/Kconfig @@ -238,7 +238,6 @@ config MAX_CPUS int - default 8 if SOC_AMD_MORGANA default 16 help Maximum number of threads the platform can have. diff --git a/src/soc/amd/morgana/cpu.c b/src/soc/amd/morgana/cpu.c index fe5a1b8..68c3a34 100644 --- a/src/soc/amd/morgana/cpu.c +++ b/src/soc/amd/morgana/cpu.c @@ -16,7 +16,7 @@ #include <soc/cpu.h> #include <soc/iomap.h> -_Static_assert(CONFIG_MAX_CPUS == 8, "Do not override MAX_CPUS. To reduce the number of " +_Static_assert(CONFIG_MAX_CPUS == 16, "Do not override MAX_CPUS. To reduce the number of " "available cores, use the downcore_mode and disable_smt devicetree settings instead."); /* MP and SMM loading initialization */ -- To view, visit https://review.coreboot.org/c/coreboot/+/71688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5169a900345e2aabefcf1e2c249ee4bce6dc8fc5 Gerrit-Change-Number: 71688 Gerrit-PatchSet: 1 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Documentation/acronyms: Add several acronyms
by Maximilian Brune (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Paul Menzel. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71665 ) Change subject: Documentation/acronyms: Add several acronyms ...................................................................... Patch Set 2: (6 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/71665/comment/e9d54502_2df6b04b PS1, Line 7: Documentation/acronyms: Add acronyms > Add several acronyms Done File Documentation/acronyms.md: https://review.coreboot.org/c/coreboot/+/71665/comment/100a88e6_ae48d560 PS1, Line 250: DMI - Direct Media Interface is a link/bus between CPU and PCH > Missing bullet? Done https://review.coreboot.org/c/coreboot/+/71665/comment/763f7a5c_da21cc05 PS1, Line 623: and Range Register**](https://www.kernel.org/doc/html/v5.19/x86/pat.html) > Maybe make that a separate commit. It’d be great if you started sentences with a capital letter. Done https://review.coreboot.org/c/coreboot/+/71665/comment/7e3f91e5_ddf63333 PS1, Line 678: set's > sets Done https://review.coreboot.org/c/coreboot/+/71665/comment/d6ca7b75_ae79307c PS1, Line 678: physicall > physical Done https://review.coreboot.org/c/coreboot/+/71665/comment/10ff25c7_a4f58d2d PS1, Line 678: set's > sets Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d925516e48231b15d9aa78c5ef05b6de1ef42ca Gerrit-Change-Number: 71665 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 05 Jan 2023 18:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/mayan: update EC FW offset in spirom
by ritul guru (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Bao Zheng, Jason Glenesk, Fred Reitberger, Felix Held. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70540 ) Change subject: mb/amd/mayan: update EC FW offset in spirom ...................................................................... Patch Set 1: (1 comment) File src/mainboard/amd/mayan/Kconfig: https://review.coreboot.org/c/coreboot/+/70540/comment/196039fe_ad74867f PS1, Line 61: default 0x81000 > this is mainboard specific bios rom offset which will be fixed, do we see a need of user configurabl […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/70540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63c797e12ed131e8411c11379f4db9bcc29b49a2 Gerrit-Change-Number: 70540 Gerrit-PatchSet: 1 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 18:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel: Add Kconfigs to define scaling factor for cores
by Arthur Heymans (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Sridhar Siricilla. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71687 ) Change subject: soc/intel: Add Kconfigs to define scaling factor for cores ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/acpi/cpu_hybrid.c: https://review.coreboot.org/c/coreboot/+/71687/comment/3641f0ec_64c3a740 PS1, Line 78: soc_get_scaling_factor > Do we even need this function now? Agreed. Maybe add some _Static_assert() on the CONFIG_SOC_INTEL_PERF_CORE_SCAL_FACTOR as a way to make sure that those are properly defined and configured (non zero). -- To view, visit https://review.coreboot.org/c/coreboot/+/71687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55e4d815116ef40c5f33be64ab495e942bf35ee8 Gerrit-Change-Number: 71687 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 18:25:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023