coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp/skx: Remove nested check for ACPI support
by Martin L Roth (Code Review) 09 Jan '23

09 Jan '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66698 ) Change subject: soc/intel/xeon_sp/skx: Remove nested check for ACPI support ...................................................................... soc/intel/xeon_sp/skx: Remove nested check for ACPI support Remove redundant nested check for ACPI support. Change-Id: Ie4b40382d304028135bcdd7851e2f48333570421 Signed-off-by: Marc Jones <marcj303(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66698 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/intel/xeon_sp/skx/chip.c 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/src/soc/intel/xeon_sp/skx/chip.c b/src/soc/intel/xeon_sp/skx/chip.c index efdeef8..35e834a 100644 --- a/src/soc/intel/xeon_sp/skx/chip.c +++ b/src/soc/intel/xeon_sp/skx/chip.c @@ -28,10 +28,8 @@ .scan_bus = &xeonsp_pci_domain_scan_bus, #if CONFIG(HAVE_ACPI_TABLES) .write_acpi_tables = &northbridge_write_acpi_tables, - #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = soc_acpi_name #endif -#endif }; static struct device_operations cpu_bus_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/66698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4b40382d304028135bcdd7851e2f48333570421 Gerrit-Change-Number: 66698 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/mediatek/common: Reset the watchdog timer before triggering reset
by KuanHsun Cheng (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Hung-Te Lin, Allen-KH Cheng, Yu-Ping Wu, Yidi Lin. KuanHsun Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71754 ) Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71754/comment/87043d1b_f5750de0 PS2, Line 18: TEST= Reboot successfully with the following cmd : stop daisydog : sleep 60 > /dev/watchdog& : > ``` […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 Gerrit-Change-Number: 71754 Gerrit-PatchSet: 3 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:40:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Don't ignore IASL warnings
by Elyes Haouas (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70768 ) Change subject: Makefile.inc: Don't ignore IASL warnings ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70768/comment/acf7bb76_74f6328f PS5, Line 8: > Nit: Maybe add a comment that the warnings are all fixed so this is no longer needed? Thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/70768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f262fae63a41f6bf52c60721380d7cbd0c1e806 Gerrit-Change-Number: 70768 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:36:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Don't ignore IASL warnings
by Elyes Haouas (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Elyes Haouas. Hello Felix Singer, build bot (Jenkins), Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70768 to look at the new patch set (#6). Change subject: Makefile.inc: Don't ignore IASL warnings ...................................................................... Makefile.inc: Don't ignore IASL warnings All warnings have been fixed, so IGNORED_IASL_WARNINGS is no longer needed. Change-Id: I1f262fae63a41f6bf52c60721380d7cbd0c1e806 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 14 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/70768/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/70768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f262fae63a41f6bf52c60721380d7cbd0c1e806 Gerrit-Change-Number: 70768 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek/common: Reset the watchdog timer before triggering reset
by KuanHsun Cheng (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Hung-Te Lin, KuanHsun Cheng, Allen-KH Cheng, Yidi Lin. Hello Hung-Te Lin, Allen-KH Cheng, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71754 to look at the new patch set (#3). Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset ...................................................................... soc/mediatek/common: Reset the watchdog timer before triggering reset When the watchdog timer reaches 0, the timer value won't reset to the default value unless there is an external reset or a kick. It will result in the watchdog failing to trigger the reset signal. We kick the watchdog to reset the timer to the default value. Also, add a 100 us delay before triggering the reset signal. BUG=b:264003005, b:264017048 BRANCH=corsola TEST= Reboot successfully with the following cmd stop daisydog sleep 60 > /dev/watchdog& Signed-off-by: Runyang Chen <runyang.chen(a)mediatek.corp-partner.google.com> Signed-off-by: Allen-kh Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 --- M src/soc/mediatek/common/include/soc/wdt_common.h M src/soc/mediatek/common/wdt.c 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/71754/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 Gerrit-Change-Number: 71754 Gerrit-PatchSet: 3 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Attention: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/kconfig: Fix patch to be compatible with quilt
by Nicholas Chin (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69863 ) Change subject: util/kconfig: Fix patch to be compatible with quilt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Hmm, looks like quilt actually can work with patches that use git diff formatting if you give it the […] I guess I could also just edit this changeset to use the new method instead of abandoning it -- To view, visit https://review.coreboot.org/c/coreboot/+/69863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95bfe6571e3a2cc2b38074b4338f1610a4c8a595 Gerrit-Change-Number: 69863 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/acronyms: Add several acronyms
by Felix Singer (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Paul Menzel, Maximilian Brune. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71665 ) Change subject: Documentation/acronyms: Add several acronyms ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Just fixed some nits, typos and such. Thanks Maximilian. Ah, I forgot. I rephrased the paragraph about MTRR a bit. What do you think? Any objections? -- To view, visit https://review.coreboot.org/c/coreboot/+/71665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d925516e48231b15d9aa78c5ef05b6de1ef42ca Gerrit-Change-Number: 71665 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Disable storage devices based on fw_config
by Ren Kuo (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Eric Lai. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 ) Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d Gerrit-Change-Number: 71726 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:30:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/kconfig: Fix patch to be compatible with quilt
by Nicholas Chin (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69863 ) Change subject: util/kconfig: Fix patch to be compatible with quilt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hmm, looks like quilt actually can work with patches that use git diff formatting if you give it the correct `patch -p` option. I was reading through the quilt manpage, and it turns out you can specify patch options after the filename in the series file. So in the case of the original git patch that this commit concerns, the appropriate option would be `-p3` to strip the `a/util/kconfig` and `b/util/kconfig/ parts of the git path. So in `util/kconfig/patches/series`: ``` 0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch -p3 ``` So I supposed I could abandon this patch in favor of the above mentioned simpler fix, and then create a new patch to document this. What do others think? -- To view, visit https://review.coreboot.org/c/coreboot/+/69863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95bfe6571e3a2cc2b38074b4338f1610a4c8a595 Gerrit-Change-Number: 69863 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:30:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: Move ME spec structure to its header file
by Eric Lai (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Kapil Porwal. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71627 ) Change subject: soc/intel/meteorlake: Move ME spec structure to its header file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3dafd6c030c0c848aa82b03bb336cc8fad14de3 Gerrit-Change-Number: 71627 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023