coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Disable storage devices based on fw_config
by Reka Norman (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Ren Kuo, Eric Lai. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 ) Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/brya/variants/craask/variant.c: https://review.coreboot.org/c/coreboot/+/71726/comment/8bf51107_5f8f9841 PS1, Line 24: if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) { > Will emmc turn off by pci scan? No https://review.coreboot.org/c/coreboot/+/71726/comment/b9a3b6eb_79ce2f08 PS1, Line 31: nvme_rp->enabled = 0; > This will turn off by pci scan. Yes, but I think it doesn't hurt to disable it here to be consistent with eMMC and UFS. What do you think? -- To view, visit https://review.coreboot.org/c/coreboot/+/71726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d Gerrit-Change-Number: 71726 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Update RTL8168 LAN LED config
by Martin L Roth (Code Review) 09 Jan '23

09 Jan '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71698 ) Change subject: mb/google/brya/var/lisbon: Update RTL8168 LAN LED config ...................................................................... mb/google/brya/var/lisbon: Update RTL8168 LAN LED config Adjust LAN LED config to 0x060f. BUG=b:246657849 TEST=emerge-brask coreboot Change-Id: Idd5ed2bf7eb4ee5990f2a842cba43f967ae3825e Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71698 Reviewed-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ricky Chang <rickytlchang(a)google.com> --- M src/mainboard/google/brya/variants/lisbon/overridetree.cb 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Kevin Chiu: Looks good to me, approved Ricky Chang: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb index 86e4b69..6a21f2a 100644 --- a/src/mainboard/google/brya/variants/lisbon/overridetree.cb +++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb @@ -187,9 +187,7 @@ device ref pcie_rp7 on chip drivers/net register "wake" = "GPE0_DW0_07" - register "led_feature" = "0xe0" - register "customized_led0" = "0x23f" - register "customized_led2" = "0x028" + register "customized_leds" = "0x060f" register "enable_aspm_l1_2" = "1" register "add_acpi_dma_property" = "true" device pci 00.0 on end -- To view, visit https://review.coreboot.org/c/coreboot/+/71698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd5ed2bf7eb4ee5990f2a842cba43f967ae3825e Gerrit-Change-Number: 71698 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update RTL8168 LAN LED config
by Martin L Roth (Code Review) 09 Jan '23

09 Jan '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update RTL8168 LAN LED config ...................................................................... mb/google/brya/var/gladios: Update RTL8168 LAN LED config Adjust LAN LED config to 0x060f. BUG=b:239513596 TEST=emerge-brask coreboot Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71697 Reviewed-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ricky Chang <rickytlchang(a)google.com> --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Kevin Chiu: Looks good to me, approved Ricky Chang: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/variants/gladios/overridetree.cb b/src/mainboard/google/brya/variants/gladios/overridetree.cb index 86e4b69..6a21f2a 100644 --- a/src/mainboard/google/brya/variants/gladios/overridetree.cb +++ b/src/mainboard/google/brya/variants/gladios/overridetree.cb @@ -187,9 +187,7 @@ device ref pcie_rp7 on chip drivers/net register "wake" = "GPE0_DW0_07" - register "led_feature" = "0xe0" - register "customized_led0" = "0x23f" - register "customized_led2" = "0x028" + register "customized_leds" = "0x060f" register "enable_aspm_l1_2" = "1" register "add_acpi_dma_property" = "true" device pci 00.0 on end -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 7 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/mediatek/common: Reset the watchdog timer before triggering reset
by KuanHsun Cheng (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Hung-Te Lin. Hello Hung-Te Lin, Allen-KH Cheng, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71754 to look at the new patch set (#2). Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset ...................................................................... soc/mediatek/common: Reset the watchdog timer before triggering reset When the watchdog timer reaches 0, the timer value won't reset to the default value unless there is an external reset or a kick. It will result in the watchdog failing to trigger the reset signal. We kick the watchdog to reset the timer to the default value. Also, add a 100 us delay before triggering the reset signal. BUG=b:264003005, b:264017048 BRANCH=corsola TEST= Reboot successfully with the following cmd stop daisydog sleep 60 > /dev/watchdog& Signed-off-by: Runyang Chen <runyang.chen(a)mediatek.corp-partner.google.com> Signed-off-by: Allen-kh Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 --- M src/soc/mediatek/common/include/soc/wdt_common.h M src/soc/mediatek/common/wdt.c 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/71754/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 Gerrit-Change-Number: 71754 Gerrit-PatchSet: 2 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Disable storage devices based on fw_config
by Eric Lai (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Ren Kuo. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 ) Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/brya/variants/craask/variant.c: https://review.coreboot.org/c/coreboot/+/71726/comment/23489a99_a48faa8e PS1, Line 24: if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) { Will emmc turn off by pci scan? https://review.coreboot.org/c/coreboot/+/71726/comment/fefff00c_4c285766 PS1, Line 31: nvme_rp->enabled = 0; This will turn off by pci scan. -- To view, visit https://review.coreboot.org/c/coreboot/+/71726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d Gerrit-Change-Number: 71726 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:05:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/common: Reset the watchdog timer before triggering reset.
by build bot (Jenkins) (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Hung-Te Lin, Allen-KH Cheng. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71754 ) Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset. ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167904): https://review.coreboot.org/c/coreboot/+/71754/comment/25264635_690abd52 PS1, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/71754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 Gerrit-Change-Number: 71754 Gerrit-PatchSet: 1 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:00:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/kconfig: Fix patch to be compatible with quilt
by Nicholas Chin (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69863 ) Change subject: util/kconfig: Fix patch to be compatible with quilt ...................................................................... Patch Set 1: (1 comment) File util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch: https://review.coreboot.org/c/coreboot/+/69863/comment/1a7595c8_84aff7c3 PS1, Line 38: char *autoconf_name > Okay, thanks for the explanation. I'm not familiar with quilt. […] I took Martin's original patch in commit b7f92a0b6a0f and ran it through steps that I documented in commit 9eab93168d. -- To view, visit https://review.coreboot.org/c/coreboot/+/69863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95bfe6571e3a2cc2b38074b4338f1610a4c8a595 Gerrit-Change-Number: 69863 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 06:00:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/common: Reset the watchdog timer before triggering reset.
by KuanHsun Cheng (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Allen-KH Cheng. Hello Allen-KH Cheng, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/71754 to review the following change. Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset. ...................................................................... soc/mediatek/common: Reset the watchdog timer before triggering reset. When the watchdog timer reaches 0, the timer value won't reset to the default value unless there is an external reset or a kick. It will result in the watchdog failing to trigger the reset signal. We kick the watchdog to reset the timer to the default value. Also, add a 100 us delay before triggering the reset signal. BUG=b:264003005, b:264017048 BRANCH=corsola TEST= Reboot successfully with the following cmd stop daisydog sleep 60 > /dev/watchdog& Signed-off-by: Runyang Chen <runyang.chen(a)mediatek.corp-partner.google.com> Signed-off-by: Allen-kh Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 --- M src/soc/mediatek/common/include/soc/wdt_common.h M src/soc/mediatek/common/wdt.c 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/71754/1 diff --git a/src/soc/mediatek/common/include/soc/wdt_common.h b/src/soc/mediatek/common/include/soc/wdt_common.h index 5587d50..6d6d2ba 100644 --- a/src/soc/mediatek/common/include/soc/wdt_common.h +++ b/src/soc/mediatek/common/include/soc/wdt_common.h @@ -32,6 +32,11 @@ MTK_WDT_MODE_ENABLE = 1 << 0 }; +/* WDT_RESTART */ +enum { + MTK_WDT_RESTART_KEY = 0x1971 +}; + /* WDT_RESET */ enum { MTK_WDT_SWRST_KEY = 0x1209, diff --git a/src/soc/mediatek/common/wdt.c b/src/soc/mediatek/common/wdt.c index 7ae4661..663fc2f 100644 --- a/src/soc/mediatek/common/wdt.c +++ b/src/soc/mediatek/common/wdt.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/cache.h> +#include <delay.h> #include <device/mmio.h> #include <console/console.h> #include <halt.h> @@ -23,7 +24,9 @@ printk(BIOS_INFO, "%s() called!\n", __func__); dcache_clean_all(); + write32(&mtk_wdt->wdt_restart, MTK_WDT_RESTART_KEY); setbits32(&mtk_wdt->wdt_mode, MTK_WDT_MODE_EXTEN | MTK_WDT_MODE_KEY); + udelay(100); write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY); halt(); -- To view, visit https://review.coreboot.org/c/coreboot/+/71754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 Gerrit-Change-Number: 71754 Gerrit-PatchSet: 1 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-Attention: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: MAINTAINERS: Add maintainers for the cross toolchain
by Felix Singer (Code Review) 09 Jan '23

09 Jan '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70923 ) Change subject: MAINTAINERS: Add maintainers for the cross toolchain ...................................................................... MAINTAINERS: Add maintainers for the cross toolchain Add the following people as maintainers for the cross toolchain. * Martin Roth * Felix Singer * Elyes Haouas Change-Id: I3fad10baa0f0177693e009a4bbc218c6064611b9 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70923 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M MAINTAINERS 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Elyes Haouas: Looks good to me, but someone else must approve diff --git a/MAINTAINERS b/MAINTAINERS index 78ff0dd..aefc432 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -956,6 +956,10 @@ F: util/genbuild_h/ TOOLCHAIN +M: Martin Roth <gaumless(a)gmail.com> +M: Felix Singer <felixsinger(a)posteo.net> +M: Elyes Haouas <ehaouas(a)noos.fr> +S: Supported F: util/crossgcc/ DOCKER -- To view, visit https://review.coreboot.org/c/coreboot/+/70923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fad10baa0f0177693e009a4bbc218c6064611b9 Gerrit-Change-Number: 70923 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: MAINTAINERS: Add maintainers for the cross toolchain
by Martin L Roth (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70923 ) Change subject: MAINTAINERS: Add maintainers for the cross toolchain ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fad10baa0f0177693e009a4bbc218c6064611b9 Gerrit-Change-Number: 70923 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 05:22:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023