Attention is currently required from: Maximilian Brune, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71519 )
Change subject: src/sbom/Makefile.inc: Fix quotes on CONFIG paths
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71519/comment/8f2d403f_12d3f4ea
PS3, Line 7: Fix quotes on CONFIG paths
> By my understanding, there is no add. […]
Sounds good to me :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/71519
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddf4e0cd8a11eaf327d6f55baf38a30c566d0f28
Gerrit-Change-Number: 71519
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 09 Jan 2023 07:41:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Maximilian Brune.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71519 )
Change subject: src/sbom/Makefile.inc: Fix quotes on CONFIG paths
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71519/comment/7c1bb0fb_406df02a
PS3, Line 7: Fix quotes on CONFIG paths
> From this I can not guess that you are adding new ones. Suggestion: […]
By my understanding, there is no add.
is "src/sbom/Makefile.inc: Remove quotes on CONFIG_SBOM_ paths" correct ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/71519
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddf4e0cd8a11eaf327d6f55baf38a30c566d0f28
Gerrit-Change-Number: 71519
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 07:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Eric Lai.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 )
Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71726/comment/ebb99c06_c0deadef
PS1, Line 15: TEST=Boot to OS on craask eMMC and NVMe SKUs with both unprovisioned
: fw_config and fw_config set correctly.
> I've tested eMMC. […]
The test result is good.
refer to:
https://partnerissuetracker.corp.google.com/issues/263920313#comment13
--
To view, visit https://review.coreboot.org/c/coreboot/+/71726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d
Gerrit-Change-Number: 71726
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 07:27:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Angel Pons, Shuming Chu (Shuming), TangYiwei.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 24:
(1 comment)
Patchset:
PS11:
> And apic_id should follow the sequence, that, first thread of socket 0 then socket 1, then second thread of socket 0 then socket 1, so the re-assign of apic_id is needed, and we don't see current patch follow this.
All apic id of socket 1 > socket 0 so only adding thread 0, then thread 1 without looking at socket (package_id) is fine.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 24
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Mon, 09 Jan 2023 07:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Angel Pons, Shuming Chu (Shuming).
TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 24:
(1 comment)
Patchset:
PS11:
> In SRAT, numa node id should be generated by SNC info algorithm, not package id. […]
And apic_id should follow the sequence, that, first thread of socket 0 then socket 1, then second thread of socket 0 then socket 1, so the re-assign of apic_id is needed, and we don't see current patch follow this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 24
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 07:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
Hello Hung-Te Lin, Allen-KH Cheng, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71754
to look at the new patch set (#4).
Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset
......................................................................
soc/mediatek/common: Reset the watchdog timer before triggering reset
When the watchdog timer reaches 0, the timer value won't reset to the
default value unless there is an external reset or a kick. It will
result in the watchdog failing to trigger the reset signal.
We kick the watchdog to reset the timer to the default value. Also,
because WDT hardware needs about 94us to synchronize the registers,
add a 100us delay before triggering the reset signal.
BUG=b:264003005, b:264017048
BRANCH=corsola
TEST= Reboot successfully with the following cmd
stop daisydog
sleep 60 > /dev/watchdog&
Signed-off-by: Runyang Chen <runyang.chen(a)mediatek.corp-partner.google.com>
Signed-off-by: Allen-kh Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com>
Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19
---
M src/soc/mediatek/common/include/soc/wdt_common.h
M src/soc/mediatek/common/wdt.c
2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/71754/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/71754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19
Gerrit-Change-Number: 71754
Gerrit-PatchSet: 4
Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset