coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: mb/google/brya/var/omnigul: Add memory parts support
by Amanda Hwang (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Jamie Chen, Tarun Tuli, Ian Feng, Dtrain Hsu. Hello build bot (Jenkins), Jamie Chen, Tarun Tuli, Ian Feng, Dtrain Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71756 to look at the new patch set (#2). Change subject: mb/google/brya/var/omnigul: Add memory parts support ...................................................................... mb/google/brya/var/omnigul: Add memory parts support Add new memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. The memory parts being added are: 1) Samsung K3KL8L80CM-MGCT 2) Hynix H58G56BK7BX068 3) Micron MT62F1G32D2DS-026 WT:B 4) Micron MT62F512M32D2DR-031 WT:B BUG=b:264340545 BRANCH=firmware-brya-14505.B TEST=FW_NAME=omnigul emerge-brya coreboot Change-Id: I699070596a77c975254660a1ba74b0f40026186d Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/omnigul/memory/Makefile.inc M src/mainboard/google/brya/variants/omnigul/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt 3 files changed, 40 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/71756/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699070596a77c975254660a1ba74b0f40026186d Gerrit-Change-Number: 71756 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: configs: Build x201 for 64bit
by Paul Menzel (Code Review) 09 Jan '23

09 Jan '23

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69390 ) Change subject: configs: Build x201 for 64bit ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Why not have a configuration for 32-bit and one for 64-bit? -- To view, visit https://review.coreboot.org/c/coreboot/+/69390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea3d5b8926fd8300c9daba0bc6dac91b9e55cdd6 Gerrit-Change-Number: 69390 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp: Don't sort struct device cpus for numa
by Paul Menzel (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Lance Zhao, Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Angel Pons, Shuming Chu (Shuming), TangYiwei. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 ) Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa ...................................................................... Patch Set 24: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68912/comment/b9b506af_eafd4e3d PS24, Line 13: it's its https://review.coreboot.org/c/coreboot/+/68912/comment/b01769d8_658bbf6a PS24, Line 16: entry (now it is done in : parallel too as a bonus). Please add the dot/period after entry, and make the sentence in the brackets start with capital letter and add a dot/period at the send. https://review.coreboot.org/c/coreboot/+/68912/comment/f0702a25_35e8f36d PS24, Line 18: Tested on what board? File src/soc/intel/xeon_sp/nb_acpi.c: https://review.coreboot.org/c/coreboot/+/68912/comment/0f5a06a0_ba291fa1 PS24, Line 29: uint32_t Could this be `unsigned int`? -- To view, visit https://review.coreboot.org/c/coreboot/+/68912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1 Gerrit-Change-Number: 68912 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: TangYiwei Gerrit-Comment-Date: Mon, 09 Jan 2023 08:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ifdtool: Determine max regions from IFD
by Paul Menzel (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Patrick Rudolph, Stefan Reinauer, Arthur Heymans, Julian Elischer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 ) Change subject: ifdtool: Determine max regions from IFD ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68780/comment/9f94243f_d505979b PS2, Line 17: Very early IFDv2 chipsets, sometimes unofficially referred to as : IFDv1.5 platforms, only have 8 regions. To not corrupt the IFD when : operating on an IFDv1.5 detect how much space is actually present : in the IFD. Please reflow for 72 characters, so it fits in three lines. -- To view, visit https://review.coreboot.org/c/coreboot/+/68780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e3f23ec580b8b8402eb1bf165e3995c8db633f1 Gerrit-Change-Number: 68780 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julian Elischer <jrelis(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Julian Elischer <jrelis(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:45:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/omnigul: Add memory parts support
by Amanda Hwang (Code Review) 09 Jan '23

09 Jan '23

Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71756 ) Change subject: mb/google/brya/var/omnigul: Add memory parts support ...................................................................... mb/google/brya/var/omnigul: Add memory parts support Add new memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. The memory parts being added are: 1) Samsung K3KL8L80CM-MGCT 2) Hynix H58G56BK7BX068 3) Micron MT62F1G32D2DS-026 WT:B 4) Micron MT62F512M32D2DR-031 WT:B BUG=b:264340545 BRANCH=firmware-brya-14505.B TEST=FW_NAME=omnigul emerge-brya coreboot Change-Id: I699070596a77c975254660a1ba74b0f40026186d Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/omnigul/memory/Makefile.inc M src/mainboard/google/brya/variants/omnigul/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt 3 files changed, 41 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/71756/1 diff --git a/src/mainboard/google/brya/variants/omnigul/memory/Makefile.inc b/src/mainboard/google/brya/variants/omnigul/memory/Makefile.inc index eace2e4..5c07a4d 100644 --- a/src/mainboard/google/brya/variants/omnigul/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/omnigul/memory/Makefile.inc @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! -# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/omnigul/memory/ src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt -SPD_SOURCES = placeholder +SPD_SOURCES = +SPD_SOURCES += spd/lp5/set-0/spd-7.hex # ID = 0(0b0000) Parts = K3KL8L80CM-MGCT, H58G56BK7BX068, MT62F1G32D2DS-026 WT:B +SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 1(0b0001) Parts = MT62F512M32D2DR-031 WT:B diff --git a/src/mainboard/google/brya/variants/omnigul/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/omnigul/memory/dram_id.generated.txt index fa24790..54ca03e 100644 --- a/src/mainboard/google/brya/variants/omnigul/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/omnigul/memory/dram_id.generated.txt @@ -1 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/omnigul/memory/ src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt + DRAM Part Name ID to assign +K3KL8L80CM-MGCT 0 (0000) +H58G56BK7BX068 0 (0000) +MT62F1G32D2DS-026 WT:B 0 (0000) +MT62F512M32D2DR-031 WT:B 1 (0001) diff --git a/src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt index 9621137..b7b746a 100644 --- a/src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/omnigul/memory/mem_parts_used.txt @@ -9,3 +9,8 @@ # See util/spd_tools/README.md for more details and instructions. # Part Name +K3KL8L80CM-MGCT +H58G56BK7BX068 +MT62F1G32D2DS-026 WT:B +MT62F512M32D2DR-031 WT:B + -- To view, visit https://review.coreboot.org/c/coreboot/+/71756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699070596a77c975254660a1ba74b0f40026186d Gerrit-Change-Number: 71756 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/baytrail/romstage: Fix uninitialized variable "speed"
by Yidi Lin (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71729 ) Change subject: soc/intel/baytrail/romstage: Fix uninitialized variable "speed" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic62a15eb152a5c6fa3d41bb8d5f104f62f89808c Gerrit-Change-Number: 71729 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: Move ME spec structure to its header file
by Sridhar Siricilla (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Kapil Porwal. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71627 ) Change subject: soc/intel/meteorlake: Move ME spec structure to its header file ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71627/comment/11c00c00_b17dc4ea PS2, Line 8: : This patch moves ME host firmware status register structure to ME header : file. It also marks unused structure fields to reserved. You may need to add reason as well for the change. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/71627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3dafd6c030c0c848aa82b03bb336cc8fad14de3 Gerrit-Change-Number: 71627 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:41:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Disable storage devices based on fw_config
by Eric Lai (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 ) Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d Gerrit-Change-Number: 71726 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:41:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
by Eric Lai (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 ) Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 18 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:41:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/baytrail/romstage: Fix uninitialized variable "speed"
by Yu-Ping Wu (Code Review) 09 Jan '23

09 Jan '23

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71729 ) Change subject: soc/intel/baytrail/romstage: Fix uninitialized variable "speed" ...................................................................... soc/intel/baytrail/romstage: Fix uninitialized variable "speed" Change-Id: Ic62a15eb152a5c6fa3d41bb8d5f104f62f89808c Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/intel/baytrail/romstage/raminit.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/71729/1 diff --git a/src/soc/intel/baytrail/romstage/raminit.c b/src/soc/intel/baytrail/romstage/raminit.c index 79614af..b26a4da 100644 --- a/src/soc/intel/baytrail/romstage/raminit.c +++ b/src/soc/intel/baytrail/romstage/raminit.c @@ -75,7 +75,7 @@ const uint32_t soc_dev = PCI_DEV(0, SOC_DEV, SOC_FUNC); uint32_t reg; int num_channels; - int speed; + int speed = 0; uint32_t ch0; uint32_t ch1; -- To view, visit https://review.coreboot.org/c/coreboot/+/71729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic62a15eb152a5c6fa3d41bb8d5f104f62f89808c Gerrit-Change-Number: 71729 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023