coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Use common gpio.h include
by Dinesh Gehlot (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71630 to look at the new patch set (#4). Change subject: soc/intel/meteorlake: Use common gpio.h include ...................................................................... soc/intel/meteorlake: Use common gpio.h include Replace the intelblocks/gpio.h, soc/gpio.h and soc/gpio_defs.h includes with the common gpio.h which will include soc/gpio.h which will include intelblocks/gpio.h which will include soc/gpio_defs.h BUG=b:261778357 TEST=Able to build and boot Google/rex. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I58e428cde5e13f4f0dfe528d798c0613b7f8a94a --- M src/soc/intel/meteorlake/acpi/gpio.asl M src/soc/intel/meteorlake/chip.c M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/finalize.c M src/soc/intel/meteorlake/gpio.c M src/soc/intel/meteorlake/pmutil.c 6 files changed, 24 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/71630/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/71630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58e428cde5e13f4f0dfe528d798c0613b7f8a94a Gerrit-Change-Number: 71630 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Disable storage devices based on fw_config
by Eric Lai (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71726 ) Change subject: mb/google/nissa/var/craask: Disable storage devices based on fw_config ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/craask/variant.c: https://review.coreboot.org/c/coreboot/+/71726/comment/86071517_5762a7f7 PS1, Line 31: nvme_rp->enabled = 0; > Yes, but I think it doesn't hurt to disable it here to be consistent with eMMC and UFS. […] It's fine to me.. -- To view, visit https://review.coreboot.org/c/coreboot/+/71726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4167ee4d00b9ae8fe074c6f5e7a2d5a7382bfe6d Gerrit-Change-Number: 71726 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:25:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Configure USB devices for MTL-RVP
by Subrata Banik (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Anilkumar N, Jamie Ryu, Harsha B R, Eric Lai, Usha P. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71168 ) Change subject: mb/intel/mtlrvp: Configure USB devices for MTL-RVP ...................................................................... Patch Set 5: (1 comment) File src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb: https://review.coreboot.org/c/coreboot/+/71168/comment/ffbb4725_c0bbcd6f PS5, Line 31: "USB3_PORT_DEFAULT(OC0)" # M.2 WWAN > Do we still have to skip the OC configuration here? please update the comment according -- To view, visit https://review.coreboot.org/c/coreboot/+/71168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1a0c31b7bf0f3fc06f039ad76b0cdd41f7cdd90 Gerrit-Change-Number: 71168 Gerrit-PatchSet: 5 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:23:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Harsha B R <harsha.b.r(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
by Subrata Banik (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 ) Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 18 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ifdtool: Determine max regions from IFD
by Christian Walter (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Patrick Rudolph, Stefan Reinauer, Arthur Heymans, Julian Elischer. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 ) Change subject: ifdtool: Determine max regions from IFD ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e3f23ec580b8b8402eb1bf165e3995c8db633f1 Gerrit-Change-Number: 68780 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julian Elischer <jrelis(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Julian Elischer <jrelis(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:21:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ifdtool: Determine max regions from IFD
by Lean Sheng Tan (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Felix Singer, Patrick Rudolph, Stefan Reinauer, Arthur Heymans, Julian Elischer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 ) Change subject: ifdtool: Determine max regions from IFD ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e3f23ec580b8b8402eb1bf165e3995c8db633f1 Gerrit-Change-Number: 68780 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julian Elischer <jrelis(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Julian Elischer <jrelis(a)google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:20:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/brya/var/omnigul: Update GPIO settings
by Ian Feng (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Jamie Chen, Tarun Tuli, Dtrain Hsu. Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71706 ) Change subject: mb/google/brya/var/omnigul: Update GPIO settings ...................................................................... Patch Set 10: Code-Review+1 (22 comments) File src/mainboard/google/brya/variants/omnigul/gpio.c: https://review.coreboot.org/c/coreboot/+/71706/comment/3d7142e3_b7e216b8 PS9, Line 231: PAD_CFG_NF_LOCK(GPP_R7, NONE, NF3, LOCK_CONFIG), > Could you check GPP_R7 setting? And GPP_R6 setting? https://review.coreboot.org/c/coreboot/+/71706/comment/210bc340_88ef0759 PS9, Line 240: PAD_NC(GPP_S3, NONE), > Could you check GPP_S3 setting? And GPP_S2 setting? File src/mainboard/google/brya/variants/omnigul/gpio.c: https://review.coreboot.org/c/coreboot/+/71706/comment/a6917355_8e30bec7 PS10, Line 17: PAD_NC(GPP_A5, NONE), Baseboard is already PAD_NC. Do you need to override it? https://review.coreboot.org/c/coreboot/+/71706/comment/ddf2d692_4a8dadf2 PS10, Line 18: /* A6 : ESPI_ALERT1# ==> ESPI_ALERT1 */ /* A6 : ESPI_ALERT1# ==> NC */ https://review.coreboot.org/c/coreboot/+/71706/comment/2acd66c4_4810114a PS10, Line 20: /* A7 : SRCCLK_OE7# ==> GPP_A7 */ Should PAD_NC(GPP_A7, NONE), or PAD_CFG_GPI(GPP_A7, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/be26b996_a0287f46 PS10, Line 49: /* B3 : PROC_GP2 ==> GPP_B3 */ Should PAD_NC_LOCK(GPP_B3, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_B3, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/dc2927e5_27e478fb PS10, Line 92: PAD_CFG_GPI_LOCK(GPP_D5, NONE, LEVEL, NONE, LOCK_CONFIG), Should PAD_NC(GPP_D5, NONE), or PAD_CFG_GPI(GPP_D5, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/a7c3d44a_4dd9c9c7 PS10, Line 96: PAD_CFG_GPI(GPP_D8, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC(GPP_D8, NONE), or PAD_CFG_GPI(GPP_D8, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/bab094aa_97405141 PS10, Line 104: PAD_CFG_GPI(GPP_D13, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC_LOCK(GPP_D13, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_D13, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/233588bf_cc267262 PS10, Line 105: /* D14 : ISH_UART0_TXD ==> NC */ : PAD_NC_LOCK(GPP_D14, NONE, LOCK_CONFIG), Could you check GPP_D14 the same with baseboard or not? https://review.coreboot.org/c/coreboot/+/71706/comment/a42f2bef_a9199e9a PS10, Line 108: PAD_CFG_GPI(GPP_D15, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC_LOCK(GPP_D15, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_D15, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/0728486a_2c13ba79 PS10, Line 110: PAD_CFG_GPI(GPP_D16, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC_LOCK(GPP_D16, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_D16, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/4bbbf456_5fd52041 PS10, Line 112: PAD_CFG_GPI(GPP_D17, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC(GPP_D17, NONE), or PAD_CFG_GPI(GPP_D17, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/5f4c79f1_07084a22 PS10, Line 122: PAD_CFG_GPI(GPP_E3, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC(GPP_E3, NONE), or PAD_CFG_GPI(GPP_E3, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/b95d0660_b2f59b4e PS10, Line 128: PAD_CFG_GPI(GPP_E7, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC(GPP_E7, NONE), or PAD_CFG_GPI(GPP_E7, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/94a021e0_6b31d02e PS10, Line 132: PAD_CFG_GPI_LOCK(GPP_E10, NONE, LEVEL, NONE, LOCK_CONFIG), Should PAD_NC_LOCK(GPP_E10, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_E10, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/900c017e_be86b39a PS10, Line 141: PAD_CFG_GPI_LOCK(GPP_E17, NONE, LEVEL, NONE, LOCK_CONFIG), Should PAD_NC_LOCK(GPP_E17, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_E17, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/32647ffc_52d41607 PS10, Line 145: PAD_CFG_GPI(GPP_E19, NONE, PLTRST, LEVEL, INVERT), Should PAD_NC(GPP_E19, NONE), or PAD_CFG_GPI(GPP_E19, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/b4e83132_381a3b62 PS10, Line 180: PAD_CFG_GPI_LOCK(GPP_F21, NONE, LEVEL, NONE, LOCK_CONFIG), Should PAD_NC(GPP_F21, NONE), or PAD_CFG_GPI(GPP_F21, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/53d649ac_2bb6b86a PS10, Line 205: PAD_CFG_GPI_LOCK(GPP_H12, NONE, LOCK_CONFIG), Should PAD_NC_LOCK(GPP_H12, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_H12, NONE, LOCK_CONFIG),? https://review.coreboot.org/c/coreboot/+/71706/comment/169c6846_37643a38 PS10, Line 213: /* H19 : SRCCLKREQ4# ==> GPP_H19 */ Should PAD_NC(GPP_H19, NONE),or PAD_CFG_GPI(GPP_H19, NONE, DEEP),? https://review.coreboot.org/c/coreboot/+/71706/comment/01b35a46_bed66e48 PS10, Line 220: PAD_CFG_GPI_LOCK(GPP_H23, NONE, LOCK_CONFIG), Should PAD_NC_LOCK(GPP_H23, NONE, LOCK_CONFIG), or PAD_CFG_GPI_LOCK(GPP_H23, NONE, LOCK_CONFIG),? -- To view, visit https://review.coreboot.org/c/coreboot/+/71706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cfaa8fce6df7f09b744fb3e0b7b1d5b6acdc79b Gerrit-Change-Number: 71706 Gerrit-PatchSet: 10 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:18:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
by Derek Huang (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. Hello David Wu, Tarun Tuli, Subrata Banik, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70773 to look at the new patch set (#18). Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag ...................................................................... chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag When AP boots up after Cr50 firmware update and reboot, AP finds that Cr50 reset is required for Cr50 to pick the new firmware so it trigger Cr50 reset and power off the system, AP expects system will power on automatically after Cr50 reset. However this is not the case for Chromebox, Chromebox EC set AP_IDLE flag when system is shutting down, when AP_IDLE flag is set in EC, the system stays at S5/G3 and wait for power button presssend. It cause an issue in factory that the operator needs to press power button to power on the DUT after Cr50 firmware update. This patch sends EC command to direct EC to clear AP_IDLE flag after AP shutdown so AP can boot up when Cr50 reset. BUG=b:261119366 BRANCH=firmware-brya-14505.B TEST=DUT boots up after Cr50 firmware update in factory test flow Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Signed-off-by: Derek Huang <derekhuang(a)google.com> --- M src/ec/google/chromeec/ec_commands.h M src/mainboard/google/brya/Kconfig M src/security/tpm/tss/vendor/cr50/Kconfig M src/vendorcode/google/chromeos/cr50_enable_update.c 4 files changed, 53 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/70773/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 18 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Configure USB devices for MTL-RVP
by Harsha B R (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Anilkumar N, Jamie Ryu, Subrata Banik, Eric Lai, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71168 ) Change subject: mb/intel/mtlrvp: Configure USB devices for MTL-RVP ...................................................................... Patch Set 5: (1 comment) File src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb: https://review.coreboot.org/c/coreboot/+/71168/comment/640fb3b7_a6ee0284 PS5, Line 31: "USB3_PORT_DEFAULT(OC0)" # M.2 WWAN > usb3_port[0] is Type-A by default. M.2 WWAN is possible only with rework. […] Do we still have to skip the OC configuration here? -- To view, visit https://review.coreboot.org/c/coreboot/+/71168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1a0c31b7bf0f3fc06f039ad76b0cdd41f7cdd90 Gerrit-Change-Number: 71168 Gerrit-PatchSet: 5 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 08:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Harsha B R <harsha.b.r(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/common: Reset the watchdog timer before triggering reset
by Rex-BC Chen (Code Review) 09 Jan '23

09 Jan '23

Attention is currently required from: Hung-Te Lin, KuanHsun Cheng. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71754 ) Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19 Gerrit-Change-Number: 71754 Gerrit-PatchSet: 4 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Comment-Date: Mon, 09 Jan 2023 07:44:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023