coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: soc/intel/alderlake: Add new CPU ID
by 9elements QA (Code Review) 04 Apr '22

04 Apr '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63302 ) Change subject: soc/intel/alderlake: Add new CPU ID ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/99424 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/99423 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/99422 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/99421 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/99420 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/99419 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/99418 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/99417 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/99416 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/99415 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/99414 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/99413 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/99412 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/99411 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/99410 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/99409 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/63302 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I280da46e5fdd3792df50556e2804b3bcb346eee3 Gerrit-Change-Number: 63302 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:47:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/fast_spi/Makefile.inc: Improve cosmetics
by Martin Roth (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56118 ) Change subject: soc/intel/common/block/fast_spi/Makefile.inc: Improve cosmetics ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41bbdabf7b846386651e64f4afb5b7b9fb38e1cb Gerrit-Change-Number: 56118 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:46:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Move adding bootblock non-x86 targets
by Martin Roth (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Arthur Heymans. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63217 ) Change subject: Makefile.inc: Move adding bootblock non-x86 targets ...................................................................... Patch Set 5: (1 comment) File Makefile.inc: https://review.coreboot.org/c/coreboot/+/63217/comment/c2bff132_15ca5649 PS5, Line 1161: ifneq ($(CONFIG_ARCH_X86),y) > Shouldn't this be part of a target or something? Right now it looks like it's just a bare part of t […] Hrm, I guess not. Maybe I can look at a future optimization to reduce the amount of code being run in the makefile if we're not doing a build. -- To view, visit https://review.coreboot.org/c/coreboot/+/63217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50eae4f00d171d26a221ca969086f4f294fa524b Gerrit-Change-Number: 63217 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/defconfig: enable vboot Lib Build
by Selma Bensaid (Code Review) 04 Apr '22

04 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63240 to look at the new patch set (#2). Change subject: libpayload/defconfig: enable vboot Lib Build ...................................................................... libpayload/defconfig: enable vboot Lib Build After depthcharge patch #3461454 merge, vboot build need to be built by libpayload. Signed-off-by: Selma Bensaid <selma.bensaid(a)intel.com> Change-Id: Ib2bb2ce42a314e05ef22ea7b8abc067d6361d511 --- M payloads/libpayload/configs/defconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/63240/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2bb2ce42a314e05ef22ea7b8abc067d6361d511 Gerrit-Change-Number: 63240 Gerrit-PatchSet: 2 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/*/Makefile.inc: Do some cosmetics
by Martin Roth (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Arthur Heymans, Fred Reitberger. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56117 ) Change subject: soc/amd/*/Makefile.inc: Do some cosmetics ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea2322ca1abd43900f3631b7965f07fed4235ca0 Gerrit-Change-Number: 56117 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:42:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tpm: Accept Google Ti50 TPM DID:VID
by Jes Klinke (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter, Julius Werner, Jett Rink. Jes Klinke has removed Jett Rink from this change. ( https://review.coreboot.org/c/coreboot/+/63158 ) Change subject: tpm: Accept Google Ti50 TPM DID:VID ...................................................................... Removed cc Jett Rink. -- To view, visit https://review.coreboot.org/c/coreboot/+/63158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986 Gerrit-Change-Number: 63158 Gerrit-PatchSet: 12 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jett Rink <jettrink(a)google.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jett Rink <jettrink(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: tpm: Accept Google Ti50 TPM DID:VID
by Jes Klinke (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter, Julius Werner, Jett Rink. Jes Klinke has removed Nick Vaccaro from this change. ( https://review.coreboot.org/c/coreboot/+/63158 ) Change subject: tpm: Accept Google Ti50 TPM DID:VID ...................................................................... Removed reviewer Nick Vaccaro. -- To view, visit https://review.coreboot.org/c/coreboot/+/63158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986 Gerrit-Change-Number: 63158 Gerrit-PatchSet: 12 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jett Rink <jettrink(a)google.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jett Rink <jettrink(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: util: Add amdfwread utility
by Robert Zieba (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Bao Zheng, Marshall Dawson, Felix Held. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 ) Change subject: util: Add amdfwread utility ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > without having looked at any of the code: there's already CB:54901 which might do a similar thing 54901 is kinda similar though it seems to be focused just on extracting the binaries. It might be a good idea to have a discussion as to if we maybe want to merge this change into that one or vice-versa. -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 7 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:37:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tpm: Accept Google Ti50 TPM DID:VID
by Jes Klinke (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter, Julius Werner, Jett Rink. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 ) Change subject: tpm: Accept Google Ti50 TPM DID:VID ...................................................................... Patch Set 12: (10 comments) File src/drivers/crb/tis.c: https://review.coreboot.org/c/coreboot/+/63158/comment/445c1422_f63ee2ce PS6, Line 20: {0x6666, 0x50a4, "TI50"}, > nit: I don't think this really needs to be here, and Cr50 should've never been here either. […] Done File src/drivers/i2c/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63158/comment/51c0b10d_48c0ef7b PS6, Line 478: gsc > It's a bit odd to change only this and none of the other instances of "cr50" in here. […] I have reverted the naming to cr50_ in this and other source files, even though many of the methods apply also to ti50. https://review.coreboot.org/c/coreboot/+/63158/comment/a92cc49b_c03fe6a4 PS6, Line 509: cr50_set_board_cfg(); /* No-op for Ti50. */ > Does this mean we send the command and Ti50 just ignores it? That sounds like a waste of boot time. […] No, by no-op I mean that internally cr50_set_board_cfg() checks that if we have a Cr50 earlier than 0.5.5 or a Ti50, then the GSC does not support a board_cfg register, and thus does not send any TPM commands in the bus. File src/drivers/spi/tpm/tpm.c: https://review.coreboot.org/c/coreboot/+/63158/comment/6d55c8e1_0ffdedb1 PS6, Line 422: H1 based > Is it? I guess it is H1D3-based (updated now), I assumed that H1 could be taken to be any generation of the GSC. File src/drivers/spi/tpm/tpm.c: https://review.coreboot.org/c/coreboot/+/63158/comment/d4c33bee_ad2b3177 PS11, Line 422: H1D3 > nit: H1D3C Done File src/drivers/tpm/cr50.h: https://review.coreboot.org/c/coreboot/+/63158/comment/f9d18af5_afb74b8e PS6, Line 11: GSC_TI50 = 2, > I'm wondering if we really need to handle this differentiation at runtime? Long-term (beyond the cur […] I have added a refactoring CL which adds a CONFIG_TPM_TI50 next to CONFIG_TPM_CR50, and also a CONFIG_TPM_GSC which will be set if either of the former are set. File src/drivers/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63158/comment/784be590_c322bddd PS6, Line 249: INFO > ERR? Done, here and two other otherwise untouched places. File src/drivers/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63158/comment/28065ddb_b969e062 PS11, Line 109: if (!CONFIG(TPM_CR50)) : return 0; > let's add a comment to why we are skipping here (e.g. […] Done File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/63158/comment/e620d82d_5e17880e PS11, Line 32: MAINBOARD_HAS_I2C_TPM_TI50 > Brya boards do not have Ti50 on them in general, this should go in BASEBOARD_NISSA I believe That is right, thanks. I know that Nissa and Brya variant has Ti50, what about Brask? https://review.coreboot.org/c/coreboot/+/63158/comment/53a2d4c4_25da5734 PS11, Line 58: BOARD_GOOGLE_BASEBOARD_NISSA > shouldn't we add `MAINBOARD_HAS_I2C_TPM_TI50` to this list if we are removing the workaround? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986 Gerrit-Change-Number: 63158 Gerrit-PatchSet: 12 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jett Rink <jettrink(a)google.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jett Rink <jettrink(a)google.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:37:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Jett Rink <jettrink(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tpm: Accept Google Ti50 TPM DID:VID
by build bot (Jenkins) (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Christian Walter, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 ) Change subject: tpm: Accept Google Ti50 TPM DID:VID ...................................................................... Patch Set 12: (13 comments) File src/mainboard/google/volteer/.history_*outside*: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/4e83ff4d_1275571b PS12, Line 68: cat overridetree.cb trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/4c431485_40139236 PS12, Line 73: git diff ../baseboard/devicetree.cb trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/0dab6aa6_8684efc2 PS12, Line 75: git diff ../baseboard/devicetree.cb trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/6f07434e_1a79afde PS12, Line 130: q trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/31d198e9_fda0e691 PS12, Line 167: cat defconfig trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/11f9f658_431d66c6 PS12, Line 168: grep SPI defconfig trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/c16f8995_d82edb40 PS12, Line 174: cat volteer/defconfig trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/c57dfb36_492cf8f4 PS12, Line 186: cat Makefile.inc trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/a5d51169_b00955b3 PS12, Line 213: git diff delbin/defconfig trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/08e30d28_ee83cc1b PS12, Line 233: rm ../src/board/zork/.history_\*shell\* trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/cb7497d8_8016cee0 PS12, Line 236: rm ../.history_\*shell\* trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/5bcb71ea_ec9e2f66 PS12, Line 400: git diff overridetree.cb trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145353): https://review.coreboot.org/c/coreboot/+/63158/comment/c7c92266_473bf8b6 PS12, Line 487: cat Kconfig.name trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/63158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986 Gerrit-Change-Number: 63158 Gerrit-PatchSet: 12 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jett Rink <jettrink(a)chromium.org> Gerrit-CC: Jett Rink <jettrink(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 04 Apr 2022 18:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022