Attention is currently required from: Paul Menzel, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63354 )
Change subject: mb/google/guybrush/var/dewatt: Correct samsung part number value in SPD data
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63354/comment/3f97143f_d4a551f7
PS1, Line 7: vaule
> value
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
Gerrit-Change-Number: 63354
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 05 Apr 2022 03:25:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63354 )
Change subject: mb/google/guybrush/var/dewatt: Correct samsung part number value in SPD data
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63354/comment/a2e4350f_a7f48431
PS1, Line 7: the
> The article can be removed from the summary to make it shorter.
Done
https://review.coreboot.org/c/coreboot/+/63354/comment/fd39dd81_07e5bc7c
PS1, Line 7: correcting
> Imperative mood [1]: Correct […]
Done
https://review.coreboot.org/c/coreboot/+/63354/comment/dd59dc87_54f645bb
PS1, Line 9: of
> at
Done
https://review.coreboot.org/c/coreboot/+/63354/comment/a8be3c45_55b63699
PS1, Line 9: The value of offset 329 should be 0x4B not 0x48.
> According to what source?
The first letter in the part number is 'K'4UBE3D4AB-MGCL not 'H'
--
To view, visit https://review.coreboot.org/c/coreboot/+/63354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
Gerrit-Change-Number: 63354
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 05 Apr 2022 03:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Chris Wang, Felix Held.
Hello Robert Zieba, build bot (Jenkins), Rob Barnes, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63354
to look at the new patch set (#4).
Change subject: mb/google/guybrush/var/dewatt: Correct samsung part number value in SPD data
......................................................................
mb/google/guybrush/var/dewatt: Correct samsung part number value in SPD data
The value at offset 329 should be:
0x4B -> "K" not 0x48 -> "H" in ASCII code.
BUG=b:224884904
TEST=Build, confirm the part number is matched the corresponding parts
Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
---
M src/mainboard/google/guybrush/variants/dewatt/memory/K4UBE3D4AB-MGCL.hex
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/63354/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/63354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
Gerrit-Change-Number: 63354
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Chris Wang, Felix Held.
Hello Robert Zieba, build bot (Jenkins), Rob Barnes, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63354
to look at the new patch set (#3).
Change subject: mb/google/guybrush/var/dewatt: Correct samsung part number value in SPD data
......................................................................
mb/google/guybrush/var/dewatt: Correct samsung part number value in SPD data
The value at offset 329 should be 0x4B not 0x48.
BUG=b:224884904
TEST=Build, confirm the part number is matched the corresponding parts
Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
---
M src/mainboard/google/guybrush/variants/dewatt/memory/K4UBE3D4AB-MGCL.hex
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/63354/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
Gerrit-Change-Number: 63354
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Chris Wang, Felix Held.
Hello Robert Zieba, build bot (Jenkins), Rob Barnes, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63354
to look at the new patch set (#2).
Change subject: mb/google/guybrush/var/dewatt: correct samsung part number value in SPD data
......................................................................
mb/google/guybrush/var/dewatt: correct samsung part number value in SPD data
The value at offset 329 should be 0x4B not 0x48.
BUG=b:224884904
TEST=Build, confirm the part number is matched the corresponding parts
Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
---
M src/mainboard/google/guybrush/variants/dewatt/memory/K4UBE3D4AB-MGCL.hex
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/63354/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dc5f036a29cdf4763389b6425df99ff63bbfa0
Gerrit-Change-Number: 63354
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro()
......................................................................
Patch Set 15:
(2 comments)
Patchset:
PS2:
> That's an interesting thought, I would love more compile-time or even loud run-time errors over sile […]
Ack
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/ee9de8cf_2f30b1f1
PS7, Line 67: }
> Yes, that's what I mean. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/58896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cb95268424dc27f8c1e26b3d34eff1a7b8eab7f
Gerrit-Change-Number: 58896
Gerrit-PatchSet: 15
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Apr 2022 01:47:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Paul Menzel, Christian Walter, Stefan Reinauer.
Elias Souza has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63351 )
Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove older tags
......................................................................
Patch Set 6:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63351/comment/5aefc259_71d0c308
PS2, Line 2: RatatouilleDummie
> I think, we cannot accept contributions without the real name of people. […]
oh i will use my name but it's needed a photography? sorry for this mistake
https://review.coreboot.org/c/coreboot/+/63351/comment/f6d55faf_2f9b4d41
PS2, Line 7: olders
> older
Done
https://review.coreboot.org/c/coreboot/+/63351/comment/7bc366c4_7594f7e9
PS2, Line 9: U-Root
> u-root
Done
https://review.coreboot.org/c/coreboot/+/63351/comment/772875dc_79fb012c
PS2, Line 10: remove
> removes
Done
https://review.coreboot.org/c/coreboot/+/63351/comment/521d6610_0e6d58a5
PS2, Line 9: The U-Root repo have modified the name of "master" branch to "main" branch
: this patch remove olders versions of u-root and use the new versions
> Please use 72 characters per line, and add a dot/period to the end of sentences.
Done
Patchset:
PS6:
i think this is resolved
--
To view, visit https://review.coreboot.org/c/coreboot/+/63351
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe
Gerrit-Change-Number: 63351
Gerrit-PatchSet: 6
Gerrit-Owner: Elias Souza
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Apr 2022 01:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Marshall Dawson, Arthur Heymans, Kyösti Mälkki, Yu-Ping Wu, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56122 )
Change subject: Makefile.inc: Add the x86 bootblock as a regular cbfs file
......................................................................
Patch Set 9:
(1 comment)
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56122/comment/c09817f0_7808e528
PS9, Line 107: bootblock-options := $(TS_OPTIONS) $(TXTIBB)
Can't we just put the -b here as well (maybe if you use = instead of := )? Or is there no way to make the whole Makefile evaluation order work out with that? Hardcoding this special case into cbfs-add-to-region is pretty ugly (and honestly, if the bootblock needs to be so special that it needs a hardcoded special case in there, maybe it shouldn't be using the cbfs-files framework after all?).
--
To view, visit https://review.coreboot.org/c/coreboot/+/56122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de9d7fedf1ae5a37a3310dd42eb07b44c030930
Gerrit-Change-Number: 56122
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 05 Apr 2022 01:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer.
Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63351
to look at the new patch set (#6).
Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove older tags
......................................................................
payloads/external/LinuxBoot: Modify Kconfig file and remove older tags
The u-root repo have modified the name of "master" branch to "main".
and remove older tag of u-root and use the new tag.
Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe
Signed-off-by: eliassouza <ratatouillemorde(a)gmail.com>
---
M payloads/external/LinuxBoot/Kconfig
M payloads/external/LinuxBoot/targets/u-root.mk
M payloads/external/Makefile.inc
3 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/63351/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/63351
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe
Gerrit-Change-Number: 63351
Gerrit-PatchSet: 6
Gerrit-Owner: Elias Souza
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer.
Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63351
to look at the new patch set (#5).
Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove older versions
......................................................................
payloads/external/LinuxBoot: Modify Kconfig file and remove older versions
The u-root repo have modified the name of "master" branch to "main".
and remove olders versions of u-root and use the new versions.
Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe
Signed-off-by: eliassouza <ratatouillemorde(a)gmail.com>
---
M payloads/external/LinuxBoot/Kconfig
M payloads/external/LinuxBoot/targets/u-root.mk
M payloads/external/Makefile.inc
3 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/63351/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/63351
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe
Gerrit-Change-Number: 63351
Gerrit-PatchSet: 5
Gerrit-Owner: Elias Souza
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset