coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: Makefile.inc: Add the x86 bootblock as a regular cbfs file
by Julius Werner (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Martin Roth, Marshall Dawson, Arthur Heymans, Kyösti Mälkki, Yu-Ping Wu, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56122 ) Change subject: Makefile.inc: Add the x86 bootblock as a regular cbfs file ...................................................................... Patch Set 9: (1 comment) File src/arch/x86/Makefile.inc: https://review.coreboot.org/c/coreboot/+/56122/comment/c09817f0_7808e528 PS9, Line 107: bootblock-options := $(TS_OPTIONS) $(TXTIBB) Can't we just put the -b here as well (maybe if you use = instead of := )? Or is there no way to make the whole Makefile evaluation order work out with that? Hardcoding this special case into cbfs-add-to-region is pretty ugly (and honestly, if the bootblock needs to be so special that it needs a hardcoded special case in there, maybe it shouldn't be using the cbfs-files framework after all?). -- To view, visit https://review.coreboot.org/c/coreboot/+/56122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de9d7fedf1ae5a37a3310dd42eb07b44c030930 Gerrit-Change-Number: 56122 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 01:12:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Modify Kconfig file and remove older tags
by Elias Souza (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63351 to look at the new patch set (#6). Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove older tags ...................................................................... payloads/external/LinuxBoot: Modify Kconfig file and remove older tags The u-root repo have modified the name of "master" branch to "main". and remove older tag of u-root and use the new tag. Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Signed-off-by: eliassouza <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/63351/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/63351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Gerrit-Change-Number: 63351 Gerrit-PatchSet: 6 Gerrit-Owner: Elias Souza Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Modify Kconfig file and remove older ver...
by Elias Souza (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63351 to look at the new patch set (#5). Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove older versions ...................................................................... payloads/external/LinuxBoot: Modify Kconfig file and remove older versions The u-root repo have modified the name of "master" branch to "main". and remove olders versions of u-root and use the new versions. Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Signed-off-by: eliassouza <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/63351/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/63351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Gerrit-Change-Number: 63351 Gerrit-PatchSet: 5 Gerrit-Owner: Elias Souza Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Modify Kconfig file and remove older ver...
by Elias Souza (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63351 to look at the new patch set (#4). Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove older versions ...................................................................... payloads/external/LinuxBoot: Modify Kconfig file and remove older versions The u-root repo have modified the name of "master" branch to "main" branch this patch remove olders versions of u-root and use the new versions Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Signed-off-by: eliassouza <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/63351/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Gerrit-Change-Number: 63351 Gerrit-PatchSet: 4 Gerrit-Owner: Elias Souza Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Modify Kconfig file and remove olders ve...
by Elias Souza (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer, Elias Souza. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63351 to look at the new patch set (#3). Change subject: payloads/external/LinuxBoot: Modify Kconfig file and remove olders versions ...................................................................... payloads/external/LinuxBoot: Modify Kconfig file and remove olders versions The U-Root repo have modified the name of "master" branch to "main" branch this patch remove olders versions of u-root and use the new versions Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Signed-off-by: eliassouza <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/63351/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70c4d064b534b28ea0be987b91a30650debc6ffe Gerrit-Change-Number: 63351 Gerrit-PatchSet: 3 Gerrit-Owner: Elias Souza Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Elias Souza Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Generate master header and pointer as C structs
by Julius Werner (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Arthur Heymans, Martin Roth, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59132 ) Change subject: Makefile.inc: Generate master header and pointer as C structs ...................................................................... Patch Set 6: (8 comments) Patchset: PS4: > but Libpayload needs to support FMAP for that. It does now, for the new CBFS APIs (e.g. cbfs_map()). We still left the old APIs untouched so that payloads have a grace period to migrate (and I guess we should probably start announcing that on the mailing list), but we did migrate depthcharge, and I doubt any other payload actually cared about reading non-primary CBFSes (which IIRC was the only place where the master header still mattered?). So I think anything using libpayload should be good now. But that still leaves the GRUB and SeaBIOS concerns? Patchset: PS6: Not sure if you have anything that's blocked by this work, but considering that we seem to be so close to just drop the master header completely, wouldn't it be easier to wait for that? File src/arch/x86/header_pointer.c: https://review.coreboot.org/c/coreboot/+/59132/comment/d848b0b3_7fa7e91c PS6, Line 7: __attribute__((used, __section__(".header_pointer"))) const uint32_t header_pointer = Wouldn't it be simpler to just merge this with the src/lib version and wrap the section attribute into an #if CONFIG(ARCH_X86)? File src/lib/cbfs_master_header.c: https://review.coreboot.org/c/coreboot/+/59132/comment/bcb35be1_02b046cb PS6, Line 10: FMAP_SECTION_FLASH_SIZE I believe this needs to be (FMAP_SECTION_COREBOOT_START + FMAP_SECTION_COREBOOT_SIZE) (which is not guaranteed to be the same, e.g. on Arm systems where the CBFS is not at the end of flash). https://review.coreboot.org/c/coreboot/+/59132/comment/99901f38_3afd98b3 PS6, Line 11: .bootblocksize = cpu_to_be32(4), This should probably have a comment about why this is 4... maybe copy the one from cbfstool (although it's also not very clear on this... I think the missing piece of information is that this is _not_ in fact the actual size of the bootblock anymore, but is only used to tell the legacy CBFS reader where the CBFS ends, and we don't want to let that go up right to the 4GB boundary for the reasons mentioned in cbfstool). https://review.coreboot.org/c/coreboot/+/59132/comment/8923626c_ddab965e PS6, Line 12: .align = cpu_to_be32(64), You should be able to use the CBFS_ALIGNMENT constant here. https://review.coreboot.org/c/coreboot/+/59132/comment/9d65b653_35aa5bf7 PS6, Line 13: FMAP_SECTION_FLASH_START Isn't this just 0? Rather than assuming that all FMAPs are named "FLASH", I think it's easier to just leave this out? File src/lib/master_header_pointer.c: https://review.coreboot.org/c/coreboot/+/59132/comment/c66388fe_84427964 PS6, Line 7: __attribute((used)) I don't think you need this? We've never needed it for other structs... (Also, I don't think __attribute(()) compiles without the __ on the other end?) -- To view, visit https://review.coreboot.org/c/coreboot/+/59132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ba01be7da1f09a8cac287751497c18cda97d293 Gerrit-Change-Number: 59132 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 00:56:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing
by 9elements QA (Code Review) 05 Apr '22

05 Apr '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63340 ) Change subject: drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/99526 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/99525 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/99524 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/99523 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/99522 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/99521 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/99520 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/99519 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/99518 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/99517 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/99516 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/99515 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/99514 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/99513 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/99512 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/99511 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/63340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fbc9565e7e9b4e1c14a68f6a5fd779577045236 Gerrit-Change-Number: 63340 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 00:51:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing
by Felix Held (Code Review) 04 Apr '22

04 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63340 ) Change subject: drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing ...................................................................... drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing Checking whether a pointer is NULL after it has been dereferenced makes zero sense. Make sure the `wifi_ssdt_write_properties()` function never gets invoked with a NULL argument for the `dev` parameter, and simplify the logic around the `is_cnvi_ddr_rfim_enabled` variable accordingly. Change-Id: I3fbc9565e7e9b4e1c14a68f6a5fd779577045236 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63340 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/drivers/wifi/generic/acpi.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 65940d6..ee09631 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -533,11 +533,9 @@ static void wifi_ssdt_write_properties(const struct device *dev, const char *scope) { - bool is_cnvi_ddr_rfim_enabled = false; - const struct drivers_wifi_generic_config *config = dev->chip_info; - if (dev && config) - is_cnvi_ddr_rfim_enabled = config->enable_cnvi_ddr_rfim; + + bool is_cnvi_ddr_rfim_enabled = config && config->enable_cnvi_ddr_rfim; /* Scope */ acpigen_write_scope(scope); @@ -646,6 +644,8 @@ void wifi_cnvi_fill_ssdt(const struct device *dev) { const char *path; + if (!dev) + return; path = acpi_device_path(dev->bus->dev); if (!path) -- To view, visit https://review.coreboot.org/c/coreboot/+/63340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fbc9565e7e9b4e1c14a68f6a5fd779577045236 Gerrit-Change-Number: 63340 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/common/block/spi: Disable SPI Clock Pulldown
by Felix Held (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63307 ) Change subject: soc/amd/common/block/spi: Disable SPI Clock Pulldown ...................................................................... Patch Set 1: (2 comments) File src/soc/amd/common/block/include/amdblocks/acpimmio.h: https://review.coreboot.org/c/coreboot/+/63307/comment/c7617bec_60f456d2 PS1, Line 35: 0x90 > Does this apply to all the generations? i don't see this in the stoneyridge bkdg or the picasso ppr. cezanne and sabrina ppr have this register and bit described File src/soc/amd/common/block/spi/fch_spi.c: https://review.coreboot.org/c/coreboot/+/63307/comment/3638ceff_4f11a61a PS1, Line 133: PM_SPI_CLK_PD_EN > Did the default change on sabrina? at least from the ppr both cezanne and sabrina have the spi clk pull-down enabled and the pull-up controlled by bit 10 in the same register disabled -- To view, visit https://review.coreboot.org/c/coreboot/+/63307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If62a1f51ac3d68e7896baac3c696c4f73d900f6d Gerrit-Change-Number: 63307 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 23:16:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/mtl: Do initial Meteor Lake SoC commit till ramstage
by Ravishankar Sarawadi (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Raj Astekar. Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63364 to look at the new patch set (#2). Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till ramstage ...................................................................... soc/intel/mtl: Do initial Meteor Lake SoC commit till ramstage List of changes: 1. Add required SoC programming till ramstage 2. Include only required headers into include/soc 3. Fill required FSP-S UPD to call FSP-S API TEST= Build mtlrvp board. Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: Ie746c0bfcf1f315a4ab6f540cc7c4933157551d7 --- M src/soc/intel/meteorlake/Kconfig M src/soc/intel/meteorlake/Makefile.inc A src/soc/intel/meteorlake/acpi.c A src/soc/intel/meteorlake/chip.c M src/soc/intel/meteorlake/chip.h A src/soc/intel/meteorlake/chipset.cb A src/soc/intel/meteorlake/cpu.c A src/soc/intel/meteorlake/crashlog.c A src/soc/intel/meteorlake/dptf.c A src/soc/intel/meteorlake/elog.c A src/soc/intel/meteorlake/finalize.c A src/soc/intel/meteorlake/fsp_params.c A src/soc/intel/meteorlake/gspi.c A src/soc/intel/meteorlake/i2c.c A src/soc/intel/meteorlake/include/soc/cpu.h A src/soc/intel/meteorlake/include/soc/crashlog.h A src/soc/intel/meteorlake/include/soc/irq.h A src/soc/intel/meteorlake/include/soc/itss.h A src/soc/intel/meteorlake/include/soc/me.h A src/soc/intel/meteorlake/include/soc/meminit.h A src/soc/intel/meteorlake/include/soc/nvs.h M src/soc/intel/meteorlake/include/soc/p2sb.h A src/soc/intel/meteorlake/include/soc/pcie.h A src/soc/intel/meteorlake/include/soc/ramstage.h A src/soc/intel/meteorlake/include/soc/serialio.h A src/soc/intel/meteorlake/include/soc/soc_info.h A src/soc/intel/meteorlake/include/soc/tcss.h A src/soc/intel/meteorlake/include/soc/usb.h A src/soc/intel/meteorlake/lockdown.c A src/soc/intel/meteorlake/me.c A src/soc/intel/meteorlake/pcie_rp.c A src/soc/intel/meteorlake/pmc.c A src/soc/intel/meteorlake/pmutil.c A src/soc/intel/meteorlake/smihandler.c A src/soc/intel/meteorlake/soc_info.c A src/soc/intel/meteorlake/soundwire.c A src/soc/intel/meteorlake/spi.c A src/soc/intel/meteorlake/systemagent.c A src/soc/intel/meteorlake/uart.c A src/soc/intel/meteorlake/xhci.c 40 files changed, 3,778 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/63364/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie746c0bfcf1f315a4ab6f540cc7c4933157551d7 Gerrit-Change-Number: 63364 Gerrit-PatchSet: 2 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022